On Thu, Jan 12, 2023 at 23:42:16 -0500, Laine Stump wrote:
> This attribute was added to support setting the --interface option for
> passt, but in a post-push/pre-9.0-release review, danpb pointed out
> that it would be better to use the existing
> attribute to set --interface rather than
On a Friday in 2023, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
NEWS.rst | 11 +++
1 file changed, 11 insertions(+)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
I have just tagged v9.0.0-rc2 (the last minute change to the XML format
for passt is included) in the repository and pushed signed tarballs and
source RPMs to https://libvirt.org/sources/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix
On Thu, Jan 12, 2023 at 23:42:15 -0500, Laine Stump wrote:
> The first patch implements what danpb suggested yesterday - using
> instead of to populate
> the passt --interface option. The other two are small cleanups I
> noticed while making the changes in patch 1.
>
> jdenemar: feel free to
Signed-off-by: Peter Krempa
---
NEWS.rst | 11 +++
1 file changed, 11 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 8482c49b3c..9baf10b8e9 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -38,6 +38,12 @@ v9.0.0 (unreleased)
Connecting the VM to a swtpm daemon started outside of
On Thu, Jan 12, 2023 at 02:44:35 -0600, Or Ozeri wrote:
> Internal disk snapshots are currently only supported on non-active VMs.
> This patch series extends this support for active VMs running with qemu.
Could you elaborate how this will be useful? Generally disk only
snapshots are of very
This function cannot fail since g_malloc0 aborts on OOM.
Signed-off-by: Daniel P. Berrangé
---
audio/audio.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/audio/audio.c b/audio/audio.c
index d849a94a81..7b4b957945 100644
--- a/audio/audio.c
+++ b/audio/audio.c
@@
Since the linked list of QEMUSoundCard structs was removed,
AUD_remove_card does nothing useful.
Signed-off-by: Daniel P. Berrangé
---
audio/audio.c| 4
audio/audio.h| 1 -
hw/audio/ac97.c | 1 -
hw/audio/adlib.c | 1 -
hw/audio/es1370.c| 1 -
hw/audio/gus.c
No code ever iterates over the list
Signed-off-by: Daniel P. Berrangé
---
audio/audio.c | 5 -
audio/audio.h | 1 -
audio/audio_int.h | 1 -
3 files changed, 7 deletions(-)
diff --git a/audio/audio.c b/audio/audio.c
index 94a16c2dda..217095306f 100644
--- a/audio/audio.c
+++
If we have no audio state configured, then we don't want to
advertize the VNC_ENCODING_AUDIO feature. If a client attempts
to use it despite being disabled, we should also reject it.
Signed-off-by: Daniel P. Berrangé
---
docs/about/deprecated.rst | 6 --
Both soundcards and VNC will require the audiodev= property
but lets split the deprecation message since these are
distinct functional areas.
Signed-off-by: Daniel P. Berrangé
---
docs/about/deprecated.rst | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git
All user created devices and the builtin pcspk can be given
a audiodev property. A few devices using audiodevs though
cannot be configured directly as they are built-in devices
created programmatically by the machine type.
To enable those to continue to be used we leave in the
logic that picks
This removes much of the deprecated audio code, most
notably the QEMU_AUDIO env variables. The VNC server
will also stop accepting client requests for audio
streaming unless an audiodev is set.
I tried to make the use of 'audiodev' mandatory for
devices but that turned out to not be practical.
Signed-off-by: Daniel P. Berrangé
---
audio/audio.c | 2 --
audio/audio.h | 1 -
2 files changed, 3 deletions(-)
diff --git a/audio/audio.c b/audio/audio.c
index f397072a1f..94a16c2dda 100644
--- a/audio/audio.c
+++ b/audio/audio.c
@@ -1833,7 +1833,6 @@ void AUD_register_card (const char *name,
The audio_calloc function does various checks on the size and
nmembers parameters to detect various error conditions. There
are only 5 callers
* alsa_poll_helper: the pollfd count is small and bounded,
* audio_pcm_create_voice_pair_: allocating a single fixed
size struct
*
Both callers of AUD_add_capture will now ensure that the
audio state is non-NULL.
Signed-off-by: Daniel P. Berrangé
---
audio/audio.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/audio/audio.c b/audio/audio.c
index 00128c2ad7..64b75cdf94 100644
--- a/audio/audio.c
+++
On Wed, Jan 11, 2023 at 03:05:53PM -0700, Jim Fehlig wrote:
> @@ -432,17 +432,30 @@ Summary: Server side daemon and supporting files for
> libvirt library
>
> # The client side, i.e. shared libs are in a subpackage
> Requires: libvirt-libs = %{version}-%{release}
> +Requires:
On Wed, Jan 11, 2023 at 03:05:57PM -0700, Jim Fehlig wrote:
> Change the dependency to a 'Wants' to avoid a pacakge
*package
> +++ b/libvirt.spec.in
> @@ -775,7 +776,8 @@ QEMU
> %if %{with_lxc}
> %package daemon-driver-lxc
> Summary: LXC driver plugin for the libvirtd daemon
> -Requires:
On Fri, Jan 13, 2023 at 07:05:36PM +0200, Andrea Bolognani wrote:
> Overall things look good. Let me actually test this a bit :)
Some quick testing (QEMU only) revealed no issues.
So I just need you to clarify the lxc virtlogd bit above and weigh in
on the other nits I mentioned, but otherwise I
On 1/13/23 10:05, Andrea Bolognani wrote:
On Wed, Jan 11, 2023 at 03:05:57PM -0700, Jim Fehlig wrote:
Change the dependency to a 'Wants' to avoid a pacakge
*package
+++ b/libvirt.spec.in
@@ -775,7 +776,8 @@ QEMU
%if %{with_lxc}
%package daemon-driver-lxc
Summary: LXC driver plugin for
On 1/13/23 09:52, Andrea Bolognani wrote:
On Wed, Jan 11, 2023 at 03:05:53PM -0700, Jim Fehlig wrote:
@@ -432,17 +432,30 @@ Summary: Server side daemon and supporting files for
libvirt library
# The client side, i.e. shared libs are in a subpackage
Requires: libvirt-libs =
The systemd service files of the qemu and libxl driver currently have a
'Requires' dependency on virtlockd, which is too strong since virtlockd
is not enabled by default in either driver. Change the dependency to a
'Wants' to avoid a package dependency between the driver subpackages and
the new
To avoid needlessly installing the monolithic daemon, replace the
libvirt-daemon dependency with libvirt-daemon-common in the primary
drivers.
The qemu driver also needs a dependency on libvirt-daemon-log since
the virtqemud systemd service file has a hard dependency on
virtlogd.socket.
Remove the libvirt-daemon dependency from the various
libvirt-daemon- subpackages, replacing it with a set of the
new sub subpackages providing similar functionality. When libvirt is build
with modular daemons, the hypervisor subpackages no longer include the
traditional, monolithic libvirt
Both drivers use numad via virNumaGetAutoPlacementAdvice. Drop the numad
dependency from libvirt-daemon-common to avoid enforcing it all users of
the subpackage.
Signed-off-by: Jim Fehlig
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Andrea Bolognani
---
libvirt.spec.in | 9 ++---
1 file
Signed-off-by: Jim Fehlig
Reviewed-by: Andrea Bolognani
---
docs/kbase/rpm-deployment.rst | 36 ---
1 file changed, 29 insertions(+), 7 deletions(-)
diff --git a/docs/kbase/rpm-deployment.rst b/docs/kbase/rpm-deployment.rst
index 7685ee1291..26fe1be8e6 100644
Signed-off-by: Jim Fehlig
Reviewed-by: Andrea Bolognani
---
NEWS.rst | 6 ++
1 file changed, 6 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 9baf10b8e9..c533c0824f 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -50,6 +50,12 @@ v9.0.0 (unreleased)
With sufficiently new QEMU (v7.1.0)
To avoid needlessly installing the monolithic daemon, replace the
libvirt-daemon dependency with libvirt-daemon-common in the secondary
drivers. The common subpackage contains all the utilities and files
needed by the secondary drivers.
Signed-off-by: Jim Fehlig
Reviewed-by: Daniel P. Berrangé
Introduce a new subpackage libvirt-daemon-common and move virt-admin,
virt-host-validate, virt-ssh-helper, libvirt-guests and miscellaneous
files/directories to it. Also move common dependencies to the new
subpackage. These files, utilities, and dependecies are used by other
core libvirt daemons
Only the nodedev and lxc drivers require module-init-tools. Remove the
dependency from libvirt-daemon-common and add it to the nodedev and lxc
drivers. This avoids enforcing the dependency on all users of
libvirt-daemon-common.
Signed-off-by: Jim Fehlig
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Jim Fehlig
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Andrea Bolognani
---
libvirt.spec.in | 68 -
1 file changed, 45 insertions(+), 23 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 19a3c8465c..6072ac2c1c
Signed-off-by: Jim Fehlig
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Andrea Bolognani
---
libvirt.spec.in | 61 +++--
1 file changed, 44 insertions(+), 17 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 77b274b6f9..bb0bfb5f35
Signed-off-by: Jim Fehlig
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Andrea Bolognani
---
libvirt.spec.in | 53 +++--
1 file changed, 38 insertions(+), 15 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index bb0bfb5f35..19a3c8465c
Introduce the libvirt-daemon-plugin-lockd subpackage to provide the
client-side lockd plugin for virtlockd.
Signed-off-by: Jim Fehlig
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Andrea Bolognani
---
libvirt.spec.in | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff
The new name "libvirt-daemon-plugin-sanlock" provides consistency with the
newly introduced "libvirt-daemon-plugin-lockd" subpackage.
It's also a good opportunity to taking ownership of
%{_libdir}/libvirt/lock-driver/, removing the need for a dependency on the
libvirt-daemon package.
This is V9 of
https://listman.redhat.com/archives/libvir-list/2023-January/237006.html
The end goal is to remove the libvirt-dameon dependency on the various
libvirt-daemon-driver-foo subpackages, allowing installation of a
modular daemon configuration without the traditional monolithic
36 matches
Mail list logo
