Re: [PATCH 00/21] qemu capability testing cleanups and improvements (part 5)

2023-04-11 Thread Ján Tomko
On a Friday in 2023, Peter Krempa wrote: This series applies on top of 'part 4' fetch everything from my repo: git fetch https://gitlab.com/pipo.sk/libvirt.git aarch-send In this part tests for the 'aarch64' platform are converted to use real capabilities. Peter Krempa (21):

Re: [libvirt PATCH 3/3] rpc/ssh: ssh_userauth_agent() is not supported on win32

2023-04-11 Thread Michal Prívozník
On 4/6/23 17:58, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The function does not exist on win32. > > Signed-off-by: Marc-André Lureau > --- > src/rpc/virnetlibsshsession.c | 14 -- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git

Re: [libvirt PATCH 0/3] RFC: fix compilation on msys2

2023-04-11 Thread Michal Prívozník
On 4/6/23 17:58, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Hi, > > libvirt fails to compile on msys2/win32. Here is a few patches that solve it, > but the way python scripts are being handled in general is a bit odd, so this > is > RFC. (fwiw, a lot of tests fail though,

Re: [libvirt PATCH 3/3] rpc/ssh: ssh_userauth_agent() is not supported on win32

2023-04-11 Thread Marc-André Lureau
Hi On Tue, Apr 11, 2023 at 11:10 AM Michal Prívozník wrote: > On 4/6/23 17:58, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > The function does not exist on win32. > > > > Signed-off-by: Marc-André Lureau > > --- > > src/rpc/virnetlibsshsession.c | 14 -- >

Re: [PATCHv2] storage_file_probe: change maximum len value in vmdk4GetBackingStore

2023-04-11 Thread Ján Tomko
On a Monday in 2023, Anastasia Belova wrote: desc length should be always less than VIR_STORAGE_MAX_HEADER. If len = VIR_STORAGE_MAX_HEADER, desc may be out of bounds. Fixes: 348b4e254b ("storage: always probe type with buffer") Signed-off-by: Anastasia Belova --- v2: change Fixes: line

Re: [libvirt PATCH 2/3] meson: drop explicit python interpreter

2023-04-11 Thread Michal Prívozník
On 4/6/23 17:58, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > meson wraps python scripts already on win32, so we end up with these > failing commands: > > [1/359] "C:/msys64/ucrt64/bin/meson" "--internal" "exe" "--capture" > "src/util/virkeycodetable_atset1.h" "--" "sh" >

Re: [libvirt PATCH 2/3] meson: drop explicit python interpreter

2023-04-11 Thread Marc-André Lureau
Hi On Tue, Apr 11, 2023 at 11:10 AM Michal Prívozník wrote: > On 4/6/23 17:58, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > meson wraps python scripts already on win32, so we end up with these > > failing commands: > > > > [1/359] "C:/msys64/ucrt64/bin/meson"

Re: [libvirt PATCH 2/3] meson: drop explicit python interpreter

2023-04-11 Thread Michal Prívozník
On 4/11/23 09:27, Marc-André Lureau wrote: > Hi > > On Tue, Apr 11, 2023 at 11:10 AM Michal Prívozník > wrote: > > On 4/6/23 17:58, marcandre.lur...@redhat.com > wrote: > > From: Marc-André Lureau

[PATCH] qemu: Fix potential crash during driver cleanup

2023-04-11 Thread Jim Fehlig
During qemu driver shutdown, objects are freed in qemuStateCleanup that could still be used by active worker threads, resulting in crashes. E.g. a worker thread could be processing a monitor EOF event after the security manager is already disposed Program terminated with signal SIGSEGV,

[libvirt PATCH 0/2] conf: Fix migration in some firmware autoselection scenarios

2023-04-11 Thread Andrea Bolognani
See commit 2/2 for details. Andrea Bolognani (2): tests: Tweak input file conf: Fix migration in some firmware autoselection scenarios src/conf/domain_conf.c| 39 ++- ...are-manual-efi-features.x86_64-latest.args | 35 +

[libvirt PATCH 2/2] conf: Fix migration in some firmware autoselection scenarios

2023-04-11 Thread Andrea Bolognani
Introduce a small kludge in the parser to avoid unnecessarily blocking incoming migration from a range of recent libvirt releases. https://bugzilla.redhat.com/show_bug.cgi?id=2184966 Signed-off-by: Andrea Bolognani --- src/conf/domain_conf.c| 39 ++-

[libvirt PATCH 1/2] tests: Tweak input file

2023-04-11 Thread Andrea Bolognani
The canonical order for child elements is then . Signed-off-by: Andrea Bolognani --- tests/qemuxml2argvdata/firmware-manual-efi-features.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemuxml2argvdata/firmware-manual-efi-features.xml

Re: [PATCH 1/4] conf: add loader type 'none'

2023-04-11 Thread Gerd Hoffmann
Hi, > The second approach is the one described in the Ubuntu wiki[3], and > also requires passing two files to QEMU, except this time they come > from the opensbi and u-boot-qemu packages respectively. The usage > looks like > > -bios /usr/lib/riscv64-linux-gnu/opensbi/generic/fw_jump.elf >