On Thu, 20 Apr 2023 at 10:13, Philippe Mathieu-Daudé wrote:
>
> On 17/4/23 18:40, Peter Maydell wrote:
> > The '-singlestep' option is confusing, because it doesn't actually
> > have anything to do with single-stepping the CPU. What it does do
> > is force TCG emulation to put one guest
On 17/4/23 18:40, Peter Maydell wrote:
Document that the -singlestep command line option is now
deprecated, as it is replaced by either the TCG accelerator
property 'one-insn-per-tb' for system emulation or the new
'-one-insn-per-tb' option for usermode emulation, and remove
the only use of the
On 17/4/23 18:40, Peter Maydell wrote:
The run-state.json file is missing a trailing newline; add it.
Signed-off-by: Peter Maydell
Reviewed-by: Richard Henderson
---
Noticed this because my editor wanted to add the newline
when I touched the file for the following patch...
---
On Wed, Apr 19, 2023 at 04:53:36PM +0200, Michal Prívozník wrote:
On 4/19/23 16:07, Martin Kletzander wrote:
Most of them are platform devices and only i6300esb can be plugged
multiple times into different PCI slots.
Signed-off-by: Martin Kletzander
---
src/qemu/qemu_validate.c | 18
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2185184
Signed-off-by: Martin Kletzander
---
docs/formatdomain.rst | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index c31c2fe35c76..cb3fe3dc1c33 100644
---
See individual commit messages for explanations (duh!)
Martin Kletzander (2):
qemu, ch: Move threads to cgroup dir before changing parameters
docs: Clarify restrictive numatune mode
docs/formatdomain.rst | 11 ++-
src/ch/ch_process.c | 12 ++--
src/qemu/qemu_process.c
With cgroupv2 this has better effect on the resource allocation. An
excerpt from Documentation/admin-guide/cgroup-v2.rst explains is this
way:
Migrating a process across cgroups is a relatively expensive operation
and stateful resources such as memory are not moved together with the
On 17/4/23 18:40, Peter Maydell wrote:
The 'singlestep' member of StatusInfo has never done what the QMP
documentation claims it does. What it actually reports is whether
TCG is working in "one guest instruction per translation block" mode.
We no longer need this field for the HMP 'info
On 17/4/23 18:40, Peter Maydell wrote:
The '-singlestep' option is confusing, because it doesn't actually
have anything to do with single-stepping the CPU. What it does do
is force TCG emulation to put one guest instruction in each TB,
which can be useful in some situations.
Create a new
On 17/4/23 18:40, Peter Maydell wrote:
The '-singlestep' option is confusing, because it doesn't actually
have anything to do with single-stepping the CPU. What it does do
is force TCG emulation to put one guest instruction in each TB,
which can be useful in some situations.
Create a new
On 17/4/23 18:40, Peter Maydell wrote:
The only place left that looks at the old 'singlestep' global
variable is the TCG curr_cflags() function. Replace the old global
with a new 'one_insn_per_tb' which is defined in tcg-all.c and
declared in accel/tcg/internal.h. This keeps it restricted to
On 17/4/23 18:40, Peter Maydell wrote:
The HMP 'singlestep' command, the QMP 'query-status' command and the
HMP 'info status' command (which is just wrapping the QMP command
implementation) look at the 'singlestep' global variable. Make them
access the new TCG accelerator 'one-insn-per-tb'
On 17/4/23 18:40, Peter Maydell wrote:
Currently we report whether the TCG accelerator is in
'one-insn-per-tb' mode in the 'info status' output. This is a pretty
minor piece of TCG specific information, and we want to deprecate the
'singlestep' field of the associated QMP command. Move the
Disabling the daemon timeout is important so that the settings don't get
discarded. Remove the comment saying it's optional and add a paragraph
outlining what to do if it is not available.
Signed-off-by: Peter Krempa
---
docs/kbase/debuglogs.rst | 6 --
1 file changed, 4 insertions(+), 2
Peter Krempa (3):
kbase: debuglogs: Emphasize disabling daemon timeout in 'TL;DR'
section
docs: manpages: Clarify that only TLS/TCP remote access needs
'virtproxyd'
docs: manpages: State that TCP connection is insecure in 'virtproxyd'
man page
docs/kbase/debuglogs.rst |
Spell out that TCP and TLS needs virtproxyd as 'off-host' might mean
that also ssh transport requires it.
Also fix the name of the 'virtproxyd' daemon.
Signed-off-by: Peter Krempa
---
docs/manpages/virtbhyved.rst | 4 ++--
docs/manpages/virtinterfaced.rst | 4 ++--
Copy the wording we have in docs/uri.rst
Signed-off-by: Peter Krempa
---
docs/manpages/virtproxyd.rst | 3 +++
1 file changed, 3 insertions(+)
diff --git a/docs/manpages/virtproxyd.rst b/docs/manpages/virtproxyd.rst
index 814575e504..cb29ccbaad 100644
--- a/docs/manpages/virtproxyd.rst
+++
On 4/20/23 08:42, Martin Kletzander wrote:
> On Wed, Apr 19, 2023 at 04:53:36PM +0200, Michal Prívozník wrote:
>> On 4/19/23 16:07, Martin Kletzander wrote:
>>> Most of them are platform devices and only i6300esb can be plugged
>>> multiple times into different PCI slots.
>>>
>>> Signed-off-by:
On 17/4/23 18:40, Peter Maydell wrote:
The 'singlestep' HMP command is confusing, because it doesn't
actually have anything to do with single-stepping the CPU. What it
does do is force TCG emulation to put one guest instruction in each
TB, which can be useful in some situations.
Create a new
On 4/20/23 10:49, Martin Kletzander wrote:
> See individual commit messages for explanations (duh!)
>
> Martin Kletzander (2):
> qemu, ch: Move threads to cgroup dir before changing parameters
> docs: Clarify restrictive numatune mode
>
> docs/formatdomain.rst | 11 ++-
>
On 4/20/23 14:07, Martin Kletzander wrote:
> On Thu, Mar 23, 2023 at 05:01:26PM +0100, Michal Privoznik wrote:
>> In our meson scripts, we use configure_file(copy:true) to copy
>> files from srcdir into builddir. However, as of meson-0.64.0,
>> this is deprecated [1] in favor of using:
>>
>> fs =
On Thu, Apr 20, 2023 at 04:02:12PM +0200, Ján Tomko wrote:
> Found by cppcheck.
>
> Ján Tomko (4):
> conf: domain: remove unreachable break
> qemu: command: join two adjacent conditions
> ch: pinVcpuLive: remove unused variable
> conf: storage: remove redundant condition
Reviewed-by:
On Thu, Apr 20, 2023 at 10:49:17AM +0200, Martin Kletzander wrote:
> See individual commit messages for explanations (duh!)
>
> Martin Kletzander (2):
> qemu, ch: Move threads to cgroup dir before changing parameters
> docs: Clarify restrictive numatune mode
Reviewed-by: Pavel Hrdina
On 4/20/23 11:09, Peter Krempa wrote:
> Peter Krempa (3):
> kbase: debuglogs: Emphasize disabling daemon timeout in 'TL;DR'
> section
> docs: manpages: Clarify that only TLS/TCP remote access needs
> 'virtproxyd'
> docs: manpages: State that TCP connection is insecure in 'virtproxyd'
Signed-off-by: Ján Tomko
---
src/conf/domain_conf.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 5c0b837697..cda50e56d0 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -30064,7 +30064,6 @@
Signed-off-by: Ján Tomko
---
src/qemu/qemu_command.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 4ca93bf3dc..0afb038954 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -8482,9 +8482,7 @@
Signed-off-by: Ján Tomko
---
src/ch/ch_driver.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/src/ch/ch_driver.c b/src/ch/ch_driver.c
index 72fe3198b2..45cdbfd37c 100644
--- a/src/ch/ch_driver.c
+++ b/src/ch/ch_driver.c
@@ -1148,8 +1148,6 @@ chDomainPinVcpuLive(virDomainObj *vm,
We exit early if poolOptions->formatToString is false.
Fixes: 9dadc7302920f9fca0057c655d03c2b0206b9a70
Signed-off-by: Ján Tomko
---
src/conf/storage_conf.c | 22 +-
1 file changed, 9 insertions(+), 13 deletions(-)
diff --git a/src/conf/storage_conf.c
Found by cppcheck.
Ján Tomko (4):
conf: domain: remove unreachable break
qemu: command: join two adjacent conditions
ch: pinVcpuLive: remove unused variable
conf: storage: remove redundant condition
src/ch/ch_driver.c | 5 -
src/conf/domain_conf.c | 1 -
On 20/4/23 11:19, Peter Maydell wrote:
On Thu, 20 Apr 2023 at 10:13, Philippe Mathieu-Daudé wrote:
On 17/4/23 18:40, Peter Maydell wrote:
The '-singlestep' option is confusing, because it doesn't actually
have anything to do with single-stepping the CPU. What it does do
is force TCG
On Thu, Mar 23, 2023 at 05:01:26PM +0100, Michal Privoznik wrote:
In our meson scripts, we use configure_file(copy:true) to copy
files from srcdir into builddir. However, as of meson-0.64.0,
this is deprecated [1] in favor of using:
fs = import('fs')
fs.copyfile(in, out)
Except, the
On Fri, Feb 24, 2023 at 17:27:10 +0800, Jiang Jiacheng wrote:
> Add description for VIR_MIGRATE_PARAM_COMPRESSION, it will
> be reused in choosing compression method during parallel migration.
> Add public API VIR_MIGRATE_PARAM_COMPRESSION_ZLIB_LEVEL,
> VIR_MIGRATE_PARAM_COMPRESSION_ZSTD_LEVEL for
On 4/20/23 17:10, Boris Fiuczynski wrote:
> With this code in master I am no longer able to build rpms from the
> tarball with rpmbuild. Am I the only one?
This is the pipeline that run after this very patch:
https://gitlab.com/libvirt/libvirt/-/pipelines/839521848
and for instance
On Fri, Feb 24, 2023 at 17:27:11 +0800, Jiang Jiacheng wrote:
> Add migrate options: --compression-zlib-level
> --compression-zstd-level
> These options are used to set compress level for "zlib"
> or "zstd" during parallel migration if the compress method
> is specified.
>
>
On Tue, Apr 18, 2023 at 14:44:47 +0600, Oleg Vasilev wrote:
> QEMU now supports multifd-compression=zstd for migration with enabled multifd.
> Bring the support to libvirt as well.
There is an earlier series implementing this functionality (with zlib as
well): [PATCH V3 0/3] migration: add qemu
On Fri, Feb 24, 2023 at 17:27:12 +0800, Jiang Jiacheng wrote:
> Add new compress methods zlib and zstd for parallel migration,
> these method should be used with migration option --comp-methods
> and will be processed in 'qemuMigrationParamsSetCompression'.
> Note that only one compress method
With this code in master I am no longer able to build rpms from the
tarball with rpmbuild. Am I the only one?
On 4/17/23 1:54 PM, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Follow better meson build system conventions. This allows to find
keymap-gen or CSV without explicitly
On Fri, Feb 24, 2023 at 17:27:09 +0800, Jiang Jiacheng wrote:
> Add compress method zlib and zstd for parallel migration and new
> migration options to set qemu's parameter related with parallel
> migration(multifd-compression, multifd-zlib-level and multifd-zstd-level).
> These parameters has
38 matches
Mail list logo
