Re: [RFC: vf-token 0/5] Introduce vf-token when using userspace PF

2023-10-06 Thread Vivek Kashyap
On Fri, 6 Oct 2023, Peter Krempa wrote: ... This is mostly because the patches do not contain any changes to documentation that would explain it and I'm not familiar with what the feature is supposed to do. Thus my comments will be purely for the code itself and a further review will be

Re: [RFC: vf-token 2/5] qemu: vf-token capability

2023-10-06 Thread Peter Krempa
On Thu, Oct 05, 2023 at 16:05:01 -0700, Vivek Kashyap wrote: > Introduce qemu capability for vf-token > > Signed-off-by: Vivek Kashyap > --- > src/qemu/qemu_capabilities.c | 3 +++ > src/qemu/qemu_capabilities.h | 1 + > 2 files changed, 4 insertions(+) > > diff --git

[RFC: vf-token 4/5] conf: vf-token parsing and formatting

2023-10-06 Thread Vivek Kashyap
Introduce XML parsing and formatting of vf-token attribute Signed-off-by: Vivek Kashyap --- src/conf/device_conf.c| 31 +-- src/conf/domain_conf.c| 5 + src/conf/schemas/basictypes.rng | 11 +++ src/conf/schemas/domaincommon.rng

[RFC: vf-token 3/5] conf: vf-token flag

2023-10-06 Thread Vivek Kashyap
Define PCI address extension flag for vf-token Signed-off-by: Vivek Kashyap --- src/conf/device_conf.h | 3 +++ src/conf/domain_addr.h | 1 + src/qemu/qemu_domain_address.c | 3 +++ 3 files changed, 7 insertions(+) diff --git a/src/conf/device_conf.h b/src/conf/device_conf.h

[RFC: vf-token 1/5] virpci: Define vf-token

2023-10-06 Thread Vivek Kashyap
Define the vf-token extension for PCI device Signed-off-by: Vivek Kashyap --- src/util/virpci.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/util/virpci.h b/src/util/virpci.h index faca6cf6f9..b4e9e95d88 100644 --- a/src/util/virpci.h +++ b/src/util/virpci.h @@ -50,7

[RFC: vf-token 5/5] qemu: validate and generate vf-token on command line

2023-10-06 Thread Vivek Kashyap
Introduce a validation function for vf-token support in qemu and generate vf-token device attribute in qmeu command line. Signed-off-by: Vivek Kashyap --- src/qemu/qemu_command.c | 27 --- src/qemu/qemu_validate.c | 19 +++ 2 files changed, 43

[RFC: vf-token 0/5] Introduce vf-token when using userspace PF

2023-10-06 Thread Vivek Kashyap
vf token is set by a vfio-pci based PF driver and it must be known to the vfio-pci based VF driver. This vf-token is set by the PF driver before VF drivers can access the device. vfio-pci driver and qemu support vf-token. This RFC patch series adds support to provide the vf-token (uuid format)

[RFC: vf-token 2/5] qemu: vf-token capability

2023-10-06 Thread Vivek Kashyap
Introduce qemu capability for vf-token Signed-off-by: Vivek Kashyap --- src/qemu/qemu_capabilities.c | 3 +++ src/qemu/qemu_capabilities.h | 1 + 2 files changed, 4 insertions(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 3a1bfbf74d..f84c4df8db 100644 ---

Re: [RFC: vf-token 3/5] conf: vf-token flag

2023-10-06 Thread Peter Krempa
On Thu, Oct 05, 2023 at 16:05:02 -0700, Vivek Kashyap wrote: > Define PCI address extension flag for vf-token > > Signed-off-by: Vivek Kashyap > --- > src/conf/device_conf.h | 3 +++ > src/conf/domain_addr.h | 1 + > src/qemu/qemu_domain_address.c | 3 +++ > 3 files changed, 7

Re: [RFC: vf-token 4/5] conf: vf-token parsing and formatting

2023-10-06 Thread Peter Krempa
On Thu, Oct 05, 2023 at 16:05:03 -0700, Vivek Kashyap wrote: > Introduce XML parsing and formatting of vf-token attribute > > Signed-off-by: Vivek Kashyap > --- > src/conf/device_conf.c| 31 +-- > src/conf/domain_conf.c| 5 + >

Re: [RFC: vf-token 0/5] Introduce vf-token when using userspace PF

2023-10-06 Thread Peter Krempa
On Thu, Oct 05, 2023 at 16:04:59 -0700, Vivek Kashyap wrote: > vf token is set by a vfio-pci based PF driver and it must be known to the > vfio-pci based VF driver. This vf-token is set by the PF driver before VF > drivers can access the device. vfio-pci driver and qemu support vf-token. > This

Re: [RFC: vf-token 1/5] virpci: Define vf-token

2023-10-06 Thread Peter Krempa
On Thu, Oct 05, 2023 at 16:05:00 -0700, Vivek Kashyap wrote: > Define the vf-token extension for PCI device > > Signed-off-by: Vivek Kashyap > --- > src/util/virpci.h | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/src/util/virpci.h b/src/util/virpci.h > index

Re: [RFC: vf-token 5/5] qemu: validate and generate vf-token on command line

2023-10-06 Thread Peter Krempa
On Thu, Oct 05, 2023 at 16:05:04 -0700, Vivek Kashyap wrote: > Introduce a validation function for vf-token support in qemu > and generate vf-token device attribute in qmeu command line. > > Signed-off-by: Vivek Kashyap > --- > src/qemu/qemu_command.c | 27 --- >