Re: [libvirt] [PATCHv2 02/15] blockjob: wire up qemu async virDomainBlockJobAbort

2012-04-06 Thread Adam Litke
On Thu, Apr 05, 2012 at 10:36:48PM -0600, Eric Blake wrote: From: Adam Litke a...@us.ibm.com Without the VIR_DOMAIN_BLOCK_JOB_ABORT_ASYNC flag, libvirt will internally poll using qemu's query-block-jobs API and will not return until the operation has been completed. API users

Re: [libvirt] [PATCHv2 01/15] blockjob: add API for async virDomainBlockJobAbort

2012-04-06 Thread Adam Litke
On Thu, Apr 05, 2012 at 10:36:47PM -0600, Eric Blake wrote: From: Adam Litke a...@us.ibm.com Qemu has changed the semantics of the block_job_cancel API. The original qed implementation (pretty much only backported to RHEL 6.2 qemu) was synchronous (ie. upon command completion, the operation

Re: [libvirt] [PATCH] network: disallow bandwidth/mac for bridged/macvtap networks

2014-01-24 Thread Adam Litke
to function unmodified. I considered it too disruptive to suddenly break working configs on the next reboot after a libvirt upgrade. Reviewed-by: Adam Litke ali...@redhat.com --- src/network/bridge_driver.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/src

Re: [libvirt] [PATCH 1/6] Add new API virDomainStreamDisk[Info] to header and drivers

2011-05-02 Thread Adam Litke
-0500, Adam Litke wrote: /* + * Disk Streaming + */ +typedef enum { +VIR_STREAM_DISK_ONE = 1, /* Stream a single disk unit */ +VIR_STREAM_DISK_START = 2, /* Stream the entire disk */ +VIR_STREAM_DISK_STOP = 4, /* Stop streaming a disk */ +} virDomainStreamDiskFlags

Re: [libvirt] [PATCH 1/6] Add new API virDomainStreamDisk[Info] to header and drivers

2011-05-09 Thread Adam Litke
On 05/09/2011 11:09 AM, Daniel P. Berrange wrote: On Mon, May 02, 2011 at 04:29:49PM -0500, Adam Litke wrote: After several long distractions, I am back to working on disk streaming. Before I hit the list with a new series of patches, I was hoping to reach some middle ground on the proposed

[libvirt] API Proposal: Block device streaming (V3)

2011-05-18 Thread Adam Litke
Version 2 of the block device streaming API diverged significantly from the original API provided by Qemu. In an effort to provide an API that is designed to work well for the specific task of streaming data to a local device from its backing store I am proposing this: version 3 of the block

Re: [libvirt] API Proposal: Block device streaming (V3)

2011-05-20 Thread Adam Litke
Hi Dan, thank you for another round of review. Stefan and Anthony, could you respond to Dan's suggestion of adding qemu events for stream completion and errors at the bottom of this message? On 05/20/2011 06:07 AM, Daniel P. Berrange wrote: On Wed, May 18, 2011 at 02:08:12PM -0500, Adam Litke

Re: [libvirt] [PATCHv4 1/4] vcpupin: inroduce a new libvir API (virDomainPinVcpuFlags)

2011-05-20 Thread Adam Litke
for the virDomainPinVcpuFlags() API? -- Adam Litke IBM Linux Technology Center -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv4 2/4] vcpupin: implement the code to address the new API in the qemu driver

2011-05-20 Thread Adam Litke
| + VIR_DOMAIN_VCPU_CONFIG, -1); Is this even possible since you already checked it at the top level? -- Adam Litke IBM Linux Technology Center -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv4 4/4] vcpupin: add the new options to virsh vcpupin command

2011-05-20 Thread Adam Litke
is hypervisor dependent). The --current switch doesn't even seem necessary. -- Adam Litke IBM Linux Technology Center -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv4 1/4] vcpupin: inroduce a new libvir API (virDomainPinVcpuFlags)

2011-05-23 Thread Adam Litke
On 05/20/2011 05:17 PM, Eric Blake wrote: On 05/20/2011 02:54 PM, Adam Litke wrote: I am really confused about what the default flags (VIR_DOMAIN_VCPU_CURRENT) actually means. It doesn't seem like I can ever know what it means from an API perspective (since it's behavior is arbitrary

[libvirt] API Proposal: virDomainBlockPull() (Block device streaming) V4

2011-05-23 Thread Adam Litke
on the backing file. This could be a virDomainBlockPull() without VIR_DOMAIN_BLOCK_PULL_CONTINUOUS and will allow libvirt to manage backing file security regardless of the pull mode used. -- Adam Litke IBM Linux Technology Center -- libvir-list mailing list libvir-list@redhat.com https

Re: [libvirt] API Proposal: virDomainBlockPull() (Block device streaming) V4

2011-05-24 Thread Adam Litke
On 05/24/2011 07:19 AM, Daniel P. Berrange wrote: On Mon, May 23, 2011 at 11:56:03AM -0500, Adam Litke wrote: Here is version 4 of the BlockStream API (now called BlockPull). Hopefully this version addresses all remaining concerns and I can begin to work on the code. Does everyone approve

Re: [libvirt] API Proposal: virDomainBlockPull() (Block device streaming) V4

2011-05-24 Thread Adam Litke
On 05/24/2011 07:16 AM, Daniel P. Berrange wrote: On Tue, May 24, 2011 at 01:00:04PM +0100, Stefan Hajnoczi wrote: On Mon, May 23, 2011 at 5:56 PM, Adam Litke a...@us.ibm.com wrote: /** * virDomainBlockPull: * @dom: pointer to domain object * @path: Fully-qualified filename of disk

Re: [libvirt] API Proposal: virDomainBlockPull() (Block device streaming) V4

2011-05-24 Thread Adam Litke
I need to clarify this a bit... On 05/24/2011 08:06 AM, Adam Litke wrote: On 05/24/2011 07:16 AM, Daniel P. Berrange wrote: On Tue, May 24, 2011 at 01:00:04PM +0100, Stefan Hajnoczi wrote: On Mon, May 23, 2011 at 5:56 PM, Adam Litke a...@us.ibm.com wrote: /** * virDomainBlockPull

[libvirt] API Proposal: virDomainBlockPull() V5

2011-05-24 Thread Adam Litke
) will indicate that the backing file has not been removed. -- Adam Litke IBM Linux Technology Center -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 7/7] test: Python Unittests for DomainBlockPull API

2011-06-01 Thread Adam Litke
*** Please do not consider for merging, example tests only *** Here are the testcases I am currently running to verify the correctness of this API. These are continuing to evolve. Signed-off-by: Adam Litke a...@us.ibm.com --- blockPull-test.py | 215

[libvirt] [PATCH 3/7] Implement virDomainBlockPull for the qemu driver

2011-06-01 Thread Adam Litke
.[ch]: implement commands using the qmp monitor Signed-off-by: Adam Litke a...@us.ibm.com --- src/qemu/qemu_driver.c | 112 +++- src/qemu/qemu_monitor.c | 16 + src/qemu/qemu_monitor.h | 13 src/qemu/qemu_monitor_json.c | 118

[libvirt] [PATCH 6/7] Asynchronous event for BlockPull completion

2011-06-01 Thread Adam Litke
monitor Signed-off-by: Adam Litke a...@us.ibm.com --- daemon/remote.c | 32 include/libvirt/libvirt.h.in | 27 + python/libvirt-override-virConnect.py | 12 python/libvirt-override.c | 51

[libvirt] [PATCH 5/7] Enable virDomainBlockPull in the python API.

2011-06-01 Thread Adam Litke
-override.c: manual overrides Signed-off-by: Adam Litke a...@us.ibm.com --- python/generator.py |5 +-- python/libvirt-override-api.xml | 14 ++ python/libvirt-override.c | 53 +++ 3 files changed, 69 insertions(+), 3 deletions

[libvirt] [PATCH 4/7] Enable the virDomainBlockPull API in virsh

2011-06-01 Thread Adam Litke
Signed-off-by: Adam Litke a...@us.ibm.com --- tools/virsh.c | 134 +++-- 1 files changed, 130 insertions(+), 4 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 2b16714..e04de60 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -3818,7

[libvirt] [PATCH 2/7] Add virDomainBlockPull support to the remote driver. The generator can handle DomainBlockPullAll and DomainBlockPullAbort. DomainBlockPull and DomainBlockPullInfo must be written

2011-06-01 Thread Adam Litke
* src/remote/remote_protocol.x: provide defines for the new entry points * src/remote/remote_driver.c daemon/remote.c: implement the client and server side * daemon/remote_generator.pl: Specify the manually-written functions Signed-off-by: Adam Litke a...@us.ibm.com --- daemon/remote.c

[libvirt] RFC: Add virDomainBlockPull API family to libvirt

2011-06-01 Thread Adam Litke
To help speed the provisioning process for large domains, new QED disks are created with backing to a template image. These disks are configured with copy on read such that blocks that are read from the backing file are copied to the new disk. This reduces I/O over a potentially costly path to

[libvirt] [PATCH 1/7] virDomainBlockPull: Add public symbols to libvirt API

2011-06-01 Thread Adam Litke
* src/libvirt.c: implement the main entry points * src/libvirt_public.syms: add them to the exported symbols Signed-off-by: Adam Litke a...@us.ibm.com --- src/libvirt.c | 252 +++ src/libvirt_public.syms |7 ++ 2 files changed, 259

[libvirt] [PATCH] Add new API virDomainBlockPull* to header and drivers

2011-06-01 Thread Adam Litke
entry to the driver structure * python/generator.py: fix compiler errors, the actual python bindings are implemented later Signed-off-by: Adam Litke a...@us.ibm.com --- include/libvirt/libvirt.h.in | 92 ++ python/generator.py |3 + src

Re: [libvirt] [PATCH 2/7] Add virDomainBlockPull support to the remote driver. The generator can handle DomainBlockPullAll and DomainBlockPullAbort. DomainBlockPull and DomainBlockPullInfo must be wri

2011-06-01 Thread Adam Litke
On 06/01/2011 12:13 PM, Matthias Bolte wrote: 2011/6/1 Adam Litke a...@us.ibm.com: This commit has a pretty long summary line. Fixed. * src/remote/remote_protocol.x: provide defines for the new entry points * src/remote/remote_driver.c daemon/remote.c: implement the client and server

Re: [libvirt] [PATCH 2/7] Add virDomainBlockPull support to the remote driver. The generator can handle DomainBlockPullAll and DomainBlockPullAbort. DomainBlockPull and DomainBlockPullInfo must be wri

2011-06-01 Thread Adam Litke
On 06/01/2011 12:27 PM, Matthias Bolte wrote: 2011/6/1 Adam Litke a...@us.ibm.com: * src/remote/remote_protocol.x: provide defines for the new entry points * src/remote/remote_driver.c daemon/remote.c: implement the client and server side * daemon/remote_generator.pl: Specify the manually

Re: [libvirt] [PATCH] Add new API virDomainBlockPull* to header and drivers

2011-06-01 Thread Adam Litke
Sorry, this one was left off from the initial post. It comes first in the series. -- Adam Litke IBM Linux Technology Center -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] RFC (v2): Add virDomainBlockPull API family to libvirt

2011-06-06 Thread Adam Litke
Changes since V1: - Rebased to incorporate changes to generator and removal of static driver structure initializers - Other small fixups suggested by Matthias Bolte To help speed the provisioning process for large domains, new QED disks are created with backing to a template image. These

[libvirt] [PATCH 3/8] Add virDomainBlockPull support to the remote driver

2011-06-06 Thread Adam Litke
* src/remote_protocol-structs: structure definitions for protocol verification Signed-off-by: Adam Litke a...@us.ibm.com --- daemon/remote.c | 71 ++ src/remote/remote_driver.c | 68 src/remote

[libvirt] [PATCH 1/8] Add new API virDomainBlockPull* to headers

2011-06-06 Thread Adam Litke
/generator.py: fix compiler errors, the actual python bindings are implemented later * src/libvirt_public.syms: export symbols Signed-off-by: Adam Litke a...@us.ibm.com --- include/libvirt/libvirt.h.in | 39 +++ python/generator.py |3 +++ src/driver.h

[libvirt] [PATCH 8/8] test: Python Unittests for DomainBlockPull API

2011-06-06 Thread Adam Litke
*** Please do not consider for merging, example tests only *** Here are the testcases I am currently running to verify the correctness of this API. These are continuing to evolve. Signed-off-by: Adam Litke a...@us.ibm.com --- blockPull-test.py | 245

[libvirt] [PATCH 4/8] Implement virDomainBlockPull for the qemu driver

2011-06-06 Thread Adam Litke
.[ch]: implement commands using the qmp monitor Signed-off-by: Adam Litke a...@us.ibm.com --- src/qemu/qemu_driver.c | 108 +++ src/qemu/qemu_monitor.c | 16 + src/qemu/qemu_monitor.h | 13 src/qemu/qemu_monitor_json.c | 117

[libvirt] [PATCH 7/8] Asynchronous event for BlockPull completion

2011-06-06 Thread Adam Litke
monitor Signed-off-by: Adam Litke a...@us.ibm.com --- daemon/remote.c | 32 include/libvirt/libvirt.h.in | 27 + python/libvirt-override-virConnect.py | 12 python/libvirt-override.c | 51

[libvirt] [PATCH 5/8] Enable the virDomainBlockPull API in virsh

2011-06-06 Thread Adam Litke
Signed-off-by: Adam Litke a...@us.ibm.com --- tools/virsh.c | 134 +++-- 1 files changed, 130 insertions(+), 4 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index d98be1c..15c5b67 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -4095,7

[libvirt] [PATCH 6/8] Enable virDomainBlockPull in the python API.

2011-06-06 Thread Adam Litke
-override.c: manual overrides Signed-off-by: Adam Litke a...@us.ibm.com --- python/generator.py |5 +-- python/libvirt-override-api.xml | 14 ++ python/libvirt-override.c | 53 +++ 3 files changed, 69 insertions(+), 3 deletions

[libvirt] [PATCH 2/8] virDomainBlockPull: Implement the main entry points

2011-06-06 Thread Adam Litke
* src/libvirt.c: implement the main entry points Signed-off-by: Adam Litke a...@us.ibm.com --- src/libvirt.c | 252 + 1 files changed, 252 insertions(+), 0 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index cbe1926..46d32cf

[libvirt] CFS Hardlimits and the libvirt cgroups implementation

2011-06-08 Thread Adam Litke
in order to figure out where to hang these cgroups). Thanks for sticking with me through this long email. I greatly appreciate your thoughts and comments on these topics. -- Adam Litke IBM Linux Technology Center -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman

[libvirt] RFC (v3): Add virDomainBlockPull API family to libvirt

2011-06-09 Thread Adam Litke
I didn't receive too many comments on the last round. That probably means everybody has been busy with the 0.9.2 release. I think this is ready to be committed but we can wait until the qemu side has gone up (which should happen any day now). Changes since V2: - Rebased - Ensure error

[libvirt] [PATCH 8/8] test: Python Unittests for DomainBlockPull API

2011-06-09 Thread Adam Litke
*** Please do not consider for merging, example tests only *** Here are the testcases I am currently running to verify the correctness of this API. These are continuing to evolve. Signed-off-by: Adam Litke a...@us.ibm.com --- blockPull-test.py | 301

[libvirt] [PATCH 6/8] Enable virDomainBlockPull in the python API.

2011-06-09 Thread Adam Litke
-override.c: manual overrides Signed-off-by: Adam Litke a...@us.ibm.com --- python/generator.py |5 +-- python/libvirt-override-api.xml | 14 ++ python/libvirt-override.c | 53 +++ 3 files changed, 69 insertions(+), 3 deletions

[libvirt] [PATCH 4/8] Implement virDomainBlockPull for the qemu driver

2011-06-09 Thread Adam Litke
.[ch]: implement commands using the qmp monitor Signed-off-by: Adam Litke a...@us.ibm.com --- src/qemu/qemu_driver.c | 108 + src/qemu/qemu_monitor.c | 16 src/qemu/qemu_monitor.h | 13 src/qemu/qemu_monitor_json.c | 131

[libvirt] [PATCH 5/8] Enable the virDomainBlockPull API in virsh

2011-06-09 Thread Adam Litke
Signed-off-by: Adam Litke a...@us.ibm.com --- tools/virsh.c | 134 +++-- 1 files changed, 130 insertions(+), 4 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 123781f..81c2e71 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -4095,7

[libvirt] [PATCH 7/8] Asynchronous event for BlockPull completion

2011-06-09 Thread Adam Litke
monitor Signed-off-by: Adam Litke a...@us.ibm.com --- daemon/remote.c | 32 include/libvirt/libvirt.h.in | 27 + python/libvirt-override-virConnect.py | 12 python/libvirt-override.c | 51

[libvirt] [PATCH 2/8] virDomainBlockPull: Implement the main entry points

2011-06-09 Thread Adam Litke
* src/libvirt.c: implement the main entry points Signed-off-by: Adam Litke a...@us.ibm.com --- src/libvirt.c | 252 + 1 files changed, 252 insertions(+), 0 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 997d4a2..71afea9

[libvirt] [PATCH 3/8] Add virDomainBlockPull support to the remote driver

2011-06-09 Thread Adam Litke
* src/remote_protocol-structs: structure definitions for protocol verification Signed-off-by: Adam Litke a...@us.ibm.com --- daemon/remote.c | 71 ++ src/remote/remote_driver.c | 68 src/remote

[libvirt] [PATCH 1/8] Add new API virDomainBlockPull* to headers

2011-06-09 Thread Adam Litke
/generator.py: fix compiler errors, the actual python bindings are implemented later * src/libvirt_public.syms: export symbols Signed-off-by: Adam Litke a...@us.ibm.com --- include/libvirt/libvirt.h.in | 39 +++ python/generator.py |3 +++ src/driver.h

Re: [libvirt] CFS Hardlimits and the libvirt cgroups implementation

2011-06-10 Thread Adam Litke
: A percentage of the period that the cpus may run. This way 'period' can be omitted or changed independently from quota. -- Adam Litke IBM Linux Technology Center -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] CFS Hardlimits and the libvirt cgroups implementation

2011-06-10 Thread Adam Litke
On 06/10/2011 04:20 AM, Daniel P. Berrange wrote: On Wed, Jun 08, 2011 at 02:20:23PM -0500, Adam Litke wrote: Hi all. In this post I would like to bring up 3 issues which are tightly related: 1. unwanted behavior when using cfs hardlimits with libvirt, 2. Scaling cputune.share according

Re: [libvirt] CFS Hardlimits and the libvirt cgroups implementation

2011-06-10 Thread Adam Litke
it. -- Adam Litke IBM Linux Technology Center -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 2/8] virDomainBlockPull: Implement the main entry points

2011-06-14 Thread Adam Litke
On 06/14/2011 04:49 AM, Daniel P. Berrange wrote: On Thu, Jun 09, 2011 at 12:10:08PM -0500, Adam Litke wrote: +if (flags != 0) { +virLibDomainError(VIR_ERR_INVALID_ARG, + _(flags must be zero)); +goto error; +} We don't want to check

Re: [libvirt] [PATCH 3/8] Add virDomainBlockPull support to the remote driver

2011-06-14 Thread Adam Litke
On 06/14/2011 04:49 AM, Daniel P. Berrange wrote: On Thu, Jun 09, 2011 at 12:10:09PM -0500, Adam Litke wrote: The generator can handle DomainBlockPullAll and DomainBlockPullAbort. DomainBlockPull and DomainBlockPullInfo must be written by hand. * src/remote/remote_protocol.x: provide

Re: [libvirt] [PATCH 5/8] Enable the virDomainBlockPull API in virsh

2011-06-14 Thread Adam Litke
the flags '--all' and '--abort' to the blockpull command. Now we have just two virsh commands: blockpull and blockpullinfo. -- Adam Litke IBM Linux Technology Center -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 7/8] Asynchronous event for BlockPull completion

2011-06-14 Thread Adam Litke
should just discard the event rather than emitting one with a zero-length path. Yes, this makes sense. Dome for the next series. -- Adam Litke IBM Linux Technology Center -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 1/8] Add new API virDomainBlockPull* to headers

2011-06-14 Thread Adam Litke
/generator.py: fix compiler errors, the actual python bindings are implemented later * src/libvirt_public.syms: export symbols Signed-off-by: Adam Litke a...@us.ibm.com Acked-by: Daniel P. Berrange berra...@redhat.com --- include/libvirt/libvirt.h.in | 39 +++ python

[libvirt] [PATCH 3/8] Add virDomainBlockPull support to the remote driver

2011-06-14 Thread Adam Litke
* src/remote_protocol-structs: structure definitions for protocol verification Signed-off-by: Adam Litke a...@us.ibm.com --- daemon/remote.c | 71 ++ src/remote/remote_driver.c | 68 src/remote

[libvirt] [PATCH 8/8] test: Python Unittests for DomainBlockPull API

2011-06-14 Thread Adam Litke
*** Please do not consider for merging, example tests only *** Here are the testcases I am currently running to verify the correctness of this API. These are continuing to evolve. Signed-off-by: Adam Litke a...@us.ibm.com --- blockPull-test.py | 301

[libvirt] [PATCH 2/8] virDomainBlockPull: Implement the main entry points

2011-06-14 Thread Adam Litke
* src/libvirt.c: implement the main entry points Signed-off-by: Adam Litke a...@us.ibm.com Acked-by: Daniel P. Berrange berra...@redhat.com --- src/libvirt.c | 228 + 1 files changed, 228 insertions(+), 0 deletions(-) diff --git a/src

[libvirt] RFC (v4): Add virDomainBlockPull API family to libvirt

2011-06-14 Thread Adam Litke
This round addresses all review comments from the last posting and should be ready for inclusion. Thanks for the review. Changes since V3: - Don't check flags at the libvirt API level - qemu: Check disk-type before looking up alias - virsh: Merge blockpullall into blockpull - event: Drop

[libvirt] [PATCH 7/8] Asynchronous event for BlockPull completion

2011-06-14 Thread Adam Litke
monitor Signed-off-by: Adam Litke a...@us.ibm.com --- daemon/remote.c | 32 include/libvirt/libvirt.h.in | 27 + python/libvirt-override-virConnect.py | 12 python/libvirt-override.c | 51

[libvirt] [PATCH 4/8] Implement virDomainBlockPull for the qemu driver

2011-06-14 Thread Adam Litke
.[ch]: implement commands using the qmp monitor Signed-off-by: Adam Litke a...@us.ibm.com Acked-by: Daniel P. Berrange berra...@redhat.com --- src/qemu/qemu_driver.c | 112 ++ src/qemu/qemu_monitor.c | 16 src/qemu/qemu_monitor.h | 13 src

Re: [libvirt] [PATCH 3/8] Add virDomainBlockPull support to the remote driver

2011-06-15 Thread Adam Litke
Thanks Eric. The push looks good. There is a small (known) issue with the text monitor interface and a one-liner will fix that. I can send that out once I have verified against upstream qemu. On 06/14/2011 10:56 PM, Eric Blake wrote: On 06/14/2011 08:36 AM, Adam Litke wrote: The generator

Re: [libvirt] [PATCH RFC 0/5] support cpu bandwidth in libvirt

2011-06-15 Thread Adam Litke
+ tests/qemuxml2argvdata/qemuxml2argv-cputune.xml |2 + 10 files changed, 328 insertions(+), 36 deletions(-) -- Adam Litke IBM Linux Technology Center -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH RFC 0/5] support cpu bandwidth in libvirt

2011-06-16 Thread Adam Litke
then. No need for a structure. -- Adam Litke IBM Linux Technology Center -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 06/10] vcpubandwidth: introduce two new libvirt APIs

2011-07-05 Thread Adam Litke
: 100/25 So why introduce VCPU level apis? Adam Litke said IBM's performance team nead to control cpu bandwidth for each vcpu. Nikunj is correct here. We only need to ensure that the bandwidth is distributed equally between all of the cpus. This can be accomplished internally

[libvirt] Exposing qemu support for SDL via capabilities

2011-07-08 Thread Adam Litke
it as a guest feature via the capabilities API call. I was thinking the node '/capabilities/guest/features/sdl' could be added when qemu supports SDL. Is this a good idea? -- Adam Litke IBM Linux Technology Center -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman

Re: [libvirt] Exposing qemu support for SDL via capabilities

2011-07-08 Thread Adam Litke
On 07/08/2011 10:14 AM, Richard W.M. Jones wrote: On Fri, Jul 08, 2011 at 09:19:46AM -0500, Adam Litke wrote: Hi all, In order to nicely support domains that use qemu's SDL support, libvirt-cim is looking for a way to confirm if the underlying qemu emulator can support SDL. Libvirt

[libvirt] RFC New virDomainBlockPull API family to libvirt

2011-07-13 Thread Adam Litke
, int status, void *opaque); -- Adam Litke IBM Linux Technology Center -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] RFC New virDomainBlockPull API family to libvirt

2011-07-14 Thread Adam Litke
On 07/13/2011 08:04 PM, Daniel Veillard wrote: On Wed, Jul 13, 2011 at 03:46:30PM -0500, Adam Litke wrote: Unfortunately, after committing the blockPull API to libvirt, the qemu community decided to change the API somewhat and we needed to revert the libvirt implementation. Now

Re: [libvirt] RFC New virDomainBlockPull API family to libvirt

2011-07-14 Thread Adam Litke
On 07/14/2011 04:21 AM, Jiri Denemark wrote: On Wed, Jul 13, 2011 at 15:46:30 -0500, Adam Litke wrote: ... /* * BlockPull API */ /* An iterator for initiating and monitoring block pull operations */ typedef unsigned long long virDomainBlockPullCursor; typedef struct

Re: [libvirt] RFC New virDomainBlockPull API family to libvirt

2011-07-14 Thread Adam Litke
-0500, Adam Litke wrote: ... /* * BlockPull API */ /* An iterator for initiating and monitoring block pull operations */ typedef unsigned long long virDomainBlockPullCursor; typedef struct _virDomainBlockPullInfo virDomainBlockPullInfo; struct _virDomainBlockPullInfo

Re: [libvirt] RFC New virDomainBlockPull API family to libvirt

2011-07-15 Thread Adam Litke
On 07/15/2011 05:39 AM, Stefan Hajnoczi wrote: On Thu, Jul 14, 2011 at 7:47 PM, Adam Litke a...@us.ibm.com wrote: On 07/13/2011 08:04 PM, Daniel Veillard wrote: On Wed, Jul 13, 2011 at 03:46:30PM -0500, Adam Litke wrote: Unfortunately, after committing the blockPull API to libvirt, the qemu

[libvirt] RFC (V2) New virDomainBlockPull API family to libvirt

2011-07-15 Thread Adam Litke
virDomainBlockPull(virDomainPtr dom, const char *path, unsigned long bandwidth, unsigned int flags); -- Adam Litke IBM Linux Technology Center -- libvir-list mailing list libvir-list

Re: [libvirt] RFC New virDomainBlockPull API family to libvirt

2011-07-18 Thread Adam Litke
) - value: maximum speed, in bytes per second (json-int) Errors: NotSupported: job type does not support speed setting Example: - { execute: block_job_set_speed, arguments: { device: virtio0, value: 1024 } } Stefan -- Adam Litke IBM Linux Technology Center -- libvir-list

Re: [libvirt] [PATCH RFC v3 3/6] Update XML Schema for new entries

2011-07-18 Thread Adam Litke
=cpuquota +data type=long + param name=pattern-?[0-9]+/param + param name=maxInclusive18446744073709551/param + param name='minInclusive'-1/param +/data + /define define name=PortNumber data type=short param name=minInclusive-1/param -- Adam Litke IBM

Re: [libvirt] [PATCH RFC v3 5/6] qemu: Implement cfs_period and cfs_quota's modification

2011-07-18 Thread Adam Litke
)); +goto cleanup; +} + +*nparams = 3; +} else { +*nparams = 1; +} + ret = 0; cleanup: -- Adam Litke IBM Linux Technology Center -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3 4/6] qemu: Implement period and quota tunable XML configuration and parsing

2011-07-18 Thread Adam Litke
. As written, the vm will be essentially capped at 1 vcpu worth of quota regardless of the number of vcpus. You will also have to apply this logic in reverse when reporting the scheduler statistics so that the quota number is a per-vcpu quantity. -- Adam Litke IBM Linux Technology Center

Re: [libvirt] [PATCH v3 4/6] qemu: Implement period and quota tunable XML configuration and parsing

2011-07-19 Thread Adam Litke
On 07/18/2011 07:46 PM, Wen Congyang wrote: At 07/19/2011 04:35 AM, Adam Litke Write: This is looking good to me. I am pleased to see that the global case is handled as expected when per-vcpu threads are not active. On 07/18/2011 04:42 AM, Wen Congyang wrote: snip +int

Re: [libvirt] [PATCH v3 4/6] qemu: Implement period and quota tunable XML configuration and parsing

2011-07-19 Thread Adam Litke
On 07/18/2011 07:51 PM, Wen Congyang wrote: At 07/19/2011 04:59 AM, Adam Litke Write: On 07/18/2011 04:42 AM, Wen Congyang wrote: +int qemuSetupCgroupForVcpu(struct qemud_driver *driver, virDomainObjPtr vm) +{ +virCgroupPtr cgroup = NULL; +virCgroupPtr cgroup_vcpu = NULL

Re: [libvirt] [PATCH RESEND RFC v4 1/6] Introduce the function virCgroupForVcpu

2011-07-21 Thread Adam Litke
instead go to a I/O thread or a display thread, etc. IMHO we should only be doing controls at the whole VM level here. Daniel -- Adam Litke IBM Linux Technology Center -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH RESEND RFC v4 5/6] qemu: Implement cfs_period and cfs_quota's modification

2011-07-21 Thread Adam Litke
to: *quota *= vm-def-vcpus; ? -- Adam Litke IBM Linux Technology Center -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH RESEND RFC v4 5/6] qemu: Implement cfs_period and cfs_quota's modification

2011-07-21 Thread Adam Litke
(per-vcpu if supported, multiply by nvcpus and apply globally if vcpu threads are not supported). -- Adam Litke IBM Linux Technology Center -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH RESEND RFC v4 1/6] Introduce the function virCgroupForVcpu

2011-07-21 Thread Adam Litke
On 07/21/2011 08:34 AM, Daniel P. Berrange wrote: On Thu, Jul 21, 2011 at 07:54:05AM -0500, Adam Litke wrote: Added Anthony to give him the opportunity to address the finer points of this one especially with respect to the qemu IO thread(s). This feature is really about capping the compute

Re: [libvirt] [PATCH RESEND RFC v4 1/6] Introduce the function virCgroupForVcpu

2011-07-21 Thread Adam Litke
On 07/21/2011 09:29 AM, Daniel P. Berrange wrote: On Thu, Jul 21, 2011 at 08:49:28AM -0500, Adam Litke wrote: On 07/21/2011 08:34 AM, Daniel P. Berrange wrote: On Thu, Jul 21, 2011 at 07:54:05AM -0500, Adam Litke wrote: Added Anthony to give him the opportunity to address the finer points

[libvirt] RFC (V2) New virDomainBlockPull API family to libvirt

2011-07-21 Thread Adam Litke
Here are the patches to implement the BlockPull/BlockJob API as discussed and agreed to. I am testing with a python script (included for completeness as the final patch). The qemu monitor interface is not expected to change in the future. Stefan is planning to submit placeholder commands for

[libvirt] [PATCH 5/8] Enable the virDomainBlockPull API in virsh

2011-07-21 Thread Adam Litke
Define two new virsh commands: * blockpull: Initiate a blockPull for the given disk * blockjob: Retrieve progress info, modify speed, and cancel active block jobs Share print_job_progress() with the migration code. * tools/virsh.c: implement the new commands Signed-off-by: Adam Litke

[libvirt] [PATCH 1/8] Add new API virDomainBlockPull* to headers

2011-07-21 Thread Adam Litke
/generator.py: fix compiler errors, the actual python bindings are implemented later * src/libvirt_public.syms: export symbols * docs/apibuild.py: Extend 'unsigned long' parameter exception to this API Signed-off-by: Adam Litke a...@us.ibm.com --- docs/apibuild.py |7 - include

[libvirt] [PATCH 4/8] Implement virDomainBlockPull for the qemu driver

2011-07-21 Thread Adam Litke
the proper qemu monitor commands. * src/qemu/qemu_monitor_json.[ch]: implement commands using the qmp monitor Signed-off-by: Adam Litke a...@us.ibm.com --- src/qemu/qemu_driver.c | 113 + src/qemu/qemu_monitor.c | 18 + src/qemu/qemu_monitor.h | 13

[libvirt] [PATCH 7/8] Asynchronous event for BlockJob completion

2011-07-21 Thread Adam Litke
, src/qemu/qemu_monitor_json.c: Watch for BLOCK_STREAM_COMPLETED event from QEMU monitor Signed-off-by: Adam Litke a...@us.ibm.com --- daemon/remote.c | 31 ++ include/libvirt/libvirt.h.in | 29 + python/libvirt-override

[libvirt] [PATCH 2/8] virDomainBlockPull: Implement the main entry points

2011-07-21 Thread Adam Litke
* src/libvirt.c: implement the main entry points Signed-off-by: Adam Litke a...@us.ibm.com --- src/libvirt.c | 226 + 1 files changed, 226 insertions(+), 0 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 39e2041..5ca8c03

[libvirt] [PATCH 6/8] Enable virDomainBlockPull in the python API.

2011-07-21 Thread Adam Litke
virDomainGetBlockJobInfo requires manual override since it returns a custom type. * python/generator.py: reenable bindings for this entry point * python/libvirt-override-api.xml python/libvirt-override.c: manual overrides Signed-off-by: Adam Litke a...@us.ibm.com --- python/generator.py

[libvirt] [PATCH 3/8] Add virDomainBlockPull support to the remote driver

2011-07-21 Thread Adam Litke
: structure definitions for protocol verification * src/rpc/gendispatch.pl: Permit some unsigned long parameters Signed-off-by: Adam Litke a...@us.ibm.com --- daemon/remote.c | 42 ++ src/remote/remote_driver.c | 42

[libvirt] [PATCH 8/8] Test the blockJob/BlockPull API

2011-07-21 Thread Adam Litke
This patch is for information only and should not be comitted. Signed-off-by: Adam Litke a...@us.ibm.com --- blockPull-test.py | 281 + 1 files changed, 281 insertions(+), 0 deletions(-) create mode 100644 blockPull-test.py diff --git

Re: [libvirt] [PATCH RESEND RFC v4 1/6] Introduce the function virCgroupForVcpu

2011-07-22 Thread Adam Litke
as you agree with Daniel P. Berrange's idea. If so, I will implement it. Yes, I am in agreement. -- Adam Litke IBM Linux Technology Center -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] RFC (V2) New virDomainBlockPull API family to libvirt

2011-07-22 Thread Adam Litke
Thanks Daniel. The upstream code is looking good. I will work on adding some documentation to the development guide. On 07/22/2011 01:07 AM, Daniel Veillard wrote: On Thu, Jul 21, 2011 at 01:55:04PM -0500, Adam Litke wrote: Here are the patches to implement the BlockPull/BlockJob API

Re: [libvirt] [PATCH] Fix bug #611823 prohibit pools with duplicate storage

2011-07-29 Thread Adam Litke
) 0) +goto cleanup; + if (virStorageBackendForType(def-type) == NULL) goto cleanup; ... and here. -- Adam Litke IBM Linux Technology Center -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] doc: Document the Block Job API

2011-08-12 Thread Adam Litke
Hi DV, This patch adds some basic documentation to the development guide for the Block Job APIs as you requested. Also included is a sample program that shows end-to-end use of the BlockPull operation. I hope this is close to what you had in mind. Signed-off-by: Adam Litke a...@us.ibm.com

Re: [libvirt] RFC (V2) New virDomainBlockPull API family to libvirt

2011-08-15 Thread Adam Litke
implementation. Let me know if you would like a link to some qemu patches that support this functionality for qed images. -- Adam Litke IBM Linux Technology Center -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] qemu: Get memory balloon info correctly for text monitor

2011-08-15 Thread Adam Litke
and so the extra fields are not present in the info balloon response. -- Adam Litke IBM Linux Technology Center -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] qemu: Get memory balloon info correctly for text monitor

2011-08-15 Thread Adam Litke
) { -ret = qemuMonitorParseExtraBalloonInfo(offset, stats, nr_stats); -} +ret = qemuMonitorParseBalloonInfo(offset, stats, nr_stats); } VIR_FREE(reply); -- Adam Litke IBM Linux Technology Center -- libvir-list mailing list libvir-list@redhat.com https

  1   2   3   >