[libvirt] [PATCH 2/2] numa: Rewrite virNumaGetNodeCPUs() to query CPUs dynamically.

numa_node_to_cpus() uses an internal cache to store the mapping between NUMA nodes and CPUs (see Bug #1213835), which means long-running processes such as libvirtd will get stale data if CPU hotplugging is used during their lifetime. The function has been rewritten to collect the information

[libvirt] [PATCH 1/2] nodeinfo: Export nodeGetCPUValue() after renaming it.

The previous name was virNodeGetCpuValue(), which was not consistent with the other functions exported by the same file. --- src/libvirt_private.syms | 1 + src/nodeinfo.c | 28 +++- src/nodeinfo.h | 6 +- 3 files changed, 21 insertions(+), 14

[libvirt] [PATCH 0/2] Don't rely on cached topology information

brought online. This happens because the list of CPUs in a node is queried using libnuma, which maintains its internal cache. This patch changes the code so that the required information is extracted from sysfs instead, making the data displayed to the user always fresh. Andrea Bolognani (2

[libvirt] [PATCH] tests: Fix grammar in comments.

Replace all occurrences of stream write to differences to with stream to write differences to. --- tests/testutils.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/testutils.c b/tests/testutils.c index 6a8fe6a..89026c6 100644 --- a/tests/testutils.c +++

Re: [libvirt] [PATCH 2/2] numa: Rewrite virNumaGetNodeCPUs() to query CPUs dynamically.

might be completely off, so feel free to point out any issue with it :) Cheers. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1213835 -- Andrea Bolognani abolo...@redhat.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] tests: Fix grammar in comments.

On Monday, May 4, 2015 at 3:04:24 PM, Michal Privoznik wrote: ACKed pushed. Thanks! -- Andrea Bolognani abolo...@redhat.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] Ignore Vim swap files.

This removes some noise when you're working on the repository and also have a bunch of source files open in Vim in another terminal. --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 7bcf359..1a5cf8e 100644 --- a/.gitignore +++ b/.gitignore @@ -18,6

[libvirt] [PATCH] conf: Ignore panic device on pSeries.

The guest firmware already provides the same functionality, so we can just safely drop the panic/ element from the domain definition. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1182388 --- src/conf/domain_conf.c | 17 +++-

Re: [libvirt] [PATCH] Ignore Vim swap files.

for the pointer :) -- Andrea Bolognani abolo...@redhat.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] conf: Ignore panic device on pSeries.

qemu_domain.c:qemuDomainDefPostParse instead My mistake. Thanks both to you and Daniel for pointing that out. Cheers. -- Andrea Bolognani abolo...@redhat.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v2] qemu: Deal with panic device on pSeries.

The guest firmware provides the same functionality as the pvpanic device, which is not available in QEMU on pSeries: make sure the XML reflects this fact by automatically adding a panic/ element when not already present. On the other hand, unlike the pvpanic device, the guest firmware can't be

[libvirt] [PATCH 1/3] virsh: Improve error message on integer value parsing failure.

Replace more than 30 ad-hoc error messages with a single, generic one that contains the name of the option being processed and some hints to help the user understand what could have gone wrong. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1207043 --- tests/vcpupin| 4

[libvirt] [PATCH 2/3] virsh: Fix dommemstat --period option type.

The option didn't have VSH_OT_INT type even thought it's expected to be numeric, as shown by the fact that vshCommandOptInt() is later used to retrieve its value. --- tools/virsh-domain-monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-domain-monitor.c

[libvirt] [PATCH 0/3] virsh: Fix and enhance handling of numeric options

The first commit improves error messages by making them much more consistent and a little bit more helpful to the user. The other two commits contain smaller fixes and enhancement. Andrea Bolognani (3): virsh: Improve error message on integer value parsing failure. virsh: Fix dommemstat

[libvirt] [PATCH 3/3] virsh: Improve handling of send-process-signal --pid.

Use vshCommandOptLongLong() instead of retrieving the value as a string and converting it to a number manually. --- tools/virsh-domain.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 10d01b6..36f3e6c 100644 ---

Re: [libvirt] [PATCH] conf: Don't output cpu tag if it contains no information.

On Mon, 2015-04-13 at 09:39 +0200, Erik Skultety wrote: Other than that, it looks good, so I removed the comments marked above and pushed. Congratulations to your first patch in libvirt ;). Thank you for reviewing and pushing the patch! Have a nice day. -- Andrea Bolognani abolo

[libvirt] [PATCH 0/2] virsh: Further improve handling of integer options

As suggested by Michal: now that we have a generic error message for failures related to the parsing of integer options, it makes sense to perform the corresponding check in a single spot instead of replicating it every time vshCommandOpt*() is used. Andrea Bolognani (2): virsh: Pass vshControl

[libvirt] [PATCH 1/2] virsh: Pass vshControl to all vshCommandOpt*() calls.

This will allow us to use vshError() to report errors from inside vshCommandOpt*(), instead of replicating the same logic and error messages all over the place. We also have more context inside the vshCommandOpt*() functions, for example the actual value used on the command line, which means we

[libvirt] [PATCH 2/2] virsh: Move error messages inside vshCommandOpt*() functions.

--- tests/vcpupin| 4 +- tools/virsh-domain-monitor.c | 9 +-- tools/virsh-domain.c | 134 +++ tools/virsh-host.c | 57 +++--- tools/virsh-interface.c | 6 +- tools/virsh-network.c| 6 +-

[libvirt] [PATCH v4 1/6] tests: Add a bunch of new tests to virsh-optparse

The new tests deal with numeric options of three kinds: regular, scaled and timeouts. For each, both valid and invalid inputs are provided, hopefully covering all cases: this should allow us to avoid regressions when changing the relevant code in virsh. --- tests/virsh-optparse | 179

[libvirt] [PATCH v4 6/6] virsh: Move error messages inside vshCommandOpt*() functions

--- tests/vcpupin| 4 +- tests/virsh-optparse | 26 - tools/virsh-domain-monitor.c | 9 +-- tools/virsh-domain.c | 134 +++ tools/virsh-host.c | 61 +++- tools/virsh-interface.c |

[libvirt] [PATCH v4 0/6] virsh: Further improve handling of integer options

As suggested by Michal: now that we have a generic error message for failures related to the parsing of integer options, it makes sense to perform the corresponding check in a single spot instead of replicating it every time vshCommandOpt*() is used. Andrea Bolognani (6): tests: Add a bunch

[libvirt] [PATCH v4 2/6] virsh: Use standard error messages in vshCommandOptTimeoutToMs()

I missed this in the first time around, thanks Michal for noticing. --- tests/virsh-optparse | 12 ++-- tools/virsh.c| 8 ++-- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/tests/virsh-optparse b/tests/virsh-optparse index 37a8d42..952fcc4 100755 ---

[libvirt] [PATCH v4 3/6] virsh: Improve vshCommandOptTimeoutToMs()

Use vshCommandOptUInt() instead of parsing the value as a signed integer and checking whether it's positive afterwards. Improve comments as well. --- tools/virsh.c | 45 +++-- 1 file changed, 27 insertions(+), 18 deletions(-) diff --git a/tools/virsh.c

[libvirt] [PATCH v4 4/6] virsh: Make vshCommandOptScaledInt() use vshCommandOpt()

This aligns it to the other vshCommandOpt*() functions. --- tools/virsh.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 55caa87..cd2bfef 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -1804,16 +1804,16 @@

[libvirt] [PATCH v4 5/6] virsh: Pass vshControl to all vshCommandOpt*() calls

This will allow us to use vshError() to report errors from inside vshCommandOpt*(), instead of replicating the same logic and error messages all over the place. We also have more context inside the vshCommandOpt*() functions, for example the actual value used on the command line, which means we

Re: [libvirt] [PATCH v3 0/5] virsh: Further improve handling of integer options

me know if there's more work to do. Cheers. -- Andrea Bolognani Software Engineer - Virtualization Team $ python -c print('a'.join(['', 'bologn', '@redh', 't.com'])) -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3 2/5] virsh: Improve vshCommandOptTimeoutToMs().

we can definitely do that, I don't feel strongly either way :) Cheers. -- Andrea Bolognani Software Engineer - Virtualization Team $ python -c print('a'.join(['', 'bologn', '@redh', 't.com'])) -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] qemu: Capitalize storage in qemuDomainAttachUSBMassStorageDevice()

--- src/qemu/qemu_hotplug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 94ebe35..3562de6 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -680,7 +680,7 @@

Re: [libvirt] [PATCH] maint: remove redundant apostrophes from 'its'

+- 12 files changed, 13 insertions(+), 13 deletions(-) Redundant: I don't think it means what you think it means ;) Cheers. -- Andrea Bolognani Software Engineer - Virtualization Team $ python -c print('a'.join(['', 'bologn', '@redh', 't.com'])) -- libvir-list mailing list libvir-list

[libvirt] [PATCH] maint: Remove control characters from LGPL license file

--- COPYING.LESSER | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/COPYING.LESSER b/COPYING.LESSER index 4362b49..e5ab03e 100644 --- a/COPYING.LESSER +++ b/COPYING.LESSER @@ -55,7 +55,7 @@ modified by someone else and passed on, the recipients should know

Re: [libvirt] [PATCH v3 0/3] qemu: Deal with panic device on pSeries

On Mon, 2015-06-01 at 06:59 -0400, John Ferlan wrote: ACK series... I'll push soon. Thanks :) -- Andrea Bolognani Software Engineer - Virtualization Team $ python -c print('a'.join(['', 'bologn', '@redh', 't.com'])) -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com

Re: [libvirt] [PATCH v2 2/3] virsh: Pass vshControl to all vshCommandOpt*() calls.

was specified or not. I added it in to keep all vshCommandOpt*() calls consistent, but since both you and Peter feel like it shouldn't be there I'll get rid of it. Cheers. -- Andrea Bolognani Software Engineer - Virtualization Team $ python -c print('a'.join(['', 'bologn', '@redh', 't.com'])) -- libvir

Re: [libvirt] [PATCH v2] qemu: Limit rtc-reset-reinjection requirement to x86 only.

On Wed, 2015-05-27 at 16:55 +0200, Martin Kletzander wrote: ACK, will push in a while. Thanks :) -- Andrea Bolognani Software Engineer - Virtualization Team $ python -c print('a'.join(['', 'bologn', '@redh', 't.com'])) -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com

[libvirt] [PATCH v3 4/5] virsh: Pass vshControl to all vshCommandOpt*() calls.

This will allow us to use vshError() to report errors from inside vshCommandOpt*(), instead of replicating the same logic and error messages all over the place. We also have more context inside the vshCommandOpt*() functions, for example the actual value used on the command line, which means we

[libvirt] [PATCH v3 3/5] virsh: Make vshCommandOptScaledInt() use vshCommandOpt().

This aligns it to the other vshCommandOpt*() functions. --- tools/virsh.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 1348985..720b715 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -1804,16 +1804,16 @@

[libvirt] [PATCH v3 1/5] virsh: Use standard error message in vshCommandOptTimeoutToMs().

I missed this in the first time around, thanks Michal for noticing. --- tools/virsh.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/virsh.c b/tools/virsh.c index 1005ba8..865948f 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -1869,7 +1869,9 @@

[libvirt] [PATCH v3 5/5] virsh: Move error messages inside vshCommandOpt*() functions.

--- tests/vcpupin| 4 +- tools/virsh-domain-monitor.c | 9 +-- tools/virsh-domain.c | 134 +++ tools/virsh-host.c | 61 +++- tools/virsh-interface.c | 6 +- tools/virsh-network.c| 6 +-

Re: [libvirt] [PATCH v2 3/3] virsh: Move error messages inside vshCommandOpt*() functions.

message for that case, we are okay to drop all the other error messages. I will look into it next, see what I can do :) Cheers. -- Andrea Bolognani Software Engineer - Virtualization Team $ python -c print('a'.join(['', 'bologn', '@redh', 't.com'])) -- libvir-list mailing list libvir-list

[libvirt] [PATCH v3 2/5] virsh: Improve vshCommandOptTimeoutToMs().

Use vshCommandOptUInt() instead of parsing the value as a signed integer and checking whether it's positive afterwards. Improve comments as well. --- tools/virsh.c | 40 1 file changed, 24 insertions(+), 16 deletions(-) diff --git a/tools/virsh.c

[libvirt] [PATCH v3 0/5] virsh: Further improve handling of integer options

As suggested by Michal: now that we have a generic error message for failures related to the parsing of integer options, it makes sense to perform the corresponding check in a single spot instead of replicating it every time vshCommandOpt*() is used. Andrea Bolognani (5): virsh: Use standard

Re: [libvirt] [PATCH v2] qemu: Deal with panic device on pSeries.

)? To be honest, I don't know nearly enough about migration to be able to tell whether this is the case. I'll look into it, but it would be great if at least the other two commits (bug fix) could be merged in the meantime. I'll post a v3 right away. Cheers. -- Andrea Bolognani Software Engineer

[libvirt] [PATCH v3 3/3] qemu: Automatically add panic element for pSeries guests.

The guest firmware provides the same functionality as the pvpanic device, and the relevant element should always be present in the domain XML to reflect this fact, so add it after parsing the definition if it wasn't there already. --- docs/formatdomain.html.in | 5

[libvirt] [PATCH v3 2/3] qemu: Allow panic device for pSeries guests

The guest firmware provides the same functionality as the pvpanic device, which is not available in QEMU on pSeries, so the domain XML should be allowed to contain the panic element. On the other hand, unlike the pvpanic device, the guest firmware can't be configured, so report an error if an

[libvirt] [PATCH v3 0/3] qemu: Deal with panic device on pSeries

be allowed. The second commit implements this change. It being part of the firmware, the panic element should actually always be present in the domain XML: the third commit makes sure this is the case. Andrea Bolognani (3): qemu: Improve error message for missing QEMU_CAPS_DEVICE_PANIC. qemu: Allow

[libvirt] [PATCH v3 1/3] qemu: Improve error message for missing QEMU_CAPS_DEVICE_PANIC.

--- src/qemu/qemu_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index d8ce511..f39442b 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -10840,7 +10840,7 @@ qemuBuildCommandLine(virConnectPtr

Re: [libvirt] [PATCH v4 0/6] virsh: Further improve handling of integer options

On Tue, 2015-06-02 at 09:23 -0400, John Ferlan wrote: ACK series... and pushed Thanks :) -- Andrea Bolognani Software Engineer - Virtualization Team $ python -c print('a'.join(['', 'bologn', '@redh', 't.com'])) -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman

Re: [libvirt] [PATCH] Fix nodeinfo output on PPC64 KVM hosts

On Wed, 2015-07-01 at 19:26 +0530, Shivaprasad bhat wrote: I have posted the v2 as per your suggestions. Also added test case to test the nodeinfo. I moved the ioctl to a new function to help mocking it for testing. Only commit 1/2 seems to have made it to the list... Cheers. -- Andrea

[libvirt] [PATCH] Fix typo incomaptible - incompatible

--- src/cpu/cpu_x86.c | 4 ++-- src/libvirt-domain-snapshot.c | 2 +- src/qemu/qemu_driver.c| 8 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index 2a14705..f5f7697 100644 --- a/src/cpu/cpu_x86.c +++

Re: [libvirt] [PATCH] Fix nodeinfo output on PPC64 KVM hosts

are described in the cover letter. Can you please take a look at it and let me know if it looks okay to you? Cheers. -- Andrea Bolognani Software Engineer - Virtualization Team -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v3 0/2] Fix nodeinfo output on PPC64 KVM hosts

I have reworked the original code quite a bit, while maintaining the same logic and hopefully introducing no bugs of my own :) Notable changes from v2 to v3: * the function to get the number of threads per subcore has been moved to the from virarch.c, which deals with architecture

[libvirt] [PATCH v3 1/2] Fix nodeinfo output on PPC64 KVM hosts

primary threads are online. The host topology displayed by the nodeinfo is also fixed when the host is in valid kvm state. Signed-off-by: Shivaprasad G Bhat sb...@linux.vnet.ibm.com Signed-off-by: Andrea Bolognani abolo...@redhat.com --- src/libvirt_private.syms | 1 + src/nodeinfo.c

Re: [libvirt] [PATCH] Fix nodeinfo output on PPC64 KVM hosts

line is repeated 155 times -- /cpus /cell /cells /topology This issue needs to be addressed before the changes can be considered for inclusion. I'd also highly recommend writing tests cases in order to prevent regressions in the future. Cheers. -- Andrea Bolognani

[libvirt] [PATCH v2 3/3] virsh: Move error messages inside vshCommandOpt*() functions.

--- tests/vcpupin| 4 +- tools/virsh-domain-monitor.c | 9 +-- tools/virsh-domain.c | 134 +++ tools/virsh-host.c | 57 +++--- tools/virsh-interface.c | 6 +- tools/virsh-network.c| 6 +-

[libvirt] [PATCH v2 1/3] virsh: Make vshCommandOptScaledInt() use vshCommandOpt().

This aligns it to the other vshCommandOpt*() functions. --- tools/virsh.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 4425774..11c2c30 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -1804,16 +1804,17 @@

[libvirt] [PATCH v2 0/3] virsh: Further improve handling of integer options

Changes from v1: * remove vshControl parameter from vshCommandOpt(), as suggested by Peter * document @ctl parameter for all other functions * update vshCommandOptScaledInt(), which I had missed the first time Cheers. Andrea Bolognani (3): virsh: Make vshCommandOptScaledInt() use

[libvirt] [PATCH v2 2/3] virsh: Pass vshControl to all vshCommandOpt*() calls.

This will allow us to use vshError() to report errors from inside vshCommandOpt*(), instead of replicating the same logic and error messages all over the place. We also have more context inside the vshCommandOpt*() functions, for example the actual value used on the command line, which means we

Re: [libvirt] [PATCH v2] qemu: Deal with panic device on pSeries.

On Fri, 2015-05-15 at 11:35 +0200, Andrea Bolognani wrote: The guest firmware provides the same functionality as the pvpanic device, which is not available in QEMU on pSeries: make sure the XML reflects this fact by automatically adding a panic/ element when not already present

[libvirt] [PATCH] qemu: Only issue the rtc-reset-reinjection QMP command on x86.

The command is only defined in QEMU for TARGET_I386, so issuing it on any other architecture can't possibly work. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1211938 --- src/qemu/qemu_driver.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git

Re: [libvirt] [PATCH] qemu: Only issue the rtc-reset-reinjection QMP command on x86.

, because not doing so would mean versions of QEMU older than 2.0.1 get the clock corrected two times. Cheers. -- Andrea Bolognani Software Engineer - Virtualization Team $ python -c print('a'.join(['', 'bologn', '@redh', 't.com'])) -- libvir-list mailing list libvir-list@redhat.com https

Re: [libvirt] [PATCH 1/3] virsh: Improve error message on integer value parsing failure.

the previous one :) Cheers. -- Andrea Bolognani abolo...@redhat.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 1/2] virsh: Pass vshControl to all vshCommandOpt*() calls.

*() calls are consistent. I don't see the harm in doing so, but maybe I'm missing something? Cheers. -- Andrea Bolognani abolo...@redhat.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v2] qemu: Limit rtc-reset-reinjection requirement to x86 only.

The QMP command, like the interrupt reinjection logic it's connected to, is only implemented in QEMU when TARGET_I386 is defined, so checking for its availability on any other architecture is pointless. On the other hand, when we're on x86, we shouldn still make sure that rtc-reset-reinjection is

Re: [libvirt] [PATCH] qemu: Only issue the rtc-reset-reinjection QMP command on x86.

:) I've updated the patch accordingly. Cheers. -- Andrea Bolognani Software Engineer - Virtualization Team $ python -c print('a'.join(['', 'bologn', '@redh', 't.com'])) -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v4 0/2] Fix nodeinfo output on PPC64 KVM hosts

Changes from v3 to v4: * removed a printf() statement; * fixed typo in a commit message. Shivaprasad G Bhat (2): Fix nodeinfo output on PPC64 KVM hosts Add testcase for PPC64 kvm host nodeinfo src/libvirt_private.syms | 1 + src/nodeinfo.c

[libvirt] [PATCH v4 1/2] Fix nodeinfo output on PPC64 KVM hosts

primary threads are online. The host topology displayed by the nodeinfo is also fixed when the host is in valid kvm state. Signed-off-by: Shivaprasad G Bhat sb...@linux.vnet.ibm.com Signed-off-by: Andrea Bolognani abolo...@redhat.com --- src/libvirt_private.syms | 1 + src/nodeinfo.c

Re: [libvirt] [PATCH v3 1/2] Fix nodeinfo output on PPC64 KVM hosts

virReportError(?). I think we can ignore the SetBit return, given this is from directory parsing. That was indeed not supposed to be there, good catch! I've removed it and posted v4 of the series. Cheers. -- Andrea Bolognani Software Engineer - Virtualization Team -- libvir-list mailing list

Re: [libvirt] [PATCH v11 0/5] nodeinfo: Add support for subcores

://ci.centos.org/view/libvirt-project/job/libvirt-daemon-build /478/systems=libvirt-centos-6/ -- Andrea Bolognani Software Engineer - Virtualization Team -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 2/4] cpu: Better support for ppc64 compatibility modes

On Fri, 2015-08-21 at 14:58 -0700, Jiri Denemark wrote: On Fri, Aug 21, 2015 at 14:55:02 -0700, Andrea Bolognani wrote: On Fri, 2015-08-21 at 14:27 -0700, Jiri Denemark wrote: +static virCPUCompareResult +ppc64CheckCompatibilityMode(const char *host_model

Re: [libvirt] [PATCH 2/4] cpu: Better support for ppc64 compatibility modes

to this with the small issues addressed. Sure, that will come later on. Cheers. -- Andrea Bolognani Software Engineer - Virtualization Team -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 4/4] tests: Add some compatibility-related cases to the CPU tests

will fail. Cheers. -- Andrea Bolognani Software Engineer - Virtualization Team -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 3/4] cpu: Move check for NULL CPU model inside the driver

While the check is appropriate for eg. the x86 and generic drivers, there are some valid ppc64 guest configurations where the CPU model is supposed to be NULL. Moving this check from the generic code to the drivers makes it possible to accomodate both use cases. Resolves:

[libvirt] [PATCH 2/4] cpu: Better support for ppc64 compatibility modes

Not all combinations of host CPU models and compatibility modes are valid, so we need to make sure we don't try to do something that QEMU will reject. Moreover, we need to apply a different logic to guests using host-model and host-passthrough modes when testing them for host compatibility.

[libvirt] [PATCH 1/4] cpu: Don't update host-model guest CPUs on ppc64

If a guest CPU is defined using cpu mode='host-model'/ the model sub-element will contain the compatibility mode to use. That means we can't just copy the host CPU model on cpuUpdate(), otherwise we'll overwrite that information and migration of such guests will fail. Resolves:

[libvirt] [PATCH 0/4] Improve handling of ppc64 compatibility modes

This series fixes an issue that prevented save / restore from working when using compatibility modes; it also introduces some new checks to make sure the requested compability configuration is actually supported and a few test cases. Cheers. Andrea Bolognani (4): cpu: Don't update host-model

[libvirt] [PATCH 4/4] tests: Add some compatibility-related cases to the CPU tests

--- tests/cputest.c| 14 ++ tests/cputestdata/ppc64-guest-compat-incompatible.xml | 3 +++ tests/cputestdata/ppc64-guest-compat-invalid.xml | 3 +++ tests/cputestdata/ppc64-guest-compat-none.xml | 1 +

[libvirt] [PATCH 12/18] cpu: Align ppc64 CPU data with x86

Use a typedef instead of the plain struct and heap allocation. This will make it easier to extend the ppc64 specific CPU data later on. --- src/cpu/cpu.h| 2 +- src/cpu/cpu_ppc64.c | 81 ++-- src/cpu/cpu_ppc64_data.h | 3 +- 3 files

[libvirt] [PATCH 15/18] cpu: Add PVR mask to CPU map XML for ppc64 models

The code currently assumes that the mask will be 0x, which is not always the case - it is for the models listed so far, though. --- src/cpu/cpu_map.xml | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml index

[libvirt] [PATCH 07/18] tests: Remove unused file

--- tests/cputestdata/ppc64-baseline-1-result.xml | 3 --- 1 file changed, 3 deletions(-) delete mode 100644 tests/cputestdata/ppc64-baseline-1-result.xml diff --git a/tests/cputestdata/ppc64-baseline-1-result.xml b/tests/cputestdata/ppc64-baseline-1-result.xml deleted file mode 100644 index

[libvirt] [PATCH 02/18] cpu: Simplify NULL handling in ppc64 driver

Use briefer checks, eg. (!model) instead of (model == NULL), and avoid initializing to NULL a pointer that would be assigned in the first line of the function anyway. Also remove a pointless NULL assignment. No functional changes. --- src/cpu/cpu_ppc64.c | 33 -

[libvirt] [PATCH 14/18] cpu: Simplify ppc64 part of CPU map XML

Use multiple PVRs per CPU model to reduce the number of models we need to keep track of. Remove specific CPU models (eg. POWER7+_v2.1): the corresponding generic CPU model (eg. POWER7) should be used instead to ensure the guest can be booted on any compatible host. Get rid of all the entries

[libvirt] [PATCH 09/18] cpu: Don't skip CPU model name check in ppc64 driver

ppc64Compute(), called by cpuNodeData(), is used not only to retrieve the driver-specific data associated to a guest CPU definition, but also to check whether said guest CPU is compatible with the host CPU. If the user is not interested in the CPU data, it's perfectly fine to pass a NULL pointer

[libvirt] [PATCH 00/18] cpu: Fix and improve the ppc64 driver

rework the driver and add some test cases to cover both existing an new features. Cheers. [1] https://www.redhat.com/archives/libvir-list/2015-July/msg01170.html Andrea Bolognani (18): cpu: Mark driver functions in ppc64 driver cpu: Simplify NULL handling in ppc64 driver cpu: Add NULL check

[libvirt] [PATCH 18/18] tests: Add a bunch of ppc64 cases to the cpu test

New test cases cover the cpuCompare() and cpuBaseline() implementation. --- tests/cputest.c | 10 ++ tests/cputestdata/ppc64-baseline-incompatible-models.xml | 14 ++ tests/cputestdata/ppc64-baseline-same-model-result.xml | 3 +++

[libvirt] [PATCH 17/18] cpu: Add POWER8 NVL information to CPU map XML

This is yet another variation of POWER8. The PVR information comes from arch/powerpc/kernel/cputable.c in the Linux kernel tree. --- src/cpu/cpu_map.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml index 0895ada..d2469ee 100644 ---

[libvirt] [PATCH 13/18] cpu: Support multiple PVRs in the ppc64 driver

This will allow us to perform PVR matching more broadly, eg. consider both POWER8 and POWER8E CPUs to be the same even though they have different PVR values. --- src/cpu/cpu_ppc64.c | 73 src/cpu/cpu_ppc64_data.h | 8 +- 2 files changed,

[libvirt] [PATCH 08/18] tests: Known failing tests should never succeed

Fix a test case that was wrongly expected to fail as well. --- tests/cputest.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/tests/cputest.c b/tests/cputest.c index 06b3f12..5b7de0f 100644 --- a/tests/cputest.c +++ b/tests/cputest.c @@ -273,13 +273,8

[libvirt] [PATCH 10/18] cpu: CPU model names have to match on ppc64

Limitations of the POWER architecture mean that you can't run eg. a POWER7 guest on a POWER8 host when using KVM. This applies to all guests, not just those using VIR_CPU_MATCH_STRICT in the CPU definition; in fact, exact and strict CPU matching are basically the same on ppc64. This means, of

[libvirt] [PATCH 01/18] cpu: Mark driver functions in ppc64 driver

Use the ppc64Driver prefix for all functions that are used to fill in the cpuDriverPPC64 structure, ie. those that are going to be called by the generic CPU code. This makes it clear which functions are exported and which are implementation details; it also gets rid of the ambiguity that affected

[libvirt] [PATCH 16/18] cpu: Parse and use PVR masks in the ppc64 driver

Instead of relying on a hard-coded mask value, read it from the CPU map XML and use it when looking up models by PVR. Rewrite ppc64DriverNodeData() to use this feature. --- src/cpu/cpu_ppc64.c | 74 src/cpu/cpu_ppc64_data.h | 1 + 2 files

[libvirt] [PATCH 04/18] cpu: Use a different name for the copy in ppc64ModelFromCPU()

While the previous code was correct, it looked wrong at first sight because the same variable used to store the result of a map lookup is later used to store a copy of said result. The copy is deallocated on error, but due to the fact that a single variable is used, it looks like the result of the

[libvirt] [PATCH 11/18] cpu: Use ppc64Compute() to implement ppc64DriverCompare()

This ensures comparison of two CPU definitions will be consistent regardless of the fact that it is performed using cpuCompare() or cpuGuestData(). The x86 driver uses the same exact code. --- src/cpu/cpu_ppc64.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff

[libvirt] [PATCH 06/18] cpu: Remove ISA information from CPU map XML

The information is not used anywhere in libvirt. No functional changes. --- src/cpu/cpu_map.xml | 5 - 1 file changed, 5 deletions(-) diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml index b924bd3..6387ce4 100644 --- a/src/cpu/cpu_map.xml +++ b/src/cpu/cpu_map.xml @@ -1385,31 +1385,26

[libvirt] [PATCH 03/18] cpu: Add NULL check in ppc64ModelCopy()

--- src/cpu/cpu_ppc64.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c index 05ff8f2..dd02a3f 100644 --- a/src/cpu/cpu_ppc64.c +++ b/src/cpu/cpu_ppc64.c @@ -115,6 +115,9 @@ ppc64ModelCopy(const struct ppc64_model *model) { struct ppc64_model

[libvirt] [PATCH 05/18] cpu: Reorder functions in the ppc64 driver

Having the functions grouped together this way will avoid further shuffling around down the line. No functional changes. --- src/cpu/cpu_ppc64.c | 135 +--- 1 file changed, 66 insertions(+), 69 deletions(-) diff --git a/src/cpu/cpu_ppc64.c

[libvirt] [PATCH v9 0/5] nodeinfo: Add support for subcores

, which prevented 'make dist' from working due to recursive linking Andrea Bolognani (3): tests: Add subcores1 nodeinfo test tests: Add subcores2 nodeinfo test tests: Add subcores3 nodeinfo test Shivaprasad G Bhat (2): nodeinfo: Fix output on PPC64 KVM hosts tests: Prepare for subcore

[libvirt] [PATCH v9 1/5] nodeinfo: Fix output on PPC64 KVM hosts

primary threads are online. The host topology displayed by the nodeinfo is also fixed when the host is in valid kvm state. Signed-off-by: Shivaprasad G Bhat sb...@linux.vnet.ibm.com Signed-off-by: Andrea Bolognani abolo...@redhat.com --- src/libvirt_private.syms | 1 + src/nodeinfo.c

Re: [libvirt] [PATCH v8 1/5] nodeinfo: Fix output on PPC64 KVM hosts

when something else is wrong, eg. permission error. Cheers. -- Andrea Bolognani Software Engineer - Virtualization Team -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v10 0/5] nodeinfo: Add support for subcores

*/node* links, which prevented 'make dist' from working due to recursive linking Andrea Bolognani (3): tests: Add subcores1 nodeinfo test tests: Add subcores2 nodeinfo test tests: Add subcores3 nodeinfo test Shivaprasad G Bhat (2): nodeinfo: Fix output on PPC64 KVM hosts tests

[libvirt] [PATCH v10 1/5] nodeinfo: Fix output on PPC64 KVM hosts

primary threads are online. The host topology displayed by the nodeinfo is also fixed when the host is in valid kvm state. Signed-off-by: Shivaprasad G Bhat sb...@linux.vnet.ibm.com Signed-off-by: Andrea Bolognani abolo...@redhat.com --- src/libvirt_private.syms | 1 + src/nodeinfo.c

  1   2   3   4   5   6   7   8   9   10   >