Remove NULL check from virObjectEventStateQueue and add NULL check to
virObjectEventStateQueueRemote
Remove NULL check around call to virObjectEventStateQueueRemote in
remote_driver.c
Signed-off-by: Anya Harter
---
src/conf/object_event.c| 6 +++---
src/remote/remote_driver.c | 3 +--
2
>From remote_driver.c
And replace all calls with virObjectEventStateQueue such that:
remoteEventQueue(priv, event, callbackID);
becomes:
virObjectEventStateQueue(priv->eventState, event, callbackID);
Signed-off-by: Anya Harter
---
src/remote/remote_driver.
.
Anya Harter (3):
events: add NULL check in virObjectEventStateQueue
events: move NULL check to EventStateQueueRemote
events: remove remoteEventQueue wrapper function
src/bhyve/bhyve_driver.c | 15 ++
src/conf/object_event.c| 3 ++
src/lxc/lxc_driver.c
And remove NULL checking from all callers
Signed-off-by: Anya Harter
---
src/bhyve/bhyve_driver.c | 15 +--
src/conf/object_event.c| 3 +++
src/lxc/lxc_driver.c | 24
src/lxc/lxc_process.c | 9 +++--
src
On 06/12/2018 01:36 AM, Pavel Hrdina wrote:
> On Mon, Jun 11, 2018 at 03:38:16PM -0400, Anya Harter wrote:
>> Currently, all virObjectEventStateQueue callers and
>> virObjectEventStateQueueRemote callers need to do NULL checking.
>>
>> In this patch series, all NULL
On 06/11/2018 03:38 PM, Anya Harter wrote:
>>From remote_driver.c
>
> And replace all calls with virObjectEventStateQueue such that:
>
> remoteEventQueue(priv, event, callbackID);
>
> becomes:
>
> virObjectEventStateQueue(priv->eventState, event
And replace all calls with virObjectEventStateQueue such that:
qemuDomainEventQueue(driver, event);
becomes:
virObjectEventStateQueue(driver->domainEventState, event);
And remove NULL checking from all callers.
Signed-off-by: Anya Harter
---
src/qemu/qemu_blockjob.c | 4 +-
virObjectEventStateQueue takes care of NULL checking, all NULL
checking by callers has also been removed.
This patch series should complete the BiteSizedTask entry at
https://wiki.libvirt.org/page/BiteSizedTasks#Remove_NULL_checking_around_EventStateQueue
.
Anya Harter (4):
events: remove
And replace all calls with virObjectEventStateQueue such that:
testObjectEventQueue(privconn, event);
becomes:
virObjectEventStateQueue(privconn->eventState, event);
Signed-off-by: Anya Harter
---
src/test/test_driver.c | 80 +++---
1 file chan
And replace all calls with virObjectEventStateQueue such that:
libxlDomainEventQueue(driver, event);
becomes:
virObjectEventStateQueue(driver->domainEventState, event);
And remove NULL checking from all callers.
Signed-off-by: Anya Harter
---
src/libxl/libxl_domain.c|
And replace all calls with virObjectEventStateQueue such that:
umlDomainEventQueue(driver, event);
becomes:
virObjectEventStateQueue(driver->domainEventState, event);
And remove NULL checking from all callers.
Signed-off-by: Anya Harter
---
src/uml/uml_driver.c |
Add test case explicitly defining a smartcard host certificates
database via the following xml:
/tmp/foo
This case is not currently covered in the test suite.
Signed-off-by: Anya Harter
---
.../smartcard-host-certificates-database.args | 28 +++
.../smartcard-host
Add comma escaping for fileval.
Signed-off-by: Anya Harter
---
src/qemu/qemu_command.c | 3 ++-
tests/qemuxml2argvdata/name-escape.args | 2 ++
tests/qemuxml2argvdata/name-escape.xml | 4
tests/qemuxml2argvtest.c| 3 ++-
4 files changed, 10 insertions(+), 2
the BiteSizedTask entry at
https://wiki.libvirt.org/page/BiteSizedTasks#qemu:_Use_comma_escaping_for_more_command_line_values.
Anya Harter (4):
qemu: Escape commas for qemuBuildChrChardevStr
qemu: Escape commas for qemuBuildChrChardevFileStr
qemu: Escape commas for qemuBuildSmartcardCommandLine
Add comma escaping for smartcard->data.cert.file[i] and
smartcard->data.cert.database.
Signed-off-by: Anya Harter
---
src/qemu/qemu_command.c | 21 -
tests/qemuxml2argvdata/name-escape.args | 3 +++
tests/qemuxml2argvdata/name-escape.xml | 6 ++
Add comma escaping for cfg->spiceTLSx509certdir and
graphics->data.spice.rendernode.
Signed-off-by: Anya Harter
---
src/qemu/qemu_command.c | 11 ---
tests/qemuxml2argvdata/name-escape.args | 5 +++--
tests/qemuxml2argvdata/name-escape.xml | 1 +
Add comma escaping for dev->data.file.path in cases
VIR_DOMAIN_CHR_TYPE_DEV and VIR_DOMAIN_CHR_TYPE_PIPE.
Signed-off-by: Anya Harter
---
src/qemu/qemu_command.c | 9 +
tests/qemuxml2argvdata/name-escape.args | 4
tests/qemuxml2argvdata/name-escape.xml
On 06/18/2018 07:37 PM, John Ferlan wrote:
>
>
> On 06/18/2018 01:57 PM, Anya Harter wrote:
>> Add comma escaping for dev->data.file.path in cases
>> VIR_DOMAIN_CHR_TYPE_DEV and VIR_DOMAIN_CHR_TYPE_PIPE.
>>
>> Signed-off-by: Anya Harter
>> ---
>&
Add comma escaping for disk->blkdeviotune.group_name.
Signed-off-by: Anya Harter
---
src/qemu/qemu_command.c | 4 ++--
tests/qemuxml2argvdata/name-escape.args | 5 +
tests/qemuxml2argvdata/name-escape.xml | 13 +
tests/qemuxml2argvtest.c|
:_Use_comma_escaping_for_more_command_line_values.
Anya Harter (2):
qemu: use virBuffer in qemuBuildSCSIiSCSIHostdevDrvStr
qemu: Escape commas for qemuBuildSCSIiSCSIHostdevDrvStr
src/qemu/qemu_command.c | 19 +--
tests/qemuxml2argvdata/name-escape.args | 6
Instead of source to enable use of virBuffer functions in
string construction.
Signed-off-by: Anya Harter
---
src/qemu/qemu_command.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index e05b106a5e
Add comma escaping for netsource
Signed-off-by: Anya Harter
---
src/qemu/qemu_command.c | 4 +++-
tests/qemuxml2argvdata/name-escape.args | 6 +-
tests/qemuxml2argvdata/name-escape.xml | 7 +++
tests/qemuxml2argvtest.c| 5 -
4 files changed, 19
On 06/19/2018 10:46 AM, Cole Robinson wrote:
> On 06/19/2018 09:47 AM, Cole Robinson wrote:
>> On 06/18/2018 07:52 PM, John Ferlan wrote:
>>>
>>>
>>> On 06/18/2018 01:57 PM, Anya Harter wrote:
>>>> Add comma escaping for cfg->spiceTLSx
On 06/21/2018 06:55 PM, John Ferlan wrote:
>
>
> On 06/20/2018 09:17 AM, Anya Harter wrote:
>> Add comma escaping for netsource
>>
>> Signed-off-by: Anya Harter
>> ---
>> src/qemu/qemu_command.c | 4 +++-
>> tests/qemuxml2a
Signed-off-by: Anya Harter
---
src/connect.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/connect.c b/src/connect.c
index 09e5628..32dda14 100644
--- a/src/connect.c
+++ b/src/connect.c
@@ -68,7 +68,7 @@ virtDBusConnectClose(virtDBusConnect *connect,
for (gint i
On 06/26/2018 08:52 AM, John Ferlan wrote:
>
>
> On 06/22/2018 09:06 AM, Anya Harter wrote:
> [...]
>
>>>
>>> Something is not quite right about seeing "example,foo.org" as a host
>>> name. I don't see that as a valid host name regar
from src/qemu/qemu_domain_address.[ch] to src/conf/domain_addr.[ch]
Signed-off-by: Anya Harter
---
src/conf/domain_addr.c | 24
src/conf/domain_addr.h | 4
src/qemu/qemu_domain_address.c | 22 --
src/qemu/qemu_domain_address.h
to virDomainCCWAddrSetCreateFromDomain
Signed-off-by: Anya Harter
---
src/conf/domain_addr.c | 2 +-
src/conf/domain_addr.h | 2 +-
src/qemu/qemu_domain_address.c | 4 ++--
src/qemu/qemu_hotplug.c| 4 ++--
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a
qemuDomainCCWAddrSetCreateFromDomain moved from qemu_domain_addr to
domain_addr and rename to virDomainCCWAddrSetCreateFromDomain because
it is not a qemu-specific function
Anya Harter (2):
qemu: move qemuDomainCCWAddrSetCreateFromDomain
domain_addr: refactor
the last use of this function was deleted in commit
19a148b7c8353d5c214bed699f8fe983317baf93
Signed-off-by: Anya Harter
---
src/conf/domain_addr.c | 44
src/conf/domain_addr.h | 5 -
src/libvirt_private.syms | 1 -
3 files changed, 50
the last use of this function was deleted in commit
1aa5e66cf3a0dd5e8ada8483f79cb745f786a131
Signed-off-by: Anya Harter
---
src/conf/domain_addr.c | 24
src/conf/domain_addr.h | 3 ---
src/libvirt_private.syms | 1 -
3 files changed, 28 deletions(-)
diff
each commit references the commit where the last use was removed
Anya Harter (2):
domain_addr: delete virDomainCCWAddressReleaseAddr
domain_addr: delete virDomainVirtioSerialAddrRelease
src/conf/domain_addr.c | 68
src/conf/domain_addr.h | 8
so that g_free(connect->nodeDevPath) line appears in alphabetical order
with the rest of the lines
Signed-off-by: Anya Harter
---
src/connect.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/connect.c b/src/connect.c
index 9ebceaa..9275121 100644
--- a/src/connec
On 07/02/2018 04:48 PM, John Ferlan wrote:
>
>
> On 06/28/2018 04:23 PM, Anya Harter wrote:
>> from src/qemu/qemu_domain_address.[ch] to src/conf/domain_addr.[ch]
>>
>> Signed-off-by: Anya Harter
>> ---
>> src/conf/domain_addr.c | 2
from src/qemu/qemu_domain_address.c to src/conf/domain_addr.c
and rename to virDomainCCWAddressSetCreateFromDomain
(rename to have Address in full instead of Addr to follow
the naming convention of other virDomainCCWAddress functions)
Signed-off-by: Anya Harter
---
renamed function in v2 patch
On 07/03/2018 09:03 AM, Ján Tomko wrote:
> On Tue, Jul 03, 2018 at 02:18:02PM +0200, Pavel Hrdina wrote:
>> On Mon, Jul 02, 2018 at 11:42:08AM -0400, Anya Harter wrote:
>>> so that g_free(connect->nodeDevPath) line appears in alphabetical order
>>> with the rest o
Allocate, Validate, SetCreate
last uses of these functions outside domain_addr.c removed in commit:
7bdd06b4e103269992122603949f585fc2bfdc6
Signed-off-by: Anya Harter
---
src/conf/domain_addr.c | 6 +++---
src/conf/domain_addr.h | 12
src/libvirt_private.syms | 3
which are unused outside domain_addr.c
The commit where the last external use was removed is linked in each
commit when it exists
Anya Harter (4):
domain_addr: make virDomainPCIAddressBusIsEmpty static
domain_addr: make virDomainCCWAddress funcs static
domain_addr: make
SetCreate, SetAddControllers, Reserve
last uses of these functions outside domain_addr.c removed in commit:
40c284f0a6b53a182af7b12173bcb5dd3eb0c826
Assign
never used outside domain_addr.c
move Assign and Reserve above their first call within domain_addr.c
Signed-off-by: Anya
never used outside domain_addr.c
Signed-off-by: Anya Harter
---
src/conf/domain_addr.c | 2 +-
src/conf/domain_addr.h | 3 ---
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c
index eb0784cd2c..ec2dfdbbdc 100644
--- a/src/conf
never used outside domain_addr.c
Signed-off-by: Anya Harter
---
src/conf/domain_addr.c | 2 +-
src/conf/domain_addr.h | 3 ---
src/libvirt_private.syms | 1 -
3 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c
index 33f859697b
so that gchar *nodeDevPath; line appears in alphabetical order with the
rest of the lines
Signed-off-by: Anya Harter
---
src/connect.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/connect.h b/src/connect.h
index b81b6a8..0b9ae10 100644
--- a/src/connect.h
+++ b/src
Signed-off-by: Anya Harter
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index ca9e4e1..c41c82c 100644
--- a/.gitignore
+++ b/.gitignore
@@ -44,3 +44,4 @@ vgcore.*
/src/org.libvirt.service
/tests/test_util
+/tests/.pytest_cache
--
2.17.1
Signed-off-by: Anya Harter
---
data/org.libvirt.Connect.xml | 6 ++
src/connect.c| 29 +
2 files changed, 35 insertions(+)
diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml
index 7c97117..f99e205 100644
--- a/data
Signed-off-by: Anya Harter
---
data/org.libvirt.Interface.xml | 4
src/interface.c| 22 ++
2 files changed, 26 insertions(+)
diff --git a/data/org.libvirt.Interface.xml b/data/org.libvirt.Interface.xml
index e6d9f2a..f50bc37 100644
--- a/data
)
- virInterfaceUndefine (interface method)
Anya Harter (15):
Introduce Interface Interface
Implement Name property for Interface Interface
Implement MACString property for Interface Interface
Implement Active property for Interface Interface
Implement ListInterfaces method for
Signed-off-by: Anya Harter
---
data/org.libvirt.Interface.xml | 5 +
src/interface.c| 22 ++
2 files changed, 27 insertions(+)
diff --git a/data/org.libvirt.Interface.xml b/data/org.libvirt.Interface.xml
index 93fa32f..ad7c326 100644
--- a/data
Signed-off-by: Anya Harter
---
data/org.libvirt.Interface.xml | 5 +
src/interface.c| 24
2 files changed, 29 insertions(+)
diff --git a/data/org.libvirt.Interface.xml b/data/org.libvirt.Interface.xml
index f62346a..16caba1 100644
--- a/data
Signed-off-by: Anya Harter
---
data/org.libvirt.Connect.xml | 5 +
src/connect.c| 22 ++
2 files changed, 27 insertions(+)
diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml
index 8c88cc8..7c97117 100644
--- a/data
Signed-off-by: Anya Harter
---
data/org.libvirt.Interface.xml | 5 +
src/interface.c| 22 ++
2 files changed, 27 insertions(+)
diff --git a/data/org.libvirt.Interface.xml b/data/org.libvirt.Interface.xml
index ad7c326..e6d9f2a 100644
--- a/data
Signed-off-by: Anya Harter
---
data/org.libvirt.Connect.xml | 7 +++
src/connect.c| 30 ++
2 files changed, 37 insertions(+)
diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml
index 0604841..791e1f5 100644
--- a/data
Signed-off-by: Anya Harter
---
data/org.libvirt.Connect.xml | 5 +
src/connect.c| 22 ++
2 files changed, 27 insertions(+)
diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml
index 791e1f5..604afea 100644
--- a/data
Signed-off-by: Anya Harter
---
data/org.libvirt.Connect.xml | 6 ++
src/connect.c| 29 +
2 files changed, 35 insertions(+)
diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml
index f99e205..535d225 100644
--- a/data
Signed-off-by: Anya Harter
---
data/Makefile.am | 1 +
data/org.libvirt.Interface.xml | 7 +++
src/Makefile.am| 2 +
src/connect.c | 6 +++
src/connect.h | 1 +
src/interface.c| 86
Signed-off-by: Anya Harter
---
data/org.libvirt.Interface.xml | 6 ++
src/interface.c| 28
2 files changed, 34 insertions(+)
diff --git a/data/org.libvirt.Interface.xml b/data/org.libvirt.Interface.xml
index 5ca366c..efe59e3 100644
--- a/data
Signed-off-by: Anya Harter
---
data/org.libvirt.Interface.xml | 4
src/interface.c| 21 +
2 files changed, 25 insertions(+)
diff --git a/data/org.libvirt.Interface.xml b/data/org.libvirt.Interface.xml
index 16caba1..5ca366c 100644
--- a/data
Signed-off-by: Anya Harter
---
data/org.libvirt.Connect.xml | 6 ++
src/connect.c| 38
2 files changed, 44 insertions(+)
diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml
index 7014a09..0604841 100644
--- a/data
Signed-off-by: Anya Harter
---
data/org.libvirt.Interface.xml | 5 +
src/interface.c| 24
2 files changed, 29 insertions(+)
diff --git a/data/org.libvirt.Interface.xml b/data/org.libvirt.Interface.xml
index f50bc37..f62346a 100644
--- a/data
Signed-off-by: Anya Harter
---
data/org.libvirt.Connect.xml | 5 +
src/connect.c| 22 ++
2 files changed, 27 insertions(+)
diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml
index 604afea..8c88cc8 100644
--- a/data
Signed-off-by: Anya Harter
---
tests/test_connect.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/test_connect.py b/tests/test_connect.py
index 7084397..2299b8a 100755
--- a/tests/test_connect.py
+++ b/tests/test_connect.py
@@ -22,7 +22,7 @@ class TestConnect
Signed-off-by: Anya Harter
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index ca9e4e1..b2021d4 100644
--- a/.gitignore
+++ b/.gitignore
@@ -44,3 +44,4 @@ vgcore.*
/src/org.libvirt.service
/tests/test_util
+**/.pytest_cache
--
2.17.1
--
libvir
On 07/10/2018 11:13 AM, Andrea Bolognani wrote:
> On Tue, 2018-07-10 at 10:00 -0400, Anya Harter wrote:
>> gitignore: add tests/.pytest_cache
>>
>> Signed-off-by: Anya Harter
>
> The commit message should have been adjusted - you're ignoring
> all .pytest_c
(property)
- virInterfaceGetXMLDesc(interface method)
- virInterfaceIsActive (property)
- virInterfaceLookupByMACString (connect method)
- virInterfaceLookupByName (connect method)
- virInterfaceUndefine (interface method)
Anya H
Signed-off-by: Anya Harter
---
data/org.libvirt.Interface.xml | 6 ++
src/interface.c| 28
tests/test_interface.py| 4
3 files changed, 38 insertions(+)
diff --git a/data/org.libvirt.Interface.xml b/data/org.libvirt.Interface.xml
Signed-off-by: Anya Harter
---
data/Makefile.am | 1 +
data/org.libvirt.Interface.xml | 7
src/Makefile.am| 2 ++
src/connect.c | 6
src/connect.h | 1 +
src/interface.c| 65
Signed-off-by: Anya Harter
---
data/org.libvirt.Connect.xml | 7 +++
src/connect.c| 30 ++
tests/test_connect.py| 4
tests/xmldata.py | 12
4 files changed, 53 insertions(+)
diff --git a/data
Signed-off-by: Anya Harter
---
data/org.libvirt.Interface.xml | 4
src/interface.c| 21 +
tests/test_interface.py| 5 +
3 files changed, 30 insertions(+)
diff --git a/data/org.libvirt.Interface.xml b/data/org.libvirt.Interface.xml
index
Signed-off-by: Anya Harter
---
data/org.libvirt.Connect.xml | 5 +
src/connect.c| 22 ++
2 files changed, 27 insertions(+)
diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml
index 604afea..8c88cc8 100644
--- a/data
Signed-off-by: Anya Harter
---
tests/Makefile.am | 1 +
tests/libvirttest.py| 12
tests/test_interface.py | 16
3 files changed, 29 insertions(+)
create mode 100755 tests/test_interface.py
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 09c3e2e
Signed-off-by: Anya Harter
---
data/org.libvirt.Connect.xml | 6 ++
src/connect.c| 38
2 files changed, 44 insertions(+)
diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml
index f690bab..791e1f5 100644
--- a/data
Signed-off-by: Anya Harter
---
data/org.libvirt.Interface.xml | 5
src/interface.c| 45 ++
2 files changed, 50 insertions(+)
diff --git a/data/org.libvirt.Interface.xml b/data/org.libvirt.Interface.xml
index 93fa32f..d98a646 100644
--- a
Signed-off-by: Anya Harter
---
data/org.libvirt.Connect.xml | 6 ++
src/connect.c| 29 +
tests/test_connect.py| 1 +
3 files changed, 36 insertions(+)
diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml
index f99e205
Signed-off-by: Anya Harter
---
data/org.libvirt.Interface.xml | 5 +
src/interface.c| 22 ++
tests/test_interface.py| 1 +
3 files changed, 28 insertions(+)
diff --git a/data/org.libvirt.Interface.xml b/data/org.libvirt.Interface.xml
index
Signed-off-by: Anya Harter
---
tests/test_interface.py | 4
1 file changed, 4 insertions(+)
diff --git a/tests/test_interface.py b/tests/test_interface.py
index 88be5dc..62fd517 100755
--- a/tests/test_interface.py
+++ b/tests/test_interface.py
@@ -7,6 +7,10 @@ class TestInterface
Signed-off-by: Anya Harter
---
data/org.libvirt.Interface.xml | 5 +
src/interface.c| 24
2 files changed, 29 insertions(+)
diff --git a/data/org.libvirt.Interface.xml b/data/org.libvirt.Interface.xml
index d98a646..f5ec281 100644
--- a/data
Signed-off-by: Anya Harter
---
data/org.libvirt.Interface.xml | 5 +
src/interface.c| 22 ++
tests/test_interface.py| 8
3 files changed, 35 insertions(+)
diff --git a/data/org.libvirt.Interface.xml b/data/org.libvirt.Interface.xml
Signed-off-by: Anya Harter
---
data/org.libvirt.Connect.xml | 6 ++
src/connect.c| 29 +
tests/test_connect.py| 12
3 files changed, 47 insertions(+)
diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml
Signed-off-by: Anya Harter
---
data/org.libvirt.Connect.xml | 5 +
src/connect.c| 22 ++
2 files changed, 27 insertions(+)
diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml
index 8c88cc8..7c97117 100644
--- a/data
Signed-off-by: Anya Harter
---
data/org.libvirt.Interface.xml | 5 +
src/interface.c| 22 ++
tests/test_interface.py| 1 +
3 files changed, 28 insertions(+)
diff --git a/data/org.libvirt.Interface.xml b/data/org.libvirt.Interface.xml
index
Signed-off-by: Anya Harter
---
data/org.libvirt.Connect.xml | 5 +
src/connect.c| 22 ++
2 files changed, 27 insertions(+)
diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml
index 791e1f5..604afea 100644
--- a/data
Signed-off-by: Anya Harter
---
src/domain.c | 2 +-
src/interface.c | 2 +-
src/network.c | 2 +-
src/nodedev.c | 2 +-
src/nwfilter.c| 2 +-
src/secret.c | 2 +-
src/storagepool.c | 2 +-
src/storagevol.c | 2 +-
8 files changed, 8 insertions(+), 8 deletions(-)
diff
to be the vir prefix and interface name followed by ObjMatch
ex. for virNetworkObjListExport, the match function is named
virNetworkObjMatch
Signed-off-by: Anya Harter
---
src/conf/virnetworkobj.c| 6 +++---
src/conf/virnodedeviceobj.c | 4 ++--
src/conf/virsecretobj.c
on vir*ObjListExport call stack
Anya Harter (3):
conf: rename structs used by Export function
conf: rename Export Callback functions
conf: rename Match functions
src/conf/virinterfaceobj.c | 10 +-
src/conf/virnetworkobj.c| 16
src/conf/virnodedeviceobj.c
to be the name of the Export function followed by Data
ex. for virInterfaceObjListExport, the struct is named
virInterfaceObjListExportData
Signed-off-by: Anya Harter
---
src/conf/virinterfaceobj.c | 6 +++---
src/conf/virnetworkobj.c | 6 +++---
src/conf/virsecretobj.c
to be the name of the export function followed by Callback
ex. for virInterfaceObjListExport, the callback function is named
virInterfaceObjListExportCallback
Signed-off-by: Anya Harter
---
src/conf/virinterfaceobj.c | 4 ++--
src/conf/virnetworkobj.c | 4 ++--
src/conf
on vir*ObjListExport call stack
Anya Harter (3):
conf: rename structs used by Export function
conf: rename Export Callback functions
conf: rename Match functions
src/conf/virinterfaceobj.c | 16 +---
src/conf/virnetworkobj.c| 24 ---
src/conf
name match functions to be the vir prefix and interface name followed by
ObjMatch
ex. for virNetworkObjListExport, the match function is named
virNetworkObjMatch
Signed-off-by: Anya Harter
---
src/conf/virnetworkobj.c| 8
src/conf/virnodedeviceobj.c | 6 +++---
src
name functions to be the name of the export function followed by Callback
ex. for virInterfaceObjListExport, the callback function is named
virInterfaceObjListExportCallback
Signed-off-by: Anya Harter
---
src/conf/virinterfaceobj.c | 8
src/conf/virnetworkobj.c | 8
;
typedef virInterfaceObjListExportData *virInterfaceObjListExportDataPtr;
struct _virInterfaceObjListExportData {...};
Signed-off-by: Anya Harter
---
src/conf/virinterfaceobj.c | 8 +---
src/conf/virnetworkobj.c| 8 +---
src/conf/virnodedeviceobj.c | 8 +---
src
89 matches
Mail list logo