Hi Eric,
On Thu, 2013-12-19 at 13:42 -0700, Eric Blake wrote:
-DO_CTX_TEST(true, cacert4req.filename, servercert4req.filename,
GNUTLS_VERSION_MAJOR = 3);
+DO_CTX_TEST(true, cacert4req.filename, servercert4req.filename,
+GNUTLS_VERSION_MAJOR = 3
Hi all,
I wish you all a happy new year 2014.
I'm currently implementing connectDomainXMLFromNative for the LXC
driver. The idea is to convert sourceforge LXC's config file into domain
XML files.
I just hit a problem with converting blkio device weights. LXC's config
directly stores the cgroup
Hi again,
On Thu, 2014-01-02 at 13:24 +0100, Cedric Bosdonnat wrote:
I just hit a problem with converting blkio device weights. LXC's config
directly stores the cgroup value, defining the device with it's major
and minor numbers. It seems to me that there is no way to get a path
from
Hi Dan,
On Fri, 2014-01-24 at 13:34 +, Daniel P. Berrange wrote:
IIUC, they use lxc.network.type = none to request sharing of
the network namespace, rather than 'empty'
Hum, the two values are existing, I'll need to implement 'none' too.
That value arrived in mid-december with commit
Hi Dan,
On Fri, 2014-01-24 at 13:17 +, Daniel P. Berrange wrote:
This data format looks really very close to the .vmx file format.
The main difference I see is that the right hand side of the =
sign does not require quotes.
We already have a src/util/virconf.{c,h} module which was
Hi Dan,
On Fri, 2014-01-24 at 13:39 +, Daniel P. Berrange wrote:
On Tue, Jan 14, 2014 at 02:49:54PM +0100, Cédric Bosdonnat wrote:
Some of the LXC configuration properties aren't migrated since they
would only cause problems in libvirt-lxc:
lxc.network.ipv[46]: LXC driver doesn't
On Fri, 2014-01-24 at 13:58 +, Daniel P. Berrange wrote:
On Tue, Jan 14, 2014 at 02:50:05PM +0100, Cédric Bosdonnat wrote:
The problem with VLAN is that the user still has to manually create the
vlan interface on the host. Then the generated configuration will use
it as a nerwork
Hi ChunYan,
On Fri, 2014-01-24 at 00:47 +0800, Chunyan Liu wrote:
Add unit test for hostdev common library. Current tests are based on
virpcimock.
Signed-off-by: Chunyan Liu cy...@suse.com
---
tests/Makefile.am |5 +
tests/virhostdevtest.c | 473
Hi Daniel,
On Tue, 2014-02-04 at 12:17 +, Daniel P. Berrange wrote:
On Thu, Jan 30, 2014 at 10:55:50AM +0100, Cédric Bosdonnat wrote:
This function aims at converting LXC configuration into a libvirt
domain XML description to help users migrate from LXC to libvirt.
Here is an
On Tue, 2014-02-04 at 12:39 +, Daniel P. Berrange wrote:
diff --git a/tests/lxcconf2xmldata/lxcconf2xml-blkiotune.config
b/tests/lxcconf2xmldata/lxcconf2xml-blkiotune.config
new file mode 100644
index 000..8083c71
--- /dev/null
+++
On Wed, 2014-02-05 at 15:10 +0100, Cédric Bosdonnat wrote:
direct interfaces are already brought up when creating them.
Just ignore (and drop) this patch, veth interfaces are already up when
starting the container... even thought I couldn't ifdown it ;)
--
Cedric
---
src/lxc/lxc_process.c |
Hi Daniel,
On Tue, 2014-02-11 at 14:55 +, Daniel P. Berrange wrote:
I realize this is helping the conversion of existing configs, but
personally I'm pretty loathe to add this syntax. With device paths
it is possible to have stable paths ie using /dev/disk/by*. With
major/minor the XML
On Wed, 2014-02-12 at 06:31 -0700, Eric Blake wrote:
On 02/12/2014 03:36 AM, Cédric Bosdonnat wrote:
Two unused global variables, and DBUS_TYPE_INVALID used as a const
char*.
---
src/phyp/phyp_driver.c | 1 -
src/storage/storage_backend_scsi.c | 24
On Thu, 2014-02-13 at 06:34 -0500, John Ferlan wrote:
New Coverity complaint regarding this change ...
...snip...
virDomainDefPtr
lxcParseConfigString(const char *config)
{
@@ -115,6 +343,7 @@ lxcParseConfigString(const char *config)
_(failed to generate
On Fri, 2014-02-14 at 09:16 +0100, Jan Kiszka wrote:
I need to submit our organization application (including our project
ideas) on Friday.
Hope it's not too late: just added the VT-d emulation proposal.
It's not too late. Ideas page must be ready when students will discover
the list of
Hello ChunYan,
Good to see your patchset into smaller pieces. This patch looks almost
OK for me, but there are problems you'll need to look into.
On Mon, 2014-02-17 at 14:32 +0800, Chunyan Liu wrote:
Add driver info to used_by, to avoid conflict among different drivers if there
are more than
On Mon, 2014-02-17 at 14:32 +0800, Chunyan Liu wrote:
For extracting hostdev codes from qemu_hostdev.c to common library, change
qemu
specific cfg-relaxedACS handling to be a flag, and pass it to hostdev
functions.
Signed-off-by: Chunyan Liu cy...@suse.com
---
src/qemu/qemu_hostdev.c |
On Mon, 2014-02-17 at 14:32 +0800, Chunyan Liu wrote:
For extracting hostdev codes from qemu_hostdev.c to common library, change
qemu
specific COLD_BOOT handling to be a flag, and pass it to hostdev functions.
Signed-off-by: Chunyan Liu cy...@suse.com
---
src/qemu/qemu_hostdev.c |6
On Mon, 2014-02-17 at 14:32 +0800, Chunyan Liu wrote:
For extracting hostdev codes from qemu_hostdev.c to common library, change
original paring VIR_DOMAIN_HOSTDEV_PCI_BACKEND_DEFAULT in hostdev function to
qemuDomainDeviceDefPostParse.
typo: paring - parsing.
Signed-off-by: Chunyan Liu
On Mon, 2014-02-17 at 14:32 +0800, Chunyan Liu wrote:
For extracting hostdev codes from qemu_hostdev.c to common library, move
add/remove a shareable csi hostdev to/from shared device table outside hostdev
functions.
Typo csi - scsi
Signed-off-by: Chunyan Liu cy...@suse.com
---
Hello Vik,
On Thu, 2014-02-20 at 15:14 -0800, vikhyath reddy wrote:
Thanks for libvirt. It is a life saver. I am in the process of writing
some custom wrappers for libvirt so that it can be easily accessed
from nodejs using the nodejs-ffi interfacing (basically describes a
way to convert
On Fri, 2014-02-21 at 14:23 +, Daniel P. Berrange wrote:
On Fri, Feb 21, 2014 at 02:57:28PM +0100, Cédric Bosdonnat wrote:
No security_driver value could cause weird behavior, like using
apparmor even though we don't want it.
---
src/lxc/lxc.conf | 2 ++
1 file changed, 2
Hello ChunYan,
I saw a few minor problems in some patches that made me rebase quite a
lot of other patches in your serie, but otherwise it really looks good
to me.
Here is a summary of the changes I made or questions I have:
* Patch 2: Fixed a few remaining changes that broke the build.
Hi Daniel, Chunyan,
On Tue, 2014-03-04 at 12:41 +, Daniel P. Berrange wrote:
On Sat, Mar 01, 2014 at 02:29:03PM +0800, Chunyan Liu wrote:
typedef enum {
VIR_STRICT_ACS_CHECK = (1 0), /* strict acs check */
+ VIR_COLD_BOOT= (1 1), /* cold boot */
}
Hi Stefan, Christian,
On Fri, 2014-03-07 at 10:16 +0100, Stefan Hajnoczi wrote:
I am not applying as a student and I am not offering myself as a mentor (I
do not qualify as a mentor), I Just wanted to point out a possible
interesting
(and challenging) project.
I am afraid it would be
On Fri, 2013-11-29 at 17:18 +, Daniel P. Berrange wrote:
On Fri, Nov 29, 2013 at 04:18:58PM +0100, Cédric Bosdonnat wrote:
The virDomainEvent class wasn't defining anything special, thus it has
been dropped.
diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c
index
On Fri, 2013-11-29 at 17:09 +, Daniel P. Berrange wrote:
On Fri, Nov 29, 2013 at 04:18:45PM +0100, Cédric Bosdonnat wrote:
static virClassPtr virObjectEventClass;
static virClassPtr virDomainEventClass;
+static virClassPtr virDomainEventLifecycleClass;
static void
Hi Eric,
On Mon, 2013-12-02 at 17:19 -0700, Eric Blake wrote:
On 12/02/2013 09:39 AM, Cédric Bosdonnat wrote:
These unit tests are aiming at providing some help during the domain
events refactoring.
---
.gitignore | 1 +
tests/Makefile.am | 7 ++
Hi John,
On Thu, 2013-12-12 at 06:50 -0500, John Ferlan wrote:
4920
(3) Event returned_null: Function virNetworkEventLifecycleNew(char
const *, unsigned char const *, int) returns null (checked 10 out of 11
times). [details]
(14) Event var_assigned: Assigning: event = null
On Wed, 2013-12-11 at 15:28 +, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The domain events demo program isn't really tied to domain
events anymore, so rename it to object events.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
Makefile.am
On Wed, 2013-12-11 at 15:28 +, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
...
@@ -633,22 +640,17 @@ virObjectEventStateDispatchFunc(virConnectPtr conn,
void *opaque)
{
virObjectEventStatePtr state = opaque;
-
On Thu, 2013-12-12 at 18:04 +, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The domain events demo program isn't really tied to domain
events anymore, so rename it to object events.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
Makefile.am
On Thu, 2013-12-12 at 18:04 +, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
While the public API wire protocol included the 'detail'
arg for network lifecycle events, the internal event handling
code did not process it. This meant that if a future libvirtd
On Thu, 2013-12-12 at 18:04 +, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Inject a virNetworkEvent class between virObjectEvent
and virNetworkEventLifecycle to mirror virDomainEvent.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
On Thu, 2013-12-12 at 18:04 +, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Instead of having the object event code have to know about each
type of event and their dispatch functions, associate a dispatch
function with the object instance. The dispatch code can
Hi,
Did anyone have some time to have a look at this small example tool?
Regards,
--
Cedric
On Tue, 2014-03-11 at 13:40 +0100, Cédric Bosdonnat wrote:
---
Makefile.am | 2 +-
configure.ac | 1 +
examples/lxcconvert/Makefile.am | 19
Hello Serge,
On Mon, 2014-03-24 at 22:21 -0500, Serge Hallyn wrote:
Quoting Cédric Bosdonnat (cbosdon...@suse.com):
See lp#1276719 for the bug description. As virt-aa-helper doesn't know
Great, thanks for addressing this.
the VFIO groups to use for the guest,
Is there really no way
On Tue, 2014-03-25 at 10:40 -0500, Serge Hallyn wrote:
Quoting Cédric Bosdonnat (cbosdon...@suse.com):
See lp#1276719 for the bug description. As virt-aa-helper doesn't know
the VFIO groups to use for the guest, allow access to all
/dev/vfio/[0-9]* and /dev/vfio/vfio files if there is a
Hi Eric,
On Fri, 2014-03-28 at 14:07 -0600, Eric Blake wrote:
On 03/28/2014 10:32 AM, Cédric Bosdonnat wrote:
From: Cédric Bosdonnat cedric.bosdon...@free.fr
pm-is-supported is the only thing needed in pm-utils, better get rid of
it since systemd is heavily used for libvirt.
---
Hum... it seems I'll have to fix somethings in that patch, ignore it for
the while.
--
Cedric
On Tue, 2014-04-01 at 15:19 +0200, Cédric Bosdonnat wrote:
This uses the dbus api of systemd to check the power management
capabilities of the node.
---
This replaces the previous pm-utils
On Wed, 2014-04-02 at 15:52 +0200, Daniel P. Berrange wrote:
On Wed, Apr 02, 2014 at 03:35:51PM +0200, Cédric Bosdonnat wrote:
This uses the dbus api of systemd to check the power management
capabilities of the node.
---
Diff with v2:
* Fixed a few dbus call problems
Could anyone have a look at this one?
--
Cedric
On Thu, 2014-04-03 at 14:20 +0200, Cédric Bosdonnat wrote:
This uses the dbus api of systemd to check the power management
capabilities of the node.
---
Diff with v3:
* Added unit tests vir virSystemdCan* helpers
* Make the default for
Eric, is there still something I should fix on this patch?
--
Cedric
On Fri, 2014-03-28 at 17:31 +0100, Cédric Bosdonnat wrote:
---
Makefile.am | 2 +-
configure.ac | 1 +
examples/lxcconvert/Makefile.am | 18 ++
Hi all,
The libvirt-daemon-config-network package is only pulled by libvirt. So
a user installing only libvirt-daemon-lxc (qemu, xen, etc) won't get
that package... and no default network.
Would it be OK if I move the dependency to
libvirt-daemon-{lxc,qemu,xen,...} packages?
--
Cedric
--
Hi all,
Thanks for your prompt answer. Good to know there is a reason for this:
I'll handle that differently on the suse side then.
Regards,
--
Cedric
On Tue, 2014-05-13 at 12:18 -0400, Daniel P. Berrange wrote:
On Tue, May 13, 2014 at 05:53:26PM +0200, Cedric Bosdonnat wrote:
Hi all
Hi all,
Is that patch now burried too far away in the mail stack? Could someone
review it?
--
Cedric
On Tue, 2014-05-13 at 10:10 +0200, Cédric Bosdonnat wrote:
---
bin/virt-sandbox-service | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bin/virt-sandbox-service
On Wed, 2014-06-04 at 11:24 +0200, Christophe Fergeau wrote:
On Tue, May 13, 2014 at 10:10:36AM +0200, Cédric Bosdonnat wrote:
---
bin/virt-sandbox-service | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bin/virt-sandbox-service b/bin/virt-sandbox-service
index
On Wed, 2014-06-04 at 12:51 +0100, Daniel P. Berrange wrote:
On Wed, Jun 04, 2014 at 01:24:17PM +0200, Cedric Bosdonnat wrote:
On Wed, 2014-06-04 at 11:24 +0200, Christophe Fergeau wrote:
On Tue, May 13, 2014 at 10:10:36AM +0200, Cédric Bosdonnat wrote:
---
bin/virt-sandbox-service
On Thu, 2014-06-05 at 10:37 +0100, Daniel P. Berrange wrote:
On Thu, Jun 05, 2014 at 11:32:22AM +0200, Christophe Fergeau wrote:
Hey,
Looks good to me.
There's a 'Nuernberg' typo in the copyright lines
I'm wondering if GVirConfigCapabilitiesSecmodel should be
On Mon, 2014-06-16 at 11:18 +0200, Christophe Fergeau wrote:
Hey,
Looks good to me, one addition below:
On Thu, Jun 05, 2014 at 08:42:24AM +0200, Cédric Bosdonnat wrote:
diff --git a/libvirt-gconfig/libvirt-gconfig-capabilities-host.c
On Mon, 2014-06-16 at 11:32 +0200, Christophe Fergeau wrote:
On Thu, Jun 12, 2014 at 10:52:21AM +0200, Cédric Bosdonnat wrote:
This code depends on new API in libvirt-gconfig to extract the
secmodels handled by the host.
---
Diff to v1:
* Adapted the naming change from
On Wed, 2014-06-18 at 11:11 +0200, Christophe Fergeau wrote:
Hi,
On Tue, Jun 17, 2014 at 04:01:53PM +0200, Cédric Bosdonnat wrote:
This code depends on new API in libvirt-gconfig to extract the
secmodels handled by the host.
---
Diff to v3:
* Added yet another missing
On Wed, 2014-07-02 at 23:00 +0200, Richard Weinberger wrote:
On Wed, Jul 2, 2014 at 3:57 PM, Cédric Bosdonnat cbosdon...@suse.com wrote:
This patch series allows users to configure the network device name in the
LXC container. I intentionaly didn't allow this for hostdev net interfaces
as
On Fri, 2014-07-11 at 11:03 -0600, Eric Blake wrote:
On 07/11/2014 09:22 AM, Serge Hallyn wrote:
Quoting Cédric Bosdonnat (cbosdon...@suse.com):
---
src/security/virt-aa-helper.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Hi,
I'm acking this anyway bc I think
On Fri, 2014-07-11 at 16:08 +, Serge Hallyn wrote:
Quoting Cédric Bosdonnat (cbosdon...@suse.com):
Rework the apparmor lxc profile abstraction to mimic ubuntu's
container-default.
This profile allows quite a lot, but strives to restrict access to
dangerous resources.
Removing
Hi Serge,
On Mon, 2014-07-14 at 13:55 +, Serge Hallyn wrote:
Quoting Cédric Bosdonnat (cbosdon...@suse.com):
diff --git a/examples/apparmor/libvirt-lxc b/examples/apparmor/libvirt-lxc
index d404328..4bfb503 100644
--- a/examples/apparmor/libvirt-lxc
+++
On Thu, 2014-07-17 at 14:51 +0800, Daniel Veillard wrote:
Plan is to get the new release on Friday Aug 1st, so
I think this mean entering freeze at some point on the
preceeding week-end, I will be travelling then, but I
should be able to do that at some point saturday 26.
We already have
On Wed, 2014-07-23 at 13:23 +0200, Ján Tomko wrote:
On 07/18/2014 10:02 AM, Cédric Bosdonnat wrote:
Added capabilities in the features section of LXC domains
configuration. This section can contain elements named after the
capabilities like:
mknod state=on/, keep CAP_MKNOD capability
On Wed, 2014-07-30 at 12:37 +0200, Ján Tomko wrote:
On 07/30/2014 11:25 AM, Cédric Bosdonnat wrote:
If all features are set to default (including the capabilities policy),
but some capabilities are toggled, we need to output the features
element when formatting the config.
---
Hi all,
On Fri, 2014-07-25 at 17:03 +0200, Cédric Bosdonnat wrote:
Uses the new virDomainNetDef ips to set the IP addresses on the network
interfaces in the container.
---
src/lxc/lxc_container.c | 20 +++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git
Hi Richard,
On Tue, 2014-08-26 at 22:32 +0200, Richard Weinberger wrote:
On Tue, Aug 26, 2014 at 3:20 PM, Cédric Bosdonnat cbosdon...@suse.com wrote:
Hi all,
Here is the whole series resent with a major addition: the functions
used to set the IP and add a route now use libnl when
Hi all,
detect_scsi_host_caps function is called without caring of the result in
most cases. Wouldn't it be more logical to have VIR_ERRORs in this
function transformed into VIR_WARN as those problems aren't blocking
libvirt?
Note: I can do the (trivial) patch if the idea is ACKed.
--
Cedric
Sorry guys, I just resent those as I got emails saying they weren't
sent. Just discard the second ones...
--
Cedric
On Thu, 2014-10-23 at 22:15 -0700, Cédric Bosdonnat wrote:
Hi guys,
Here are 2 trivial patches to fixes issues connecting using libssh2. The first
one fixes a -1 use with a
Hi Daniel,
On Wed, 2014-10-22 at 11:03 +0100, Daniel P. Berrange wrote:
On Fri, Oct 10, 2014 at 02:03:54PM +0200, Cédric Bosdonnat wrote:
Add the possibility to have more than one IP address configured for a
domain network interface. IP addresses can also have a prefix to define
the
On Thu, 2014-09-18 at 16:38 -0600, Eric Blake wrote:
On 09/18/2014 03:24 PM, Cédric Bosdonnat wrote:
libc has another constant with the same name, which leads to
redefinition error when building against static libvirt
---
src/util/virtime.c | 4 ++--
1 file changed, 2 insertions(+), 2
Hi Daniel,
On Wed, 2014-10-22 at 11:09 +0100, Daniel P. Berrange wrote:
It would be nice if we can share the parsing of this with the parsingdone
in the network xml block. Since the XML schema is the same, I'd expect
we can have a single function that contains everything from the
Hello Claudio,
On Fri, 2014-10-31 at 23:40 +0100, Claudio Bley wrote:
At Sat, 25 Oct 2014 16:25:48 -0700,
Cédric Bosdonnat wrote:
I'd prefer an enum instead of these (ugly) constants.
As a side node, these constants are useless since the
ListAllDomainsFlags is not public.
Ok, I mimicked
Hi Daniel,
On Wed, 2014-10-22 at 11:03 +0100, Daniel P. Berrange wrote:
I think it is probably worth a followup patch to make drivers
report VIR_ERR_CONFIG_UNSUPPORTED in the case where nips 1
and the driver only supports nips==1.
Shouldn't we just VIR_WARN this? That would avoid breaking
On Fri, 2014-11-07 at 10:31 +0100, Eric Blake wrote:
On 11/04/2014 03:15 PM, Cédric Bosdonnat wrote:
If detect_scsi_host_caps reports errors but keeps libvirtd going on
startup, the user is mislead by the error messages. Transforming them
s/mislead/misled/
into warning still shows the
Hi all,
As an example, the following command
virt-sandbox-service create --network dhcp,source=default --unitfile
sshd.service mysshd -i 512
generates a container definition containing these filesystems (in the
same order):
filesystem type='file' accessmode='passthrough'
source
On Tue, 2014-11-25 at 08:05 +0100, Martin Kletzander wrote:
On Mon, Nov 24, 2014 at 09:54:43PM +0100, Cédric Bosdonnat wrote:
To get virt-sandbox-service working with AppArmor, virt-aa-helper
needs not to choke on path in /etc/libvirt-sandbox/services.
---
src/security/virt-aa-helper.c | 8
On Tue, 2014-11-25 at 08:42 +0100, Martin Kletzander wrote:
On Mon, Nov 24, 2014 at 09:54:44PM +0100, Cédric Bosdonnat wrote:
Due to a change (or bug?) in ip link implementation, the command
'ip link add vnet0...'
is forced into
'ip link add name vnet0...'
The changed command also
On Tue, 2014-11-25 at 08:48 +0100, Martin Kletzander wrote:
On Mon, Nov 24, 2014 at 09:54:46PM +0100, Cédric Bosdonnat wrote:
The typical case where we had a problem is with such a filesystem
definition as created by virt-sandbox-service:
filesystem type='bind' accessmode='passthrough'
Pushed them all with changes to patch #2 as requested by Martin.
Thanks Martin for your review.
--
Cedric
On Mon, 2014-11-24 at 21:54 +0100, Cédric Bosdonnat wrote:
Hi all,
this patch series fixes a few problems I encountered when getting
virt-sandbox-service
containers with images to
Hi Martin,
On Wed, 2014-11-26 at 05:51 +0100, Martin Kletzander wrote:
Instead of papering over the issue in libvirt better ship a non-broken
iproute2
in openSUSE 13.2.
real fix:
https://git.kernel.org/cgit/linux/kernel/git/shemminger/iproute2.git/commit/?id=f1b66ff
Oh, thank you for
Hi Martin,
On Wed, 2014-11-26 at 05:32 +0100, Martin Kletzander wrote:
+
+# /var contains the mounted image if there is an image:
should be the
+# last thing to mount
+self.add_bind_mount(source, /var)
You have the source set from a random value from self.dirs, ACK
On Wed, 2014-11-26 at 09:34 +0100, Richard Weinberger wrote:
Am 26.11.2014 um 09:25 schrieb Cedric Bosdonnat:
Hi Martin,
On Wed, 2014-11-26 at 05:51 +0100, Martin Kletzander wrote:
Instead of papering over the issue in libvirt better ship a non-broken
iproute2
in openSUSE 13.2
Oops... forgot to mention it's a libvirt-sandbox patch.
On Tue, 2014-12-09 at 13:43 +0100, Cédric Bosdonnat wrote:
---
libvirt-sandbox/libvirt-sandbox-config-service-systemd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Fri, 2014-12-19 at 10:46 +0100, Guido Günther wrote:
Reported and patch provided by Bastian Blank at
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=769600
---
src/lxc/lxc_container.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lxc/lxc_container.c
Hi Jihoon,
On Sat, 2015-01-24 at 17:17 +, Kim Larry wrote:
I was trying to pass ip address to scripts/vif-bridge by putting ip
address=/ in guest config xml file, however, I found that
libxlMakeNic(which located in libxl/libxl_conf.c:956) doesn't set
x_nic-ip. So I patched myself but I'm
On Mon, 2015-01-19 at 18:25 -0700, Mike Latimer wrote:
Apparmor must not prevent access to required helper programs. The following
helpers should be allowed to run in unconfined execution mode:
- libvirt_parthelper
- libvirt_iohelper
---
examples/apparmor/usr.sbin.libvirtd | 2 ++
1
On Mon, 2015-01-19 at 18:25 -0700, Mike Latimer wrote:
The network and nwfilter tests contained in the libvirt-TCK testkit can fail
unless access to raw network packets is granted. Without this access, the
following apparmor error can be seen while running the tests:
apparmor=DENIED
On Mon, 2015-01-19 at 18:25 -0700, Mike Latimer wrote:
In order for apparmor to work properly in Xen environments, the following
access rights need to be allowed:
- Allow CAP_SYS_PACCT, which is required when resetting some multi-port
Broadcom cards by writting to the PCI config space
On Wed, 2015-01-21 at 22:32 -0700, Mike Latimer wrote:
On Tuesday, January 20, 2015 09:08:04 AM Cedric Bosdonnat wrote:
On Mon, 2015-01-19 at 18:25 -0700, Mike Latimer wrote:
Apparmor must not prevent access to required helper programs. The
following
helpers should be allowed
Hi Laine,
On Thu, 2015-01-15 at 13:34 -0500, Laine Stump wrote:
(Gene - I Cc'ed you because of one question I have for you down in the
bowels of the review. Just search for Gene and you'll get to it).
Looks like you forgot to actually add Gene to CC ;)
On 01/15/2015 04:25 AM, Cédric
On Thu, 2015-01-15 at 11:58 +0100, Michal Privoznik wrote:
On 15.01.2015 10:25, Cédric Bosdonnat wrote:
Hi guys,
Here are a few patches to have common route definitions for domains and
networks.
What has changed since v1:
* Split into several patches for backportability as
On Fri, 2015-01-16 at 06:50 -0500, John Ferlan wrote:
On 01/15/2015 04:25 AM, Cédric Bosdonnat wrote:
If 0.0.0.0 address is provided, then the returned prefix should be 0,
rather than 8.
---
src/util/virsocketaddr.c | 6 ++
1 file changed, 6 insertions(+)
diff --git
On Thu, 2015-01-15 at 11:58 +0100, Michal Privoznik wrote:
On 15.01.2015 10:25, Cédric Bosdonnat wrote:
Moving network route to the network common schema will allow reusing it.
---
docs/schemas/network.rng | 20 +---
docs/schemas/networkcommon.rng | 22
On Thu, 2015-01-15 at 11:58 +0100, Michal Privoznik wrote:
On 15.01.2015 10:25, Cédric Bosdonnat wrote:
Moving code for parsing and formatting network routes to
networkcommon_conf helps reusing those routes for domains. The route
definition has been hidden to help reducing the number of
Hello Gaurav,
First, thanks a lot for being interested in that idea!
You said that you tried Daniel's proof of concept, but did you manage to
get a disk image out of a docker image? I guess not... or you have some
patches to send back ;)
In this project I already see these steps:
* Get
On Thu, 2015-01-22 at 09:17 -0700, Mike Latimer wrote:
On Thursday, January 22, 2015 08:55:07 AM Cedric Bosdonnat wrote:
Seems like the apparmor profile for libvirtd is pretty wide open, so I'm
not sure if there will be much of a difference between those two
settings. I'm also not sure
Hi Eric,
On Mon, 2015-01-05 at 15:13 -0700, Eric Blake wrote:
Commit 4dc04d3a added virNetlinkGetErrorCode, but forgot to provide
a fallback, which kills the build on mingw (among others):
CCLD libvirt.la
Cannot export virNetlinkGetErrorCode: symbol not defined
collect2: error:
On Sun, 2015-01-04 at 10:00 -0600, Jamie Strandboge wrote:
On 12/30/2014 04:33 AM, Cédric Bosdonnat wrote:
The apparmor profiles forgot about /usr/lib64 folders, just add lib64
as a possible alternative to lib in the paths
These changes all look good to me. +1
Pushed, then.
Thanks for the
On Sun, 2015-01-11 at 13:51 +0100, Guido Günther wrote:
Reported and patch provided by Bastian Blank at
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=769600
---
src/lxc/lxc_container.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lxc/lxc_container.c
cycles before addressing 3/6 4/6 since it seems Cedric Bosdonnat is
already in the process of adjusting virDomainNetRoutesFormat() and these
changes may partially be duplicitous.
Cedric - perhaps as part of your changes, you could also make
adjustments to cover the cases found through
Hi Michal,
On Mon, 2015-01-12 at 11:47 +0100, Michal Privoznik wrote:
On 09.01.2015 17:47, Cédric Bosdonnat wrote:
Made the network configuration schemas and codes for the route element
reusable.
Created networkcommon_conf.[ch] files containing pieces to be used in both
domain
and
Hi Jan,
On Mon, 2015-02-09 at 10:04 +0100, Ján Tomko wrote:
On Fri, Feb 06, 2015 at 02:28:15PM +0100, Cédric Bosdonnat wrote:
commit a58e1cb4 didn't fix the bug if the security_default_confined is
not set to 1. We now clean up even if there is no seclabel defined or
the default one.
---
Hi Jan,
Thanks for your review. Pushed.
--
Cedric
On Mon, 2015-01-05 at 10:37 +0100, Ján Tomko wrote:
On 12/30/2014 11:33 AM, Cédric Bosdonnat wrote:
Hi there,
Here are 2 patches fixing tiny annoying problems. One of them, makes
apparmor profiles handle /usr/lib64 folder and the other
Hi Daniel,
Thanks a lot for your reviews. I just pushed the patch series with the
IP Doc commit squashed.
--
Cedric
On Mon, 2015-01-05 at 17:26 +, Daniel P. Berrange wrote:
On Tue, Dec 30, 2014 at 11:27:10AM +0100, Cédric Bosdonnat wrote:
---
src/conf/domain_conf.c | 2 ++
1 file
Hi Jamie,
On Thu, 2015-04-09 at 20:29 -0500, Jamie Strandboge wrote:
On 04/09/2015 04:25 AM, Cédric Bosdonnat wrote:
SLES 11 has legacy qemu-kvm package, /usr/bin/qemu-kvm and
/usr/share/qemu-kvm need to be accessed by domains.
---
examples/apparmor/libvirt-qemu | 9 +
1 file
1 - 100 of 317 matches
Mail list logo
