Re: [libvirt] [Qemu-devel] [qemu-devel] Default machine type setting for ppc64

2013-05-21 Thread Christian Borntraeger
On 21/05/13 14:04, Anthony Liguori wrote: Daniel P. Berrange berra...@redhat.com writes: On Tue, May 21, 2013 at 07:55:27PM +1000, Paul Mackerras wrote: On Tue, May 21, 2013 at 09:39:53AM +0100, Daniel P. Berrange wrote: QEMU has the notion of a default machine for each target, and that is

Re: [libvirt] [Qemu-devel] pvpanic plans?

2013-08-22 Thread Christian Borntraeger
08eb8c85e3967b97865d46acadf26dc908fbb094 Author: Christian Borntraeger borntrae...@de.ibm.com Date: Fri Apr 26 11:24:47 2013 +0800 Wire up disabled wait a panicked event on s390 Should we remove that as well? From s390 point of view, after allowing the crashed-running transition the feature

Re: [libvirt] Release of libvirt-3.0.0

2017-01-17 Thread Christian Borntraeger
On 01/17/2017 07:40 PM, Daniel Veillard wrote: > So I got mixed reports in the last day about the state of the head > but one of the big issues seems solved, and I'm not sure keeping the > freeze much longer will help, so libvirt-3.0.0 is out. It's tagged in > git, signed tarball and rpms are

Re: [libvirt] Availability of libvirt-3.0.0 release candidate 2

2017-01-17 Thread Christian Borntraeger
On 01/17/2017 05:39 PM, Daniel P. Berrange wrote: > I'm thinking we've hit the limit of what we should try to force into the > 3.0.0 release. > > My vote at this poiint is to change the code so that namespaces are > disabled out of the box, and do a 3.0.0 release. Look at fixing the Ack. >

Re: [libvirt] [PATCH] util: Fix build on s390

2016-10-07 Thread Christian Borntraeger
On 10/07/2016 12:43 PM, Jiri Denemark wrote: > GCC on s390 complains > > util/virconf.c: In function 'virConfGetValueSizeT': > util/virconf.c:1220:9: error: format '%zu' expects argument of type > 'size_t', but argument 9 has type 'unsigned int' [-Werror=format=] Interesting, we have never seen

Re: [libvirt] [RFC 0/5] Qemu: s390: Cpu Model Support

2016-11-03 Thread Christian Borntraeger
On 11/03/2016 02:37 PM, Jiri Denemark wrote: > Well, this should be correct, or is QEMU on s390 able to use -cpu host > in TCG mode? > > Does "virsh domcapabilities --virttype kvm" report host-passthrough as > supported? yes, this is what I get /usr/bin/qemu-system-s390x kvm

Re: [libvirt] [RFC 0/5] Qemu: s390: Cpu Model Support

2016-11-03 Thread Christian Borntraeger
On 11/03/2016 02:37 PM, Jiri Denemark wrote: > On Wed, Nov 02, 2016 at 16:34:30 -0400, Jason J. Herne wrote: > ... >> Patch #5 updates qemuBuildCpuModelArgStr's VIR_CPU_MODE_HOST_MODEL case. It >> seems like all archs except PPC64 do not support host model mode. > > x86 supports host-model too,

Re: [libvirt] [PATCH V3 2/2] qemu: Allow use of hot plugged host CPUs if no affinity set

2016-12-06 Thread Christian Borntraeger
nly the ones that are currently running have this bug. So this fix does not only allow hotplug it also fixes an imbalance for running/new QEMUs. So I think it makes a lot of sense to also allow running QEMUs to use new CPUs. Acked-by: Christian Borntraeger <borntrae...@de.ibm.com> > >

Re: [libvirt] Making panic great again

2017-04-28 Thread Christian Borntraeger
On 04/28/2017 02:34 AM, Ed Swierk wrote: > The panic device is currently documented as a way for "libvirt to receive > panic notification from a QEMU guest". > > This is true, but not the whole story. When a guest triggers the panic > device, QEMU pauses the guest, and libvirt takes the action

Re: [libvirt] [PATCH v1 0/3] Loadparm support

2017-05-19 Thread Christian Borntraeger
On 05/19/2017 07:34 PM, Daniel P. Berrange wrote: > On Fri, May 19, 2017 at 12:56:44PM -0400, Farhan Ali wrote: >> This patch series introduces the support for new s390x 'loadparm' >> feature. The 'loadparm' can be used to select the boot entry to >> boot from, for a boot device. > > Why do we

Re: [libvirt] [PATCH v2 1/3] conf : Add loadparm boot option for a boot device

2017-05-19 Thread Christian Borntraeger
On 05/19/2017 06:56 PM, Farhan Ali wrote: > Update the per device boot schema to add an optional loadparm parameter. > Extend the virDomainDeviceInfo to support loadparm option. > Modify the appropriate functions to parse loadparm from boot device xml. > > Signed-off-by: Farhan Ali

Re: [libvirt] [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

2017-10-26 Thread Christian Borntraeger
On 10/26/2017 01:35 AM, Halil Pasic wrote: try the most interesting scenarios out. > > The idea of the patch is very clear, but I don't understand the bigger gs > feature context fully. > > From what I read in the code, the attempt to enable the gs capability in > the kernel is made

Re: [libvirt] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

2017-10-25 Thread Christian Borntraeger
Ping, I plan to submit belows patch for 2.11. We can then still look into a libvirt<->qemu interface for limiting host-model depending on machine versions (or not). On 10/20/2017 04:54 PM, Christian Borntraeger wrote: > Starting a guest with > > hvm > > >

Re: [libvirt] [PATCH 0/1] Bug: Sandbox: libvirt breakdowns qemu guest

2018-05-07 Thread Christian Borntraeger
On 05/07/2018 05:32 AM, Yi Min Zhao wrote: > 1. Problem Description > == > If QEMU is built without seccomp support, 'elevatorprivileges' remains > compiled. > This option of sandbox is treated as an indication for seccomp blacklist > support > in libvirt. This behavior is

Re: [libvirt] [PATCH 0/1] Bug: Sandbox: libvirt breakdowns qemu guest

2018-05-07 Thread Christian Borntraeger
On 05/07/2018 02:02 PM, Ján Tomko wrote: > On Mon, May 07, 2018 at 12:33:20PM +0200, Eduardo Otubo wrote: >> On 07/05/2018 - 11:29:57, Christian Borntraeger wrote: >>> On 05/07/2018 05:32 AM, Yi Min Zhao wrote: >>> > 1. Problem Description >>> > ===

Re: [libvirt] [PATCH 02/12] Introduce new domain create API virDomainCreateWithParams

2018-05-16 Thread Christian Borntraeger
On 05/16/2018 05:35 PM, Daniel P. Berrangé wrote: > On Wed, May 16, 2018 at 05:30:33PM +0200, Marc Hartmayer wrote: >> On Wed, May 09, 2018 at 05:40 PM +0200, "Daniel P. Berrangé" >> wrote: >>> On Wed, May 09, 2018 at 04:56:12PM +0200, Marc Hartmayer wrote: Introduce

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Christian Borntraeger
On 06/22/2018 05:01 PM, Kevin Wolf wrote: > Am 22.06.2018 um 16:38 hat Christian Borntraeger geschrieben: >> >> >> On 06/22/2018 04:25 PM, Kevin Wolf wrote: >>> Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben: >>>> >>>> &

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Christian Borntraeger
On 06/22/2018 04:25 PM, Kevin Wolf wrote: > Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben: >> >> >> On 06/22/2018 02:55 PM, Kevin Wolf wrote: >>> Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: >>>> >>>> On 0

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-03 Thread Christian Borntraeger
On 07/03/2018 01:35 PM, Peter Maydell wrote: > On 3 July 2018 at 12:32, Kevin Wolf wrote: >> Am 03.07.2018 um 13:22 hat Daniel P. Berrangé geschrieben: >>> Just posted latest version here: >>> >>> https://www.redhat.com/archives/libvir-list/2018-July/msg00130.html >>> >>> It will be in the

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-03 Thread Christian Borntraeger
0100, Daniel P. Berrangé wrote: >>>>> On Fri, Jun 22, 2018 at 04:25:13PM +0200, Kevin Wolf wrote: >>>>>> Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben: >> >> [...] >> >>> >>> Thanks! >>> >>> I'll lo

Re: [libvirt] Question about the host-model CPU mode

2017-10-20 Thread Christian Borntraeger
On 10/20/2017 03:16 PM, David Hildenbrand wrote: > >> Hi all, >> >> we recently encountered the problem that the 'host-model' [1] has to be >> related to the machine type of a domain. We have following problem: >> >>Let's assume we've a z13 system with a QEMU 2.9 and we define a >>

Re: [libvirt] Question about the host-model CPU mode

2017-10-20 Thread Christian Borntraeger
On 10/20/2017 03:43 PM, David Hildenbrand wrote: > On 20.10.2017 15:36, Christian Borntraeger wrote: >> >> >> On 10/20/2017 03:16 PM, David Hildenbrand wrote: >>> >>>> Hi all, >>>> >>>> we recently encountered the problem th

Re: [libvirt] Question about the host-model CPU mode

2017-10-20 Thread Christian Borntraeger
On 10/20/2017 04:06 PM, David Hildenbrand wrote: > On 20.10.2017 16:02, Christian Borntraeger wrote: >> >> >> On 10/20/2017 03:51 PM, David Hildenbrand wrote: >> [...] >>>> The problem goes much further. >>>> A fresh guest with >>&g

Re: [libvirt] Question about the host-model CPU mode

2017-10-20 Thread Christian Borntraeger
On 10/20/2017 03:51 PM, David Hildenbrand wrote: [...] >> The problem goes much further. >> A fresh guest with >> >> >> hvm >> >> >> >> does not start. No migration from an older system is necessary. >> > > Yes, as stated in the documentation "copying host CPU definition from

[libvirt] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

2017-10-20 Thread Christian Borntraeger
nes <= 2.9 lets allow it for all machine types that support the CPU model. This will make "host-model" runnable all the time, while relying on the CPU model to reject invalid migration attempts. Suggested-by: David Hildenbrand <da...@redhat.com> Signed-off-by: Christian Borntraeg

Re: [libvirt] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

2017-10-20 Thread Christian Borntraeger
binary that can emulate an x86 and an s390x depending on the machine type. Should libvirt be able to detect that -cpu pentium only makes sense for the q35 machines, but not for the s390-ccw-virtio ones? On 10/20/2017 04:54 PM, Christian Borntraeger wrote: > Starting a guest with > >

Re: [libvirt] [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

2017-10-27 Thread Christian Borntraeger
On 10/27/2017 02:31 PM, Halil Pasic wrote: > > > On 10/25/2017 08:13 PM, Jason J. Herne wrote: >> On 10/20/2017 10:54 AM, Christian Borntraeger wrote: >>> Starting a guest with >>>     >>> hvm >>>    >>>    >>> &

Re: [libvirt] [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

2017-10-27 Thread Christian Borntraeger
On 10/27/2017 02:31 PM, Halil Pasic wrote: gs is explicitly disabled. > > Now that I think about it, maybe the 2.9 binary is going to reject > the explicit gs flag altogether, because it's unknown. > > Isn't this a problem? No. This is exactly the _solution_ and not the problem. The target

Re: [libvirt] [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

2017-10-27 Thread Christian Borntraeger
On 10/27/2017 02:45 PM, Christian Borntraeger wrote: > > > On 10/27/2017 02:31 PM, Halil Pasic wrote: > gs is explicitly disabled. >> >> Now that I think about it, maybe the 2.9 binary is going to reject >> the explicit gs flag altogether, because it's unkno

Re: [libvirt] [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

2017-10-27 Thread Christian Borntraeger
On 10/27/2017 03:40 PM, Halil Pasic wrote: > > > On 10/27/2017 02:57 PM, Christian Borntraeger wrote: >> >> >> On 10/27/2017 02:45 PM, Christian Borntraeger wrote: >>> >>> >>> On 10/27/2017 02:31 PM, Halil Pasic wrote: >>> gs is

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Christian Borntraeger
On 06/15/2018 04:21 PM, Kevin Wolf wrote: > The -drive option serial was deprecated in QEMU 2.10. It's time to > remove it. > > Tests need to be updated to set the serial number with -global instead > of using the -drive option. libvirt 4.5 still creates those (at least on s390x)

Re: [libvirt] [PATCH for-3.1] s390x: remove 's390-squash-mcss' option

2018-07-24 Thread Christian Borntraeger
Acked-by: Christian Borntraeger On 07/24/2018 11:24 AM, Cornelia Huck wrote: > This option has been deprecated for two releases; remove it. > > Signed-off-by: Cornelia Huck > --- > hw/s390x/3270-ccw.c| 2 +- > hw/s390x/css-bridge.c | 1 -

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-04 Thread Christian Borntraeger
On 07/04/2018 03:34 PM, Kevin Wolf wrote: > Am 04.07.2018 um 15:02 hat Cornelia Huck geschrieben: >> On Tue, 3 Jul 2018 13:32:29 +0200 >> Kevin Wolf wrote: >> >> Has serial/gemoetry been fixed meanwhile and will it make it into the >> next release? > > I cannot find an

[libvirt] request a revert for "block: Remove deprecated -drive option serial" (was block: Remove deprecated -drive option serial)

2018-06-22 Thread Christian Borntraeger
adding more CC. On 06/22/2018 01:38 PM, Christian Borntraeger wrote: > > On 06/15/2018 04:21 PM, Kevin Wolf wrote: >> The -drive option serial was deprecated in QEMU 2.10. It's time to >> remove it. >> >> Tests need to be updated to set the serial number wi

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Christian Borntraeger
On 06/22/2018 03:36 PM, Christian Borntraeger wrote: > > > On 06/22/2018 02:55 PM, Kevin Wolf wrote: >> Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: >>> >>> On 06/15/2018 04:21 PM, Kevin Wolf wrote: >>>> The -drive option

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Christian Borntraeger
On 06/22/2018 02:55 PM, Kevin Wolf wrote: > Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: >> >> On 06/15/2018 04:21 PM, Kevin Wolf wrote: >>> The -drive option serial was deprecated in QEMU 2.10. It's time to >>> remove it. >>> >

Re: [libvirt] [RFC PATCH 0/3] qemu: guest dedicated crypto adapters

2018-10-12 Thread Christian Borntraeger
FWIW, the qemu patches are now in master. https://git.qemu.org/?p=qemu.git;a=commit;h=69ac8c4cb93f2685839ff7b857cef306b388ff3c On 10/08/2018 06:25 PM, Boris Fiuczynski wrote: > This RFC patch series introduces initial libvirt support for guest > dedicated crypto adapters on S390. > It

Re: [libvirt] [PATCH v6 00/13] PCI passthrough support on s390

2018-10-15 Thread Christian Borntraeger
On 10/15/2018 09:30 AM, Boris Fiuczynski wrote: > On 10/14/18 2:47 PM, Andrea Bolognani wrote: >> On Fri, 2018-10-12 at 16:04 +0100, Daniel P. Berrangé wrote: >>> On Fri, Sep 28, 2018 at 04:46:13PM +0800, Yi Min Zhao wrote: >> [...]      

Re: [libvirt] [PATCH v6 09/13] conf: Allocate/release 'uid' and 'fid' in PCI address

2018-10-18 Thread Christian Borntraeger
On 10/18/2018 05:44 PM, Andrea Bolognani wrote: > On Thu, 2018-10-18 at 15:13 +0800, Yi Min Zhao wrote: >> 在 2018/10/17 下午10:30, Andrea Bolognani 写道: >>> On Tue, 2018-10-16 at 11:28 +0800, Yi Min Zhao wrote: I think this would make things complex. If either PCI address or zPCI address

Re: [libvirt] [PATCH 00/11] Allow modification of IOThread polling values (redux)

2018-10-15 Thread Christian Borntraeger
On 10/15/2018 04:28 PM, John Ferlan wrote: > > ping? > > Any takers or thoughts? No review, but I think it makes a lot of sense to expose these tuneables. > > Tks, > > John > > > On 10/7/18 9:00 AM, John Ferlan wrote: >> This series attempts to resurrect the concept of being able to modify

Re: [libvirt] [Qemu-devel] [PATCH 3/3] cirrus: mark as deprecated

2018-10-26 Thread Christian Borntraeger
On 10/26/2018 11:42 AM, Daniel P. Berrangé wrote: > On Fri, Oct 26, 2018 at 12:33:55PM +0530, P J P wrote: >> Hello Dan, all >> >> +-- On Thu, 25 Oct 2018, Daniel P. Berrangé wrote --+ >> | On Thu, Oct 25, 2018 at 10:52:56AM +0200, Gerd Hoffmann wrote: >> | > While being at it deprecate cirrus

Re: [libvirt] [REPOST PATCH v2 00/12] Allow modification of IOThread polling values (redux)

2018-11-05 Thread Christian Borntraeger
> qemu: Alter qemuDomainChgIOThread to take qemuMonitorIOThreadInfo > qemu: Detect whether iothread polling is supported > qemu: Introduce qemuDomainSetIOThreadParams > tools: Add virsh iothreadset command > docs: Add news article for IOThread polling For the fea

Re: [libvirt] [PATCH 0/4] qemu: Use host-model CPU on s390 by default

2019-11-15 Thread Christian Borntraeger
On 15.11.19 15:47, Jiri Denemark wrote: > On Fri, Nov 15, 2019 at 15:12:18 +0100, Boris Fiuczynski wrote: >> Just a heads up. >> After installing libvirt rpms of this branch all my existing kvm s390 >> domains ended up with >> >> >> qemu >> >> >> Newly defined domains without

Re: [libvirt] s390: change default cpu model to host-model?

2019-11-08 Thread Christian Borntraeger
On 08.11.19 12:43, Daniel P. Berrangé wrote: > On Mon, Nov 04, 2019 at 11:49:01AM +0100, David Hildenbrand wrote: >> On 02.11.19 11:32, Daniel P. Berrangé wrote: >>> On Fri, Nov 01, 2019 at 06:43:16PM +0100, Christian Borntraeger wrote: >>>> On the KVM forum I

Re: [libvirt] s390: change default cpu model to host-model?

2019-11-08 Thread Christian Borntraeger
On 08.11.19 12:52, Daniel P. Berrangé wrote: > On Fri, Nov 08, 2019 at 12:49:23PM +0100, Christian Borntraeger wrote: >> >> >> On 08.11.19 12:43, Daniel P. Berrangé wrote: >>> On Mon, Nov 04, 2019 at 11:49:01AM +0100, David Hildenbrand wrote: >>>> O

Re: [libvirt] s390: change default cpu model to host-model?

2019-11-08 Thread Christian Borntraeger
On 08.11.19 14:10, Daniel P. Berrangé wrote: > On Fri, Nov 08, 2019 at 01:56:47PM +0100, Christian Borntraeger wrote: >> >> >> On 08.11.19 12:52, Daniel P. Berrangé wrote: >>> On Fri, Nov 08, 2019 at 12:49:23PM +0100, Christian Borntraeger wrote: >>>

Re: [libvirt] [PATCH v3 00/52] qemu: Store default CPU in domain XML

2019-11-08 Thread Christian Borntraeger
As discussed, does it make sense to add the default change to host-model for s390 in this series or should that be a separate patch? On 05.11.19 14:26, Jiri Denemark wrote: > When starting a domain without a CPU model specified in the domain XML, > QEMU will choose a default one. Which is fine

[libvirt] s390: change default cpu model to host-model?

2019-11-01 Thread Christian Borntraeger
On the KVM forum I have discussed the default cpu model mode on s390. Right now if the xml does not specify anything, libvirt defaults to not specifying anything on the qemu command line (no -cpu statement) which is the equivalent of -cpu host for s390 which is equivalent to host-passthrough.

Re: [libvirt] s390: change default cpu model to host-model?

2019-11-04 Thread Christian Borntraeger
On 04.11.19 11:49, David Hildenbrand wrote: > On 02.11.19 11:32, Daniel P. Berrangé wrote: >> On Fri, Nov 01, 2019 at 06:43:16PM +0100, Christian Borntraeger wrote: >>> On the KVM forum I have discussed the default cpu model mode on s390. >>> Right now if the xm

[libvirt] libvirt? qemu change that mmaps ELF files breaks libvirt svirt handling for os.kernel

2019-10-04 Thread Christian Borntraeger
Stefano, Paolo, I have an interesting fail in QEMU 2019-10-04T12:00:32.675188Z qemu-system-s390x: GLib: g_mapped_file_unref: assertion 'file != NULL' failed that bisected to commit 816b9fe450220e19acb91a0ce4a8ade7000648d1 (refs/bisect/bad) elf-ops.h: Map into memory the ELF to load

Re: [libvirt] libvirt? qemu change that mmaps ELF files breaks libvirt svirt handling for os.kernel

2019-10-04 Thread Christian Borntraeger
On 04.10.19 14:13, Paolo Bonzini wrote: > On 04/10/19 14:03, Christian Borntraeger wrote: >> Stefano, Paolo, >> >> I have an interesting fail in QEMU >> >> 2019-10-04T12:00:32.675188Z qemu-system-s390x: GLib: g_mapped_file_unref: >> assertion

Re: [libvirt] libvirt? qemu change that mmaps ELF files breaks libvirt svirt handling for os.kernel

2019-10-04 Thread Christian Borntraeger
On 04.10.19 14:36, Daniel P. Berrangé wrote: > On Fri, Oct 04, 2019 at 02:18:49PM +0200, Christian Borntraeger wrote: >> >> >> On 04.10.19 14:13, Paolo Bonzini wrote: >>> On 04/10/19 14:03, Christian Borntraeger wrote: >>>> Stefano, Paolo, &g

Re: [PATCH] qemu: capabilities: update qemu-4.2 capabilities for s390x

2020-03-25 Thread Christian Borntraeger
ND z14 to be available. to the patch description? The cpu features changes look sane to me. Acked-by: Christian Borntraeger > This picks up the new blockdev capability, so we need to refresh a bunch > of test cases as well. > > Reviewed-by: Boris Fiuczynski > Signed-off-by: Bjoern

Re: [PATCH] docs: Describe protected virtualization guest setup

2020-04-29 Thread Christian Borntraeger
On 29.04.20 15:25, Daniel P. Berrangé wrote: > On Wed, Apr 29, 2020 at 10:19:20AM -0300, Daniel Henrique Barboza wrote: >> >> >> On 4/28/20 12:58 PM, Boris Fiuczynski wrote: >>> From: Viktor Mihajlovski >>> >> >> [...] >>> + >>> +If the check fails despite the host system actually supporting

Re: [PATCH] docs: Describe protected virtualization guest setup

2020-04-29 Thread Christian Borntraeger
On 29.04.20 16:09, Christian Borntraeger wrote: > > > On 29.04.20 15:25, Daniel P. Berrangé wrote: >> On Wed, Apr 29, 2020 at 10:19:20AM -0300, Daniel Henrique Barboza wrote: >>> >>> >>> On 4/28/20 12:58 PM, Boris Fiucz

Re: [libvirt PATCH 5/6] hostcpu: Implement virHostCPUGetSignature for s390

2020-05-20 Thread Christian Borntraeger
On 20.05.20 14:20, Boris Fiuczynski wrote: > On 5/18/20 2:56 PM, Jiri Denemark wrote: >> Signed-off-by: Jiri Denemark >> --- >>   src/util/virhostcpu.c    | 16 +++- >>   .../linux-s390x-with-frequency.signature |  1 + >>   2 files changed, 16

Re: [PATCH] qemu: validate: Allow 'preserve' action for on_crash lifecycle action

2021-09-15 Thread Christian Borntraeger
Reported-by: Christian Borntraeger Acked-by: Christian Borntraeger Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 1 + src/qemu/qemu_validate.c | 5 ++--- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index

Re: [PATCH 07/22] qemu: Reject 'preserve' action for 'on_reboot'/'on_poweroff'/'on_crash'

2021-09-15 Thread Christian Borntraeger
On 24.08.21 16:44, Peter Krempa wrote: The qemu driver didn't ever implement any meaningful handling for the 'preserve' action. Forbid the flag in the qemu def validator and update the documentation to be factual. Signed-off-by: Peter Krempa NACK. It is a perfectly sane usecase to have

Re: [PATCH 07/22] qemu: Reject 'preserve' action for 'on_reboot'/'on_poweroff'/'on_crash'

2021-09-15 Thread Christian Borntraeger
On 15.09.21 11:45, Christian Borntraeger wrote: On 24.08.21 16:44, Peter Krempa wrote: The qemu driver didn't ever implement any meaningful handling for the 'preserve' action. Forbid the flag in the qemu def validator and update the documentation to be factual. Signed-off-by: Peter Krempa

Re: [PATCH RFC 0/1] s390x CPU Model Feature Deprecation

2022-03-11 Thread Christian Borntraeger
Am 11.03.22 um 10:30 schrieb David Hildenbrand: On 11.03.22 05:17, Collin Walling wrote: The s390x architecture has a growing list of features that will no longer be supported on future hardware releases. This introduces an issue with migration such that guests, running on models with these

Re: [PATCH RFC 1/1] qemu: capabilities: disable csske for host cpu

2022-03-11 Thread Christian Borntraeger
Am 11.03.22 um 13:27 schrieb David Hildenbrand: On 11.03.22 13:12, Christian Borntraeger wrote: Am 11.03.22 um 10:23 schrieb David Hildenbrand: On 11.03.22 10:17, Daniel P. Berrangé wrote: On Thu, Mar 10, 2022 at 11:17:38PM -0500, Collin Walling wrote: CPU models past gen16a will no longer

Re: [PATCH RFC 1/1] qemu: capabilities: disable csske for host cpu

2022-03-11 Thread Christian Borntraeger
Am 11.03.22 um 10:23 schrieb David Hildenbrand: On 11.03.22 10:17, Daniel P. Berrangé wrote: On Thu, Mar 10, 2022 at 11:17:38PM -0500, Collin Walling wrote: CPU models past gen16a will no longer support the csske feature. In order to secure migration of guests running on machines that still

Re: [PATCH RFC 1/1] qemu: capabilities: disable csske for host cpu

2022-03-11 Thread Christian Borntraeger
Am 11.03.22 um 14:08 schrieb Daniel P. Berrangé: On Fri, Mar 11, 2022 at 12:37:46PM +, Daniel P. Berrangé wrote: On Fri, Mar 11, 2022 at 01:12:35PM +0100, Christian Borntraeger wrote: Am 11.03.22 um 10:23 schrieb David Hildenbrand: On 11.03.22 10:17, Daniel P. Berrangé wrote: On Thu

Re: [PATCH RFC 1/1] qemu: capabilities: disable csske for host cpu

2022-03-11 Thread Christian Borntraeger
Am 11.03.22 um 15:56 schrieb Daniel P. Berrangé: On Fri, Mar 11, 2022 at 03:52:57PM +0100, Christian Borntraeger wrote: Am 11.03.22 um 14:08 schrieb Daniel P. Berrangé: On Fri, Mar 11, 2022 at 12:37:46PM +, Daniel P. Berrangé wrote: On Fri, Mar 11, 2022 at 01:12:35PM +0100, Christian

Re: [PATCH RFC 1/1] qemu: capabilities: disable csske for host cpu

2022-03-11 Thread Christian Borntraeger
Am 11.03.22 um 16:24 schrieb Christian Borntraeger: Am 11.03.22 um 15:56 schrieb Daniel P. Berrangé: On Fri, Mar 11, 2022 at 03:52:57PM +0100, Christian Borntraeger wrote: Am 11.03.22 um 14:08 schrieb Daniel P. Berrangé: On Fri, Mar 11, 2022 at 12:37:46PM +, Daniel P. Berrangé