Re: [libvirt] [PATCH] rpc: fixing compilation error due to deprecated ssh_get_publickey().

2018-05-04 Thread Daniel P . Berrangé
On Fri, May 04, 2018 at 12:53:14PM -0400, John Ferlan wrote: > > > On 05/01/2018 12:21 PM, Julio Faracco wrote: > > After 0.7.5 release, libssh deprecated ssh_get_publickey() method to > > introduce ssh_get_server_publickey(). This commit check the current > > version of libssh and use the

Re: [libvirt] [PATCH 3/7] po: fix typo: remove a redundant Chinese character

2018-05-04 Thread Daniel P . Berrangé
On Fri, May 04, 2018 at 12:07:39PM +0200, Peter Krempa wrote: > On Fri, May 04, 2018 at 17:28:50 +0800, Lin Ma wrote: > > Signed-off-by: Lin Ma > > --- > > NACK > > This needs to be fixed in Zanata where we pull the translations from > since it would be overwritten by the next

Re: [libvirt] [sandbox PATCH] maint: Drop autobuild.sh

2018-05-04 Thread Daniel P . Berrangé
On Thu, May 03, 2018 at 06:28:13PM +0200, Andrea Bolognani wrote: > On Thu, 2018-05-03 at 16:59 +0100, Daniel P. Berrangé wrote: > > On Thu, May 03, 2018 at 05:58:07PM +0200, Andrea Bolognani wrote: > > > Renaming the scripts sounds good to me. Just come up with > > > a

Re: [libvirt] [jenkins-ci PATCH] projects: Run libvirt's 'make check' on all machines

2018-05-04 Thread Daniel P . Berrangé
bolo...@redhat.com> > --- > projects/libvirt.yaml | 7 --- > 1 file changed, 7 deletions(-) Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-

Re: [libvirt] Expose vfio device display/migration to libvirt and above, was Re: [PATCH 0/3] sample: vfio mdev display devices.

2018-05-04 Thread Daniel P . Berrangé
On Thu, May 03, 2018 at 12:58:00PM -0600, Alex Williamson wrote: > Hi, > > The previous discussion hasn't produced results, so let's start over. > Here's the situation: > > - We currently have kernel and QEMU support for the QEMU vfio-pci >display option. > > - The default for this option

Re: [libvirt] [PATCH] travis: Uninstall packages before upgrade

2018-05-14 Thread Daniel P . Berrangé
script: > # We can't run make distcheck/syntax-check because they > # fail on macOS, but doing 'install' and 'dist' gives us Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/

[libvirt] [PATCH] log: actually do substring matches with fnmatch

2018-05-14 Thread Daniel P . Berrangé
lly make that happen. This fixes it to prepend and append "*" if not already present in the user's pattern. Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- src/util/virlog.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/uti

Re: [libvirt] [PATCH] libxl: don't set hasManagedSave when performing save

2018-05-15 Thread Daniel P . Berrangé
d change callers to use it. > > Signed-off-by: Jim Fehlig <jfeh...@suse.com> > --- > src/libxl/libxl_driver.c | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https:

Re: [libvirt] Question about verifying same uid:gid in src and dst for live migration

2018-05-09 Thread Daniel P . Berrangé
On Wed, May 09, 2018 at 01:45:53PM +0800, Fei Li wrote: > Hi, > > When I do live migration using virsh command line based on NFS shared > storage between two systems > having the same security mechanism and having the same kvm/qemu/libvirt > version, I encounter the > following error: > > debug

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-09 Thread Daniel P . Berrangé
On Wed, May 09, 2018 at 10:38:59AM +0200, Peter Krempa wrote: > On Wed, May 09, 2018 at 08:51:01 +0100, Daniel Berrange wrote: > > On Wed, May 09, 2018 at 09:14:29AM +0300, David Kiarie wrote: > > > > > > This is okay but this definitely wrong. And it does indeed sound wrong. > > > And > > > it

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-09 Thread Daniel P . Berrangé
On Wed, May 09, 2018 at 01:36:35PM +0300, David Kiarie wrote: > On Wed, May 9, 2018 at 1:18 PM, David Kiarie <davidkiar...@gmail.com> wrote: > > > > > > > On Wed, May 9, 2018 at 1:15 PM, David Kiarie <davidkiar...@gmail.com> > > wrote: > > > >

Re: [libvirt] [PATCH] Add a MAINTAINERS file to suggest reviewers for patches

2018-05-09 Thread Daniel P . Berrangé
On Wed, May 09, 2018 at 10:46:19AM +0200, Jiri Denemark wrote: > On Tue, May 08, 2018 at 14:07:31 +0100, Daniel P. Berrangé wrote: > > Currently all patches are simply sent to the main libvirt development > > mailing list. Sometimes individual developers are also CC'd but this i

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-09 Thread Daniel P . Berrangé
On Wed, May 09, 2018 at 09:14:29AM +0300, David Kiarie wrote: > > This is okay but this definitely wrong. And it does indeed sound wrong. And > it will always sound wrong. > > Being involved in a GSoC project is not about contributions. And also > considering the scale of our project(some of the

Re: [libvirt] [PATCH 02/12] Introduce new domain create API virDomainCreateWithParams

2018-05-09 Thread Daniel P . Berrangé
On Wed, May 09, 2018 at 04:56:12PM +0200, Marc Hartmayer wrote: > Introduce new libvirt API virDomainCreateWithParams that allows to > temporarily boot from another boot device, to use another kernel, > initrd, and cmdline than defined in the persistent domain > definition. All typed parameters

Re: [libvirt] [jenkins-ci PATCH] Build libosinfo and osinfo-db-tools on mingw platform

2018-05-09 Thread Daniel P . Berrangé
On Wed, May 09, 2018 at 01:34:53PM +0200, Andrea Bolognani wrote: > On Tue, 2018-05-08 at 14:37 +0100, Daniel P. Berrangé wrote: > > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> > > --- > > guests/host_vars/libvirt-fedora-rawhide/main.yml | 2 ++ &g

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-09 Thread Daniel P . Berrangé
On Wed, May 09, 2018 at 01:47:26PM +0300, David Kiarie wrote: > On Wed, May 9, 2018 at 1:43 PM, Daniel P. Berrangé <berra...@redhat.com> > wrote: > > > On Wed, May 09, 2018 at 01:36:35PM +0300, David Kiarie wrote: > > > On Wed, May 9, 2018 at 1:18 PM, David

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-09 Thread Daniel P . Berrangé
On Wed, May 09, 2018 at 02:05:54PM +0300, David Kiarie wrote: > On Wed, May 9, 2018 at 2:01 PM, Daniel P. Berrangé <berra...@redhat.com> > wrote: > > > On Wed, May 09, 2018 at 01:47:26PM +0300, David Kiarie wrote: > > > On Wed, May 9, 2018 at 1:43 PM, Daniel P.

Re: [libvirt] [RFC PATCH 4/4] qemu: migration: Forbid 'nbd' migration of non-shared storage if TLS is requested

2018-04-27 Thread Daniel P . Berrangé
n if non-shared storage is > requested but the security implications are more severe. > > Signed-off-by: Peter Krempa <pkre...@redhat.com> > --- > src/qemu/qemu_migration.c | 9 + > 1 file changed, 9 insertions(+) Reviewed-by: Daniel P. Berrangé <berra...

Re: [libvirt] [PATCH 2/2] qemu: migration: Set the 'set' boolean in qemuMigrationParamsSetString

2018-04-27 Thread Daniel P . Berrangé
...@redhat.com> > --- > src/qemu/qemu_migration_params.c | 11 +++ > 1 file changed, 11 insertions(+) Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-

Re: [libvirt] [PATCH v2 1/4] Revert "util: virlog: Introduce wildcard to log filters"

2018-04-27 Thread Daniel P . Berrangé
On Fri, Apr 27, 2018 at 09:38:06AM -0400, John Ferlan wrote: > > > On 04/23/2018 08:28 AM, Daniel P. Berrangé wrote: > > This reverts commit 8daa593b0741452a78daea76075254ae7d3c6ab6. > > > > There are two undesirable aspects to the impl > > > >

[libvirt] [PATCH 02/14] nwfilter: remove methods that are trivial wrappers for virHash APIs

2018-04-27 Thread Daniel P . Berrangé
if it does not currently exist. Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- src/conf/domain_conf.c | 6 ++-- src/conf/nwfilter_conf.c | 2 +- src/conf/nwfilter_ipaddrmap.c | 7 ++-- src/conf/nwfilter_params.c

[libvirt] [PATCH 12/14] nwfilter: report an error if nic needs filtering by no driver is present

2018-04-27 Thread Daniel P . Berrangé
and fix it. Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- src/conf/domain_nwfilter.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_nwfilter.c b/src/conf/domain_nwfilter.c index e360aceeba..7570e0ae83 100644 --- a/sr

[libvirt] [PATCH 11/14] nwfilter: convert DHCP address snooping code to virNWFilterBinding

2018-04-27 Thread Daniel P . Berrangé
Use the virNWFilterBinding struct in the DHCP address snooping code directly. Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- src/nwfilter/nwfilter_dhcpsnoop.c | 150 + src/nwfilter/nwfilter_dhcpsnoop.h | 7 +- src/nw

[libvirt] [PATCH 09/14] nwfilter: convert the gentech driver code to use virNWFilterBinding

2018-04-27 Thread Daniel P . Berrangé
Use the virNWFilterBinding struct in the gentech driver code directly. Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- src/nwfilter/nwfilter_dhcpsnoop.c | 35 +++--- src/nwfilter/nwfilter_driver.c | 21 +++- src/nwfilter/nwfilter_gentech_driver.c

[libvirt] [PATCH 10/14] nwfilter: convert IP address learning code to virNWFilterBinding

2018-04-27 Thread Daniel P . Berrangé
Use the virNWFilterBinding struct i nthe IP address learning code directly. Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- src/nwfilter/nwfilter_gentech_driver.c | 7 +-- src/nwfilter/nwfilter_learnipaddr.c| 98 ++ src/nw

Re: [libvirt] [PATCH 1/4] tests: Fix virnetsockettest on FreeBSD

2018-04-27 Thread Daniel P . Berrangé
On Fri, Apr 27, 2018 at 05:21:20PM +0200, Andrea Bolognani wrote: > FreeBSD doesn't let IPv4 clients to connect to IPv6 sockets, > so one of our test cases has to be compiled out there. Yep, IPV6_V6ONLY is set to true by default, where as it is false by default on Linux, however, . > >

[libvirt] [PATCH 04/14] nwfilter: make virNWFilterIPAddrLearnReq type private

2018-04-27 Thread Daniel P . Berrangé
The virNWFilterIPAddrLearnReq type should only be used by the IP address learning code, so can live in the implementation file instead of header file. Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- src/nwfilter/nwfilter_gentech_driver.c | 8 src/nw

[libvirt] [PATCH 08/14] nwfilter: pass vm name in when instantiating filters

2018-04-27 Thread Daniel P . Berrangé
The vm name is not needed for any functional requirement, but it will be useful when debugging problems to identify which VM is associated with a filter, since UUID is not human friendly. Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- src/conf/domain_nwfilter.c | 5 +++-

Re: [libvirt] [PATCH 2/4] tests: Fix qemumemlocktest on FreeBSD

2018-04-27 Thread Daniel P . Berrangé
On Fri, Apr 27, 2018 at 05:21:21PM +0200, Andrea Bolognani wrote: > When hostdevs are involved, libvirt needs to poke into sysfs to > collect some information about them; since that pseudo-filesystem > doesn't exist on platforms other than Linux, the corresponding > tests would fail and need to be

[libvirt] [PATCH 07/14] nwfilter: introduce virNWFilterBinding to decouple from virDomainNet

2018-04-27 Thread Daniel P . Berrangé
. Thus the virNWFilterBinding struct is created to track this information. Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- src/conf/nwfilter_conf.c | 53 +++- src/conf/nwfilter_conf.h | 18 +++- src/libvirt_private.syms | 2

[libvirt] [PATCH 00/14] nwfilter: refactor the driver to make it independent of virt drivers

2018-04-27 Thread Daniel P . Berrangé
the last patch should be ok to merge though. Daniel P. Berrangé (14): nwfilter: remove pointless virNWFilterHashTable struct nwfilter: remove methods that are trivial wrappers for virHash APIs nwfilter: remove virNWFilterHashTable typedefs entirely nwfilter: make virNWFilterIPAddrLearnReq

[libvirt] [PATCH 01/14] nwfilter: remove pointless virNWFilterHashTable struct

2018-04-27 Thread Daniel P . Berrangé
liases virHashTable. Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- src/conf/nwfilter_ipaddrmap.c | 6 ++--- src/conf/nwfilter_params.c | 49 +++--- src/conf/nwfilter_params.h | 8 ++ src/nwfilter/nwfilter_dhcpsnoop

[libvirt] [PATCH WIP 14/14] nwfilter: remove virt driver callback layer for rebuilding filters

2018-04-27 Thread Daniel P . Berrangé
objects, as they're never touched. Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- src/conf/nwfilter_conf.c | 169 ++--- src/conf/nwfilter_conf.h | 51 +- src/conf/virnwfilterobj.c | 4 +

[libvirt] [PATCH 03/14] nwfilter: remove virNWFilterHashTable typedefs entirely

2018-04-27 Thread Daniel P . Berrangé
All the code now just uses the virHashTablePtr type directly. Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- src/conf/domain_conf.c | 2 +- src/conf/domain_conf.h | 2 +- src/conf/nwfilter_conf.h | 2 +- src/conf/nwfilter_ipadd

[libvirt] [PATCH 06/14] nwfilter: fix leaking of filter parameters upon error

2018-04-27 Thread Daniel P . Berrangé
The filter parameters were not correctly free'd when an error hits while adding to the hash table. Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- src/nwfilter/nwfilter_gentech_driver.c | 22 ++ src/nwfilter/nwfilter_gentech_driver.h | 2 +- 2 files chan

[libvirt] [PATCH 05/14] nwfilter: remove obsolete code related to firewalld

2018-04-27 Thread Daniel P . Berrangé
There is a bunch of left over code in the nwfilter driver related to monitoring firewalld over dbus, that is no longer used since the conversion to use virFirewall APIs. Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- src/conf/virnwfilterobj.h | 1 - src/nw

[libvirt] [PATCH 13/14] nwfilter: keep track of active filter bindings

2018-04-27 Thread Daniel P . Berrangé
has a record of all active filters. Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- src/conf/virnwfilterobj.h | 3 +++ src/nwfilter/nwfilter_driver.c | 57 +- 2 files changed, 48 insertions(+), 12 deletions(-) diff --git a/sr

Re: [libvirt] [jenkins-ci PATCH] projects: Drop explicit --enable-gtk-doc

2018-05-10 Thread Daniel P . Berrangé
jobs: >- autotools-build-job: >parent_jobs: 'libvirt-glib-master-build' > - autogen_args: --enable-gtk-doc >- autotools-syntax-check-job: > parent_jobs: 'libvirt-sandbox-master-build' >- autotools-check-job: Reviewed-by: Daniel P. Berrangé &

Re: [libvirt] [go-xml PATCH] test: Clone libvirt.git via https:// instead of git://

2018-05-10 Thread Daniel P . Berrangé
olognani <abolo...@redhat.com> > --- > xml_test.go | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libv

Re: [libvirt] [jenkins-ci PATCH] projects: Reduce scope for local_env

2018-05-10 Thread Daniel P . Berrangé
olognani <abolo...@redhat.com> > --- > projects/libvirt-go-xml.yaml | 4 ++-- > projects/libvirt-go.yaml | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-

Re: [libvirt] [PATCH v2 3/4] log: support logging using shell wildcard syntax

2018-05-11 Thread Daniel P . Berrangé
On Mon, Apr 30, 2018 at 11:05:48AM -0400, John Ferlan wrote: > > > On 04/23/2018 08:28 AM, Daniel P. Berrangé wrote: > > Rather than specialcasing handling of the '*' character, use fnmatch() > > to get normal shell wildcard syntax, as described in 'man glob(7)'. > >

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-08 Thread Daniel P . Berrangé
On Mon, May 07, 2018 at 05:55:51PM +0300, David Kiarie wrote: > On Mon, May 7, 2018 at 10:29 AM, Peter Krempa wrote: > > > On Sat, May 05, 2018 at 12:17:05 +0300, David Kiarie wrote: > > > On Sat, May 5, 2018 at 12:15 PM, David Kiarie > > > wrote: > >

Re: [libvirt] [PATCH] xenconfig: remove my name and email from files

2018-05-08 Thread Daniel P . Berrangé
> diff --git a/tests/xlconfigtest.c b/tests/xlconfigtest.c > index 39f51e2d..36f7699f 100644 > --- a/tests/xlconfigtest.c > +++ b/tests/xlconfigtest.c > @@ -19,7 +19,6 @@ > * <http://www.gnu.org/licenses/>. > * > * Author: Daniel P. Berrange <berra...@redhat.com

Re: [libvirt] [PATCH] qemu: add sdl opengl support

2018-05-08 Thread Daniel P . Berrangé
On Tue, May 08, 2018 at 12:12:42PM +0100, Maciej Wolny wrote: > On 02/05/18 11:54, Daniel P. Berrangé wrote: > > On Wed, May 02, 2018 at 11:48:24AM +0100, Maciej Wolny wrote: > >> On 02/05/18 08:13, Daniel P. Berrangé wrote: > >>> On Tue, May 01, 2018 at 08:22:

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

2018-05-08 Thread Daniel P . Berrangé
On Tue, May 08, 2018 at 03:42:27PM +0300, David Kiarie wrote: > On Tue, May 8, 2018 at 2:21 PM, Daniel P. Berrangé <berra...@redhat.com> > wrote: > > > On Mon, May 07, 2018 at 05:55:51PM +0300, David Kiarie wrote: > > > On Mon, May 7, 2018 at 10:29 AM, Peter Krempa

[libvirt] [PATCH] Add a MAINTAINERS file to suggest reviewers for patches

2018-05-08 Thread Daniel P . Berrangé
2211c6 | \ ./build-aux/get_maintainer.pl Jiri Denemar <jdene...@redhat.com> (maintainer:CPU modelling) libvir-list@redhat.com (open list:All patches) Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- .gitpublish |1 + MAINTAINERS |

Re: [libvirt] [PATCH 0/3] spec: drop deprecated el5 bits

2018-05-08 Thread Daniel P . Berrangé
ove BuildRoot definition > spec: Remove %clean section > > libvirt.spec.in | 45 - > 1 file changed, 45 deletions(-) For all threee Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com

Re: [libvirt] [jenkins-ci PATCH] projects: Run libvirt's 'make check' on all machines

2018-05-08 Thread Daniel P . Berrangé
On Thu, May 03, 2018 at 06:25:19PM +0200, Andrea Bolognani wrote: > Up until now, we had to skip it on FreeBSD due to some > portability issues in the test suite, but as of libvirt > commit 0b86e23d2569 they've all been fixed. Unfortunately it appears that gnulib has a non-deterministic failure

[libvirt] [jenkins-ci PATCH] Build libosinfo and osinfo-db-tools on mingw platform

2018-05-08 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- guests/host_vars/libvirt-fedora-rawhide/main.yml | 2 ++ guests/vars/mappings.yml | 6 ++ guests/vars/projects/libosinfo+mingw.yml | 8 guests/vars/projects/osinfo-db-tools+mingw.yml

Re: [libvirt] [perl PATCH] spec: Drop %{extra_release}

2018-05-04 Thread Daniel P . Berrangé
prepare-release.sh| 4 +--- > 2 files changed, 2 insertions(+), 4 deletions(-) Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-

Re: [libvirt] [perl PATCH v2 2/3] prepare-release: Drop references to Test::AutoBuild

2018-05-04 Thread Daniel P . Berrangé
On Fri, May 04, 2018 at 03:14:04PM +0200, Andrea Bolognani wrote: > On Fri, 2018-05-04 at 13:38 +0100, Daniel P. Berrangé wrote: > > On Fri, May 04, 2018 at 02:20:25PM +0200, Andrea Bolognani wrote: > [...] > > > if [ -f /usr/bin/rpmbuild ]; then > > >

Re: [libvirt] [perl PATCH v2 2/3] prepare-release: Drop references to Test::AutoBuild

2018-05-04 Thread Daniel P . Berrangé
On Fri, May 04, 2018 at 03:37:50PM +0200, Andrea Bolognani wrote: > On Fri, 2018-05-04 at 14:20 +0100, Daniel P. Berrangé wrote: > > On Fri, May 04, 2018 at 03:14:04PM +0200, Andrea Bolognani wrote: > > > On Fri, 2018-05-04 at 13:38 +0100, Daniel P. Berrangé wrote: > >

Re: [libvirt] [perl PATCH v2 2/3] prepare-release: Drop references to Test::AutoBuild

2018-05-04 Thread Daniel P . Berrangé
On Fri, May 04, 2018 at 02:20:25PM +0200, Andrea Bolognani wrote: > They are no longer relevant and misleading. > > Signed-off-by: Andrea Bolognani > --- > prepare-release.sh | 14 +++--- > 1 file changed, 3 insertions(+), 11 deletions(-) > > diff --git

Re: [libvirt] [perl PATCH v2 3/3] prepare-release: Drop references to Debian packages

2018-05-04 Thread Daniel P . Berrangé
d, 8 deletions(-) Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-ht

Re: [libvirt] [perl PATCH v2 1/3] maint: Rename autobuild.sh to prepare-release.sh

2018-05-04 Thread Daniel P . Berrangé
pose is more clearly communicated instead. > > [1] https://ci.centos.org/view/libvirt/ > > Signed-off-by: Andrea Bolognani <abolo...@redhat.com> > --- > autobuild.sh => prepare-release.sh | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > rename autobuil

Re: [libvirt] [PATCHv3 03/13] Switch from yajl to Jansson

2018-05-15 Thread Daniel P . Berrangé
On Tue, May 15, 2018 at 03:05:55PM +0200, Peter Krempa wrote: > On Fri, May 11, 2018 at 14:59:04 +0200, Ján Tomko wrote: > > Yajl has not seen much activity upstream recently. > > [0] [snip] > [0] For anyone following current meme trends, this looks like it's > relevant to our YAJL->janson

Re: [libvirt] [PATCHv3 00/13] Switch from yajl to Jansson

2018-05-15 Thread Daniel P . Berrangé
On Tue, May 15, 2018 at 10:23:52AM +0200, Andrea Bolognani wrote: > On Fri, 2018-05-11 at 14:59 +0200, Ján Tomko wrote: > > Per the discussion here: > > https://www.redhat.com/archives/libvir-list/2017-November/msg00225.html > > Switch from using yajl to Jansson. > > I expect Peter will review

Re: [libvirt] [PATCHv3 03/13] Switch from yajl to Jansson

2018-05-15 Thread Daniel P . Berrangé
On Tue, May 15, 2018 at 03:23:17PM +0200, Peter Krempa wrote: > On Tue, May 15, 2018 at 14:21:07 +0100, Daniel Berrange wrote: > > On Tue, May 15, 2018 at 03:05:55PM +0200, Peter Krempa wrote: > > > On Fri, May 11, 2018 at 14:59:04 +0200, Ján Tomko wrote: > > > > Yajl has not seen much activity

Re: [libvirt] [jenkins-ci PATCH v2 0/3] Enable out-of-the-box parallel make

2018-05-15 Thread Daniel P . Berrangé
On Tue, May 15, 2018 at 03:23:21PM +0200, Andrea Bolognani wrote: > Changes from [v1]: > > * turns out some versions of ExtUtils::MakeMaker output Makefiles > that are not entirely compatible with parallel make, which forces > us to introduce an exception in the relevant template and shuffle

Re: [libvirt] [RFC v3] external (pull) backup API

2018-05-18 Thread Daniel P . Berrangé
On Thu, May 17, 2018 at 05:43:37PM -0500, Eric Blake wrote: > Here's my updated counterproposal for a backup API. > > In comparison to v2 posted by Nikolay: > https://www.redhat.com/archives/libvir-list/2018-April/msg00115.html > - changed terminology a bit: Nikolay's "BlockSnapshot" is now

Re: [libvirt] [perl PATCH] Switch over to using Module::Build

2018-05-16 Thread Daniel P . Berrangé
On Wed, May 16, 2018 at 10:49:39AM +0200, Andrea Bolognani wrote: > On Tue, 2018-05-15 at 20:47 +0100, Daniel P. Berrangé wrote: > > On Tue, May 15, 2018 at 08:17:09PM +0200, Andrea Bolognani wrote: > > > + /usr/bin/perl Build.PL installdirs=vendor > > > Created

Re: [libvirt] [PATCH] log: actually do substring matches with fnmatch

2018-05-16 Thread Daniel P . Berrangé
On Wed, May 16, 2018 at 11:59:31AM +0200, Erik Skultety wrote: > On Mon, May 14, 2018 at 02:53:49PM +0100, Daniel P. Berrangé wrote: > > Historically we matched log filters with strstr(), and when switching to > > fnmatch in cbb0fd3cfdc287f6f4653ef1f04a7cfb2ea51b27, it was stated th

Re: [libvirt] [PATCHv3 00/13] Switch from yajl to Jansson

2018-05-16 Thread Daniel P . Berrangé
On Wed, May 16, 2018 at 10:53:22AM +0200, Ján Tomko wrote: > On Tue, May 15, 2018 at 05:24:40PM +0100, Daniel P. Berrangé wrote: > > On Tue, May 15, 2018 at 06:12:05PM +0200, Andrea Bolognani wrote: > > > On Fri, 2018-05-11 at 14:59 +0200, Ján Tomko wrote: > > >

[libvirt] [PATCH] qemu: include kernel version in QEMU log file

2018-05-18 Thread Daniel P . Berrangé
We currently print the libvirt and qemu version strings into the per-guest logfile. It would be useful to know what kernel is running too, so add that. Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- src/qemu/qemu_process.c | 8 +++- 1 file changed, 7 insertions(+), 1 de

Re: [libvirt] [PATCH] set default seccompSandbox as 0 for qemu

2018-05-18 Thread Daniel P . Berrangé
On Fri, May 18, 2018 at 12:42:07PM +0100, Daniel P. Berrangé wrote: > On Fri, May 18, 2018 at 07:37:33PM +0800, zhenwei pi wrote: > > start qemu fail : qemu-system-x86_64: -sandbox on,obsolete=deny, > > elevateprivileges=deny,spawn=deny,resourcecontrol=deny: > > seccom

Re: [libvirt] [PATCH] set default seccompSandbox as 0 for qemu

2018-05-18 Thread Daniel P . Berrangé
On Fri, May 18, 2018 at 07:37:33PM +0800, zhenwei pi wrote: > start qemu fail : qemu-system-x86_64: -sandbox on,obsolete=deny, > elevateprivileges=deny,spawn=deny,resourcecontrol=deny: > seccomp support is disabled > libvirt version : 4.3 > qemu version : 2.12 > reproducer : recompile qemu

[libvirt] [PATCH] nwfilter: fix IP address learning

2018-05-18 Thread Daniel P . Berrangé
In a previous commit: commit d4bf8f415074759baf051644559e04fe7f8b Author: Daniel P. Berrangé <berra...@redhat.com> Date: Wed Feb 14 09:43:59 2018 + nwfilter: handle missing switch enum cases Ensure all enum cases are listed in switch statements, or cast away

Re: [libvirt] [jenkins-ci PATCH] lcitool: Use Perl to generate password hashes

2018-05-17 Thread Daniel P . Berrangé
On Thu, May 17, 2018 at 04:10:37PM +0200, Andrea Bolognani wrote: > On Thu, 2018-05-17 at 14:18 +0100, Daniel P. Berrangé wrote: > > On Thu, May 17, 2018 at 03:09:11PM +0200, Andrea Bolognani wrote: > > > Perl to the rescue! The script ends up being only marginally > > &g

[libvirt] [jenkins-ci PATCH] projects: set TEST_MAINTAINER for libvirt-perl build job too

2018-05-17 Thread Daniel P . Berrangé
The TEST_MAINTAINER=1 env variable will effect running of Build.PL, causing it to turn on many more GCC warning flags to validate the build. So we need to set it for build job as well as test job. Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- projects/libvirt-perl.yaml | 2

[libvirt] [PATCH v3 0/4] qemu: use FD passing for chardev UNIX sockets

2018-05-17 Thread Daniel P . Berrangé
: - Refactor UNIX socket opening code to allow it to be mocked in the unit tests to avoid creating real UNIX sockets Daniel P. Berrangé (4): qemu: probe for -chardev 'fd' parameter for FD passing qemu: support passing pre-opened UNIX socket listen FD qemu: don't retry connect() if doing FD

[libvirt] [PATCH v3 1/4] qemu: probe for -chardev 'fd' parameter for FD passing

2018-05-17 Thread Daniel P . Berrangé
QEMU >= 2.12 will support passing of pre-opened file descriptors for socket based character devices. Reviewed-by: John Ferlan <jfer...@redhat.com> Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu

[libvirt] [PATCH v3 2/4] qemu: support passing pre-opened UNIX socket listen FD

2018-05-17 Thread Daniel P . Berrangé
some hostnames may require listening on multiple FDs to cover IPv4 and IPv6 concurrently. Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- src/qemu/qemu_command.c | 64 ++- src/qemu/qemu_command.h | 4 ++ .../disk-drive

Re: [libvirt] [jenkins-ci PATCH] lcitool: Use Perl to generate password hashes

2018-05-17 Thread Daniel P . Berrangé
<abolo...@redhat.com> > --- > guests/lcitool | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |:

[libvirt] [PATCH v3 4/4] qemu: remove pointless connect retry logic in agent

2018-05-17 Thread Daniel P . Berrangé
p. We can thus be sure the QEMU agent socket is present and don't need to retry connections to it, even without having the chardev FD passing feature. Reviewed-by: John Ferlan <jfer...@redhat.com> Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- src/

[libvirt] [PATCH v3 3/4] qemu: don't retry connect() if doing FD passing

2018-05-17 Thread Daniel P . Berrangé
remove the retry loop and timeout when connecting to the QEMU monitor if we are doing FD passing. Libvirt can go straight to sending the QMP greeting and will simply block waiting for a reply until QEMU is ready. Reviewed-by: John Ferlan <jfer...@redhat.com> Signed-off-by: Daniel P. Berrangé

Re: [libvirt] [jenkins-ci PATCH] lcitool: Use Perl to generate password hashes

2018-05-17 Thread Daniel P . Berrangé
On Thu, May 17, 2018 at 04:35:12PM +0200, Andrea Bolognani wrote: > On Thu, 2018-05-17 at 15:22 +0100, Daniel P. Berrangé wrote: > > On Thu, May 17, 2018 at 04:10:37PM +0200, Andrea Bolognani wrote: > > > A friend suggested > > > > > > diff --git a/guests/

[libvirt] [tck PATCH] Stop deleting MANIFEST file when making release dists

2018-05-17 Thread Daniel P . Berrangé
The MANIFEST file is now pre-created rather than auto-generated Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- Pushed as trivial + build fix prepare-release.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/prepare-release.sh b/prepare-release.sh index a

Re: [libvirt] [perl PATCH v2] Switch over to using Module::Build

2018-05-16 Thread Daniel P . Berrangé
On Wed, May 16, 2018 at 04:56:24PM +0200, Andrea Bolognani wrote: > On Tue, 2018-05-15 at 18:54 +0100, Daniel P. Berrangé wrote: > [...] > > diff --git a/prepare-release.sh b/prepare-release.sh > > index fea03f4..6850350 100755 > > --- a/prepare-release.sh > > +++ b/p

[libvirt] [jenkins-ci PATCH] jobs: don't create MANIFEST file during build

2018-05-16 Thread Daniel P . Berrangé
Projects have switched to a pre-built MANIFEST Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- jobs/perl-modulebuild.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/jobs/perl-modulebuild.yaml b/jobs/perl-modulebuild.yaml index 60374da..a80d6b8 100644 --- a/job

Re: [libvirt] [jenkins-ci PATCH 2/2] projects: Define archive_format for osinfo-db

2018-05-16 Thread Daniel P . Berrangé
On Wed, May 16, 2018 at 05:18:56PM +0200, Andrea Bolognani wrote: > On Wed, 2018-05-16 at 15:25 +0200, Erik Skultety wrote: > > On Thu, May 10, 2018 at 05:26:33PM +0200, Andrea Bolognani wrote: > > > Follow the standard templating behavior instead of needlessly > > > hardcoding information in the

Re: [libvirt] [PATCH 02/12] Introduce new domain create API virDomainCreateWithParams

2018-05-16 Thread Daniel P . Berrangé
On Wed, May 16, 2018 at 05:30:33PM +0200, Marc Hartmayer wrote: > On Wed, May 09, 2018 at 05:40 PM +0200, "Daniel P. Berrangé" > <berra...@redhat.com> wrote: > > On Wed, May 09, 2018 at 04:56:12PM +0200, Marc Hartmayer wrote: > >> Introduce new libvirt API

Re: [libvirt] [PATCHv3 00/13] Switch from yajl to Jansson

2018-05-15 Thread Daniel P . Berrangé
On Tue, May 15, 2018 at 11:46:57AM +0200, Andrea Bolognani wrote: > On Tue, 2018-05-15 at 10:19 +0100, Daniel P. Berrangé wrote: > > On Tue, May 15, 2018 at 10:23:52AM +0200, Andrea Bolognani wrote: > > > Personally, I think Travis CI being limited to Ubuntu, and stuck to > &g

Re: [libvirt] [PATCH] tests: Link mocks with libvirt.so

2018-05-15 Thread Daniel P . Berrangé
LIB_LIBS) > + $(GNULIB_LIBS) \ > + ../src/libvirt.la > > EXTRA_DIST = \ > .valgrind.supp \ Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org

Re: [libvirt] [PATCHv3 00/13] Switch from yajl to Jansson

2018-05-15 Thread Daniel P . Berrangé
On Tue, May 15, 2018 at 02:03:12PM +0200, Andrea Bolognani wrote: > On Tue, 2018-05-15 at 12:08 +0100, Daniel P. Berrangé wrote: > > On Tue, May 15, 2018 at 11:46:57AM +0200, Andrea Bolognani wrote: > > > "xenial" (Ubuntu 16.04 LTS) support has been in the works for a &

[libvirt] [PATCH] util: fix misleading command for virObjectLock

2018-05-15 Thread Daniel P . Berrangé
It only accepts a virObjecLockable, not a virObjecRWLockable Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- src/util/virobject.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virobject.c b/src/util/virobject.c index 9fb0328d58..a597ff4f54

Re: [libvirt] [dbus PATCH v2] docs: Introduce man file for libvirt-dbus daemon

2018-05-16 Thread Daniel P . Berrangé
> configure.ac | 1 + > docs/Makefile.am | 13 + > docs/libvirt-dbus.pod | 66 +++ > libvirt-dbus.spec.in | 2 ++ > 6 files changed, 85 insertions(+), 1 deletion(-) > create mode 100644 docs/Makefile.am > create mode

Re: [libvirt] [jenkins-ci PATCH 4/3] guests: Add Package::Constants dependency for Perl projects

2018-05-16 Thread Daniel P . Berrangé
> @@ -8,6 +8,7 @@ packages: >- perl-IO-Compress-Bzip2 >- perl-IO-String > - perl-Module-Build > + - perl-Package-Constants >- perl-Sub-Uplevel >- perl-TAP-Formatter-HTML >- perl-TAP-Formatter-JUnit Reviewed-by: Daniel P. Berrangé <berra...@redhat.com>

Re: [libvirt] ANNOUNCE: Plans for the next release

2018-05-16 Thread Daniel P . Berrangé
On Wed, May 16, 2018 at 01:38:06PM +0200, Pavel Hrdina wrote: > On Wed, May 16, 2018 at 12:09:15PM +0100, Daniel P. Berrangé wrote: > > On Mon, May 14, 2018 at 05:15:59PM +0200, Pavel Hrdina wrote: > > > Hi, > > > > > > I would like to make the next l

Re: [libvirt] [jenkins-ci PATCH 3/3] guests: Blacklist perl-ExtUtils-MakeMaker

2018-05-16 Thread Daniel P . Berrangé
er a reasonable amount of time. > > Signed-off-by: Andrea Bolognani <abolo...@redhat.com> > --- > guests/vars/mappings.yml | 1 - > guests/vars/projects/blacklist.yml | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé

[libvirt] [PATCH v2] log: actually do substring matches with fnmatch

2018-05-16 Thread Daniel P . Berrangé
lly make that happen. This fixes it to prepend and append "*". We don't bother to check if the pattern already has a leading/trailing '*', because "**foo**" will match the same as "*foo*". Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- Changed in v2:

Re: [libvirt] [PATCH] travis: Install Jansson instead of yajl

2018-05-16 Thread Daniel P . Berrangé
om> > --- > Should be pushed at the same time as Ján's series. > > .travis.yml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://w

Re: [libvirt] ANNOUNCE: Plans for the next release

2018-05-16 Thread Daniel P . Berrangé
On Mon, May 14, 2018 at 05:15:59PM +0200, Pavel Hrdina wrote: > Hi, > > I would like to make the next libvirt-dbus release with stable APIs, > there is a lot of them already implemented and other projects can start > adapting to use libvirt-dbus. > > The release version would be 1.0.0 and

Re: [libvirt] [jenkins-ci PATCH 1/3] guests: Install Module::Build for libvirt-perl

2018-05-16 Thread Daniel P . Berrangé
vars/projects/libvirt-perl.yml > @@ -1,7 +1,7 @@ > --- > packages: >- perl-CPAN-Changes > - - perl-ExtUtils-MakeMaker > + - perl-Module-Build >- perl-Test-Pod > - perl-Test-Pod-Coverage >- perl-Time-HiRes Reviewed-by: Daniel P. Berrangé <berra...@

Re: [libvirt] [jenkins-ci PATCH 2/3] guests: Add Archive::Tar dependency for Perl projects

2018-05-16 Thread Daniel P . Berrangé
le-Build >- perl-Test-Pod > diff --git a/guests/vars/projects/libvirt-tck.yml > b/guests/vars/projects/libvirt-tck.yml > index 8d29c1c..d0f 100644 > --- a/guests/vars/projects/libvirt-tck.yml > +++ b/guests/vars/projects/libvirt-tck.yml > @@ -1,5 +1,6 @@ > --- > packa

Re: [libvirt] [jenkins-ci PATCH 5/3] guests: Fix PERL5LIB for Module::Build

2018-05-16 Thread Daniel P . Berrangé
rt-freebsd-11/main.yml | 2 +- > guests/host_vars/libvirt-freebsd-current/main.yml | 2 +- > guests/host_vars/libvirt-ubuntu-14/main.yml | 2 +- > guests/host_vars/libvirt-ubuntu-16/main.yml | 2 +- > guests/host_vars/libvirt-ubuntu-18/main.yml | 2 +- > 14 fi

[libvirt] [PATCH v2 19/21] nwfilter: wire up new APIs for listing and querying filter bindings

2018-05-15 Thread Daniel P . Berrangé
Wire up the ListAll, LookupByPortDev and GetXMLDesc APIs to allow the virsh nwfilter-binding-list & nwfilter-binding-dumpxml commands to work. Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- src/nwfilter/nwfilter_driver.c | 71 ++ 1 file c

[libvirt] [PATCH v2 08/21] access: add nwfilter binding object permissions

2018-05-15 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- src/access/viraccessdriver.h | 5 src/access/viraccessdrivernop.c| 10 src/access/viraccessdriverpolkit.c | 21 src/access/viraccessdriverstack.c | 24 ++ src/

[libvirt] [PATCH v2 13/21] nwfilter: convert DHCP address snooping code to virNWFilterBindingDefPtr

2018-05-15 Thread Daniel P . Berrangé
Use the virNWFilterBindingDefPtr struct in the DHCP address snooping code directly. Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- src/nwfilter/nwfilter_dhcpsnoop.c | 150 ++--- src/nwfilter/nwfilter_dhcpsnoop.h | 7 +- src/nw

[libvirt] [PATCH v2 18/21] nwfilter: remove virt driver callback layer for rebuilding filters

2018-05-15 Thread Daniel P . Berrangé
objects, as they're never touched. Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- src/conf/nwfilter_conf.c | 169 +++-- src/conf/nwfilter_conf.h | 51 +--- src/conf/virnwfilterobj.c | 4 +- src/libvirt_privat

[libvirt] [PATCH v2 15/21] conf: introduce a virNWFilterBindingObjPtr struct

2018-05-15 Thread Daniel P . Berrangé
Introduce a new struct to act as the stateful owner of the virNWFilterBindingDefPtr objects. Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- src/conf/Makefile.inc.am | 2 + src/conf/virnwfilterbindingobj.c | 260 +++ sr

  1   2   3   4   5   6   7   8   9   10   >