Re: [libvirt] [PATCH] Power Hypervisor support

2009-07-27 Thread Daniel P. Berrange
On Fri, Jul 24, 2009 at 07:52:53PM -0300, Eduardo Otubo wrote: > On Thu, 2009-07-23 at 21:52 +0100, Daniel P. Berrange wrote: > > > > BTW, if you could provide a short introduction outlining any important > > points for the Phyp driver that'd be great. Driver docs und

Re: [libvirt] Unable to get libvirt working with KVM using direct kernel boot.

2009-07-27 Thread Daniel P. Berrange
On Mon, Jul 27, 2009 at 03:07:38PM +0300, Tiit Kaeeli wrote: > Hi, > > I am trying to get libvirt to manage a KVM virtual machine on Debian > squeeze with multiple relevant parts included form unstable (because of > need for gpt partition tables, Intel 82576 nic etc). > > Unfortunately the VM d

Re: [libvirt] RFC: libvirt java bindings based on JNA

2009-07-27 Thread Daniel P. Berrange
On Sat, Jul 25, 2009 at 07:56:36AM -0400, Bryan Kearney wrote: > I will send a patch stream to the list, but you can also get the code > via an SRPM [3] or via github [4]. [snip] > [4] http://github.com/bkearney/libvirt-java/tree/jna FYI, I've just add the libvirt-java to the list or libvirt GI

[libvirt] PATCH: Implement vCPU cpuTime + cpu fields for QEMU

2009-07-27 Thread Daniel P. Berrange
The qemudDomainGetVcpus() method in QEMU driver has the following long standing todo item /* XXX cpu time, current pCPU mapping */ This has caused confusion for users, because they set affinity and then wonder why 'virsh vcpuinfo' constantly reports their guest as running on pCPU 0

Re: [libvirt] test driver and virtOpenAuth()

2009-07-27 Thread Daniel P. Berrange
On Fri, Jul 24, 2009 at 02:23:51PM -0400, Bryan Kearney wrote: > Daniel P. Berrange wrote: > >On Fri, Jul 24, 2009 at 01:56:24PM -0400, Bryan Kearney wrote: > >>I am trying to test a call into virConnectOpenAuth. How can I configure > >>the test driver to accept auth

Re: [libvirt] [PATCH] Kernel command line support for UML

2009-07-27 Thread Daniel P. Berrange
On Mon, Jul 27, 2009 at 07:51:08PM +0100, Ron Yorston wrote: > When experimenting with libvirt and UML I found it necessary to add > support for additional kernel command line arguments. ACK, this looks reasonable. Daniel > diff -up libvirt-0.6.5/src/uml_conf.c.uml-cmdline libvirt-0.6.5/src/uml_

Re: [libvirt] VMware ESX: Add no_verify query parameter

2009-07-27 Thread Daniel P. Berrange
On Mon, Jul 27, 2009 at 01:15:16PM +0200, Matthias Bolte wrote: > Adds a no_verify query parameter to stop libcurl from verifying the > server certificate for the https transport. > > Idea from Tom Hughes. ACK, this matches the same no_verify parameter supported for the generic 'remote' driver, w

Re: [libvirt] [PATCH 4/7] Factor qemudMonitorSend() out of qemudMonitorCommandExtra()

2009-07-27 Thread Daniel P. Berrange
On Wed, Jul 22, 2009 at 10:57:33PM +0100, Mark McLoughlin wrote: > Add a little helper function to write the monitor command followed by > carriage return in a single write. > > This doesn't make any real difference, but allows us to more easily > switch to using sendmsg() when using the monitor o

Re: [libvirt] [PATCH 5/7] Use sendmsg() on QEMU monitor socket

2009-07-27 Thread Daniel P. Berrange
On Wed, Jul 22, 2009 at 10:57:34PM +0100, Mark McLoughlin wrote: > Switch from using write() to using sendmsg() on QEMU's monitor socket > so that we can add support for SCM_RIGHTS. > > * src/qemu_driver.c: add sendmsg() based qemudMonitorSendUnix() and use > it when the monitor fd is a unix soc

Re: [libvirt] [PATCH 6/7] Add SCM_RIGHTS support to QEMU monitor code

2009-07-27 Thread Daniel P. Berrange
On Mon, Jul 27, 2009 at 10:59:47AM +0200, Daniel Veillard wrote: > On Wed, Jul 22, 2009 at 10:57:35PM +0100, Mark McLoughlin wrote: > > Add qemudMonitorCommandWithFd() which allows a file descriptor to be > > sent to qemu over a unix monitor socket using SCM_RIGHTS. See the > > unix(7) and cmsg(3)

Re: [libvirt] [PATCH 7/7] Add support for attaching network/bridge NICs in QEMU driver

2009-07-27 Thread Daniel P. Berrange
On Wed, Jul 22, 2009 at 10:57:36PM +0100, Mark McLoughlin wrote: > @@ -4637,10 +4639,16 @@ static int qemudDomainAttachNetDevice(virConnectPtr > conn, > > if (net->type == VIR_DOMAIN_NET_TYPE_BRIDGE || > net->type == VIR_DOMAIN_NET_TYPE_NETWORK) { > -qemudReportError(conn,

Re: [libvirt] [PATCH 0/7] QEMU network/bridge backed NIC hotplug

2009-07-27 Thread Daniel P. Berrange
On Wed, Jul 22, 2009 at 10:57:29PM +0100, Mark McLoughlin wrote: > > Hey, > So, here are the patches needed to complete the QEMU NIC hotplug > work by supporting network and bridge backed interfaces. > > We support this by passing a tap file descriptor to qemu over > the monitor s

[libvirt] Re: [PATCH] Add huge page support to libvirt, v2..

2009-07-27 Thread Daniel P. Berrange
On Thu, Jul 23, 2009 at 09:00:18PM -0400, john cooper wrote: > I've incorporated feedback received on the > prior version into the patch below. > > The host mount point for hugetlbfs is queried by > default from /proc/mounts unless overridden in > qemu.conf via: > > hugepage_mount = "" > > T

Re: [libvirt] XenStore fix

2009-07-28 Thread Daniel P. Berrange
On Tue, Jul 28, 2009 at 10:15:10AM +0200, Daniel Veillard wrote: > On Tue, Jul 28, 2009 at 08:30:12AM +0200, Jonas Eriksson wrote: > > Hi, > > > > I have been examining a bug where libvirtd (and virsh) does not show > > all virtual machines on a xen host. This proved to be because of this > > prog

Re: [libvirt] XenStore fix

2009-07-28 Thread Daniel P. Berrange
On Tue, Jul 28, 2009 at 08:30:12AM +0200, Jonas Eriksson wrote: > Hi, > > I have been examining a bug where libvirtd (and virsh) does not show > all virtual machines on a xen host. This proved to be because of this > program flow: > 1. virConnectNumOfDomains -> .. -> xenUnifiedNumOfDomains >->

Re: [libvirt] VMware support and libcurl on rhel-u1

2009-07-28 Thread Daniel P. Berrange
On Tue, Jul 28, 2009 at 02:22:25AM -0700, Shahar Klein wrote: > doesn't work for me(with curl 7.15 and ESX4i) > > [r...@rain8 libvirt]# virsh -c esx://172.30.8.63?no_verify=1 > Enter username for 172.30.8.63 [root]: > Enter root password for 172.30.8.63: > error: internal error curl_easy_perform()

[libvirt] Re: [PATCH] Add huge page support to libvirt, v2..

2009-07-28 Thread Daniel P. Berrange
On Tue, Jul 28, 2009 at 10:55:58AM +0100, Mark McLoughlin wrote: > On Mon, 2009-07-27 at 22:55 +0100, Daniel P. Berrange wrote: > > On Thu, Jul 23, 2009 at 09:00:18PM -0400, john cooper wrote: > > > I've incorporated feedback received on the > > > pr

[libvirt] PATCH: Fix remote domain events deadlock

2009-07-28 Thread Daniel P. Berrange
o protect against people deleting callbacks during the course of dispatch Daniel commit e2e6f795dd1832227c7d5c7832596be3642fe6e4 Author: Daniel P. Berrange Date: Tue Jul 28 17:45:19 2009 +0100 Fix deadlock in remote driver domain events * src/remote_internal.c: Release driver

Re: [libvirt] [PATCH 14/14] Remove the spec files

2009-07-28 Thread Daniel P. Berrange
On Tue, Jul 28, 2009 at 07:44:17PM +0100, Mark McLoughlin wrote: > Maintaining a spec file is hard, and it's extremely distribution > specific > > Keeping it (mostly) in sync with an upstream spec file makes things > harder and more error prone > > Unless we have some really strong desire by user

Re: [libvirt] [PATCH] libvirt-glib: add missing details argument to callbacks

2009-07-29 Thread Daniel P. Berrange
On Wed, Jul 29, 2009 at 03:44:07AM +0200, Guido G?nther wrote: > On Wed, Jul 22, 2009 at 12:16:27PM +0200, Guido Günther wrote: > > Hi, > > the python example is lacking the details argument in the callback. This > > makes the example fail due to the wrong number of arguments. > > Cheers, > > -- G

Re: [libvirt] [PATCH] libvirt-glib: add missing details argument to callbacks

2009-07-29 Thread Daniel P. Berrange
On Wed, Jul 29, 2009 at 01:24:24PM +0200, Guido G?nther wrote: > On Wed, Jul 29, 2009 at 10:33:12AM +0100, Daniel P. Berrange wrote: > [..snip..] > > FYI, my libvirt-glib work is temporarily on hold due to lack of time. > > As such I've just pulled the event loop code dire

Re: [libvirt] Debug the username/passwords

2009-07-29 Thread Daniel P. Berrange
On Tue, Jul 28, 2009 at 04:58:17PM -0400, Bryan Kearney wrote: > Hopefully this is the last question I have on the Java drivers. I am > trying to debug the callback from openAuth(). I am passing back what I > think is valid information, but I see in /var/log/messages the following: > > Jul 28 16

Re: [libvirt] [PATCH] qemu: fix monitor socket reconnection

2009-07-29 Thread Daniel P. Berrange
On Wed, Jul 29, 2009 at 12:09:44AM +0900, Ryota Ozaki wrote: > Hi, > > This patch fixes a handling of a qemu monitor unix socket. Current code > addresses 'Socket may not have shown up yet' case with catching EACCES > of connect(2), however, in that case, an errno which should be catched > is ENOE

Re: [libvirt] [PATCH] Remove MAX_TAP_ID, take 2

2009-07-29 Thread Daniel P. Berrange
On Wed, Jul 29, 2009 at 12:27:58AM -0400, Aron Griffis wrote: > (Sorry, my first posting included some gnulib droppings in the > patch. This removes that, everything else is the same.) > > As far as I can tell, there's no reason to format the device string in > brAddTap(). Delegate the job to TUN

Re: [libvirt] Feature request? Console tunnelling..

2009-07-30 Thread Daniel P. Berrange
On Wed, Jul 29, 2009 at 02:57:45PM -0700, r...@rocketmail.com wrote: > Hello libvirt-list.. > > Firstly I hope this is the appropriate forum for this question, I > tried the IRC channel but didn't get any response... > > Anyway, currently libvirt has console functionality built into it > that can

Re: [libvirt] VM creation failed : Permission denied : bind(unix:/var/run/libvirt/qemu//VM.monitor)

2009-07-30 Thread Daniel P. Berrange
On Thu, Jul 30, 2009 at 10:57:53AM +0200, Daniel Veillard wrote: > On Thu, Jul 30, 2009 at 05:44:41PM +0900, Ryota Ozaki wrote: > > On Thu, Jul 30, 2009 at 5:33 PM, Pierre-Gilles > > Mialon wrote: > > >        I use Ovirt under Fedora 11 with the latest developpement package > > > and the VM > > >

Re: [libvirt] VM creation failed : Permission denied : bind(unix:/var/run/libvirt/qemu//VM.monitor)

2009-07-30 Thread Daniel P. Berrange
On Thu, Jul 30, 2009 at 10:33:31AM +0200, Pierre-Gilles Mialon wrote: > I use Ovirt under Fedora 11 with the latest developpement package and > the VM > creation failed with : > bind(unix:/var/run/libvirt/qemu//VM-4.monitor): Permission denied > ==> /var/log/libvirt/qemu/VM-4.log <== > LC

[libvirt] PATCH: Fix RPM upgrades to create qemu user

2009-07-30 Thread Daniel P. Berrange
If upgrading from F11 to F12 it is possible the qemu user/group does not yet exist. Since the libvirt RPM needs to deploy files owned by this user/group, regardless of whether QEMU is yet installed, we need to make sure to create this user/group in %pre, otherwise fiels will end up with wrong owner

Re: [libvirt] XenStore fix

2009-07-30 Thread Daniel P. Berrange
On Thu, Jul 30, 2009 at 01:51:40PM +0200, Jonas Eriksson wrote: > Hi again, > > How should we tackle this? The discussions seems to have stopped, > but as this is a bug, it would be nice to have the fix in 0.7.0 > if possible. Any suggestions of what an eveutual reworked patch > should contain, or

Re: [libvirt] VM creation failed : Permission denied : bind(unix:/var/run/libvirt/qemu//VM.monitor)

2009-07-30 Thread Daniel P. Berrange
On Thu, Jul 30, 2009 at 03:36:37PM +0200, Pierre-Gilles Mialon wrote: > Le jeudi 30 juillet 2009 12:26:57, Daniel P. Berrange a écrit : > > On Thu, Jul 30, 2009 at 10:33:31AM +0200, Pierre-Gilles Mialon wrote: > > > I use Ovirt under Fedora 11 with the latest developpement pac

[libvirt] PATCH: Always start dnsmasq to provide DNS

2009-07-30 Thread Daniel P. Berrange
ds, Daniel commit deb71927a3551b3a1554351ef098644aec978a09 Author: Daniel P. Berrange Date: Thu Jul 30 14:52:31 2009 +0100 Allow dnsmasq to provide DNS without DHCP * src/network_driver.c: Always start dnsmasq to allow it to provide DNS, even if no DHCP ranges are enabled diff -

[libvirt] PATCH: Fix permissions problem starting QEMU

2009-07-30 Thread Daniel P. Berrange
e PID file has been created. We should also be sure to kill the child if writing the PID file fails Daniel commit ce246587178bc6539a3ea6181cdf06ea45878fd3 Author: Daniel P. Berrange Date: Thu Jul 30 14:58:16 2009 +0100 Fix problem writing QEMU pidfile * src/util.c: Don't dr

[libvirt] PATCH: Disable IPv6 on virtual network bridges

2009-07-30 Thread Daniel P. Berrange
This is to address: https://bugzilla.redhat.com/show_bug.cgi?id=501934 which allows the guest to DOS the host IPv6 connectivity Daniel commit 763cf06ff76b4ded03a9b577cd8c541729190edc Author: Daniel P. Berrange Date: Thu Jul 30 16:34:56 2009 +0100 Disable IPv6 on virtual networks

[libvirt] PATCH: Re-enable ESX driver on Mingw32

2009-07-30 Thread Daniel P. Berrange
After finding an RPM of mingw32-curl for Fedora 11, I was able to successfully build the ESX driver on Ming32 with only a couple of tweaks. Daniel commit 8b135962ef026ef3ef1b5c5163b1213eeba9ec36 Author: Daniel P. Berrange Date: Thu Jul 30 16:40:29 2009 +0100 Enable ESX driver build on

Re: [libvirt] PATCH: Disable IPv6 on virtual network bridges

2009-07-30 Thread Daniel P. Berrange
On Thu, Jul 30, 2009 at 05:50:30PM +0200, Jonas Eriksson wrote: > On Thu, Jul 30, 2009 at 04:37:35PM +0100 Daniel P. Berrange wrote: > > This is to address: > > > > https://bugzilla.redhat.com/show_bug.cgi?id=501934 > > > > which allows the guest

Re: [libvirt] PATCH: Disable IPv6 on virtual network bridges

2009-07-30 Thread Daniel P. Berrange
On Thu, Jul 30, 2009 at 04:55:11PM +0100, Daniel P. Berrange wrote: > On Thu, Jul 30, 2009 at 05:50:30PM +0200, Jonas Eriksson wrote: > > On Thu, Jul 30, 2009 at 04:37:35PM +0100 Daniel P. Berrange wrote: > > > This is to address: > > > > > > https://bugzil

Re: [libvirt] PATCH: Fix permissions problem starting QEMU

2009-07-31 Thread Daniel P. Berrange
On Fri, Jul 31, 2009 at 09:28:37AM +0100, Mark McLoughlin wrote: > On Thu, 2009-07-30 at 15:00 +0100, Daniel P. Berrange wrote: > > There is a minor bug when running QEMU non-root, and having > > capng enabled. libvirt is unable to write the PID file in > > /var/run/libvir

Re: [libvirt] [PATCH] Workaround for broken GCC in Debian Etch

2009-07-31 Thread Daniel P. Berrange
On Thu, Jul 30, 2009 at 09:29:20PM +0200, Maximilian Wilhelm wrote: > Hi again! > > I missed one patch for working around a GCC bug in Debian Etch > regarding limit definitions. > > Sorry for the unstripped git-format-patch outputs, I just realised > this after pressing send :( > > (This seems t

Re: [libvirt] [PATCH] Add some automatic dependency checks for configure to enable/disable {ESX, UML, LXC, Xen-Inotify}

2009-07-31 Thread Daniel P. Berrange
On Thu, Jul 30, 2009 at 09:25:55PM +0200, Maximilian Wilhelm wrote: > Hi! > > While building libVirt on an older Debian Etch machine, I stumbled > across some automatic enabled drivers which stopped configure and make > very badly due to missing header files, old libraries and stuff. > > So I dec

[libvirt] PATCH: Fix crash attempting to shutdown inactive QEMU vm

2009-07-31 Thread Daniel P. Berrange
If the virDomainShutdown() op was run on an active QEMu vm, it would crash, since the def->monitor_chr was NULL. Daniel commit 49ec121fd806aaa07bbcba9668a8f9dd43dda9c4 Author: Daniel P. Berrange Date: Fri Jul 31 15:50:46 2009 +0100 Fix crash when attempting to shutdown inactive QEMU

[libvirt] PATCH: Fix startup of LXC vms without cgroups

2009-07-31 Thread Daniel P. Berrange
If cgroups was not mounted at all, LXC would fail to start any VM, since we missed an error code check Daniel commit 8713c7e8111e73879f8380b920995ff3d1f3f9e9 Author: Daniel P. Berrange Date: Fri Jul 31 14:37:25 2009 +0100 Don't try to activate cgroups if not present fo

[libvirt] PATCH: Fix cleanup of transient VMs

2009-07-31 Thread Daniel P. Berrange
If a transient VM quit unexpectedly it would never be cleaned up, resulting in a guest that's impossible to remove Daniel commit 7781032c3d870f5c9dacfc02baecc151689d9c57 Author: Daniel P. Berrange Date: Fri Jul 31 14:38:46 2009 +0100 Fix removal of transient VMs when LXC a

[libvirt] PATCH: Add name uniqueness checking to LXC driver

2009-07-31 Thread Daniel P. Berrange
The LXC driver define/create methods didn't yet have name uniqueness checking enabled Daniel commit 4b23a44f34392b5c6d1c5aa483cbe81b010e47c4 Author: Daniel P. Berrange Date: Fri Jul 31 15:25:03 2009 +0100 Add uniqness checking for LXC define/create methods * src/lxc_dri

Re: [libvirt] [PATCH] Fix up a silly typo in apibuild.py.

2009-07-31 Thread Daniel P. Berrange
On Fri, Jul 31, 2009 at 03:19:46PM +0200, Chris Lalancette wrote: > Signed-off-by: Chris Lalancette > --- > docs/apibuild.py |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/docs/apibuild.py b/docs/apibuild.py > index 6fec049..84bc1ac 100755 > --- a/docs/apibuild.py

Re: [libvirt] [PATCH] Fix virCapabilitiesDefaultGuestMachine documentation.

2009-07-31 Thread Daniel P. Berrange
On Fri, Jul 31, 2009 at 03:19:48PM +0200, Chris Lalancette wrote: > Signed-off-by: Chris Lalancette > --- > src/capabilities.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/capabilities.c b/src/capabilities.c > index d186961..c6766b6 100644 > --- a/src/capabi

Re: [libvirt] [PATCH] Fix up a minor indentation issue with virDomainMigratePrepare.

2009-07-31 Thread Daniel P. Berrange
On Fri, Jul 31, 2009 at 03:19:50PM +0200, Chris Lalancette wrote: > Signed-off-by: Chris Lalancette > --- > src/libvirt.c | 14 +++--- > 1 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/src/libvirt.c b/src/libvirt.c > index 7ecf1ec..167359f 100644 > --- a/src/libvirt.c

Re: [libvirt] [PATCH] Use virGetHostname instead of gethostname.

2009-07-31 Thread Daniel P. Berrange
On Fri, Jul 31, 2009 at 03:19:53PM +0200, Chris Lalancette wrote: > Fix up qemudDomainMigratePrepare2 to use virGetHostname instead of > gethostname. Besides the fact that virGetHostname is far more clever, > there was a latent bug in the handling that could cause a buffer overflow > on a very lon

Re: [libvirt] [PATCH] Convert a few stray users of free() in libvirt.c to VIR_FREE().

2009-07-31 Thread Daniel P. Berrange
On Fri, Jul 31, 2009 at 03:19:54PM +0200, Chris Lalancette wrote: > Signed-off-by: Chris Lalancette > --- > src/libvirt.c |6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/libvirt.c b/src/libvirt.c > index 167359f..9fd864d 100644 > --- a/src/libvirt.c > +++ b

Re: [libvirt] [PATCH] Remove a stray semicolon in qemudDomainMigratePrepare2.

2009-07-31 Thread Daniel P. Berrange
On Fri, Jul 31, 2009 at 03:19:58PM +0200, Chris Lalancette wrote: > Signed-off-by: Chris Lalancette > --- > src/qemu_driver.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/qemu_driver.c b/src/qemu_driver.c > index 83cbcf3..5f4b28b 100644 > --- a/src/qemu_driv

Re: [libvirt] [PATCH] Fix an erroneous debug error to KVM; it should read QEMU/KVM.

2009-07-31 Thread Daniel P. Berrange
On Fri, Jul 31, 2009 at 03:19:59PM +0200, Chris Lalancette wrote: > Signed-off-by: Chris Lalancette > --- > src/qemu_driver.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/qemu_driver.c b/src/qemu_driver.c > index 5f4b28b..fcfbfbc 100644 > --- a/src/qemu_driv

Re: [libvirt] [PATCH] Add a comment about setting errors after qemudStartVMDaemon().

2009-07-31 Thread Daniel P. Berrange
On Fri, Jul 31, 2009 at 03:20:01PM +0200, Chris Lalancette wrote: > Signed-off-by: Chris Lalancette > --- > src/qemu_driver.c |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/src/qemu_driver.c b/src/qemu_driver.c > index fcfbfbc..eadb53f 100644 > --- a/src/qemu_dri

Re: [libvirt] [PATCH] Remove ATTRIBUTE_UNUSED from flags to qemudDomainMigratePerform.

2009-07-31 Thread Daniel P. Berrange
On Fri, Jul 31, 2009 at 03:20:08PM +0200, Chris Lalancette wrote: > Signed-off-by: Chris Lalancette > --- > src/qemu_driver.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/qemu_driver.c b/src/qemu_driver.c > index eadb53f..9fcc07a 100644 > --- a/src/qemu_driv

Re: [libvirt] [PATCH] Fix latent buffer overflow in qemudOpenMonitorUnix.

2009-07-31 Thread Daniel P. Berrange
On Fri, Jul 31, 2009 at 03:20:09PM +0200, Chris Lalancette wrote: > Fix a possible latent bug in qemudOpenMonitorUnix(). If the pathname > to the monitor is very long (i.e. >= UNIX_MAX_PATH), then strncpy will > *not* place a final \0 on the string (see "man strncpy"). > NULL terminate the buffer

Re: [libvirt] [PATCH] Split virDomainMigrate into functions.

2009-07-31 Thread Daniel P. Berrange
On Fri, Jul 31, 2009 at 03:19:56PM +0200, Chris Lalancette wrote: > Re-factor virDomainMigrate to split out the version 1 and version 2 > protocols into their own functions. In reality, the two versions share > very little in common, so forcing them together in the same function was > just confusi

Re: [libvirt] VMware support and Server 2.0.1

2009-08-03 Thread Daniel P. Berrange
On Sun, Aug 02, 2009 at 03:45:43PM +0200, Matthias Bolte wrote: > > The attached second GSX patch adds a gsx:// scheme to the ESX driver, > so you can connect to a GSX host using > > virsh -c gsx://host > > and the driver will select the port automatically dependent on the > scheme and transport

Re: [libvirt] [PATCH] Workaround for broken GCC in Debian Etch

2009-08-03 Thread Daniel P. Berrange
On Sun, Aug 02, 2009 at 05:36:20PM +0200, Maximilian Wilhelm wrote: > Anno domini 2009 Daniel P. Berrange scripsit: > > > > I missed one patch for working around a GCC bug in Debian Etch > > > regarding limit definitions. > > > > Sorry for the unstripped git-f

Re: [libvirt] [PATCH] Don't clobber ID when redefining dom in xm driver

2009-08-03 Thread Daniel P. Berrange
On Fri, Jul 31, 2009 at 12:40:59PM -0400, Cole Robinson wrote: > If redefining a domain in the xen xm driver, we unconditionally set the > domain ID to -1. This can make a running domain appear inactive, and > really confuse things. Just drop the offending code, since virGetDomain > already sets th

[libvirt] PATCH: Fix escaping for 8-bit high characters

2009-08-04 Thread Daniel P. Berrange
The virBufferEscapeString method has a broken test *cur > 0x20 which causes all 8-bit high characters to be lost as 'cur' is a signed char. This obviously dooms anyone using UTF-8 characters outside the boring old ASCII-7 range, like this guy https://bugzilla.redhat.com/show_bug.cgi?id=47951

Re: [libvirt] [PATCH] Refresh /etc/xen if inotify wasn't initialized

2009-08-05 Thread Daniel P. Berrange
On Tue, Aug 04, 2009 at 12:29:02PM -0400, Cole Robinson wrote: > If libvirt was built against inotify, but an API user isn't using domain > events (virsh, virt-manager), the xen xm driver doesn't poll /etc/xen > for new config files. This means that domains created or deleted on > other libvirt con

Re: [libvirt] [PATCH] Allow libvirtd to RPC to external libvirtd.

2009-08-05 Thread Daniel P. Berrange
On Wed, Aug 05, 2009 at 11:22:12AM +0200, Daniel Veillard wrote: > On Fri, Jul 31, 2009 at 03:19:51PM +0200, Chris Lalancette wrote: > > Allow the daemon itself to make RPCs to an external libvirtd, but only if > > the URI is fully specified. While this isn't used at the moment, it will > > be for

Re: [libvirt] Re: [PATCH] Add huge page support to libvirt, v2..

2009-08-05 Thread Daniel P. Berrange
On Tue, Jul 28, 2009 at 08:04:31AM -0400, Stephen Smalley wrote: > On Mon, 2009-07-27 at 22:55 +0100, Daniel P. Berrange wrote: > > > > In light of what Chris said about extended attribute support > > for SELinux I think we, sadly, have no choice by to mount > > a new i

Re: [libvirt] Re: [PATCH] Add huge page support to libvirt, v2..

2009-08-05 Thread Daniel P. Berrange
On Wed, Aug 05, 2009 at 03:50:56PM +0100, Daniel P. Berrange wrote: > On Tue, Jul 28, 2009 at 08:04:31AM -0400, Stephen Smalley wrote: > > On Mon, 2009-07-27 at 22:55 +0100, Daniel P. Berrange wrote: > > > > > > In light of what Chris said about extended attribute

Re: [libvirt] Is it possible to use more then 2 CPUs in the guest?

2009-08-06 Thread Daniel P. Berrange
On Wed, Aug 05, 2009 at 10:11:07AM +0200, Mirko Raasch wrote: > Hi, > > in my server i use an Intel Quad Core CPU and i want to use in one > WindowsXP guest all 4 cores. > The device manager shows four CPU (Qemu Virtual CPU version 0.10.5). > When i start prime95 or superpi, only 2 of them are in

Re: [libvirt] [PATCH] Support the usage of socat instead of netcat

2009-08-06 Thread Daniel P. Berrange
On Wed, Aug 05, 2009 at 12:58:33PM +0200, Jonas Eriksson wrote: > Some netcat implementations does not support unix domain sockets (-U). > Distros that ship these implementations often also ships socat, that > do support this. > > This is a reworked patch based on the openSUSE libvirt package. The

Re: [libvirt] running with UID != 0: internal error about bridged network

2009-08-06 Thread Daniel P. Berrange
On Wed, Aug 05, 2009 at 02:51:14PM +0200, Harald Dunkel wrote: > Hi folks, > > I would like to avoid running the virtual hosts with UID=0. > But if I try to create a new virtual machine without being > root, then it fails with > > % name=Lenny_amd64 > % kvmdir=/local/kvm > % mkdir -p $kvmdir/$nam

Re: [libvirt] VMware ESX 1/3: Add proper OOM reporting for esxDomainGetOSType

2009-08-06 Thread Daniel P. Berrange
On Wed, Aug 05, 2009 at 03:22:51PM +0200, Matthias Bolte wrote: > Subject says it all. > > Matthias 5B> diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c > index dba6305..8b8575c 100644 > --- a/src/esx/esx_driver.c > +++ b/src/esx/esx_driver.c > @@ -1395,9 +1395,16 @@ esxDomainDestroy(virD

Re: [libvirt] VMware ESX 2/3: Fix memleak if esxOpen fails

2009-08-06 Thread Daniel P. Berrange
On Wed, Aug 05, 2009 at 03:23:14PM +0200, Matthias Bolte wrote: > Subject says it all. > > Matthias > diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c > index 8b8575c..49fdf00 100644 > --- a/src/esx/esx_driver.c > +++ b/src/esx/esx_driver.c > @@ -298,6 +298,7 @@ esxOpen(virConnectPtr conn

Re: [libvirt] VMware ESX 3/3: Cleanup varaible naming

2009-08-06 Thread Daniel P. Berrange
On Wed, Aug 05, 2009 at 03:23:28PM +0200, Matthias Bolte wrote: > Subject says it all. No functional change included. > diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c > index 49fdf00..0225e9a 100644 > --- a/src/esx/esx_driver.c > +++ b/src/esx/esx_driver.c > @@ -56,11 +56,11 @@ static in

Re: [Fwd: Re: [libvirt] Release of libvirt-0.7.0]

2009-08-06 Thread Daniel P. Berrange
On Wed, Aug 05, 2009 at 07:21:46PM -0400, Robert L Cochran wrote: > Ooops! I sent this to Dan when I meant to send it to the list. > > To be a bit repetitive...how do I get this for Fedora 11 -- and all of > its dependencies? Join the Fedora virt mailing list - Mark will post an announcement whe

Re: [libvirt] libvirt-0.3.3-14.el5 (redhat rpm) vs libvirt-0.6.5 (source)

2009-08-06 Thread Daniel P. Berrange
On Mon, Aug 03, 2009 at 05:14:27PM +0200, Jim Bergensen wrote: > Hello everyone, > > I am looking to write a simple php interface to create, stop, start, > restart, configure, backup, transfer VM's across a network of servers. > Storage is done locally on the particular node (lvm), but I am consid

Re: [libvirt] [PATCH 1/5] Tighten libvirt's parsing of logging environment variables

2009-08-06 Thread Daniel P. Berrange
On Fri, Jul 31, 2009 at 05:57:25PM -0400, Amy Griffis wrote: > Don't convert high priority levels to the debug level. Don't parse > LIBVIRT_LOG_FILTERS and LIBVIRT_LOG_OUTPUTS when they're set to the > empty string. Warn when the user specifies an invalid value (empty > string remains a noop). > --

Re: [libvirt] [PATCH 2/5] Several fixes to libvirtd's log setup

2009-08-06 Thread Daniel P. Berrange
On Fri, Jul 31, 2009 at 05:57:31PM -0400, Amy Griffis wrote: > Similar as for general libvirt, don't convert high priority levels to debug > level. Ignore LIBVIRT_LOG_FILTERS and LIBVIRT_LOG_OUTPUTS when they're set to > the empty string, otherwise they can override a valid setting from the config

Re: [libvirt] [PATCH 3/5] Cleanup VIR_LOG_DEBUG parsing in eventtest

2009-08-06 Thread Daniel P. Berrange
On Fri, Jul 31, 2009 at 05:57:37PM -0400, Amy Griffis wrote: > Don't covert high priority levels to debug level. Consider an invalid priority > level setting a setup failure. > --- > > tests/eventtest.c | 12 > 1 files changed, 8 insertions(+), 4 deletions(-) ACK Daniel > > dif

Re: [libvirt] [PATCH 4/5] Consolidate code for parsing the logging environment variables

2009-08-06 Thread Daniel P. Berrange
On Fri, Jul 31, 2009 at 05:57:42PM -0400, Amy Griffis wrote: > Add two new functions to the internal API, > virLogParseDefaultPriority() and virLogSetFromEnv(), > as was suggested earlier by Cole Robinson. > --- > > qemud/qemud.c| 50 > ++

Re: [libvirt] [PATCH 5/5] Update logging documentation

2009-08-06 Thread Daniel P. Berrange
On Fri, Jul 31, 2009 at 05:57:48PM -0400, Amy Griffis wrote: > Try to include a little more description about the corner cases, > things someone might get hung up on on. > --- > > docs/logging.html.in | 22 -- > 1 files changed, 20 insertions(+), 2 deletions(-) > > diff --g

Re: [libvirt] virt-manager

2009-08-06 Thread Daniel P. Berrange
On Sat, Aug 01, 2009 at 12:13:42PM -0400, Michael Zeller wrote: > okay so using virt-manager it only lists my root partition as storage, or > atleast thats what it appears > So it says I can only make a vm the size of 9G when my home partition has > 800+G > is there a way to change that? You'll pr

Re: [libvirt] error: failed to connect to the hypervisor

2009-08-06 Thread Daniel P. Berrange
On Mon, Aug 03, 2009 at 08:56:48AM +0200, Dominik Klein wrote: > Hi > > I am running kvm-78 with libvirt 0.6.1 and see the following error from > time to time when my linux-ha cluster tries to run "virsh domstate" to > figure out a virtual machine's state: > > error: failed to connect to the hype

Re: [libvirt] Is it possible to use more then 2 CPUs in the guest?

2009-08-06 Thread Daniel P. Berrange
On Thu, Aug 06, 2009 at 12:59:19PM +0100, Tom Hughes wrote: > On 06/08/09 12:36, Daniel P. Berrange wrote: > >On Wed, Aug 05, 2009 at 10:11:07AM +0200, Mirko Raasch wrote: > > > >>in my server i use an Intel Quad Core CPU and i want to use in one > >>WindowsXP

[libvirt] PATCH: Support PolicyKit 1.0

2009-08-06 Thread Daniel P. Berrange
In the seriously annoying way of things, the newest PolicyKit in Fedora 12 has been completely re-written from scratch with a totally incompatible application facing API. Conceptually it is still pretty similar though, with the exception that client applications no longer need to explicitly launch

Re: [libvirt] [PATCH 5/5] Update logging documentation

2009-08-06 Thread Daniel P. Berrange
On Thu, Aug 06, 2009 at 09:59:56AM -0400, Amy Griffis wrote: > Mark McLoughlin wrote: [Thu Aug 06 2009, 08:25:06AM EDT] > > On Fri, 2009-07-31 at 17:57 -0400, Amy Griffis wrote: > > > +Libvirtd does not reload its logging configuration when issued a > > > SIGHUP. > > > + If you want to

Re: [libvirt] [PATCH] Set perms on /var/lib/libvirt/boot to 0711

2009-08-06 Thread Daniel P. Berrange
On Thu, Aug 06, 2009 at 03:48:45PM +0100, Mark McLoughlin wrote: > Allow qemu user to open kernel/initrds in this dir, but still prevent > others from listing it. > > * libvirt.spec.in: set /var/lib/libvirt/boot perms to 0711 ACK > --- > libvirt.spec.in |2 +- > 1 files changed, 1 insertion

Re: [libvirt] [PATCH] chown kernel/initrd before spawning qemu

2009-08-06 Thread Daniel P. Berrange
On Thu, Aug 06, 2009 at 03:48:44PM +0100, Mark McLoughlin wrote: > If we're running qemu unprivileged, we need to chown any supplied kernel > or initrd before spawning it. > > * src/qemu_driver.c: rename qemuDomainSetDiskOwnership() to > qemuDomainSetFileOwnership(), pass it a path string instea

Re: [libvirt] [PATCH 01/20] Secret manipulation step 1: Public API

2009-08-06 Thread Daniel P. Berrange
On Tue, Aug 04, 2009 at 10:28:16PM +0200, Miloslav Trma?? wrote: > This patch adds a "secret" as a separately managed object, using a > special-purpose API to transfer the secret values between nodes and > libvirt users. > > Rather than add explicit accessors for attributes of secrets, and > hard-

Re: [libvirt] Is it possible to use more then 2 CPUs in the guest?

2009-08-06 Thread Daniel P. Berrange
On Thu, Aug 06, 2009 at 05:53:01PM +0200, Gerrit Slomma wrote: > I could test what is detected by windows if i choose another cpu-model > than "qemu" when invoking kvm. > Couldn't it made possible to choose the cpu-model via libvirt? We do have an RFE to choose the CPU model in libvirt, but that

Re: [libvirt] [PATCH 11/20] Add volume encryption information handling.

2009-08-06 Thread Daniel P. Berrange
On Tue, Aug 04, 2009 at 10:28:26PM +0200, Miloslav Trma?? wrote: > Define an tag specifying volume encryption format and > format-depenedent parameters (e.g. passphrase, cipher name, key > length, key). > > Currently the only defined parameter is a reference to a "secret" > (passphrase/key) manag

Re: [libvirt] [PATCH 12/20] Attach encryption information to virStorageVolDef.

2009-08-06 Thread Daniel P. Berrange
On Tue, Aug 04, 2009 at 10:28:27PM +0200, Miloslav Trma?? wrote: > The XML allows , this implementation > canonicalizes the internal representation so that "vol->encryption" is > non-NULL iff the volume is encrypted. > > Note that partial encryption information (e.g. specifying an encryption > for

Re: [libvirt][PATCH] running libvirt on the latest kvm snapshot

2009-08-07 Thread Daniel P. Berrange
On Fri, Aug 07, 2009 at 01:57:34PM +0200, Chris Lalancette wrote: > Anton Protopopov wrote: > > Hi. > > > > Libvirt tryes to extract kvm version from the string > > "QEMU PC emulator version .. (kvm-)..." > > For examle, > > # kvm -help | head -1 > > QEMU PC emulator version 0.10.0 (kvm-85),

Re: [libvirt] Project announcement: abiCloud

2009-08-07 Thread Daniel P. Berrange
On Fri, Aug 07, 2009 at 02:13:15PM +0200, Diego Mari?o wrote: > Hi all, > > This is a one-time post to announce a project which supports libvirt > for managing virtual machines: abiCloud. > > AbiCloud is an open source cloud platform manager which allows to > easily deploy a private cloud in your

Re: [libvirt][PATCH] running libvirt on the latest kvm snapshot

2009-08-10 Thread Daniel P. Berrange
On Sat, Aug 08, 2009 at 01:20:19AM +0200, Gerrit Slomma wrote: > Daniel P. Berrange schrieb: > >Fix kvm to include a relevant version number instead of just the 'devel' > >eg, Instead of > > > > QEMU PC emulator version 0.10.0 (kvm-devel), Copyright (c) 20

Re: [libvirt] Unable to create cgroup for driver

2009-08-11 Thread Daniel P. Berrange
On Tue, Aug 11, 2009 at 10:03:32AM +0900, Jun Koi wrote: > Hi, > > The libvirt 0.7 has a following error when i start libvirtd: > > warning : qemudStartup:521 : Unable to create cgroup for driver: No > such device or address That is not an error, it is a expected warning if you don't have any cg

Re: [libvirt] does libvirt support qemu-kvm vmchannel option?

2009-08-11 Thread Daniel P. Berrange
On Tue, Aug 11, 2009 at 11:18:36AM +0800, cyliu7 wrote: > Hi all, > > I noticed that qemu-kvm support an option vmchannel (-net channel ...) > to create a new device to communicate between host and guest. > > does libvirt support this option when creating a KVM based VM. if so, > how to config

Re: [libvirt] Unable to create cgroup for driver

2009-08-11 Thread Daniel P. Berrange
On Tue, Aug 11, 2009 at 06:04:29PM +0900, Jun Koi wrote: > On Tue, Aug 11, 2009 at 6:00 PM, Daniel P. Berrange > wrote: > > On Tue, Aug 11, 2009 at 10:03:32AM +0900, Jun Koi wrote: > >> Hi, > >> > >> The libvirt 0.7 has a following error when i start libvirt

Re: [libvirt] [PATCH] Handle kernels with no ipv6 support

2009-08-11 Thread Daniel P. Berrange
On Mon, Aug 10, 2009 at 11:20:51AM +0100, Mark McLoughlin wrote: > If the ipv6 kernel module is not loaded, then we get this when starting > a virtual network: > > libvir: Network Config error : > cannot enable /proc/sys/net/ipv6/conf/virbr0/disable_ipv6: > No such file or directory > > If

Re: [libvirt] Crash while using virConnectRef

2009-08-11 Thread Daniel P. Berrange
On Mon, Aug 10, 2009 at 01:27:06PM +0200, Chris Lalancette wrote: > All, > I've been doing some testing of the virConnectRef() function, and as far > as > I can tell, it's busted. Here's the simple example program I'm using: Its not really virConnectRef - the entire connection ref-counting

Re: [libvirt] [PATCH] Fix up a stray whitespace in virHashGrow.

2009-08-11 Thread Daniel P. Berrange
On Fri, Aug 07, 2009 at 11:06:12AM +0200, Chris Lalancette wrote: > Signed-off-by: Chris Lalancette > --- > src/hash.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/hash.c b/src/hash.c > index bde3a0b..9308c0c 100644 > --- a/src/hash.c > +++ b/src/hash.c > @@

Re: [libvirt] [PATCH] Fix up a whitespace in comments in src/console.c

2009-08-11 Thread Daniel P. Berrange
On Fri, Aug 07, 2009 at 11:06:14AM +0200, Chris Lalancette wrote: > Signed-off-by: Chris Lalancette > --- > src/console.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/console.c b/src/console.c > index badb62c..4a1a80b 100644 > --- a/src/console.c > +++ b/src

Re: [libvirt] [PATCH] Error path mutex unlock in virGetStorageVol.

2009-08-11 Thread Daniel P. Berrange
On Fri, Aug 07, 2009 at 11:06:15AM +0200, Chris Lalancette wrote: > Signed-off-by: Chris Lalancette > --- > src/datatypes.c |5 + > 1 files changed, 1 insertions(+), 4 deletions(-) > > diff --git a/src/datatypes.c b/src/datatypes.c > index 1889dc3..ac61682 100644 > --- a/src/datatypes.c

Re: [libvirt] [PATCH] Minor cleanup of error path for c_oneVmInfo.

2009-08-11 Thread Daniel P. Berrange
On Fri, Aug 07, 2009 at 11:06:19AM +0200, Chris Lalancette wrote: > Signed-off-by: Chris Lalancette > --- > src/opennebula/one_client.c | 16 ++-- > 1 files changed, 6 insertions(+), 10 deletions(-) > > diff --git a/src/opennebula/one_client.c b/src/opennebula/one_client.c > index

Re: [libvirt] [PATCH] Make openvzGetVPSUUID take a len.

2009-08-11 Thread Daniel P. Berrange
On Fri, Aug 07, 2009 at 11:06:20AM +0200, Chris Lalancette wrote: > Minor fix to openvzGetVPSUUID to make it take a length parameter. > This ensures that it doesn't make assumptions about the length > of the UUID buffer, and paves the way for removal of strncpy in > the future. > > Signed-off-by:

Re: [libvirt] [PATCH] Fix phyp escape_specialcharacters.

2009-08-11 Thread Daniel P. Berrange
On Fri, Aug 07, 2009 at 11:06:22AM +0200, Chris Lalancette wrote: > A couple of minor fixes to phyp escape_specialcharacters. Make it > a static function (since it's only used in phyp/phyp_driver.c), and > make it take a dstlen parameter. This paves the way for removing > strncpy in the future. >

  1   2   3   4   5   6   7   8   9   10   >