qemudDomainShutdown() currently doesn't free the returned reply from
qemudMonitorCommand().
Signed-off-by: Eduardo Habkost [EMAIL PROTECTED]
---
src/qemu_driver.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/qemu_driver.c b/src/qemu_driver.c
index 806608d..a88cb75
This patch implements reboot support on qemu_driver.
It is so simple that I am wondering if there is some problem I am missing,
that would be the reason it wasn't implemented yet. I hope not. :)
Signed-off-by: Eduardo Habkost [EMAIL PROTECTED]
---
src/qemu_driver.c | 23
On Tue, Oct 07, 2008 at 09:58:47PM +0100, Daniel P. Berrange wrote:
On Tue, Oct 07, 2008 at 05:55:37PM -0300, Eduardo Habkost wrote:
This patch implements reboot support on qemu_driver.
It is so simple that I am wondering if there is some problem I am missing,
that would be the reason
Hi,
On Thu, Sep 06, 2007 at 02:10:39PM +0100, Richard W.M. Jones wrote:
[Using `pahole' and friends - see
http://git.kernel.org/?p=linux/kernel/git/acme/pahole.git;a=summary and
https://ols2006.108.redhat.com/2007/Reprints/melo-Reprint.pdf ]
These are all on x86-64. You'll get slightly
Hi,
Sorry for the long message, but I didn't find a way to summarize the
questions and issues and make it shorter.
For people who don't know me: I have started to work recently on the
Qemu CPU model code. I have been looking at how things work on
libvirt+Qemu today w.r.t. CPU models, and I have
Thanks a lot for the explanations, Daniel.
Comments about specific items inline.
On Wed, Mar 07, 2012 at 02:18:28PM +, Daniel P. Berrange wrote:
I have two main points I would like to understand/discuss:
1) The relationship between libvirt's cpu_map.xml and the Qemu CPU model
On Wed, Mar 07, 2012 at 04:07:06PM -0700, Eric Blake wrote:
(Do we have any case of capability-querying being made using QMP before
starting any actual VM, today?)
Right now, we have two levels of queries - the 'qemu -help' and 'qemu
-device ?' output is gathered up front (we really
On Thu, Mar 08, 2012 at 02:41:54PM +0100, Jiri Denemark wrote:
On Wed, Mar 07, 2012 at 19:26:25 -0300, Eduardo Habkost wrote:
Awesome. So, if Qemu and libvirt disagrees, libvirt will know that and
add the necessary flags? That was my main worry. If disagreement between
Qemu and libvirt
Resurrecting an old thread:
I didn't see any clear conclusion in this thread (this is why I am
resurrecting it), except that many were arguing that libvirt should
simply copy and/or generate the CPU model definitions from Qemu. I
really don't think it's reasonable to expect that.
On Thu, Dec 15,
On Fri, Mar 09, 2012 at 03:15:26PM -0600, Anthony Liguori wrote:
On 03/09/2012 03:04 PM, Daniel P. Berrange wrote:
On Fri, Mar 09, 2012 at 05:56:52PM -0300, Eduardo Habkost wrote:
Resurrecting an old thread:
I didn't see any clear conclusion in this thread (this is why I am
resurrecting
On Sat, Mar 10, 2012 at 12:42:46PM +, Daniel P. Berrange wrote:
I could have sworn we had this discussion a year ago or so, and had decided
that the default CPU models would be in something like
/usr/share/qemu/cpu-x86_64.conf
and loaded regardless of the -nodefconfig setting.
On Sun, Mar 11, 2012 at 09:12:58AM -0500, Anthony Liguori wrote:
On 03/11/2012 08:27 AM, Gleb Natapov wrote:
On Sat, Mar 10, 2012 at 12:24:47PM -0600, Anthony Liguori wrote:
Let's step back here.
Why are you writing these patches? It's probably not because you
have a desire to say -cpu
On Sun, Mar 11, 2012 at 10:41:32AM -0500, Anthony Liguori wrote:
On 03/11/2012 10:12 AM, Gleb Natapov wrote:
On Sun, Mar 11, 2012 at 09:16:49AM -0500, Anthony Liguori wrote:
If libvirt assumes anything about what kvm actually supports it is
working only by sheer luck.
Well the simple answer
On Mon, Mar 12, 2012 at 03:15:32PM +0200, Gleb Natapov wrote:
On Mon, Mar 12, 2012 at 01:04:19PM +, Daniel P. Berrange wrote:
On Mon, Mar 12, 2012 at 09:52:27AM -0300, Eduardo Habkost wrote:
On Sun, Mar 11, 2012 at 09:12:58AM -0500, Anthony Liguori wrote:
On 03/11/2012 08:27 AM, Gleb
On Mon, Mar 12, 2012 at 09:48:11AM -0500, Anthony Liguori wrote:
On 03/11/2012 11:16 AM, Gleb Natapov wrote:
On Sun, Mar 11, 2012 at 10:33:15AM -0500, Anthony Liguori wrote:
On 03/11/2012 09:56 AM, Gleb Natapov wrote:
On Sun, Mar 11, 2012 at 09:12:58AM -0500, Anthony Liguori wrote:
-cpu best
On Mon, Mar 12, 2012 at 04:49:47PM +0100, Andreas Färber wrote:
Am 11.03.2012 17:16, schrieb Gleb Natapov:
On Sun, Mar 11, 2012 at 10:33:15AM -0500, Anthony Liguori wrote:
On 03/11/2012 09:56 AM, Gleb Natapov wrote:
On Sun, Mar 11, 2012 at 09:12:58AM -0500, Anthony Liguori wrote:
-cpu
On Mon, Mar 12, 2012 at 06:41:06PM +0100, Andreas Färber wrote:
Am 12.03.2012 17:50, schrieb Eduardo Habkost:
On Mon, Mar 12, 2012 at 04:49:47PM +0100, Andreas Färber wrote:
[...]
IMO interpreting an explicit -cpu parameter depending on -M would be
wrong. Changing the default CPU based
So, trying to summarize what was discussed in the call:
On Mon, Mar 12, 2012 at 10:08:10AM -0300, Eduardo Habkost wrote:
Let's say we moved CPU definitions to /usr/share/qemu/cpu-models.xml.
Obviously, we'd want a command line option to be able to change that
location so we'd introduce
, Eduardo Habkost wrote:
Resurrecting an old thread:
[...]
--
Eduardo
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Thu, Mar 22, 2012 at 11:32:44AM +0200, Gleb Natapov wrote:
On Tue, Mar 13, 2012 at 11:53:19AM -0300, Eduardo Habkost wrote:
So, trying to summarize what was discussed in the call:
On Mon, Mar 12, 2012 at 10:08:10AM -0300, Eduardo Habkost wrote:
Let's say we moved CPU definitions
On Thu, Mar 22, 2012 at 11:37:39AM -0500, Anthony Liguori wrote:
On 03/22/2012 04:32 AM, Gleb Natapov wrote:
On Tue, Mar 13, 2012 at 11:53:19AM -0300, Eduardo Habkost wrote:
So, this problem is solved if the defaults are easily found on
/usr/share.
What problem is solved and why are we
On Sun, Mar 25, 2012 at 12:19:13PM +0200, Gleb Natapov wrote:
(That's why I said that perhaps keymaps could become configuration
someday. Because maybe they can be converted to a key=value model
relatively easily)
Such whole sale approach is harmful since it starts to affect design
On Mon, Mar 26, 2012 at 02:03:21PM +0200, Gleb Natapov wrote:
On Mon, Mar 26, 2012 at 01:59:05PM +0200, Avi Kivity wrote:
On 03/26/2012 01:24 PM, Jiri Denemark wrote:
...
The command line becomes unstable if you use -nodefconfig.
-no-user-config solves this but I fully expect
On Sun, Mar 25, 2012 at 01:11:04PM -0500, Anthony Liguori wrote:
On 03/25/2012 10:40 AM, Avi Kivity wrote:
On 03/25/2012 05:26 PM, Anthony Liguori wrote:
Put the emphasis around *configuration*.
So how about:
1) Load ['@SYSCONFDIR@/qemu/qemu.cfg',
'@SYSCONFDIR@/qemu/target-@ARCH@.cfg',
More files will be added to the list, with additional attributes, later.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
arch_init.c | 25 -
1 files changed, 16 insertions(+), 9 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index 152cbbb..62332e9 100644
to previous discussion:
- http://marc.info/?l=qemu-develm=133278877315665
This series depends on the following:
Subject: [PATCH v5 00/14] configure: --with-confsuffix option
Message-Id: 1334778950-18660-1-git-send-email-ehabk...@redhat.com
Eduardo Habkost (5):
move code to read default config
Function added to arch_init.c because it depends on arch-specific
settings.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
arch_init.c | 18 ++
arch_init.h |4
vl.c| 10 ++
3 files changed, 24 insertions(+), 8 deletions(-)
diff --git
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
arch_init.c | 10 +++---
arch_init.h |2 +-
qemu-options.hx | 16 +---
vl.c|6 +-
4 files changed, 26 insertions(+), 8 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index 62332e9
Not needed anymore, as the code that uses the variable is already inside
arch_init.c.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
arch_init.c |3 +--
arch_init.h |2 --
2 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index 4008115
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
Makefile | 12 +++-
arch_init.c |1 +
sysconfigs/target/cpus-x86_64.conf | 128 ++
sysconfigs/target/target-x86_64.conf | 128
Not needed anymore, as the code that uses the variable is already inside
arch_init.c.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
arch_init.c |3 +--
arch_init.h |2 --
2 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index 4008115
More files will be added to the list, with additional attributes, later.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
arch_init.c | 25 -
1 files changed, 16 insertions(+), 9 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index 152cbbb..62332e9 100644
Changes v1 - v2:
- userconfig variable is now bool, not int
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
Makefile | 12 +++-
arch_init.c |1 +
sysconfigs/target/cpus-x86_64.conf | 128
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
vl.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/vl.c b/vl.c
index 1e5e593..a4f4676 100644
--- a/vl.c
+++ b/vl.c
@@ -2279,7 +2279,7 @@ int main(int argc, char **argv, char **envp)
#ifdef CONFIG_VNC
int
Function added to arch_init.c because it depends on arch-specific
settings.
Changes v1 - v2:
- Move qemu_read_default_config_file() prototype to qemu-config.h
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
arch_init.c | 18 ++
qemu-config.h |4
vl.c
Changes v1 - v2:
- Change 'userconfig' field/variables to bool instead of int
- Coding style change
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
arch_init.c | 11 ---
qemu-config.h |2 +-
qemu-options.hx | 16 +---
vl.c|6 +-
4
/share/qemu
/cpus-x86_64.conf file, with the CPU models we currently have on Qemu.
Reference to previous discussion:
- http://marc.info/?l=qemu-develm=133278877315665
Eduardo Habkost (6):
move code to read default config files to a separate function (v2)
eliminate arch_config_name variable
On Sat, Apr 28, 2012 at 07:53:41AM +, Blue Swirl wrote:
On Tue, Apr 24, 2012 at 20:32, Eduardo Habkost ehabk...@redhat.com wrote:
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
vl.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/vl.c b/vl.c
I changed everything on my previous patch to change 'defconfig', but
forgot to actually change the variable data type.
As the incomplete change doesn't cause any issues or compiler warnings,
I am simply sending this additional patch instead of respinning the
whole series.
Signed-off-by: Eduardo
Anthony, isn't this going to get in for 1.1? I was expecting it to be
applied before the freeze.
On Tue, Apr 24, 2012 at 05:32:55PM -0300, Eduardo Habkost wrote:
Changes v1 - v2:
- Move qemu_read_default_config_files() prototype to qemu-config.h
- Make defconfig and userconfig variable
On Wed, May 02, 2012 at 04:01:55PM +0200, Andreas Färber wrote:
Am 02.05.2012 15:50, schrieb Eduardo Habkost:
Anthony, isn't this going to get in for 1.1? I was expecting it to be
applied before the freeze.
You wrote you would respin it with s/int/bool/. :)
I sent an additional patch
More files will be added to the list, with additional attributes, later.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
arch_init.c | 25 -
1 files changed, 16 insertions(+), 9 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index 152cbbb..62332e9 100644
Not needed anymore, as the code that uses the variable is already inside
arch_init.c.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
arch_init.c |3 +--
arch_init.h |2 --
2 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index 4008115
Changes v1 - v2:
- Actually change the variable type declaration to 'bool'
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
vl.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/vl.c b/vl.c
index 1e5e593..eb3e088 100644
--- a/vl.c
+++ b/vl.c
@@ -2279,7 +2279,7
=qemu-develm=133278877315665
Eduardo Habkost (6):
move code to read default config files to a separate function (v2)
eliminate arch_config_name variable
move list of default config files to an array
vl.c: change 'defconfig' variable to bool (v2)
implement -no-user-config command-line
Changes v2 - v3:
- Rebase against latest qemu.git
Changes v1 - v2:
- Change 'userconfig' field/variables to bool instead of int
- Coding style change
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
arch_init.c | 11 ---
qemu-config.h |2 +-
qemu-options.hx | 16
Changes v1 - v2:
- userconfig variable is now bool, not int
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
Makefile | 12 +++-
arch_init.c |1 +
sysconfigs/target/cpus-x86_64.conf | 128
Function added to arch_init.c because it depends on arch-specific
settings.
Changes v1 - v2:
- Move qemu_read_default_config_file() prototype to qemu-config.h
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
arch_init.c | 18 ++
qemu-config.h |4
vl.c
,D
will _not_ work yet, as , is the option separator for the command-line
option parser, and it will require changing the -numa option parsing
code to handle cpus as a special case.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
vl.c | 14 +-
1 file changed, 13 insertions(+), 1
, and it would require changing the -numa option parsing
code to handle cpus as a special case.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
Changes v2:
- Use : as separator
- Document the new format
---
qemu-options.hx | 10 --
vl.c| 14 +-
2 files changed
On Fri, Feb 22, 2013 at 11:04:24AM +0100, Markus Armbruster wrote:
Markus Armbruster arm...@redhat.com writes:
Anthony Liguori anth...@codemonkey.ws writes:
Markus Armbruster arm...@redhat.com writes:
Eduardo Habkost ehabk...@redhat.com writes:
This allows , to be used a separator
On Mon, Feb 25, 2013 at 10:04:07PM +0100, Andreas Färber wrote:
Am 21.02.2013 21:57, schrieb Eduardo Habkost:
On Thu, Feb 21, 2013 at 09:23:22PM +0100, Markus Armbruster wrote:
Eduardo Habkost ehabk...@redhat.com writes:
This allows , to be used a separator between each CPU range. Note
On Tue, Feb 26, 2013 at 10:53:07AM +0100, Markus Armbruster wrote:
Eduardo Habkost ehabk...@redhat.com writes:
On Thu, Feb 21, 2013 at 09:23:22PM +0100, Markus Armbruster wrote:
Eduardo Habkost ehabk...@redhat.com writes:
This allows , to be used a separator between each CPU range
On Tue, Feb 26, 2013 at 11:50:08AM +0100, Markus Armbruster wrote:
Eduardo Habkost ehabk...@redhat.com writes:
This allows : to be used a separator between each CPU range, so the
command-line may look like:
-numa node,cpus=A-B:C-D
Note that the following format, currently used
On Tue, Feb 26, 2013 at 01:35:14PM -0600, Anthony Liguori wrote:
Eduardo Habkost ehabk...@redhat.com writes:
On Tue, Feb 26, 2013 at 11:50:08AM +0100, Markus Armbruster wrote:
Eduardo Habkost ehabk...@redhat.com writes:
This allows : to be used a separator between each CPU range, so
On Wed, Feb 27, 2013 at 09:42:50AM -0600, Anthony Liguori wrote:
Paolo Bonzini pbonz...@redhat.com writes:
Il 26/02/2013 20:35, Anthony Liguori ha scritto:
See also discussion on multi-valued keys in command line option
arguments and config files in v1 thread. Hopefully we can
On Wed, Feb 27, 2013 at 04:57:15PM +0100, Paolo Bonzini wrote:
Il 27/02/2013 16:42, Anthony Liguori ha scritto:
There's such thing as list support in QemuOpts. The only way
QemuOptsVisitor was able to implement it was to expose QemuOpts publicly
via options_int.h and rely on a
On Wed, Feb 27, 2013 at 05:58:39PM +0100, Paolo Bonzini wrote:
Il 27/02/2013 17:19, Eduardo Habkost ha scritto:
If it is meant as a prototype only, and the final command-line syntax
would be with repeated keys, that's okay. I think that Eduardo/Markus/I
are focusing on the user
On Wed, Feb 27, 2013 at 11:04:08AM -0600, Anthony Liguori wrote:
Eduardo Habkost ehabk...@redhat.com writes:
On Wed, Feb 27, 2013 at 04:57:15PM +0100, Paolo Bonzini wrote:
Il 27/02/2013 16:42, Anthony Liguori ha scritto:
There's such thing as list support in QemuOpts. The only way
On Fri, Mar 01, 2013 at 02:12:38PM +0100, Jiri Denemark wrote:
On Thu, Feb 21, 2013 at 11:58:18 -0300, Eduardo Habkost wrote:
Hi,
After a long time trying to figure out the proper modelling inside QEMU,
I believe the plans are now clearer in QEMU, so it's time to coordinate
more
On Fri, Mar 01, 2013 at 02:28:37PM +0100, Jiri Denemark wrote:
On Thu, Feb 21, 2013 at 11:58:18 -0300, Eduardo Habkost wrote:
= Querying host capabilities =
Requirement: libvirt needs to know which feature can really be enabled,
before
it tries to start a VM, and before it tries
On Fri, Mar 01, 2013 at 07:31:46PM +0100, Andreas Färber wrote:
Am 01.03.2013 14:12, schrieb Jiri Denemark:
On Thu, Feb 21, 2013 at 11:58:18 -0300, Eduardo Habkost wrote:
= Listing CPU models =
Requirement: libvirt needs to know which CPU models are available to be
used
with the -cpu
On Fri, Mar 01, 2013 at 06:34:31PM +, Daniel P. Berrange wrote:
On Fri, Mar 01, 2013 at 07:31:46PM +0100, Andreas Färber wrote:
Am 01.03.2013 14:12, schrieb Jiri Denemark:
On Thu, Feb 21, 2013 at 11:58:18 -0300, Eduardo Habkost wrote:
= Listing CPU models =
Requirement: libvirt
On Fri, Mar 01, 2013 at 11:56:00PM +0100, Jiri Denemark wrote:
[...]
= Getting information about CPU models =
Requirement: libvirt uses the predefined CPU models from QEMU, but it
needs to
be able to query for CPU model details, to find out how it can create a
VM that
of missing host capabilities (to allow libvirt to implement enforce
mode in a more reliable way).
Eduardo Habkost (4):
target-i386: Add ECX information to FeatureWordInfo
target-i386: Move feature word array outside get_register_name_32()
target-i386: Add feature-words property
target-i386
FEAT_7_0_EBX uses ECX as input, so we have to take that into account
when reporting feature word values.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
[7].cpuid-register: EDX
item[7].cpuid-input-eax: 2147483658
item[7].features: 0
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
* This is the solution not using qapi. The next patch will introduce a
solution using qapi, so both approaches can get feedback.
* Current solution
The array will be used by the feature-words properties to output the
register enum value.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.c | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
On Mon, Apr 01, 2013 at 04:46:47PM -0300, Eduardo Habkost wrote:
The array will be used by the feature-words properties to output the
register enum value.
Oops, the patch subject line is wrong: it was supposed to say Move
register name array.
Signed-off-by: Eduardo Habkost ehabk
item[7].cpuid-register: EDX
item[7].cpuid-input-eax: 1
item[7].features: 126614521
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
Changes v1 - v2:
* Merge the non-qapi and qapi patches, to keep series simpler
* Use the feature word array series as base, so we don't have
to set
item[7].cpuid-register: EDX
item[7].cpuid-input-eax: 1
item[7].features: 0
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 64e5570..0dceaf2
FEAT_7_0_EBX uses ECX as input, so we have to take that into account
when reporting feature word values.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
].cpuid-register: EAX
item[6].cpuid-input-eax: 1073741825
item[6].features: 0
item[7].cpuid-register: EDX
item[7].cpuid-input-eax: 2147483658
item[7].features: 0
Eduardo Habkost (5):
target-i386: Add ECX information to FeatureWordInfo
target-i386: Add feature-words property
target
Instead of open-coding the filtering code for each feature word, change
the existing code to use the feature_word_info array, that have exactly
the same CPUID eax/ecx/register values for each feature word.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.c | 24
This field will contain the feature bits that were filtered out because
of missing host support.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu-qom.h | 3 +++
target-i386/cpu.c | 9 ++---
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/target-i386
Instead of open-coding the filtering code for each feature word, change
the existing code to use the feature_word_info array, that have exactly
the same CPUID eax/ecx/register values for each feature word.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.c | 24
the required set of CPU features, as
configured by the user.
Eduardo Habkost (9):
target-i386: cleanup: Group together level, xlevel, xlevel2 fields
target-i386/kvm.c: Code formatting changes
target-i386/cpu.c: Break lines so they don't get too long
target-i386: Replace cpuid_*features fields
item[7].cpuid-register: EDX
item[7].cpuid-input-eax: 1
item[7].features: 126614521
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
Changes v1 - v2:
* Merge the non-qapi and qapi patches, to keep series simpler
* Use the feature word array series as base, so we don't have
to set
item[7].cpuid-register: EDX
item[7].cpuid-input-eax: 1
item[7].features: 0
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 1178c5f..5bcb79c
FEAT_7_0_EBX uses ECX as input, so we have to take that into account
when reporting feature word values.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
Consolidate level, xlevel, xlevel2 fields in x86_def_t and CPUX86State.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
Reviewed-By: Igor Mammedov imamm...@redhat.com
---
Changes v9:
* Merged target-i386: Move cpuid_xlevel, cpuid_xlevel2 fields in X86CPU
and target-i386: Move xlevel
Add appropriate spaces around operators, and break line where it needs
to be broken to allow feature-words array to be introduced without
having too-long lines.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
Reviewed-By: Igor Mammedov imamm...@redhat.com
---
Changes v9:
* 1-char alignment
Break lines on kvm_check_features_against_host(), kvm_cpu_fill_host(),
and builtin_x86_defs, so they don't get too long once the *_features
fields are replaced by an array.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
Reviewed-By: Igor Mammedov imamm...@redhat.com
---
Changes v9:
* Merged
This field will contain the feature bits that were filtered out because
of missing host support.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu-qom.h | 3 +++
target-i386/cpu.c | 9 ++---
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/target-i386
On Mon, Apr 22, 2013 at 02:37:06PM -0600, Eric Blake wrote:
On 04/22/2013 01:00 PM, Eduardo Habkost wrote:
This property will be useful for libvirt, as libvirt already has logic
based on low-level feature bits (not feature names), so it will be
really easy to convert the current libvirt
(CCing libvir-list)
On Tue, Apr 30, 2013 at 08:34:01AM +0200, Igor Mammedov wrote:
Adds cpu-add id=xxx QMP command.
cpu-add's id argument is a CPU number in a range [0..max-cpus)
Example QMP command:
- { execute: cpu-add, arguments: { id: 2 } }
- { return: {} }
Signed-off-by: Igor
On Thu, May 02, 2013 at 01:03:01AM +0200, Andreas Färber wrote:
Am 22.04.2013 21:00, schrieb Eduardo Habkost:
This replaces the feature-bit fields on both X86CPU and x86_def_t
structs with an array.
With this, we will be able to simplify code that simply does the same
operation on all
On Thu, May 02, 2013 at 12:53:33AM +0200, Andreas Färber wrote:
Eduardo Habkost (9):
target-i386: cleanup: Group together level, xlevel, xlevel2 fields
target-i386/kvm.c: Code formatting changes
target-i386/cpu.c: Break lines so they don't get too long
target-i386: Replace cpuid_
On Fri, May 03, 2013 at 01:34:23PM +0200, Igor Mammedov wrote:
On Mon, 22 Apr 2013 16:00:17 -0300
Eduardo Habkost ehabk...@redhat.com wrote:
This property will be useful for libvirt, as libvirt already has logic
based on low-level feature bits (not feature names), so it will be
really
On Fri, May 03, 2013 at 05:16:46PM +0200, Andreas Färber wrote:
Am 22.04.2013 21:00, schrieb Eduardo Habkost:
FEAT_7_0_EBX uses ECX as input, so we have to take that into account
when reporting feature word values.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386
item[7].cpuid-register: EDX
item[7].cpuid-input-eax: 1
item[7].features: 126614521
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
Reviewed-by: Eric Blake ebl...@redhat.com
---
Changes v11 - v12:
* Remove unnecessary entries from .gitignore
* Fix indentation of x86_cpu_get_feature_words
item[7].cpuid-register: EDX
item[7].cpuid-input-eax: 1
item[7].features: 0
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
Reviewed-by: Eric Blake ebl...@redhat.com
---
Changes v11 - v12:
* Rebase on top of qom-cpu-next
(commit bd87d2a - target-i386: Use FeatureWord loop
())
Git tree for reference:
git://github.com/ehabkost/qemu-hacks.git work/cpu-raw-features.v12
Eduardo Habkost (3):
target-i386: Add feature-words property
target-i386: Introduce X86CPU.filtered_features field
target-i386: Add filtered-features property to X86CPU
Makefile.objs
This field will contain the feature bits that were filtered out because
of missing host support.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
Reviewed-by: Eric Blake ebl...@redhat.com
---
Changes v11 - v12:
* Rebase on top of qom-cpu-next
(commit bd87d2a - target-i386: Use FeatureWord
(CCing libvirt people)
On Tue, May 28, 2013 at 06:48:52PM +0200, Andreas Färber wrote:
Am 28.05.2013 18:46, schrieb Paolo Bonzini:
Il 28/05/2013 18:34, Bandan Das ha scritto:
Eduardo Habkost ehabk...@redhat.com writes:
On Mon, May 27, 2013 at 02:21:36PM +0200, Paolo Bonzini wrote:
Il
On Mon, Jul 22, 2013 at 07:24:24PM +0800, Peter Huang(Peng) wrote:
Hi, Everyone
I have been encountered a problem recently.
My box uses Nehalem E5520 CPU, and this model doesn't support x2apic feature.
I created a VM on KVM, and uses cpu mode=pass-through, I can get the right cpu
model from
On Tue, Jul 23, 2013 at 05:19:03PM +0100, Daniel P. Berrange wrote:
On Tue, Jul 23, 2013 at 06:11:35PM +0200, Jiri Denemark wrote:
Since QEMU and kvm may filter some host CPU features or add efficiently
emulated features, asking QEMU binary for host CPU data provides
better results when we
On Tue, Jul 23, 2013 at 07:32:46PM +0200, Jiri Denemark wrote:
On Tue, Jul 23, 2013 at 19:28:38 +0200, Jiri Denemark wrote:
On Tue, Jul 23, 2013 at 17:32:42 +0100, Daniel Berrange wrote:
On Tue, Jul 23, 2013 at 06:11:33PM +0200, Jiri Denemark wrote:
---
src/qemu/qemu_monitor.c
On Wed, Jul 24, 2013 at 11:03:03AM +0100, Daniel P. Berrange wrote:
On Tue, Jul 23, 2013 at 07:28:38PM +0200, Jiri Denemark wrote:
On Tue, Jul 23, 2013 at 17:32:42 +0100, Daniel Berrange wrote:
On Tue, Jul 23, 2013 at 06:11:33PM +0200, Jiri Denemark wrote:
---
On Thu, Jul 25, 2013 at 10:45:10AM +0100, Daniel P. Berrange wrote:
On Wed, Jul 24, 2013 at 03:25:19PM -0300, Eduardo Habkost wrote:
On Tue, Jul 23, 2013 at 07:32:46PM +0200, Jiri Denemark wrote:
On Tue, Jul 23, 2013 at 19:28:38 +0200, Jiri Denemark wrote:
On Tue, Jul 23, 2013 at 17:32
1 - 100 of 722 matches
Mail list logo
