[libvirt] [Question] vhost-user hotplug: multiqueue hotplug seems doesn't pass mq and vectors

2016-11-29 Thread Gaohaifeng (A)
Hi ALL: Recently I review the vhost-user hotplug codes, when attach a vhost-user nic with multiqueue, it seems that it doesn't pass mq=on and vectors num to qemu. Is there any special consideration or just a small mistake? Parts of codes: qemuDomainAttachNetDevice(vhostfdSize is 0 when type is vh

Re: [libvirt] [Question] vhost-user hotplug: multiqueue hotplug seems doesn't pass mq and vectors

2016-11-30 Thread Gaohaifeng (A)
INT32("vectors", VirtIOPCIProxy, nvectors, 3)) So that qemu init msix table with 3 vectors(qemu function: msix_init_exclusive_bar), this will cause Guest can only use 3 interrupts at most. Actually, it use Two, one for config one for other virtqueues. > On 30.11.2016 08:41, Gaohaifeng

Re: [libvirt] [Question] vhost-user hotplug: multiqueue hotplug seems doesn't pass mq and vectors

2016-11-30 Thread Gaohaifeng (A)
OK. I will try to provide a patch. On 30.11.2016 10:02, Gaohaifeng (A) wrote: > I think we should pass it. Two reasons: > 1. in none hotplug, we will pass it. We can see from libvirt function > qemuBuildVhostuserCommandLine, it will pass queue num as vhostfdSize > 2. If we don&#x