Re: [libvirt] [PATCH 2/2] qemu: allow multiple buses in PCI address alocation

2013-02-22 Thread Ján Tomko
On 02/21/13 17:12, Laine Stump wrote: On 02/15/2013 03:22 AM, Ján Tomko wrote: Allow allocating addresses with non-zero bus numbers. while not actually allowing it :-) (since maxbus is never set to anything 0, as you say in Patch 0/2). How/when do you envision that being changed? liguang's

Re: [libvirt] [PATCH 5/5] storage: qemu-img: change INFO to DEBUG

2013-02-24 Thread Ján Tomko
On 02/22/13 14:28, John Ferlan wrote: On 02/18/2013 09:27 AM, Ján Tomko wrote: For really old qemu-img binaries which do not support specifying the format of the backing file, display a DEBUG message instead of INFO that this can't be done. --- src/storage/storage_backend.c | 4 ++-- 1

[libvirt] [PATCH] qemu: enable direct migration over IPv6

2013-02-25 Thread Ján Tomko
Use virURIParse in qemuMigrationPrepareDirect to allow parsing IPv6 addresses, which would cause an 'incorrect :port' error message before. To be able to migrate over IPv6, QEMU needs to listen on [::] instead of 0.0.0.0. This patch adds a call to getaddrinfo and sets the listen address based on

Re: [libvirt] [PATCH] qemu: enable direct migration over IPv6

2013-02-26 Thread Ján Tomko
Sorry, I only noticed your reply today. On 02/19/13 17:36, John Ferlan wrote: On 02/15/2013 05:13 AM, Peter Krempa wrote: On 02/15/13 11:00, Ján Tomko wrote: Use virURIParse in qemuMigrationPrepareDirect to allow parsing IPv6 addresses, which would cause an 'incorrect :port' error message

[libvirt] [PATCH] libvirt: fix error message when connection can't be opened

2013-02-26 Thread Ján Tomko
VIR_ERR_NO_CONNECT already contains no connection driver available. This patch changes: no connection driver available for No connection for URI hello to: no connection driver available for hello Bug: https://bugzilla.redhat.com/show_bug.cgi?id=851413 --- src/libvirt.c | 2 +- 1 file changed, 1

[libvirt] [PATCH] qemu: fix graphics port allocation

2013-02-26 Thread Ján Tomko
Right now, we allocate a port or a TLS port for SPICE if it's set to -1, even if autoport is off. But we only free them if autoport is on. With autoport on, we only allocate TLS port if cfg-spiceTLS is set, but we free it even if it's not, leading to an error message. This patch separates the

Re: [libvirt] [PATCH] libvirt: fix error message when connection can't be opened

2013-02-26 Thread Ján Tomko
On 02/26/13 13:45, Eric Blake wrote: On 02/26/2013 05:05 AM, Ján Tomko wrote: VIR_ERR_NO_CONNECT already contains no connection driver available. This patch changes: no connection driver available for No connection for URI hello to: no connection driver available for hello Bug: https

[libvirt] [PATCH] tests: fix leaks in storagevolxml2argvtest

2013-02-27 Thread Ján Tomko
Reported by John Ferlan. --- tests/storagevolxml2argvtest.c | 4 1 file changed, 4 insertions(+) diff --git a/tests/storagevolxml2argvtest.c b/tests/storagevolxml2argvtest.c index 416bb6f..77ba800 100644 --- a/tests/storagevolxml2argvtest.c +++ b/tests/storagevolxml2argvtest.c @@ -89,6

Re: [libvirt] [PATCH] tests: fix leaks in storagevolxml2argvtest

2013-02-27 Thread Ján Tomko
On 02/27/13 10:23, Peter Krempa wrote: On 02/27/13 10:18, Ján Tomko wrote: Reported by John Ferlan. --- tests/storagevolxml2argvtest.c | 4 1 file changed, 4 insertions(+) ACK. Peter Thanks, pushed now. Jan -- libvir-list mailing list libvir-list@redhat.com https

[libvirt] [PATCHv2] qemu: fix graphics port allocation

2013-02-27 Thread Ján Tomko
Only release ports that have been allocated before. This fixes these issues: * trying to release ports when qemuProcessStart fails before port allocation * trying to release the SPICE TLS port if spice_tls is 0 * failing to release SPICE port with autoport=off (when only one of them is -1)

Re: [libvirt] [PATCHv2] qemu: fix graphics port allocation

2013-02-28 Thread Ján Tomko
On 02/28/13 00:17, Eric Blake wrote: On 02/27/2013 04:51 AM, Ján Tomko wrote: Only release ports that have been allocated before. This fixes these issues: * trying to release ports when qemuProcessStart fails before port allocation * trying to release the SPICE TLS port if spice_tls is 0

Re: [libvirt] [PATCH] qemu: enable direct migration over IPv6

2013-03-01 Thread Ján Tomko
(Replying to myself to correct some mistakes) On 02/26/13 11:56, Ján Tomko wrote: On 02/19/13 17:36, John Ferlan wrote: On 02/15/2013 05:13 AM, Peter Krempa wrote: On 02/15/13 11:00, Ján Tomko wrote: } } +if (getaddrinfo(hostname, NULL, NULL, info

[libvirt] [RFC] qcow3 format in libvirt

2013-03-04 Thread Ján Tomko
Before posting another version of my patches [1], attempting to add support for the new qcow format to libvirt, I would like to know if this sounds reasonable: A new format named 'qcow3' would be added, along with a features sub-element for target. volume nameqcow3test/name source /source

Re: [libvirt] [PATCH v4 4/4] auto-create pci-bridge controller info

2013-03-04 Thread Ján Tomko
On 02/19/13 03:25, liguang wrote: if some devices specify a pci bus number that haven't been defined by a pci-bridge controller then fill the required correct controller info silently. Acked-by: Daniel P. Berrange berra...@redhat.com Signed-off-by: liguang lig.f...@cn.fujitsu.com ---

Re: [libvirt] [PATCH v4 4/4] auto-create pci-bridge controller info

2013-03-05 Thread Ján Tomko
On 03/04/13 20:39, Laine Stump wrote: On 03/04/2013 11:51 AM, Ján Tomko wrote: This will only add bridges for the explictly mentioned buses, which would mean we could have buses 0 and 6 with no buses between them. Maybe we should add them the way we add disk controllers - find the highest

Re: [libvirt] [PATCH v4 4/4] auto-create pci-bridge controller info

2013-03-06 Thread Ján Tomko
On 03/05/13 11:36, Daniel P. Berrange wrote: On Mon, Mar 04, 2013 at 02:39:40PM -0500, Laine Stump wrote: On 03/04/2013 11:51 AM, Ján Tomko wrote: It would be nice if we could add pci bridges even when there weren't any specified in the XML, but there are too many PCI devices. I don't know

[libvirt] [PATCH] virsh: fix snapshot-create with no xmlfile

2013-03-11 Thread Ján Tomko
Properly check the return value of vshCommandOptStringReq for xmlfile: * error out on incorrect input (--xmlfile '') * use default XML domainsnapshot/ with no --xmlfile specified (Broken by commit b2e8585) Bug: https://bugzilla.redhat.com/show_bug.cgi?id=919826 --- tools/virsh-snapshot.c | 4

Re: [libvirt] [PATCH] virsh: fix snapshot-create with no xmlfile

2013-03-11 Thread Ján Tomko
On 03/11/13 13:48, Peter Krempa wrote: On 03/11/13 13:40, Ján Tomko wrote: Properly check the return value of vshCommandOptStringReq for xmlfile: * error out on incorrect input (--xmlfile '') * use default XML domainsnapshot/ with no --xmlfile specified (Broken by commit b2e8585) Bug

Re: [libvirt] [Qemu-devel] [RFC] qcow3 format in libvirt

2013-03-11 Thread Ján Tomko
On 03/04/2013 04:40 PM, Kevin Wolf wrote: Am 04.03.2013 um 16:19 hat Daniel P. Berrange geschrieben: On Mon, Mar 04, 2013 at 04:05:50PM +0100, Kevin Wolf wrote: I'm not talking about the QEMU cli, but about qcow2 as the format as defined in the spec (which just happens to sit in qemu.git, but

[libvirt] IPv6 migration

2013-03-11 Thread Ján Tomko
Hello. We can only tell QEMU on the destination to listen either on IPv6 or on IPv4. If we're supplied with a numeric v6 address, that's the only thing we need to know to set the listen address to [::]. For hostnames, we can either assume this based on how it resolves by default on the

Re: [libvirt] [PATCH v4 4/4] auto-create pci-bridge controller info

2013-03-11 Thread Ján Tomko
On 03/04/2013 08:39 PM, Laine Stump wrote: On 03/04/2013 11:51 AM, Ján Tomko wrote: On 02/19/13 03:25, liguang wrote: if some devices specify a pci bus number that haven't been defined by a pci-bridge controller then fill the required correct controller info silently. Acked-by: Daniel P

[libvirt] [PATCH] Fix size probing for VDI images

2013-03-14 Thread Ján Tomko
Commit 027bf2ea used the wrong offset: the text field at the start of the header has 64 bytes, not 68. [1] Bug: https://bugzilla.redhat.com/show_bug.cgi?id=921452 [1] https://forums.virtualbox.org/viewtopic.php?p=29267#p29267 --- Relevant for v1.0.3-maint. src/util/virstoragefile.c | 2 +- 1

Re: [libvirt] [PATCH] Fix size probing for VDI images

2013-03-14 Thread Ján Tomko
On 03/14/2013 02:57 PM, Martin Kletzander wrote: On 03/14/2013 01:45 PM, Ján Tomko wrote: Commit 027bf2ea used the wrong offset: the text field at the start of the header has 64 bytes, not 68. [1] Bug: https://bugzilla.redhat.com/show_bug.cgi?id=921452 [1] https://forums.virtualbox.org

[libvirt] [PATCHv4 1/2] rpc: add virNetSocketNewConnectTCPHints

2013-03-21 Thread Ján Tomko
Just like virNetSocketNewConnectTCP, but it has one extra parameter specifying the address family. --- src/libvirt_private.syms | 1 + src/rpc/virnetsocket.c | 9 + src/rpc/virnetsocket.h | 4 3 files changed, 14 insertions(+) diff --git a/src/libvirt_private.syms

[libvirt] [PATCHv4 0/2] allow migration over IPv6

2013-03-21 Thread Ján Tomko
Diff to v3: Use VIR_MIGRATE_IPV6 flag instead of trying to automagically guess if we should use IPv6 or IPv4. v3: https://www.redhat.com/archives/libvir-list/2013-February/msg01379.html Ján Tomko (2): rpc: add virNetSocketNewConnectTCPHints qemu: allow migration over IPv6 include/libvirt

[libvirt] [PATCHv4 2/2] qemu: allow migration over IPv6

2013-03-21 Thread Ján Tomko
Add VIR_MIGRATE_IPV6 flag which allows QEMU migration over IPv6 by specifying a hostname. If this flag is specified (or the migrate URI contains a numeric v6 address), we tell QEMU to listen on [::] instead of 0.0.0.0. The same listen address is used for the NBD server. Use virURIParse in

Re: [libvirt] IPv6 migration

2013-03-21 Thread Ján Tomko
On 03/21/2013 11:52 AM, Daniel P. Berrange wrote: On Tue, Mar 19, 2013 at 03:21:31PM +0100, Jiri Denemark wrote: On Mon, Mar 11, 2013 at 19:40:52 +0100, Ján Tomko wrote: ... Yeah, I think using an explicit flag would be the best approach. As we learnt several times, implementing automagic

Re: [libvirt] [PATCH] Correct invalid RNG schemas.

2013-03-21 Thread Ján Tomko
On 03/21/2013 04:28 PM, Martin Kletzander wrote: The 'trang' utility, which is able to transform '.rng' files into '.rnc' files, reported some errors in our schemas that weren't caught by the tools we use in the build. I haven't added a test for this, but the validity can be checked by the

[libvirt] [PATCH] virsh: don't print --(null) in vol-name and vol-pool

2013-03-22 Thread Ján Tomko
Don't print the pool option name if it's null. Before: virsh # vol-name vol error: failed to get vol 'vol', specifying --(null) might help error: Storage volume not found: no storage vol with matching path vol After: virsh # vol-name vol error: failed to get vol 'vol' error: Storage volume not

[libvirt] [PATCH] util: fix virAllocVar's comment

2013-03-22 Thread Ján Tomko
--- Pushed under the trivial rule. src/util/viralloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/viralloc.c b/src/util/viralloc.c index 342b0eb..8f219bf 100644 --- a/src/util/viralloc.c +++ b/src/util/viralloc.c @@ -389,7 +389,7 @@ virDeleteElementsN(void

Re: [libvirt] [PATCH] virsh: don't print --(null) in vol-name and vol-pool

2013-03-22 Thread Ján Tomko
On 03/22/2013 12:58 PM, Michal Privoznik wrote: On 22.03.2013 12:51, Ján Tomko wrote: Don't print the pool option name if it's null. Before: virsh # vol-name vol error: failed to get vol 'vol', specifying --(null) might help error: Storage volume not found: no storage vol with matching path

[libvirt] [PATCH v5] qemu: Allow migration over IPv6

2013-03-22 Thread Ján Tomko
Allow migration over IPv6 by listening on [::] instead of 0.0.0.0 when QEMU supports it (QEMU_CAPS_IPV6_MIGRATION) and there is at least one v6 address configured on the system. Use virURIParse in qemuMigrationPrepareDirect to allow parsing IPv6 addresses, which would cause an 'incorrect :port'

[libvirt] [PATCH] virsh: error out on non-numeric timeout values

2013-03-26 Thread Ján Tomko
Some block commands and migrate ignored incorrect values. Bug: https://bugzilla.redhat.com/show_bug.cgi?id=927495 --- tools/virsh-domain.c | 48 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/tools/virsh-domain.c

Re: [libvirt] [PATCH v2] qemu: Don't set address type too early during virtio disk hotplug

2013-03-26 Thread Ján Tomko
On 03/22/2013 06:52 PM, Guido Günther wrote: f946462e14ac036357b7c11ce5c23f94a3ee4e49 changed behavior by settings VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI upfront. If we do so before invoking qemuDomainPCIAddressEnsureAddr we merely try to set the PCI slot via qemuDomainPCIAddressReserveSlot

Re: [libvirt] [PATCH] virsh: error out on non-numeric timeout values

2013-03-26 Thread Ján Tomko
On 03/26/2013 05:18 PM, Eric Blake wrote: On 03/26/2013 09:44 AM, Ján Tomko wrote: Some block commands and migrate ignored incorrect values. Bug: https://bugzilla.redhat.com/show_bug.cgi?id=927495 --- tools/virsh-domain.c | 48 1 file

[libvirt] [PATCH] nodedev: invert virIsCapableFCHost return value

2013-03-28 Thread Ján Tomko
Both virIsCapableFCHost and virIsCapableVport return 0 when the respective sysfs path is accessible. --- src/node_device/node_device_linux_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/node_device/node_device_linux_sysfs.c

[libvirt] [PATCH] virsh: don't call virSecretFree on NULL

2013-03-29 Thread Ján Tomko
Since the refactoring in fbe2d49 we call virSecretFree even if virSecretDefineXML fails, which leads to overwriting the error message with: error: Invalid secret: virSecretFree Bug: https://bugzilla.redhat.com/show_bug.cgi?id=929045 --- tools/virsh-secret.c | 3 ++- 1 file changed, 2

Re: [libvirt] [PATCH] virsh: don't call virSecretFree on NULL

2013-03-29 Thread Ján Tomko
On 03/29/2013 01:10 PM, Peter Krempa wrote: On 03/29/13 13:04, Ján Tomko wrote: Since the refactoring in fbe2d49 we call virSecretFree even if virSecretDefineXML fails, which leads to overwriting the error message with: error: Invalid secret: virSecretFree Bug: https://bugzilla.redhat.com

Re: [libvirt] [PATCH v5] qemu: Allow migration over IPv6

2013-04-02 Thread Ján Tomko
On 04/02/2013 01:29 PM, Daniel P. Berrange wrote: On Fri, Mar 22, 2013 at 08:06:00PM +0100, Ján Tomko wrote: Allow migration over IPv6 by listening on [::] instead of 0.0.0.0 when QEMU supports it (QEMU_CAPS_IPV6_MIGRATION) and there is at least one v6 address configured on the system

Re: [libvirt] [PATCH] virsh: Call virDomainFree in cmdDomFSTrim

2013-04-02 Thread Ján Tomko
On 04/02/2013 05:20 PM, Michal Privoznik wrote: The virsh domfstrim command was not freeing allocated domain, leaving leaked references behind. --- tools/virsh-domain.c | 2 ++ 1 file changed, 2 insertions(+) You could add the public bugzilla link to the commit message too:

[libvirt] [PATCH 1/7] qemu: QEMU_PCI constant consistency

2013-04-03 Thread Ján Tomko
Change QEMU_PCI_ADDRESS_LAST_SLOT to the number of slots in the bus, not the maximum slot value, to match QEMU_PCI_ADDRESS_LAST_FUNCTION. --- src/qemu/qemu_command.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index

[libvirt] [PATCH 0/7] qemu: PCI bridge support

2013-04-03 Thread Ján Tomko
://www.redhat.com/archives/libvir-list/2013-February/msg00793.html Ján Tomko (5): qemu: QEMU_PCI constant consistency qemu: move PCI address check out of qemuPCIAddressAsString qemu: switch PCI address set from hash table to an array qemu: Add support for plugging devices into PCI bridges qemu: auto

[libvirt] [PATCH 2/7] qemu: move PCI address check out of qemuPCIAddressAsString

2013-04-03 Thread Ján Tomko
Move bus and domain checks from qemuPCIAddressAsString to a separate function and add a check for function and slot so that we can switch from a hash table to an array. Remove redundant checks in qemuBuildDeviceAddressStr. --- src/qemu/qemu_command.c | 111

[libvirt] [PATCH 4/7] add pci-bridge controller type

2013-04-03 Thread Ján Tomko
From: liguang lig.f...@cn.fujitsu.com add a new controller type, then one can define a pci-bridge controller like this: controller type='pci-bridge' index='0'/ controller type='pci-bridge' index='1' address type='pci' domain='0x' bus='0x00' slot='0x05' function='0x0'/

[libvirt] [PATCH 3/7] qemu: switch PCI address set from hash table to an array

2013-04-03 Thread Ján Tomko
Each bus (just one so far) is represented by an array with 32 slots where each slot is stored as an 8-bit integer where each bit represents a function. This makes operations with whole slots easier. --- src/qemu/qemu_command.c | 152 +++- 1 file

[libvirt] [PATCH 7/7] qemu: auto-add and use bridges

2013-04-03 Thread Ján Tomko
Add a dry run address allocation to figure out how many bridges will be needed for all the devices without explicit addresses. Auto-add just enough bridges to put all the devices on, or up to the bridge with the largest specified index. --- src/qemu/qemu_command.c | 138

[libvirt] [PATCH 5/7] qemu: build command line for pci-bridge device

2013-04-03 Thread Ján Tomko
From: liguang lig.f...@cn.fujitsu.com --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 15 ++- tests/qemuhelptest.c | 21 ++--- 4 files changed, 31 insertions(+), 8 deletions(-) diff --git

[libvirt] [PATCH 6/7] qemu: Add support for plugging devices into PCI bridges

2013-04-03 Thread Ján Tomko
Allow specifying addresses with non-zero buses in the XML. Check that the bridge topology results in their indexes matching the PCI buses they provide. --- src/qemu/qemu_command.c | 207 +--- src/qemu/qemu_command.h | 3 +- 2 files changed, 196

Re: [libvirt] [PATCH] storage: Fix volume cloning for logical volume.

2013-04-04 Thread Ján Tomko
On 04/04/2013 07:15 AM, Atsushi Kumagai wrote: When creating a logical volume with virStorageVolCreateXMLFrom, qemu-img convert is called internally if clonevol is a file volume. Then, vol-target.format is used as output_fmt parameter but the target.format of logical volumes is always 0

Re: [libvirt] [PATCH 06/18] Rename virCgroupMounted to virCgroupHasController make it more robust

2013-04-08 Thread Ján Tomko
On 04/04/2013 03:40 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The virCgroupMounted method is badly named, since a controller can be mounted, but disabled in the current object. Rename the method to be virCgroupHasController. Also make it tolerant to a NULL

Re: [libvirt] [PATCH] Add error handling to optional arguments in cmdCPUStats

2013-04-08 Thread Ján Tomko
On 04/05/2013 10:40 PM, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=907732 Also added informational message when count value is larger than number of CPUs present. Original code commit '31047e2b' quietly changes it and continues on. Prior to this patch, no errors were

Re: [libvirt] [PATCH 0/3] Un-break s390 default network model and clean up obsolete

2013-04-09 Thread Ján Tomko
On 04/05/2013 12:12 PM, Peter Krempa wrote: This series fixes the default network model for s390 that was broken by the recent addition of post parse close callbacks and cleans up code obsoleted by that addition. Peter Krempa (2): qemu: Clean up network device CLI generator qemu:

[libvirt] [PATCH] docs: use MiB/s instead of Mbps for migration speed

2013-04-09 Thread Ján Tomko
https://bugzilla.redhat.com/show_bug.cgi?id=948821 --- src/libvirt.c | 24 tools/virsh.pod | 4 ++-- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index cef9f1f..c5221f5 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@

Re: [libvirt] [PATCH] docs: use MiB/s instead of Mbps for migration speed

2013-04-09 Thread Ján Tomko
On 04/09/2013 04:44 PM, Eric Blake wrote: On 04/09/2013 08:29 AM, Ján Tomko wrote: https://bugzilla.redhat.com/show_bug.cgi?id=948821 --- src/libvirt.c | 24 tools/virsh.pod | 4 ++-- 2 files changed, 14 insertions(+), 14 deletions(-) ACK. Thank you, pushed

[libvirt] [PATCH] conf: fix error for parallel port mismatch

2013-04-11 Thread Ján Tomko
--- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 68f024f..36a46da 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -11940,7 +11940,7 @@

Re: [libvirt] [PATCH] conf: fix error for parallel port mismatch

2013-04-11 Thread Ján Tomko
On 04/11/2013 09:44 AM, Peter Krempa wrote: On 04/11/13 09:18, Ján Tomko wrote: --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ACK, Peter. Thanks, pushed. Jan -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman

[libvirt] [PATCH] qemu: fix crash in qemuOpen

2013-04-11 Thread Ján Tomko
If the path part of connection URI is not present, cfg is used unitialized. https://bugzilla.redhat.com/show_bug.cgi?id=950855 --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 2c0d7d1..0d41e39

Re: [libvirt] [PATCH] qemu: fix crash in qemuOpen

2013-04-11 Thread Ján Tomko
On 04/11/2013 11:48 AM, Peter Krempa wrote: On 04/11/13 11:42, Ján Tomko wrote: If the path part of connection URI is not present, cfg is used unitialized. https://bugzilla.redhat.com/show_bug.cgi?id=950855 --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [libvirt] [PATCH v2 1/2] Remove extraneous comma in info_cpu_stats and opts_cpu_stats

2013-04-11 Thread Ján Tomko
On 04/08/2013 05:35 PM, John Ferlan wrote: --- tools/virsh-domain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ACK, trivial. Jan -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 2/2] Add error handling to optional arguments in cmdCPUStats

2013-04-11 Thread Ján Tomko
On 04/08/2013 05:35 PM, John Ferlan wrote: --- tools/virsh-domain.c | 29 ++--- 1 file changed, 26 insertions(+), 3 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index e6e6877..6d760f2 100644 --- a/tools/virsh-domain.c +++

Re: [libvirt] [PATCH 2/6] cleanup: Only include testutils.h once

2013-04-15 Thread Ján Tomko
diff --git a/tests/esxutilstest.c b/tests/esxutilstest.c index 55b3623..0c6f3cb 100644 --- a/tests/esxutilstest.c +++ b/tests/esxutilstest.c @@ -1,5 +1,7 @@ #include config.h +#include virutil.h + #ifdef WITH_ESX # include stdio.h @@ -9,7 +11,6 @@ # include internal.h #

[libvirt] [PATCH v2 00/11] qemu: add PCI bridge support

2013-04-17 Thread Ján Tomko
Add new 'pci' controller type with two models: pci-root - auto-added to a pc* machine, providing pci bus 0 pci-bridge - auto-added if the devices would not leave at least one slot empty on bus 0 or bus 0 is specified Ján Tomko (10): qemu: make qemuComparePCIDevice aware of multiple buses qemu

[libvirt] [PATCH v2 03/11] qemu: QEMU_PCI constant consistency

2013-04-17 Thread Ján Tomko
Change QEMU_PCI_ADDRESS_LAST_SLOT to the number of slots in the bus, not the maximum slot value, to match QEMU_PCI_ADDRESS_LAST_FUNCTION and rename them both to have _LAST at the end. --- src/qemu/qemu_command.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git

[libvirt] [PATCH v2 05/11] qemu: switch PCI address set from hash table to an array

2013-04-17 Thread Ján Tomko
Each bus is represented as an array of 32 8-bit integers where each bit represents a PCI function and each byte represents a PCI slot. Uses just one bus so far. --- src/qemu/qemu_command.c | 152 ++-- 1 file changed, 45 insertions(+), 107 deletions(-)

[libvirt] [PATCH v2 01/11] qemu: make qemuComparePCIDevice aware of multiple buses

2013-04-17 Thread Ján Tomko
Bus and domain need to be checked as well, otherwise we might get false positives when searching for multi-function devices. --- src/qemu/qemu_hotplug.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index a6c75cb..fb78af3

[libvirt] [PATCH v2 07/11] conf: add model attribute to virDomainDefMaybeAddController

2013-04-17 Thread Ján Tomko
--- src/conf/domain_conf.c | 29 +++-- 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 548368e..cf0f1c4 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -9747,21 +9747,18 @@

[libvirt] [PATCH v2 02/11] qemu: print PCI address hexadecimally in errors

2013-04-17 Thread Ján Tomko
Use the same formatting as we do for XML in error and debug outputs. --- src/qemu/qemu_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 009d42d..ac5e1f3 100644 --- a/src/qemu/qemu_command.c +++

[libvirt] [PATCH v2 04/11] qemu: move PCI address check out of qemuPCIAddressAsString

2013-04-17 Thread Ján Tomko
Create a new function qemuPCIAddressValidate and call it everywhere the user might supply an incorrect address: * qemuCollectPCIAddress for domain definition * qemuDomainPCIAddressEnsureAddr and ReleaseSlot for hotplug Slot and function shouldn't be wrong at this point, since values out of range

[libvirt] [PATCH v2 09/11] qemu: build command line for pci-bridge device

2013-04-17 Thread Ján Tomko
From: liguang lig.f...@cn.fujitsu.com --- src/qemu/qemu_capabilities.c | 3 +++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 44 tests/qemuhelptest.c | 21 ++--- 4 files changed, 58 insertions(+), 11

[libvirt] [PATCH v2 06/11] qemu: rename CheckSlot to SlotInUse

2013-04-17 Thread Ján Tomko
Also change its return value from int to bool. --- src/qemu/qemu_command.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index c51c336..1b9d940 100644 --- a/src/qemu/qemu_command.c +++

[libvirt] [PATCH v2 10/11] qemu: auto-add bridges and allow using them

2013-04-17 Thread Ján Tomko
Add a dry run address allocation to figure out how many bridges will be needed for all the devices without explicit addresses. Auto-add just enough bridges to put all the devices on, or up to the bridge with the largest specified index. --- src/conf/domain_conf.c | 9 +--

[libvirt] [PATCH v2 08/11] conf: add PCI controllers

2013-04-17 Thread Ján Tomko
Add new controller type 'pci' with models 'pci-root' and 'pci-bridge'. --- docs/schemas/domaincommon.rng | 3 +++ src/conf/domain_conf.c| 21 - src/conf/domain_conf.h| 9 + 3 files changed, 32 insertions(+), 1 deletion(-) diff --git

[libvirt] [PATCH] conf: fix comment about parsing graphics listen address

2013-04-17 Thread Ján Tomko
--- Pushed under the trivial rule. src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 548368e..1643f30 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -7291,7 +7291,7 @@

Re: [libvirt] [PATCH v2 11/11] qemu: auto-add pci-root controller for pc machine types

2013-04-18 Thread Ján Tomko
On 04/18/2013 07:22 AM, Laine Stump wrote: On 04/17/2013 03:00 PM, Ján Tomko wrote: diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 68518a7..a2179aa 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -10849,9 +10849,15 @@ virDomainDefParseXML(xmlDocPtr

[libvirt] [PATCH] qemu: fix default spice password setting

2013-04-18 Thread Ján Tomko
Set spice password even if default VNC password hasn't been set. https://bugzilla.redhat.com/show_bug.cgi?id=953720 --- src/qemu/qemu_hotplug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index a6c75cb..4f39ca4 100644 ---

Re: [libvirt] [PATCH v2 10/11] qemu: auto-add bridges and allow using them

2013-04-19 Thread Ján Tomko
On 04/19/2013 01:02 AM, Eric Blake wrote: On 04/17/2013 01:00 PM, Ján Tomko wrote: @@ -1321,7 +1363,39 @@ qemuDomainAssignPCIAddresses(virDomainDefPtr def, qemuDomainObjPrivatePtr priv = NULL; if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE)) { -if (!(addrs

Re: [libvirt] [PATCH v2 11/11] qemu: auto-add pci-root controller for pc machine types

2013-04-19 Thread Ján Tomko
On 04/18/2013 04:38 PM, Laine Stump wrote: On 04/18/2013 08:09 AM, Ján Tomko wrote: On 04/18/2013 07:22 AM, Laine Stump wrote: On 04/17/2013 03:00 PM, Ján Tomko wrote: diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 68518a7..a2179aa 100644 --- a/src/conf/domain_conf.c

Re: [libvirt] [PATCH] qemu: fix default spice password setting

2013-04-19 Thread Ján Tomko
On 04/19/2013 10:52 AM, Martin Kletzander wrote: On 04/19/2013 07:09 AM, Ján Tomko wrote: Set spice password even if default VNC password hasn't been set. https://bugzilla.redhat.com/show_bug.cgi?id=953720 --- ... ACK, Martin Thanks, pushed now. Jan -- libvir-list mailing list

Re: [libvirt] [PATCH v2 11/11] qemu: auto-add pci-root controller for pc machine types

2013-04-19 Thread Ján Tomko
On 04/18/2013 04:38 PM, Laine Stump wrote: On 04/18/2013 08:09 AM, Ján Tomko wrote: On 04/18/2013 07:22 AM, Laine Stump wrote: On 04/17/2013 03:00 PM, Ján Tomko wrote: diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 68518a7..a2179aa 100644 --- a/src/conf/domain_conf.c

Re: [libvirt] [PATCH v2 00/11] qemu: add PCI bridge support

2013-04-19 Thread Ján Tomko
On 04/17/2013 09:00 PM, Ján Tomko wrote: Add new 'pci' controller type with two models: pci-root - auto-added to a pc* machine, providing pci bus 0 pci-bridge - auto-added if the devices would not leave at least one slot empty on bus 0 or bus 0 is specified Ján Tomko (10): I've pushed

[libvirt] [PATCH v3 1/5] qemu: call post-parse callbacks when parsing command line too

2013-04-22 Thread Ján Tomko
Assume format type is 'auto' when none is specified on qemu command line. --- src/conf/domain_conf.c | 2 +- src/conf/domain_conf.h | 5 + src/libvirt_private.syms

[libvirt] [PATCH v3 5/5] qemu: auto-add bridges and allow using them

2013-04-22 Thread Ján Tomko
Add a dry run address allocation to figure out how many bridges will be needed for all the devices without explicit addresses. Auto-add just enough bridges to put all the devices on, or up to the bridge with the largest specified index. --- src/conf/domain_conf.c |

[libvirt] [PATCH v3 3/5] qemu: build command line for pci-bridge device

2013-04-22 Thread Ján Tomko
From: liguang lig.f...@cn.fujitsu.com --- src/qemu/qemu_capabilities.c | 3 +++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 30 +- tests/qemuhelptest.c | 21 ++--- 4 files changed, 47 insertions(+), 8 deletions(-) diff

[libvirt] [PATCH v3 0/5] qemu: add PCI bridge support

2013-04-22 Thread Ján Tomko
- xml test and schema validation rewrote implicit controller removal and search for free slots check for multiple pci controllers with the same index added documentation Ján Tomko (4): qemu: call post-parse callbacks when parsing command line too conf: add PCI controllers qemu: auto-add pci

[libvirt] [PATCH v3 2/5] conf: add PCI controllers

2013-04-22 Thread Ján Tomko
Add new controller type 'pci' with models 'pci-root' and 'pci-bridge'. --- docs/formatdomain.html.in | 22 +- docs/schemas/domaincommon.rng | 12 src/conf/domain_conf.c| 21 - src/conf/domain_conf.h| 9 + 4 files

[libvirt] [PATCHv4 5/5] qemu: auto-add bridges and allow using them

2013-04-23 Thread Ján Tomko
Add a dry run address allocation to figure out how many bridges will be needed for all the devices without explicit addresses. Auto-add just enough bridges to put all the devices on, or up to the bridge with the largest specified index. --- v4: Moved the check for duplicate controller indexes to

[libvirt] [PATCHv4 6/5] conf: reject controllers with duplicate indexes

2013-04-23 Thread Ján Tomko
Reject multiple controllers with the same index, except for USB controllers. Multi-function USB controllers can have the same index. --- src/conf/domain_conf.c | 64 ++ 1 file changed, 64 insertions(+) diff --git a/src/conf/domain_conf.c

Re: [libvirt] [PATCH v3 5/5] qemu: auto-add bridges and allow using them

2013-04-23 Thread Ján Tomko
On 04/23/2013 12:24 AM, Eric Blake wrote: On 04/22/2013 12:43 PM, Ján Tomko wrote: qemuDomainPCIAddressGetNextSlot(qemuDomainPCIAddressSetPtr addrs, virDevicePCIAddressPtr next_addr) { -virDevicePCIAddress tmp_addr = addrs-lastaddr; -int i

[libvirt] [PATCH] virsh: don't shorten incorrect arguments

2013-04-23 Thread Ján Tomko
https://bugzilla.redhat.com/show_bug.cgi?id=949373 Print the whole incorrect argument as specified by the user instead of the short option. Before: $ virsh --debu error: option '-d' requires an argument $ virsh ---debu error: unsupported option '- $ virsh --debu c error: option -d takes a

Re: [libvirt] [PATCH] virsh: don't shorten incorrect arguments

2013-04-23 Thread Ján Tomko
On 04/23/2013 04:25 PM, Michal Privoznik wrote: On 23.04.2013 16:08, Ján Tomko wrote: https://bugzilla.redhat.com/show_bug.cgi?id=949373 Print the whole incorrect argument as specified by the user instead of the short option. Before: $ virsh --debu error: option '-d' requires an argument

Re: [libvirt] [PATCH] virsh: don't shorten incorrect arguments

2013-04-24 Thread Ján Tomko
On 04/23/2013 06:05 PM, Eric Blake wrote: On 04/23/2013 08:08 AM, Ján Tomko wrote: https://bugzilla.redhat.com/show_bug.cgi?id=949373 Print the whole incorrect argument as specified by the user instead of the short option. case 'd': if (virStrToLong_i(optarg, NULL

Re: [libvirt] [PATCHv4 5/5] qemu: auto-add bridges and allow using them

2013-04-25 Thread Ján Tomko
On 04/25/2013 02:39 AM, Eric Blake wrote: On 04/23/2013 06:47 AM, Ján Tomko wrote: @@ -1326,15 +1368,53 @@ qemuDomainAssignPCIAddresses(virDomainDefPtr def, qemuDomainObjPrivatePtr priv = NULL; if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE)) { +int max_idx = -1; So

Re: [libvirt] [PATCH v3 2/5] conf: add PCI controllers

2013-04-25 Thread Ján Tomko
On 04/22/2013 10:11 PM, Laine Stump wrote: On 04/22/2013 02:43 PM, Ján Tomko wrote: --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -2124,7 +2124,7 @@ p Each controller has a mandatory attribute codetype/code, which must be one of ide, fdc, scsi, sata

Re: [libvirt] [PATCH v3 4/5] qemu: auto-add pci-root controller for pc machine types

2013-04-25 Thread Ján Tomko
On 04/22/2013 10:37 PM, Laine Stump wrote: On 04/22/2013 02:43 PM, Ján Tomko wrote: diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index a7aabdf..ab99538 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -673,6 +673,37 @@ qemuDomainDefPostParse(virDomainDefPtr

[libvirt] [PATCH] conf: reject controllers with duplicate indexes

2013-04-25 Thread Ján Tomko
Reject multiple controllers with the same index, except for USB controllers. Multi-function USB controllers can have the same index. --- src/conf/domain_conf.c | 59 ++ 1 file changed, 59 insertions(+) diff --git a/src/conf/domain_conf.c

Re: [libvirt] [PATCH v3 0/5] qemu: add PCI bridge support

2013-04-25 Thread Ján Tomko
On 04/22/2013 08:43 PM, Ján Tomko wrote: Add new 'pci' controller type with two models: pci-root - auto-added to machines with implicit pci bus pci-bridge - auto-added if the devices would not leave at least one slot empty on bus 0 or bus 0 is specified v3: moved the implicit PCI root

[libvirt] [PATCH] qemu: auto-add pci-root to 'pc-i440*' machines too

2013-04-25 Thread Ján Tomko
Commit b33eb0d missed this machine type. --- src/qemu/qemu_domain.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 98ac56f..4e88eaf 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -687,6 +687,7 @@

Re: [libvirt] [PATCH] qemu: auto-add pci-root to 'pc-i440*' machines too

2013-04-25 Thread Ján Tomko
On 04/25/2013 04:19 PM, Eric Blake wrote: On 04/25/2013 07:25 AM, Ján Tomko wrote: Commit b33eb0d missed this machine type. --- src/qemu/qemu_domain.c | 1 + 1 file changed, 1 insertion(+) ACK. Thank you, I've pushed it now. Jan -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] conf: reject controllers with duplicate indexes

2013-04-25 Thread Ján Tomko
On 04/25/2013 04:36 PM, Eric Blake wrote: On 04/25/2013 05:41 AM, Ján Tomko wrote: Reject multiple controllers with the same index, except for USB controllers. Multi-function USB controllers can have the same index. --- Compared to the earlier version you posted as patch 6/5 on the pci

[libvirt] [PATCH] docs: fix memballoon examples

2013-04-25 Thread Ján Tomko
Use a pair of 'memballoon' tags instead of single 'watchdog' one. Add a few missing colons. --- Pushed under the trivial rule. docs/formatdomain.html.in | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index

  1   2   3   4   5   6   7   8   9   10   >