[Libvir] [PATCH] Add /usr/sbin to path when searching for iptables

2008-05-05 Thread Jim Fehlig
iptables resides in /usr/sbin on SuSE distros. Add it to path when searching for iptables. Regards, Jim diff -ur a/configure.in b/configure.in --- a/configure.in 2008-05-05 13:46:20.0 -0600 +++ b/configure.in 2008-05-05 13:43:14.0 -0600 @@ -217,7 +217,7 @@

[libvirt] [PATCH]Fix minor issues in logical storage backend

2008-08-28 Thread Jim Fehlig
Hi All! I came across some problems trying to create a new LVM-based storage pool using this config pool type=logical nametest_vg/name source device path=/dev/sdb1/ /source target path/dev/test_vg/path /target /pool Volume group did not previously exist so I did virsh

[Libvir] Request for additional entry points

2006-03-31 Thread Jim Fehlig
As discussed on the xen-cim call on 3/31, the Xen CIM provider needs some additional entry points in libvirt. I would like to open a discussion about adding the following entry points to libvirt. virDomainSetConfig(virConnectPtr conn, const char *xmlDesc) Stores the domU config data in

Re: [Libvir] Request for additional entry points

2006-04-04 Thread Jim Fehlig
Daniel Veillard wrote: On Fri, Mar 31, 2006 at 04:47:38PM -0500, Daniel Veillard wrote: I just added the following: /** * virDomainReboot: * @domain: a domain object * @flags: extra flags for the reboot operation, not used yet * * Reboot a domain, the domain object is still usable there

Re: [Libvir] BUG: virDomainLookupByID fails after XenStore path discovery

2006-04-04 Thread Jim Fehlig
Bryan D. Payne [EMAIL PROTECTED] 04/04/06 6:23 PM I'm just not seeing it included in path returned by xs_get_domain_path(), only see /local/domain/num For what it's worth, I was trying to put a patch together for this, but I kept getting memory corruption errors. I was trying to access

[Libvir] Re: [Xen-cim] LTC provider working on SLES/openwbem

2006-04-21 Thread Jim Fehlig
Daniel Veillard wrote: On Thu, Apr 20, 2006 at 04:24:28PM -0600, Jim Fehlig wrote: FYI, I have managed to get one of the LTC providers (Xen_ComputerSystem) working on SLES using openwbem cimom, the xm shim, and libvirt. The following changes were made: libvirt - changed

Re: [Libvir] Request for additional entry points

2006-04-27 Thread Jim Fehlig
Daniel P. Berrange wrote: On Tue, Apr 18, 2006 at 05:40:07PM -0400, Daniel Veillard wrote: On Tue, Apr 18, 2006 at 04:40:13PM -0400, Daniel Veillard wrote: So we have 2 more APIs which allows to define the XML for a domain and name it. That then allow to reserve that name, and the

[Libvir] Re: support for hvm guests

2006-04-28 Thread Jim Fehlig
Daniel Veillard wrote: On Fri, Apr 07, 2006 at 04:10:36PM -0600, Jim Fehlig wrote: Daniel, FYI, I'm working on a patch to support hvm guests. [snip] Calling virsh dumpxml some_hvm_guest will (almost) correctly dump xml config info on hvm guests. Needs to handle type=ioemu

[Libvir] Re: support for hvm guests

2006-05-03 Thread Jim Fehlig
Daniel Veillard wrote: First sorry for being a bit late answering, On Fri, Apr 28, 2006 at 06:07:43PM -0600, Jim Fehlig wrote: Type 'bridge' can be valid for hvm guests. Perhaps it is better to not expose ioemu in the XML for now as there will probably be changes in this area anyway

Re: [Libvir] Re: Proposal : add 3 functions to Libvirt API, for virtual CPUs

2006-07-28 Thread Jim Fehlig
Has any progress been made on this proposal? I don't see anything in current CVS. This functionality would be useful for Xen-CIM project. Regards, Jim [EMAIL PROTECTED] wrote: Corrections on proposal: 1) PinVcpus Replace: * @cpumap: pointer to a bit map of real CPUs (format in

Re: [Libvir] Re: Virtual CPU functions

2006-08-02 Thread Jim Fehlig
Philippe Berthault wrote: Daniel Veillard a écrit : On Tue, Aug 01, 2006 at 05:06:59PM +0200, Philippe Berthault wrote: [snip] I wonder how people are most likely to use those APIs. Building scenarios like: - physical CPU is to be locked to serve only VCPU N in domain D -

Re: [Libvir] Semantics for ListDomains/ ListDefinedDomains

2006-08-23 Thread Jim Fehlig
Daniel Veillard wrote: On Wed, Aug 23, 2006 at 07:16:45PM +0100, Daniel P. Berrange wrote: So I was thinking a little about lifecycle support for passive domains in libvirt and wanted to clarify the intended semantics of the two methods: virConnectListDomains

[Libvir] Problem with hypercall

2006-09-13 Thread Jim Fehlig
Stumbled across a problem trying to list domains with libvirt-0.1.5. Using virsh I get errors such as xen81:/tests/jim # virsh list Id Name State -- 0 Domain-0 running libvir: Xen Daemon error : GET operation failed: No such domain

Re: [Libvir] PATCH: Allow remote driver to handle any connection URI

2007-09-27 Thread Jim Fehlig
Daniel P. Berrange wrote: We currently have logic in the remote driver so that it handles the local QEMU driver URIs, so they get re-directed to the daemon. It also handles networking APIs for Xen driver. For normal APIs, Xen has the auto-spawned setuid proxy daemon. This was very useful at

Re: [Libvir] [PATCH] Xen: Support cpu_weight and cpu_cap for Xen.

2007-11-01 Thread Jim Fehlig
David Lutterkort wrote: On Fri, 2007-10-26 at 09:08 -0400, Daniel Veillard wrote: I can understand the need to make it easy for an user, I still don't think this means those tuning informations need to be associated to the domain definition, to me it is somehow orthogonal to the domain

Re: [Libvir] The problem of the definition of tuning informations

2007-11-08 Thread Jim Fehlig
Daniel Veillard wrote: On Thu, Nov 08, 2007 at 02:00:10PM -0600, Ryan Harper wrote: * Daniel Veillard [EMAIL PROTECTED] [2007-11-08 10:08]: I promised that mail for the beginning of the week but I still have I think tuning informations are that set of parameters associated to a

Re: [Libvir] Libvirt version

2007-12-18 Thread Jim Fehlig
Katti, Vadiraj (STSD-Openview) wrote: Hi, Currently the latest version of libvirt available is 0.3.3. But SLES 10 ships 0.2.0 version of libvirt (not sure what version RHEL 5.1 ships). Any idea when and on what basis SLES decides to ship the upgraded version of libvirt. libvirt will be

Re: [Libvir] Libvirt version

2007-12-18 Thread Jim Fehlig
Jim Fehlig wrote: [...] I have latest libvirt packages for 10.3 and SLE in my home project: https://build.opensuse.org/package/show?project=home%3Ajfehligpackage=libvirt Oops, sorry - I was logged in when I copied that link. For SLE you can get rpms here http://download.opensuse.org

[libvirt] [PATCH] Fix build after commit e3ba4025

2012-03-05 Thread Jim Fehlig
This patch fixes some build error I've encountered, but would prefer an ACK before pushing. Thanks, Jim From ff81637b66793fd4b2b46e8e04357e8d406dde31 Mon Sep 17 00:00:00 2001 From: Jim Fehlig jfeh...@suse.com Date: Mon, 5 Mar 2012 12:08:54 -0700 Subject: [PATCH] Fix build after commit e3ba4025

Re: [libvirt] [PATCH] Fix build after commit e3ba4025

2012-03-05 Thread Jim Fehlig
Eric Blake wrote: On 03/05/2012 12:17 PM, Jim Fehlig wrote: +++ b/src/util/virnetlink.h @@ -55,7 +55,7 @@ int virNetlinkEventServiceStart(void); /** * virNetlinkEventServiceIsRunning: returns if the netlink event service is running. */ -bool virNetlinkEventServiceIsRunning(void

Re: [libvirt] [PATCH] Add migration APIs for libxl driver

2012-03-05 Thread Jim Fehlig
Chunyan Liu wrote: Add migration APIs for libxl driver. Implemented in migration version 3. Based on xen 4.1. I didn't get a chance to test this yet, but have some initial review comments. Signed-off-by: Chunyan Liu cy...@suse.com --- src/libxl/libxl_driver.c | 617

Re: [libvirt] [PATCH] Add migration APIs for libxl driver

2012-03-06 Thread Jim Fehlig
Chunyan Liu wrote: Chun Yan Liu cy...@suse.com 3/6/2012 2:29 PM I didn't get a chance to test this yet, but have some initial review comments. Signed-off-by: Chunyan Liu --- src/libxl/libxl_driver.c | 617 ++

Re: [libvirt] [PATCH] Add migration APIs for libxl driver

2012-03-14 Thread Jim Fehlig
Chunyan Liu wrote: Hi, Jim, I made some changes to the patch according to your comments: a. support concurrent migrations, add virBitmapPtr for probing migration ports b. update doParseURI: use virAsprintf instead of strdup and snprintf, support migration URI syntax hostname[:port],

Re: [libvirt] [PATCH] Add migration APIs for libxl driver

2012-03-16 Thread Jim Fehlig
Chunyan Liu wrote: 2012/3/15 Jim Fehlig jfeh...@suse.com mailto:jfeh...@suse.com +/* Create socket connection to receive migration data */ +if (!uri_in) { +hostname = virGetHostname(dconn); +if (hostname == NULL) +goto cleanup

Re: [libvirt] [PATCH] Add migration APIs for libxl driver

2012-03-16 Thread Jim Fehlig
Jim Fehlig wrote: +static int +libxlDomainMigratePerform3(virDomainPtr dom, +const char *xmlin ATTRIBUTE_UNUSED, +const char *cookiein ATTRIBUTE_UNUSED, +int cookieinlen ATTRIBUTE_UNUSED

Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1

2012-03-26 Thread Jim Fehlig
Daniel Veillard wrote: As scheduled, we are entering the freeze for 0.9.11. I think most API additions are now commited to git upstream (please raise your voice quickly if you see something missing !) I have made a release candidate 1 tarball (and associated rpms) at

Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1

2012-03-27 Thread Jim Fehlig
Jim Fehlig wrote: Daniel Veillard wrote: As scheduled, we are entering the freeze for 0.9.11. I think most API additions are now commited to git upstream (please raise your voice quickly if you see something missing !) I have made a release candidate 1 tarball (and associated rpms

Re: [libvirt] libvirt-libxl driver defaulting to tap disk and not working (on Fedora 18 and rawhide)

2013-02-20 Thread Jim Fehlig
Ian Campbell wrote: if (l_disk-driverName) { ... } else { /* No driverName - default to raw/tap?? */ x_disk-format = LIBXL_DISK_FORMAT_RAW; x_disk-backend = LIBXL_DISK_BACKEND_TAP; } I recall some discussion about the choice of these defaults,

[libvirt] [PATCH] libxl: Fix setting of disk backend

2013-02-20 Thread Jim Fehlig
The libxl driver was setting the backend field of libxl_device_disk structure to LIBXL_DISK_BACKEND_TAP when the driver element of disk configuration was not specified. This needlessly forces the use of blktap driver, which may not be loaded in dom0

Re: [libvirt] [PATCH] libxl: Fix setting of disk backend

2013-02-20 Thread Jim Fehlig
Eric Blake wrote: On 02/20/2013 01:31 PM, Jim Fehlig wrote: The libxl driver was setting the backend field of libxl_device_disk structure to LIBXL_DISK_BACKEND_TAP when the driver element of disk configuration was not specified. This needlessly forces the use of blktap driver, which may

[libvirt] [PATCH] Fix starting qemu instances when apparmor driver is enabled

2013-02-27 Thread Jim Fehlig
With the apparmor security driver enabled, qemu instances fail to start # grep ^security_driver /etc/libvirt/qemu.conf security_driver = apparmor # virsh start test-kvm error: Failed to start domain test-kvm error: internal error security label already defined for VM The model field of

Re: [libvirt] [PATCH] Fix starting qemu instances when apparmor driver is enabled

2013-02-28 Thread Jim Fehlig
Eric Blake wrote: On 02/27/2013 04:51 PM, Jim Fehlig wrote: With the apparmor security driver enabled, qemu instances fail to start # grep ^security_driver /etc/libvirt/qemu.conf security_driver = apparmor # virsh start test-kvm error: Failed to start domain test-kvm error: internal

Re: [libvirt] [PATCH] Fix starting qemu instances when apparmor driver is enabled

2013-03-01 Thread Jim Fehlig
Guannan Ren wrote: On 03/01/2013 08:37 AM, Jim Fehlig wrote: Eric Blake wrote: On 02/27/2013 04:51 PM, Jim Fehlig wrote: With the apparmor security driver enabled, qemu instances fail to start # grep ^security_driver /etc/libvirt/qemu.conf security_driver = apparmor # virsh start test

Re: [libvirt] [PATCH 2/3] libxl_driver: Resolve Coverity errors

2013-03-05 Thread Jim Fehlig
Eric Blake wrote: On 03/05/2013 05:43 AM, John Ferlan wrote: 1. The virObjectLock() call was unconditional, but Unlock was conditional on vm being valid. Removed the check 2. A call to virDomainEventNewFromObj() isn't guaranteed to return an event - that check needs to be made

Re: [libvirt] [PATCH] Fix starting qemu instances when apparmor driver is enabled

2013-03-06 Thread Jim Fehlig
Guannan Ren wrote: On 03/02/2013 12:41 AM, Jim Fehlig wrote: Guannan Ren wrote: Hi Jim In selinux, libvirt added a label for tapfd. Do you think this patch makes sense for apparmor? https://www.redhat.com/archives/libvir-list/2012-October/msg01461.html Hi Gunannan

Re: [libvirt] [PATCH v2] apparmor: use AppArmorSetFDLabel for both imageFD and tapFD

2013-03-07 Thread Jim Fehlig
Guannan Ren wrote: Rename AppArmorSetImageFDLabel to AppArmorSetFDLabel which could be used as a common function for *ALL* fd relabelling in Linux. In apparmor profile for specific vm with uuid cdbebdfa-1d6d-65c3-be0f-fd74b978a773 Path:

Re: [libvirt] libvirtd segfault

2013-03-20 Thread Jim Fehlig
AL13N wrote: Thread 1 (Thread 0x7fdef683b800 (LWP 20522)): #0 0x in ?? () #1 0x7fdee9a72dc7 in libxl_osevent_occurred_timeout (ctx=optimized out, for_libxl=0x7fdedc001608) at libxl_event.c:1039 #2 0x7fdee9c9ff87 in libxlTimerCallback (timer=optimized out,

[libvirt] [PATCH] Fix parsing of bond interface XML

2013-03-21 Thread Jim Fehlig
Noticed that parsing bond interface XML containing the miimon element fails interface type=bond name=bond0 ... bond mode=active-backup miimon freq=100 carrier=netif/ ... /bond /interface This configuration does not contain the optional updelay and downdelay

[libvirt] [PATCH V2] Fix parsing of bond interface XML

2013-03-21 Thread Jim Fehlig
Noticed that parsing bond interface XML containing the miimon element fails interface type=bond name=bond0 ... bond mode=active-backup miimon freq=100 carrier=netif/ ... /bond /interface This configuration does not contain the optional updelay and downdelay

Re: [libvirt] [PATCH] Fix parsing of bond interface XML

2013-03-21 Thread Jim Fehlig
Eric Blake wrote: On 03/21/2013 03:50 PM, Jim Fehlig wrote: Noticed that parsing bond interface XML containing the miimon element fails interface type=bond name=bond0 ... bond mode=active-backup miimon freq=100 carrier=netif/ ... /bond /interface

Re: [libvirt] [PATCH V2] Fix parsing of bond interface XML

2013-03-21 Thread Jim Fehlig
Eric Blake wrote: On 03/21/2013 05:13 PM, Jim Fehlig wrote: Noticed that parsing bond interface XML containing the miimon element fails interface type=bond name=bond0 ... bond mode=active-backup miimon freq=100 carrier=netif/ ... /bond /interface

Re: [libvirt] libvirtd segfault

2013-04-02 Thread Jim Fehlig
AL13N wrote: Op woensdag 20 maart 2013 08:42:52 schreef Jim Fehlig: AL13N wrote: Thread 1 (Thread 0x7fdef683b800 (LWP 20522)): #0 0x in ?? () #1 0x7fdee9a72dc7 in libxl_osevent_occurred_timeout (ctx=optimized out, for_libxl=0x7fdedc001608) at libxl_event.c

Re: [libvirt] [PATCH RESENT 01/12] libxl: allow script for any network interface, not only bridge

2013-04-10 Thread Jim Fehlig
Laine Stump wrote: On 04/10/2013 05:10 AM, Daniel P. Berrange wrote: On Wed, Apr 10, 2013 at 04:44:43AM +0200, Marek Marczykowski wrote: This can be useful for route or NAT networks, or any other custom network setup. Especially configuration example in documentation uses script/

Re: [libvirt] [PATCH RESENT 02/12] libxl: PCI passthrough support

2013-04-10 Thread Jim Fehlig
Daniel P. Berrange wrote: On Wed, Apr 10, 2013 at 04:44:43AM +0200, Marek Marczykowski wrote: --- src/libxl/libxl_conf.c | 72 ++ src/libxl/libxl_conf.h | 2 ++ 2 files changed, 74 insertions(+) This needs todo more than just

Re: [libvirt] [PATCH RESENT 04/12] libxl: populate xenstore memory entries at startup

2013-04-10 Thread Jim Fehlig
Marek Marczykowski wrote: libxl uses some xenstore entries for hints in memory management (especially when starting new domain). This includes dom0 memory limit and Xen free memory margin, based on current system state. Entries are created at first usage, so force such usage at daemon startup,

Re: [libvirt] [Xen-devel] libvirt libxl driver leaking libxl_event's?

2013-04-11 Thread Jim Fehlig
On 04/11/2013 07:09 AM, Ian Campbell wrote: On Thu, 2013-04-11 at 13:46 +0100, Ian Campbell wrote: Hi Jim, I don't see any calls to libxl_event_dispose in libvirt.git, actually I think I meant libxl_event_free, but I can't see that either. Right. I confirmed that was needed with Ian J. a

Re: [libvirt] USB pass-through with XEN

2013-04-19 Thread Jim Fehlig
Carlos Rodrigues wrote: Hello everybody, I try to doing USB pass-through with XEN hypervisor using libvirt and i get the following error: # virsh attach-device c6test /tmp/usb_device.xml error: Failed to attach device from /tmp/usb_device.xml error: unsupported configuration: unsupported

[libvirt] Using leases with virtlockd

2013-04-23 Thread Jim Fehlig
Nearly a question for the users list, but I might be encountering a bug too. I'm using virtlockd with 'auto_disk_leases = 0' and struggle with the correct configuration for a lease in the domXML. Using lease lockspacetest-ls/lockspace keytest-lock/key target

Re: [libvirt] [PATCH 6/7] xen: implement virNodeDeviceDetachFlags backend

2013-04-24 Thread Jim Fehlig
Laine Stump wrote: This was the only hypervisor driver other than qemu that implemented virNodeDeviceDettach. It doesn't currently support multiple pci device assignment driver backends, but it is simple to plug in this new API, which will make it easier for Xen people to fill it in later when

Re: [libvirt] [PATCH] fix segfault during virsh save in pv guest

2013-04-26 Thread Jim Fehlig
Bamvor Jian Zhang wrote: this patch fix the wrong sequence for fd and timeout register. the sequence was right in dfa1e1dd for fd register, but it changed in e0622ca2. in this patch, set priv, xl_priv in info and increase info-priv ref count before virEventAddHandle. if do this after

Re: [libvirt] libvirtd segfault

2013-04-26 Thread Jim Fehlig
AL13N wrote: AL13N wrote: Op woensdag 20 maart 2013 08:42:52 schreef Jim Fehlig: AL13N wrote: Thread 1 (Thread 0x7fdef683b800 (LWP 20522)): #0 0x in ?? () #1 0x7fdee9a72dc7 in libxl_osevent_occurred_timeout (ctx=optimized out, for_libxl

Re: [libvirt] [PATCH RESENT 01/12] libxl: allow script for any network interface, not only bridge

2013-04-26 Thread Jim Fehlig
Jim Fehlig wrote: Laine Stump wrote: On 04/10/2013 05:10 AM, Daniel P. Berrange wrote: On Wed, Apr 10, 2013 at 04:44:43AM +0200, Marek Marczykowski wrote: This can be useful for route or NAT networks, or any other custom network setup. Especially configuration

Re: [libvirt] [Xen-devel] libvirt, libxl and QDISKs

2013-04-26 Thread Jim Fehlig
David Scott wrote: Something like the attached, which seems to work well for me when specifying driverName = qemu, e.g. disk type='file' device='disk' driver name='qemu'/ source file='/var/lib/xen/images/sles11sp2-pv/disk0.raw'/ target dev='xvda' bus='xen'/

Re: [libvirt] [PATCH 1/2] libxl: expose multiple emulators per guest in the capabilities XML

2013-04-29 Thread Jim Fehlig
David Scott wrote: libxl allows users to choose between two standard emulators: 1. (default in xen-4.2): qemu traditional (aka qemu-dm) 2. (default in xen-4.3): qemu upstream (aka qemu-system-i386) The person who builds and packages xen gets to choose which emulators are built. We examine

Re: [libvirt] [PATCH 2/2] libxl: allow an emulator to be selected in the domain config XML

2013-04-29 Thread Jim Fehlig
David Scott wrote: We cross-check the given path against the capabilties, and translate it into a libxl_device_model_version. Signed-off-by: David Scott dave.sc...@eu.citrix.com --- src/libxl/libxl_conf.c | 41 + 1 files changed, 41 insertions(+),

Re: [libvirt] [PATCH 1/2] libxl: expose multiple emulators per guest in the capabilities XML

2013-04-29 Thread Jim Fehlig
Daniel P. Berrange wrote: On Mon, Apr 29, 2013 at 12:18:56PM -0600, Jim Fehlig wrote: David Scott wrote: libxl allows users to choose between two standard emulators: 1. (default in xen-4.2): qemu traditional (aka qemu-dm) 2. (default in xen-4.3): qemu upstream (aka qemu-system-i386

Re: [libvirt] [PATCH 2/2] libxl: allow an emulator to be selected in the domain config XML

2013-04-29 Thread Jim Fehlig
Jim Fehlig wrote: David Scott wrote: We cross-check the given path against the capabilties, and translate it into a libxl_device_model_version. Signed-off-by: David Scott dave.sc...@eu.citrix.com --- src/libxl/libxl_conf.c | 41 + 1 files

[libvirt] [PATCH] libxl: Fix double-dispose of libxl domain config

2013-04-29 Thread Jim Fehlig
libxlBuildDomainConfig() was disposing the libxl_domain_config object on error, only to have it disposed again by libxlBuildDomainConfig()'s caller, which resulted in a segfault. Leave disposing of the config object to it's owner. --- src/libxl/libxl_conf.c | 12 1 file changed, 4

[libvirt] [PATCH 0/2] libxl: Add support for qdisk disk backend

2013-04-29 Thread Jim Fehlig
disk format. Fix this with the first patch, including adding format checks in the other supported disk backends. Jim Fehlig (2): libxl: Fix disk format error message libxl: support qdisk backend src/libxl/libxl_conf.c | 49 +++-- 1 file changed, 47

[libvirt] [PATCH 2/2] libxl: support qdisk backend

2013-04-29 Thread Jim Fehlig
libxl supports the LIBXL_DISK_BACKEND_QDISK disk backend, where qemu is used to provide the disk backend. This patch simply maps the existing driver name='qemu'/ to LIBXL_DISK_BACKEND_QDISK. --- src/libxl/libxl_conf.c | 25 + 1 file changed, 25 insertions(+) diff --git

[libvirt] [PATCH 1/2] libxl: Fix disk format error message

2013-04-29 Thread Jim Fehlig
Specifying an unsupported disk format with the tap driver resulted in a less than helpful error message error: Failed to start domain test-hvm error: internal error libxenlight does not support disk driver qed Change the message to state that the qed format is not supported by the tap driver,

Re: [libvirt] [PATCH 1/2] libxl: expose multiple emulators per guest in the capabilities XML

2013-04-29 Thread Jim Fehlig
Daniel P. Berrange wrote: On Mon, Apr 29, 2013 at 12:18:56PM -0600, Jim Fehlig wrote: David Scott wrote: libxl allows users to choose between two standard emulators: 1. (default in xen-4.2): qemu traditional (aka qemu-dm) 2. (default in xen-4.3): qemu upstream (aka qemu-system-i386

Re: [libvirt] [PATCH 1/2] libxl: expose multiple emulators per guest in the capabilities XML

2013-04-30 Thread Jim Fehlig
Daniel P. Berrange wrote: On Mon, Apr 29, 2013 at 11:01:04PM -0600, Jim Fehlig wrote: Daniel P. Berrange wrote: On Mon, Apr 29, 2013 at 12:18:56PM -0600, Jim Fehlig wrote: David Scott wrote: libxl allows users to choose between two standard emulators: 1

Re: [libvirt] [PATCH] libxl: Fix double-dispose of libxl domain config

2013-04-30 Thread Jim Fehlig
Eric Blake wrote: On 04/29/2013 05:20 PM, Jim Fehlig wrote: libxlBuildDomainConfig() was disposing the libxl_domain_config object on error, only to have it disposed again by libxlBuildDomainConfig()'s caller, which resulted in a segfault. Leave disposing of the config object to it's

Re: [libvirt] [PATCH] libxl: allow an emulator to be selected in the domain config XML

2013-04-30 Thread Jim Fehlig
David Scott wrote: The emulator path supplied can be any valid path on the system. Note that when setting a device_model, libxl needs us to set the device_model_version too. The device_model_version can be either ...QEMU_XEN: meaning upstream qemu, the default in xen-4.3 onwards

Re: [libvirt] [Xen-devel] [PATCH] libxl: allow an emulator to be selected in the domain config XML

2013-04-30 Thread Jim Fehlig
David Scott wrote: Hi, [added xen-devel: FYI this is about how to properly set the libxl device_model_version when the user has provided a manual device_model override (aka a path to a qemu) in the libvirt domain XML.] On 30/04/13 16:10, Jim Fehlig wrote: David Scott wrote: The emulator

Re: [libvirt] [Xen-devel] [PATCH] libxl: allow an emulator to be selected in the domain config XML

2013-05-01 Thread Jim Fehlig
Ian Campbell wrote: On Wed, 2013-05-01 at 04:42 +0100, Jim Fehlig wrote: David Scott wrote: Hi, [added xen-devel: FYI this is about how to properly set the libxl device_model_version when the user has provided a manual device_model override (aka a path to a qemu) in the libvirt

Re: [libvirt] [Xen-devel] [PATCH] libxl: allow an emulator to be selected in the domain config XML

2013-05-01 Thread Jim Fehlig
Ian Campbell wrote: On Wed, 2013-05-01 at 15:31 +0100, Jim Fehlig wrote: Ian Campbell wrote: On Wed, 2013-05-01 at 04:42 +0100, Jim Fehlig wrote: David Scott wrote: Hi, [added xen-devel: FYI this is about how to properly set the libxl

[libvirt] [PATCH] build: Fix build when WITH_HAL is defined

2013-05-02 Thread Jim Fehlig
Commit 7c9a2d88 missed inclusion of virstring.h in a few places when WITH_HAL is defined, causing build failures. --- Pushing under build-breaker rule. src/node_device/node_device_driver.c | 1 + src/node_device/node_device_hal.c| 1 + 2 files changed, 2 insertions(+) diff --git

Re: [libvirt] [PATCH 01/40] Remove xen driver checks for priv-handle 0

2013-05-03 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The Xen hypervisor driver checks for 'priv-handle 0' and returns -1, but without raising any error. Fortunately this code will never be executed, since the main Xen driver always checks

Re: [libvirt] [PATCH 02/40] Remove VIR_CONNECT_RO checks from xen drivers

2013-05-03 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Some of the Xen sub-drivers have checks against the VIR_CONNECT_RO flag. This is not required, since such checks are done at the top level before the driver methods are invoked Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH 03/40] Remove pointless GET_PRIVATE macro from Xen driver

2013-05-03 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The Xen driver uses a macro GET_PRIVATE as a supposed shorthand for 'xenUnifiedPrivatePtr priv = (xenUnifiedPrivatePtr) (conn)-privateData'. It does not in fact save any lines of code, and obscures what is happening.

Re: [libvirt] [PATCH 04/40] Simplify opening of Xen drivers

2013-05-03 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Since the Xen driver was changed to only execute inside libvirtd, there is no scenario in which it will be opened from a non-privileged context. This all the code dealing with opening the sub-drivers can s/This/Thus/

Re: [libvirt] [PATCH 05/40] Simplify the Xen get type driver method

2013-05-06 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com There is no point iterating over sub-drivers since the user would not have a virConnectPtr instance at all if opening the drivers failed. Just return 'Xen' immediately. Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH 06/40] Simplify the Xen get version driver method

2013-05-06 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The hypervisor driver is mandatory, so the the call to xenHypervisorGetVersion must always succeed. Thus there is no need to ever run xenDaemonGetVersion Signed-off-by: Daniel P. Berrange berra...@redhat.com ---

Re: [libvirt] [PATCH 07/40] Simplify the Xen get max vcpus / node get info driver methods

2013-05-06 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Unconditionally call into xenHypervisorGetMaxVcpus and xenDaemonNodeGetInfo respectively, since those drivers are both mandatory Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/xen/xen_driver.c | 15

Re: [libvirt] [PATCH 08/40] Simplify the Xen count/list domains driver methods

2013-05-06 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The XenStore driver is mandatory, so it can be used unconditonally for the xenUnifiedConnectListDomains xenUnifiedConnectNumOfDomains drivers. Delete the unused XenD and Hypervisor driver code for listing / counting

Re: [libvirt] [PATCH 09/40] Simplify the Xen domain create driver method

2013-05-06 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Unconditionally call xenDaemonCreateXML in the xenUnifiedDomainCreateXML driver, since the XenD driver is always present. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/xen/xen_driver.c| 6 ++

Re: [libvirt] [PATCH 08/40] Simplify the Xen count/list domains driver methods

2013-05-06 Thread Jim Fehlig
Jim Fehlig wrote: Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The XenStore driver is mandatory, so it can be used unconditonally for the xenUnifiedConnectListDomains xenUnifiedConnectNumOfDomains drivers. Delete the unused XenD and Hypervisor driver code

Re: [libvirt] [PATCH 10/40] Simplify the Xen domain lookup driver methods

2013-05-06 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Unconditionally invoke the xenHypervisorLookupDomainByID, xenHypervisorLookupDomainByUUID or xenDaemonLookupByName for looking up domains. Fallback to xenXMDomainLookupByUUID and xenXMDomainLookupByName for legacy XenD

Re: [libvirt] [PATCH 11/40] Simplify the Xen domain is persistent driver method

2013-05-06 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Unconditionally call xenDaemonLookupByUUID, since the XenD driver must always be present. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/xen/xen_driver.c | 41 +++--

Re: [libvirt] [PATCH 12/40] Simplify the Xen domain suspend/resume driver methods

2013-05-06 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Update xenUnifiedDomainSuspend and xenUnifiedDomainResume to unconditionally invoke the XenD APIs for suspend/resume. Delete the impls in the hypervisor driver which was unreachable. Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH 13/40] Simplify the Xen domain shutdown/reboot driver methods

2013-05-06 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Make the xenUnifiedDomainShutdownFlags and xenUnifiedDomainReboot driver methods unconditionally call the XenD APIs for shutdown and reboot. Delete the unreachable impls in the XenStore driver. Signed-off-by: Daniel P.

Re: [libvirt] [PATCH 14/40] Simplify the Xen domain destroy driver method

2013-05-06 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Unconditionally call the xenDaemonDomainDestroyFlags API since the XenD driver is always available. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/xen/xen_driver.c | 19 +---

Re: [libvirt] [PATCH 15/40] Simplify the Xen domain get OS type driver method

2013-05-06 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Make xenUnifiedDomainGetOSType directly call either the xenHypervisorDomainGetOSType or xenDaemonDomainGetOSType method depending on whether the domain is active or not. Useful to add a note about removing the unused

Re: [libvirt] [PATCH 15/40] Simplify the Xen domain get OS type driver method

2013-05-06 Thread Jim Fehlig
Jim Fehlig wrote: Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Make xenUnifiedDomainGetOSType directly call either the xenHypervisorDomainGetOSType or xenDaemonDomainGetOSType method depending on whether the domain is active or not. Useful to add

Re: [libvirt] [PATCH 16/40] Remove Xen get hostname driver method

2013-05-06 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The xenGetHostname entry point in the xenUnifiedDriver table was unused. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/xen/xen_driver.h | 1 - 1 file changed, 1 deletion(-) ACK. Regards, Jim

Re: [libvirt] [PATCH 10/40] Simplify the Xen domain lookup driver methods

2013-05-06 Thread Jim Fehlig
Jim Fehlig wrote: Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Unconditionally invoke the xenHypervisorLookupDomainByID, xenHypervisorLookupDomainByUUID or xenDaemonLookupByName for looking up domains. Fallback to xenXMDomainLookupByUUID

Re: [libvirt] [PATCH 17/40] Simplify the Xen domain get/set (max) memory driver methods

2013-05-06 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Simplify the Xen memory limit driver methods to directly call the most appropriate sub-driver Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/xen/xen_driver.c | 50 ++-

Re: [libvirt] [PATCH 18/40] Simplify the Xen domain get info/state driver methods

2013-05-07 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Make the xenUnifiedDomainGetInfo and xenUnifiedDomainGetState drivers call the correct sub-driver APIs directly. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/xen/xen_driver.c | 52

Re: [libvirt] [PATCH 19/40] Simplify the Xen domain save/restore driver methods

2013-05-07 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Unconditionally call the XenD APIs for save/restore, since that driver will always be open. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/xen/xen_driver.c| 21 -

Re: [libvirt] [PATCH 20/40] Simplify the Xen domain VCPU driver methods

2013-05-08 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/xen/xen_driver.c | 91 src/xen/xen_driver.h | 2 -- src/xen/xen_hypervisor.c | 90

Re: [libvirt] [PATCH 10/40] Simplify the Xen domain lookup driver methods

2013-05-08 Thread Jim Fehlig
Daniel P. Berrange wrote: On Wed, May 08, 2013 at 11:37:44AM +0100, Daniel P. Berrange wrote: On Mon, May 06, 2013 at 09:40:43PM -0600, Jim Fehlig wrote: Jim Fehlig wrote: Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Unconditionally

Re: [libvirt] [PATCH 10/40] Simplify the Xen domain lookup driver methods

2013-05-08 Thread Jim Fehlig
Daniel P. Berrange wrote: On Mon, May 06, 2013 at 03:01:25PM -0600, Jim Fehlig wrote: Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Unconditionally invoke the xenHypervisorLookupDomainByID, xenHypervisorLookupDomainByUUID or xenDaemonLookupByName

Re: [libvirt] [PATCH 21/40] Simplify the Xen domain get XML driver method

2013-05-08 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The xenUnifiedDomainGetXMLDesc driver can assume that the XM and XenD drivers are always present Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/xen/xen_driver.c| 24 +---

Re: [libvirt] [PATCH 22/40] Simplify the Xen domain migration driver methods

2013-05-08 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com All the migration code is done by the XenD subdriver which can be assumed to always be present Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/xen/xen_driver.c | 32 +--- 1

Re: [libvirt] [PATCH 23/40] Simplify the Xen driver define domain driver methods

2013-05-08 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Directly call either XenD or the XM driver for handling domain define operations. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/xen/xen_driver.c| 28 ++--

Re: [libvirt] [PATCH 25/40] Simplify the Xen domain define/undefine driver methods

2013-05-08 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Make the domain define/undefine driver methods directly call into either the XenD or XM drivers Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/xen/xen_driver.c| 24

Re: [libvirt] [PATCH 24/40] Simplify the Xen domain start driver method

2013-05-08 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Directly call either the XenD or XM driver when starting a persistent domain Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/xen/xen_driver.c| 20 +++- src/xen/xen_driver.h| 1 -

Re: [libvirt] [PATCH 26/40] Simplify the Xen domain attach/dettach driver methods

2013-05-08 Thread Jim Fehlig
Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Make the domain attach/dettach driver methods directly call into either the XenD or XM drivers Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/xen/xen_driver.c| 55

  1   2   3   4   5   6   7   8   9   10   >