Re: [libvirt] [Qemu-devel] IO accounting overhaul

2014-09-05 Thread Kevin Wolf
Am 01.09.2014 um 13:41 hat Markus Armbruster geschrieben: > Benoît Canet writes: > > > The Monday 01 Sep 2014 à 11:52:00 (+0200), Markus Armbruster wrote : > >> Cc'ing libvirt following Stefan's lead. > >> > >> Benoît Canet writes: > >> > /* the following would compute latecies for slices of 1

Re: [libvirt] [Qemu-devel] IO accounting overhaul

2014-09-08 Thread Kevin Wolf
Am 08.09.2014 um 09:12 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 01.09.2014 um 13:41 hat Markus Armbruster geschrieben: > >> Benoît Canet writes: > >> > >> > The Monday 01 Sep 2014 à 11:52:00 (+0200), Markus Armbruster wrote :

Re: [libvirt] [RFC PATCH] qcow2: Fix race in cache invalidation

2014-09-24 Thread Kevin Wolf
Am 23.09.2014 um 10:47 hat Alexey Kardashevskiy geschrieben: > On 09/19/2014 06:47 PM, Kevin Wolf wrote:> Am 16.09.2014 um 14:59 hat Paolo > Bonzini geschrieben: > >> Il 16/09/2014 14:52, Kevin Wolf ha scritto: > >>> Yes, that's true. We can't fix this prob

Re: [libvirt] [Qemu-devel] internal snapshots with sheepdog

2015-09-18 Thread Kevin Wolf
Am 18.09.2015 um 11:03 hat Vasiliy Tolstov geschrieben: > 2015-09-18 12:02 GMT+03:00 Kevin Wolf : > > Doesn't sheepdog already support storing snapshots in the same image? > > I thought it would just work; at least, there's some code there for it. > > Yes, qemu and

Re: [libvirt] [PATCH 1/1] qemu: add support for multiple gluster hosts

2015-10-05 Thread Kevin Wolf
nly formatting it this way for readability): -drive file.driver=gluster, file.volname=testvol, file.image-path=/a.qcow2, file.volfile-servers.0.server=1.2.3.4, file.volfile-servers.0.port=24009, ... > > "transport": "tcp" > &g

Re: [libvirt] [PATCH 1/1] qemu: add support for multiple gluster hosts

2015-10-05 Thread Kevin Wolf
Am 05.10.2015 um 15:01 hat Peter Krempa geschrieben: > On Mon, Oct 05, 2015 at 14:51:00 +0200, Kevin Wolf wrote: > > Am 05.10.2015 um 13:01 hat Peter Krempa geschrieben: > > > On Mon, Oct 05, 2015 at 15:30:42 +0530, Prasanna Kumar Kalever wrote: > > ... > > > >

Re: [libvirt] [RFC PATCH] qcow2: Fix race in cache invalidation

2014-09-25 Thread Kevin Wolf
Am 25.09.2014 um 10:41 hat Alexey Kardashevskiy geschrieben: > On 09/24/2014 07:48 PM, Kevin Wolf wrote: > > Am 23.09.2014 um 10:47 hat Alexey Kardashevskiy geschrieben: > >> On 09/19/2014 06:47 PM, Kevin Wolf wrote:> Am 16.09.2014 um 14:59 hat > >> Paolo Bonzini ges

Re: [libvirt] [RFC PATCH] qcow2: Fix race in cache invalidation

2014-09-25 Thread Kevin Wolf
Am 25.09.2014 um 11:55 hat Alexey Kardashevskiy geschrieben: > Right. Cool. So is below what was suggested? I am doublechecking as it does > not solve the original issue - the bottomhalf is called first and then > nbd_trip() crashes in qcow2_co_flush_to_os(). > > diff --git a/block.c b/block.c > i

Re: [libvirt] [RFC PATCH] qcow2: Fix race in cache invalidation

2014-09-25 Thread Kevin Wolf
Am 25.09.2014 um 14:29 hat Alexey Kardashevskiy geschrieben: > On 09/25/2014 08:20 PM, Kevin Wolf wrote: > > Am 25.09.2014 um 11:55 hat Alexey Kardashevskiy geschrieben: > >> Right. Cool. So is below what was suggested? I am doublechecking as it does > >> not sol

Re: [libvirt] [Qemu-devel] [PATCH] block: Set cdrom device read only flag

2012-09-20 Thread Kevin Wolf
Am 13.08.2012 09:54, schrieb Kevin Wolf: > Am 12.08.2012 04:48, schrieb Kevin Shanahan: >> So qmp_change_blockdev uses bdrv_is_read_only() to check whether to >> try and open the backing file read only, which uses the ->read_only >> member of struct BlockDriverState to de

Re: [libvirt] [PATCH] blockdev: preserve readonly and snapshot states across media changes

2012-09-21 Thread Kevin Wolf
Am 21.09.2012 01:20, schrieb Kevin Shanahan: > If readonly=on is given at device creation time, the ->readonly flag > needs to be set in the block driver state for this device so that > readonly-ness is preserved across media changes (qmp change command). > Similarly, to preserve the snapshot prope

Re: [libvirt] [PATCH v2 2/3] monitor: Enable adding an inherited fd to an fd set

2012-10-11 Thread Kevin Wolf
Am 10.10.2012 16:20, schrieb Corey Bryant: > qmp_add_fd() gets an fd that was received over a socket with > SCM_RIGHTS and adds it to an fd set. This patch adds support > that will enable adding an fd that was inherited on the > command line to an fd set. > > This patch also prevents removal of a

Re: [libvirt] [Qemu-devel] [PATCH v2 2/3] monitor: Enable adding an inherited fd to an fd set

2012-10-12 Thread Kevin Wolf
Am 11.10.2012 17:04, schrieb Corey Bryant: > > > On 10/11/2012 07:25 AM, Kevin Wolf wrote: >> Am 10.10.2012 16:20, schrieb Corey Bryant: >>> qmp_add_fd() gets an fd that was received over a socket with >>> SCM_RIGHTS and adds it to an fd set. This patch adds su

Re: [libvirt] [PATCH v3 2/4] monitor: Enable adding an inherited fd to an fd set

2012-10-17 Thread Kevin Wolf
Am 16.10.2012 20:08, schrieb Corey Bryant: > qmp_add_fd() gets an fd that was received over a socket with > SCM_RIGHTS and adds it to an fd set. This patch adds support > that will enable adding an fd that was inherited on the > command line to an fd set. > > Note: All of the code added to monito

Re: [libvirt] [PATCH v3 4/4] qemu-config: Add new -add-fd command line option

2012-10-17 Thread Kevin Wolf
Am 17.10.2012 06:16, schrieb Eric Blake: > I'm still seeing the corner case of: > > qemu-kvm -add-fd fd=3,set=1 -add-fd fd=4,set=2 4<&- > > where the dup(3) will populate fd 4 prior to the point where we get to > process the -add-fd fd=4 command to notice that the user started > qemu-kvm with fd

Re: [libvirt] [PATCH v3 4/4] qemu-config: Add new -add-fd command line option

2012-10-17 Thread Kevin Wolf
Am 17.10.2012 17:01, schrieb Eric Blake: > On 10/17/2012 08:02 AM, Kevin Wolf wrote: >> Am 17.10.2012 06:16, schrieb Eric Blake: >>> I'm still seeing the corner case of: >>> >>> qemu-kvm -add-fd fd=3,set=1 -add-fd fd=4,set=2 4<&- >>> >>

Re: [libvirt] [PATCH v4 4/4] qemu-config: Add new -add-fd command line option

2012-10-19 Thread Kevin Wolf
Am 18.10.2012 23:37, schrieb Corey Bryant: > > > On 10/18/2012 04:43 PM, Eric Blake wrote: >> On 10/18/2012 01:19 PM, Corey Bryant wrote: >>> This option can be used for passing file descriptors on the >>> command line. It mirrors the existing add-fd QMP command which >>> allows an fd to be pass

Re: [libvirt] [PATCH v5 0/6] file descriptor passing using fd sets

2012-07-24 Thread Kevin Wolf
Am 23.07.2012 15:07, schrieb Corey Bryant: > Corey Bryant (6): > qemu-char: Add MSG_CMSG_CLOEXEC flag to recvmsg > qapi: Introduce add-fd, remove-fd, query-fdsets > monitor: Clean up fd sets on monitor disconnect > block: Convert open calls to qemu_open > block: Convert close calls to qem

Re: [libvirt] [PATCH v5 6/6] block: Enable qemu_open/close to work with fd sets

2012-07-24 Thread Kevin Wolf
Am 23.07.2012 15:08, schrieb Corey Bryant: > When qemu_open is passed a filename of the "/dev/fdset/nnn" > format (where nnn is the fdset ID), an fd with matching access > mode flags will be searched for within the specified monitor > fd set. If the fd is found, a dup of the fd will be returned >

Re: [libvirt] [Qemu-devel] [PATCH v5 6/6] block: Enable qemu_open/close to work with fd sets

2012-07-25 Thread Kevin Wolf
Am 25.07.2012 05:41, schrieb Corey Bryant: >>> diff --git a/block/raw-posix.c b/block/raw-posix.c >>> index a172de3..5d0a801 100644 >>> --- a/block/raw-posix.c >>> +++ b/block/raw-posix.c >>> @@ -271,7 +271,7 @@ static int raw_open_common(BlockDriverState *bs, const >>> char *filename, >>> out_f

Re: [libvirt] [PATCH v5 6/6] block: Enable qemu_open/close to work with fd sets

2012-07-26 Thread Kevin Wolf
Am 26.07.2012 05:57, schrieb Corey Bryant: > On 07/25/2012 03:43 PM, Eric Blake wrote: >> On 07/23/2012 07:08 AM, Corey Bryant wrote: >>> +int monitor_fdset_get_fd(Monitor *mon, int64_t fdset_id, int flags) >>> +{ >>> +mon_fdset_t *mon_fdset; >>> +mon_fdset_fd_t *mon_fdset_fd; >>> +int

Re: [libvirt] [Qemu-devel] [PATCH v5 6/6] block: Enable qemu_open/close to work with fd sets

2012-07-26 Thread Kevin Wolf
Am 26.07.2012 15:13, schrieb Eric Blake: > On 07/25/2012 09:21 PM, Corey Bryant wrote: >> >> >> On 07/25/2012 03:25 PM, Eric Blake wrote: >>> On 07/25/2012 02:22 AM, Kevin Wolf wrote: >>>>>> Hm, not a nice interface where qemu_close() needs the fi

Re: [libvirt] [PATCH v5 6/6] block: Enable qemu_open/close to work with fd sets

2012-08-06 Thread Kevin Wolf
Am 03.08.2012 00:21, schrieb Corey Bryant: >>> @@ -84,6 +158,36 @@ int qemu_open(const char *name, int flags, ...) >>> int ret; >>> int mode = 0; >>> >>> +#ifndef _WIN32 >>> +const char *fdset_id_str; >>> + >>> +/* Attempt dup of fd from fd set */ >>> +if (strstart(name, "/d

Re: [libvirt] [PATCH] block: Set cdrom device read only flag

2012-08-06 Thread Kevin Wolf
Am 02.08.2012 09:20, schrieb Kevin Shanahan: > On Thu, Aug 02, 2012 at 02:49:52PM +0930, Kevin Shanahan wrote: >> On Thu, Aug 02, 2012 at 11:46:13AM +0930, Kevin Shanahan wrote: >>> On Thu, Aug 02, 2012 at 11:02:42AM +0930, Kevin Shanahan wrote: Set the block driver read_only flag for cdrom de

Re: [libvirt] [PATCH v5 6/6] block: Enable qemu_open/close to work with fd sets

2012-08-06 Thread Kevin Wolf
Am 06.08.2012 15:32, schrieb Corey Bryant: > On 08/06/2012 05:15 AM, Kevin Wolf wrote: >> Am 03.08.2012 00:21, schrieb Corey Bryant: >>>>> @@ -84,6 +158,36 @@ int qemu_open(const char *name, int flags, ...) >>>>>int ret; >>>>

Re: [libvirt] [PATCH] block: Set cdrom device read only flag

2012-08-09 Thread Kevin Wolf
Am 07.08.2012 10:47, schrieb Markus Armbruster: > Kevin Wolf writes: > >> Am 02.08.2012 09:20, schrieb Kevin Shanahan: >>> On Thu, Aug 02, 2012 at 02:49:52PM +0930, Kevin Shanahan wrote: >>>> On Thu, Aug 02, 2012 at 11:46:13AM +0930, Kevin Shanahan wrote: >>

Re: [libvirt] [PATCH v7 2/6] qapi: Introduce add-fd, remove-fd, query-fdsets

2012-08-09 Thread Kevin Wolf
Am 07.08.2012 18:49, schrieb Eric Blake: > On 08/07/2012 09:58 AM, Corey Bryant wrote: >> This patch adds support that enables passing of file descriptors >> to the QEMU monitor where they will be stored in specified file >> descriptor sets. >> >> A file descriptor set can be used by a client like

Re: [libvirt] [PATCH v8 2/7] qapi: Introduce add-fd, remove-fd, query-fdsets

2012-08-10 Thread Kevin Wolf
Am 10.08.2012 04:10, schrieb Corey Bryant: > This patch adds support that enables passing of file descriptors > to the QEMU monitor where they will be stored in specified file > descriptor sets. > > A file descriptor set can be used by a client like libvirt to > store file descriptors for the same

Re: [libvirt] [PATCH v8 7/7] block: Enable qemu_open/close to work with fd sets

2012-08-10 Thread Kevin Wolf
Am 10.08.2012 04:10, schrieb Corey Bryant: > When qemu_open is passed a filename of the "/dev/fdset/nnn" > format (where nnn is the fdset ID), an fd with matching access > mode flags will be searched for within the specified monitor > fd set. If the fd is found, a dup of the fd will be returned >

Re: [libvirt] [PATCH v8 0/7] file descriptor passing using fd sets

2012-08-10 Thread Kevin Wolf
Am 10.08.2012 04:10, schrieb Corey Bryant: > libvirt's sVirt security driver provides SELinux MAC isolation for > Qemu guest processes and their corresponding image files. In other > words, sVirt uses SELinux to prevent a QEMU process from opening > files that do not belong to it. > > sVirt provi

Re: [libvirt] [PATCH] block: Set cdrom device read only flag

2012-08-13 Thread Kevin Wolf
Am 12.08.2012 04:48, schrieb Kevin Shanahan: > So qmp_change_blockdev uses bdrv_is_read_only() to check whether to > try and open the backing file read only, which uses the ->read_only > member of struct BlockDriverState to decide whether to pass the > BDRV_O_RDRW flag to qmp_bdrv_open_encypted() a

Re: [libvirt] [PATCH] block: Set cdrom device read only flag

2012-08-13 Thread Kevin Wolf
Am 13.08.2012 13:57, schrieb Markus Armbruster: > Kevin Wolf writes: > >> Am 12.08.2012 04:48, schrieb Kevin Shanahan: >>> So qmp_change_blockdev uses bdrv_is_read_only() to check whether to >>> try and open the backing file read only, which uses the -&

Re: [libvirt] [Qemu-devel] [PATCH v10 0/7] file descriptor passing using fd sets

2012-08-14 Thread Kevin Wolf
Am 13.08.2012 20:39, schrieb Corey Bryant: > > > On 08/13/2012 02:02 PM, Eric Blake wrote: >> On 08/13/2012 08:08 AM, Corey Bryant wrote: >>> libvirt's sVirt security driver provides SELinux MAC isolation for >>> Qemu guest processes and their corresponding image files. In other >>> words, sVirt

Re: [libvirt] [PATCH v10 6/7] block: Enable qemu_open/close to work with fd sets

2012-08-14 Thread Kevin Wolf
Am 13.08.2012 16:08, schrieb Corey Bryant: > When qemu_open is passed a filename of the "/dev/fdset/nnn" > format (where nnn is the fdset ID), an fd with matching access > mode flags will be searched for within the specified monitor > fd set. If the fd is found, a dup of the fd will be returned >

Re: [libvirt] [PATCH 0/3] add disk driver metadata_cache_size option

2018-11-02 Thread Kevin Wolf
Am 01.11.2018 um 12:32 hat Nikolay Shirokovskiy geschrieben: > Hi, all. > > This is a patch series after offlist agreement on introducing > metadata-cache-size option for disks. The options itself is described in 2nd > patch of the series. > > There is a plenty of attempts to add option to set qc

Re: [libvirt] [PATCH 3/3] qemu: support metadata-cache-size for blockdev

2018-11-02 Thread Kevin Wolf
Am 01.11.2018 um 12:32 hat Nikolay Shirokovskiy geschrieben: > Just set l2-cache-size to INT64_MAX for all format nodes of > qcow2 type in block node graph. > > AFAIK this is sane because *actual* cache size depends on size > of data being referenced in image and thus the total size of > all cache

Re: [libvirt] [PATCH 3/3] qemu: support metadata-cache-size for blockdev

2018-11-02 Thread Kevin Wolf
Am 02.11.2018 um 12:37 hat Nikolay Shirokovskiy geschrieben: > On 02.11.2018 13:23, Kevin Wolf wrote: > > Am 01.11.2018 um 12:32 hat Nikolay Shirokovskiy geschrieben: > >> Just set l2-cache-size to INT64_MAX for all format nodes of > >> qcow2 type in block node graph. &

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Kevin Wolf
Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: > > On 06/15/2018 04:21 PM, Kevin Wolf wrote: > > The -drive option serial was deprecated in QEMU 2.10. It's time to > > remove it. > > > > Tests need to be updated to set the serial number with -glo

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Kevin Wolf
Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben: > > > On 06/22/2018 02:55 PM, Kevin Wolf wrote: > > Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: > >> > >> On 06/15/2018 04:21 PM, Kevin Wolf wrote: > >>> The -drive op

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Kevin Wolf
Am 22.06.2018 um 16:38 hat Christian Borntraeger geschrieben: > > > On 06/22/2018 04:25 PM, Kevin Wolf wrote: > > Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben: > >> > >> > >> On 06/22/2018 02:55 PM, Kevin Wolf wrote: > >>

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Kevin Wolf
Am 22.06.2018 um 17:40 hat Daniel P. Berrangé geschrieben: > On Fri, Jun 22, 2018 at 04:25:13PM +0200, Kevin Wolf wrote: > > This was in fact one release longer than our deprecation policy says. > > Are we serious about the deprecation policy or aren't we? > > > &

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-25 Thread Kevin Wolf
Am 25.06.2018 um 11:53 hat Daniel P. Berrangé geschrieben: > On Fri, Jun 22, 2018 at 03:31:46PM +0100, Daniel P. Berrangé wrote: > > On Fri, Jun 22, 2018 at 04:25:13PM +0200, Kevin Wolf wrote: > > > Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben: > > > &

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-02 Thread Kevin Wolf
Am 25.06.2018 um 13:45 hat Peter Krempa geschrieben: > On Mon, Jun 25, 2018 at 13:41:06 +0200, Kevin Wolf wrote: > > Am 25.06.2018 um 11:53 hat Daniel P. Berrangé geschrieben: > > > On Fri, Jun 22, 2018 at 03:31:46PM +0100, Daniel P. Berrangé wrote: > > > > On Fri, Ju

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-03 Thread Kevin Wolf
Am 03.07.2018 um 13:22 hat Daniel P. Berrangé geschrieben: > On Tue, Jul 03, 2018 at 12:53:44PM +0200, Christian Borntraeger wrote: > > > > > > On 07/02/2018 10:04 AM, Kevin Wolf wrote: > > > Am 25.06.2018 um 13:45 hat Peter Krempa geschrieben: > > >&

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-04 Thread Kevin Wolf
Am 04.07.2018 um 15:02 hat Cornelia Huck geschrieben: > On Tue, 3 Jul 2018 13:32:29 +0200 > Kevin Wolf wrote: > > > > > > Has serial/gemoetry been fixed meanwhile and will it make it into the > > > > > next release? > > > > > > &

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-04 Thread Kevin Wolf
Am 04.07.2018 um 15:43 hat Daniel P. Berrangé geschrieben: > On Wed, Jul 04, 2018 at 03:34:40PM +0200, Kevin Wolf wrote: > > I understand where you're coming from, but let's be honest: It's not as > > if disk geometry or serial numbers were features that absolutel

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-06 Thread Kevin Wolf
Am 06.07.2018 um 13:11 hat Cornelia Huck geschrieben: > On Wed, 4 Jul 2018 17:14:02 +0100 > Peter Maydell wrote: > > > On 4 July 2018 at 14:34, Kevin Wolf wrote: > > > Essentially, what is important to me isn't getting these options dropped > > > exactly in

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-10 Thread Kevin Wolf
Am 10.07.2018 um 16:22 hat Cornelia Huck geschrieben: > On Tue, 10 Jul 2018 07:59:15 +0200 > Markus Armbruster wrote: > > > In addition to actively pulling libvirt developers into review of > > deprecation patches, we should pursue the idea to optionally let QEMU > > fail on use of deprecated fea

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-12 Thread Kevin Wolf
Am 12.07.2018 um 09:48 hat Cornelia Huck geschrieben: > On Thu, 12 Jul 2018 08:51:16 +0200 > Markus Armbruster wrote: > > > Markus Armbruster writes: > > > > > Kevin Wolf writes: > > > > > >> Am 10.07.2018 um 16:22 hat Cornelia Huck geschr

Re: [libvirt] [PATCH RFC 00/39] qemu: Add support for -blockdev

2018-07-26 Thread Kevin Wolf
Am 25.07.2018 um 17:57 hat Peter Krempa geschrieben: > This series adds support for starting and hotplug of disks with > -blockdev/blockdev-add. > > Blockjobs are not supported and thus the last patch should not be > applied yet as some refactoring of the jobs is required. > > At the beginning of

Re: [libvirt] [PATCH RFC 00/39] qemu: Add support for -blockdev

2018-07-27 Thread Kevin Wolf
Am 27.07.2018 um 10:01 hat Peter Krempa geschrieben: > On Thu, Jul 26, 2018 at 17:04:19 +0800, Fam Zheng wrote: > > On Thu, 07/26 10:44, Kevin Wolf wrote: > > > Am 25.07.2018 um 17:57 hat Peter Krempa geschrieben: > > > > This series adds support for star

[libvirt] [PATCH 0/3] scsi-disk: Device Identification fixes

2019-01-25 Thread Kevin Wolf
/show_bug.cgi?id=1668248 Kevin Wolf (3): scsi-disk: Don't use empty string as device id scsi-disk: Add device_id property scsi-disk: Deprecate device_id fallback to BlockBackend name hw/scsi/scsi-disk.c | 41 - qemu-deprecated.texi

[libvirt] [PATCH 1/3] scsi-disk: Don't use empty string as device id

2019-01-25 Thread Kevin Wolf
ipath setup, which is obviously not what was intended. Instead of using an empty string for the vendor specific designator, simply leave out that designator, which makes Linux detect such setups as separate disks again. Signed-off-by: Kevin Wolf --- hw/scsi/scsi-disk.c | 14 -- 1 file ch

[libvirt] [PATCH 2/3] scsi-disk: Add device_id property

2019-01-25 Thread Kevin Wolf
BlockBackend name is used) to -blockdev (where the vendor specific designator is left out by default). Signed-off-by: Kevin Wolf --- hw/scsi/scsi-disk.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 93eef40b87

[libvirt] [PATCH 3/3] scsi-disk: Deprecate device_id fallback to BlockBackend name

2019-01-25 Thread Kevin Wolf
We should never have exposed BlockBackend names to the guest, it's a host detail. Deprecate this behaviour. Users who need to maintain the guest ABI can explicitly set the value with the device_id property. Signed-off-by: Kevin Wolf --- hw/scsi/scsi-disk.c | 5 + qemu-deprecated.texi

Re: [libvirt] [PATCH 2/3] scsi-disk: Add device_id property

2019-01-28 Thread Kevin Wolf
Am 28.01.2019 um 09:50 hat Peter Krempa geschrieben: > On Fri, Jan 25, 2019 at 18:46:52 +0100, Kevin Wolf wrote: > > The new device_id property specifies which value to use for the vendor > > specific designator in the Device Identification VPD page. > > > > In partic

Re: [libvirt] [PATCH] qmp: Deprecate query-nodes option of query-blockstats

2019-01-28 Thread Kevin Wolf
Am 28.01.2019 um 16:15 hat Anton Kuchin geschrieben: > This option is broken since a6baa60807 in v2.9 and returns mostly > zeroes instead of real stats because actual querring of BlockStats > that resides in blk is missing. > > And it makes no sense because with this option BlockDriverState-s > ar

Re: [libvirt] [PATCH] qmp: Deprecate query-nodes option of query-blockstats

2019-01-28 Thread Kevin Wolf
Am 28.01.2019 um 17:12 hat Daniel P. Berrangé geschrieben: > On Mon, Jan 28, 2019 at 04:37:50PM +0100, Kevin Wolf wrote: > > Am 28.01.2019 um 16:15 hat Anton Kuchin geschrieben: > > > This option is broken since a6baa60807 in v2.9 and returns mostly > > > zeroes in

Re: [libvirt] [Qemu-devel] [PATCH 2/3] scsi-disk: Add device_id property

2019-01-28 Thread Kevin Wolf
Am 28.01.2019 um 17:55 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 28.01.2019 um 09:50 hat Peter Krempa geschrieben: > [...] > >> 2) Is actually using 'scsi-cd'/'scsi-hd' the better option than > >> 'scsi-disk&#x

Re: [libvirt] [Qemu-devel] [PATCH 1/3] scsi-disk: Don't use empty string as device id

2019-01-30 Thread Kevin Wolf
Am 29.01.2019 um 17:37 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > scsi-disk includes in the Device Identification VPD page, depending on > > configuration amongst others, a vendor specific designator that consists > > either of the serial number if g

Re: [libvirt] [PATCH 0/3] scsi-disk: Device Identification fixes

2019-02-01 Thread Kevin Wolf
Am 25.01.2019 um 18:46 hat Kevin Wolf geschrieben: > The vendor specific designator in the Device Identification VPD page has > two problems: > > 1. It defaults to the BlockBackend name (-drive id=...), which everyone >expected to be a host detail that the guest never se

Re: [libvirt] [PATCH 3/3] scsi-disk: Deprecate device_id fallback to BlockBackend name

2019-02-04 Thread Kevin Wolf
Am 29.01.2019 um 16:58 hat Daniel P. Berrangé geschrieben: > On Fri, Jan 25, 2019 at 06:46:53PM +0100, Kevin Wolf wrote: > > We should never have exposed BlockBackend names to the guest, it's a > > host detail. Deprecate this behaviour. Users who need to maintain the > >

Re: [libvirt] [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-15 Thread Kevin Wolf
Am 14.08.2019 um 21:27 hat John Snow geschrieben: > > > On 8/14/19 6:07 AM, Vladimir Sementsov-Ogievskiy wrote: > > To get rid of implicit filters related workarounds in future let's > > deprecate them now. > > > > Signed-off-by: Vladimir Sementsov-Ogievskiy > > --- > > qemu-deprecated.texi

Re: [libvirt] [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-15 Thread Kevin Wolf
Am 15.08.2019 um 18:07 hat John Snow geschrieben: > > > On 8/15/19 6:49 AM, Kevin Wolf wrote: > > Am 14.08.2019 um 21:27 hat John Snow geschrieben: > >> > >> > >> On 8/14/19 6:07 AM, Vladimir Sementsov-Ogievskiy wrote: > >>> To get rid o

Re: [libvirt] [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-16 Thread Kevin Wolf
Am 15.08.2019 um 21:24 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 15.08.2019 um 18:07 hat John Snow geschrieben: > >> > >> > >> On 8/15/19 6:49 AM, Kevin Wolf wrote: > >> > Am 14.08.2019 um 21:27 hat John Snow gesc

Re: [libvirt] [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-09-02 Thread Kevin Wolf
Am 30.08.2019 um 20:11 hat John Snow geschrieben: > > > On 8/30/19 6:07 AM, Christophe de Dinechin wrote: > > Without having looked at the code much, I think I would > > > > 1. extend the existing QAPI error to support warnings, deprecations and > >info messages. The first problem I see is t

Re: [libvirt] [PATCH 2/2] qapi: deprecate implicit filters

2019-09-02 Thread Kevin Wolf
Am 23.08.2019 um 11:22 hat Vladimir Sementsov-Ogievskiy geschrieben: > 14.08.2019 13:07, Vladimir Sementsov-Ogievskiy wrote: > > To get rid of implicit filters related workarounds in future let's > > deprecate them now. > > Interesting, could we deprecate implicit filter without deprecation of > u

Re: [libvirt] [PATCH 0/2] qemu: Enable -blockdev support (blockdev-add saga)

2019-09-16 Thread Kevin Wolf
Am 16.09.2019 um 11:32 hat Peter Krempa geschrieben: > (ccing Kevin) > > On Mon, Sep 16, 2019 at 10:14:44 +0100, Daniel Berrange wrote: > > On Fri, Sep 13, 2019 at 02:43:53PM +0200, Peter Krempa wrote: > > > To my knowledge, everything in libvirt is now prepared to fully use > > > -blockdev way to

Re: [libvirt] [PULL 01/19] util/hbitmap: strict hbitmap_reset

2019-10-15 Thread Kevin Wolf
Am 14.10.2019 um 20:10 hat John Snow geschrieben: > > > On 10/11/19 7:18 PM, John Snow wrote: > > > > > > On 10/11/19 5:48 PM, Eric Blake wrote: > >> On 10/11/19 4:25 PM, John Snow wrote: > >>> From: Vladimir Sementsov-Ogievskiy > >>> > >>> hbitmap_reset has an unobvious property: it rounds re

Re: [libvirt] [RFC PATCH 02/30] qemu: domain: Format storage source node names into private data

2018-04-20 Thread Kevin Wolf
Am 19.04.2018 um 17:24 hat Peter Krempa geschrieben: > Save and restore node names if we know them in the status XML so that we > don't need to recalculate them or don't lose them in some cases. > > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_domain.c | 12 > 1 file changed, 1

Re: [libvirt] [RFC PATCH 05/30] qemu: block: Extract formatting of props for 'file' backend

2018-04-20 Thread Kevin Wolf
Am 19.04.2018 um 17:25 hat Peter Krempa geschrieben: > 'file' backend in qemu supports few more options than the current > implementation. Extract it so that changes don't pollute the code. > > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_block.c | 16 +--- > 1 file changed, 13

Re: [libvirt] [RFC PATCH 14/30] [RFC] qemu: block: Always set discard for storage nodes

2018-04-20 Thread Kevin Wolf
Am 19.04.2018 um 17:25 hat Peter Krempa geschrieben: > According to my research it seems that qemu always sets discard for the > storage nodes. Replicate this in our generator. > --- > src/qemu/qemu_block.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/qemu/qemu

Re: [libvirt] [RFC PATCH 15/30] qemu: block: Add support for creating 'format' layer for blockdev-add

2018-04-20 Thread Kevin Wolf
Am 19.04.2018 um 17:25 hat Peter Krempa geschrieben: > When using blockdev-add and friends, libvirt will need to create also > properties for the qcow2/raw/... format handler in qemu. This patch adds > the infrastructure and implements all formats known to libvirt including > all properties which a

Re: [libvirt] [RFC PATCH 02/30] qemu: domain: Format storage source node names into private data

2018-04-20 Thread Kevin Wolf
Am 20.04.2018 um 09:45 hat Peter Krempa geschrieben: > On Fri, Apr 20, 2018 at 09:30:16 +0200, Kevin Wolf wrote: > > Am 19.04.2018 um 17:24 hat Peter Krempa geschrieben: > > > Save and restore node names if we know them in the status XML so that we > > > don't n

Re: [libvirt] [RFC PATCH 05/30] qemu: block: Extract formatting of props for 'file' backend

2018-04-20 Thread Kevin Wolf
Am 20.04.2018 um 09:56 hat Peter Krempa geschrieben: > Is there a special need to use 'host_cdrom' explicitly if the CDROM > drive is used? That would complicate things since we don't know when > that will happen. You don't get the full CD-ROM passthrough functionality with host_device. Specifical

Re: [libvirt] [RFC PATCH 05/30] qemu: block: Extract formatting of props for 'file' backend

2018-04-20 Thread Kevin Wolf
Am 20.04.2018 um 10:50 hat Peter Krempa geschrieben: > On Fri, Apr 20, 2018 at 10:41:50 +0200, Kevin Wolf wrote: > > Am 20.04.2018 um 09:56 hat Peter Krempa geschrieben: > > > Is there a special need to use 'host_cdrom' explicitly if the CDROM > > > drive

Re: [libvirt] [RFC PATCH 22/30] tests: qemublock: Add tests for all other format without special options

2018-04-20 Thread Kevin Wolf
Am 19.04.2018 um 17:25 hat Peter Krempa geschrieben: > Similarly to the 'raw' case add tests for bochs, cloop, dmg, ploop, vdi > vhd, and vpc. Covering all supproted non-backing formats. > > Note that the JSON name for 'ploop' maps to 'parallels' and 'vhd' maps > to 'vhdx'. Your -drive lines belo

Re: [libvirt] [RFC PATCH 22/30] tests: qemublock: Add tests for all other format without special options

2018-04-23 Thread Kevin Wolf
Am 20.04.2018 um 21:20 hat Peter Krempa geschrieben: > On Fri, Apr 20, 2018 at 13:55:35 +0200, Kevin Wolf wrote: > > Am 19.04.2018 um 17:25 hat Peter Krempa geschrieben: > > > Similarly to the 'raw' case add tests for bochs, cloop, dmg, ploop, vdi > > > vhd

Re: [libvirt] [PATCH 00/35] qemu: Add formatting of JSON objects for -blockdev (blockdev-add saga)

2018-04-25 Thread Kevin Wolf
Am 25.04.2018 um 17:15 hat Peter Krempa geschrieben: > Diff to the RFC posting: > - host_device and host_cdrom handling was added > - modified code to format and parse node-names to status XML so that we > can add other node names easier (for quorum, throttling, etc) > - added test case for host_

Re: [libvirt] [Qemu-devel] [RFC] qcow3 format in libvirt

2013-03-04 Thread Kevin Wolf
Am 04.03.2013 um 14:09 hat Daniel P. Berrange geschrieben: > On Mon, Mar 04, 2013 at 01:58:12PM +0100, Ján Tomko wrote: > > Before posting another version of my patches [1], attempting to add > > support for the new qcow format to libvirt, I would like to know if this > > sounds reasonable: > > >

Re: [libvirt] [Qemu-devel] [RFC] qcow3 format in libvirt

2013-03-04 Thread Kevin Wolf
Am 04.03.2013 um 15:27 hat Daniel P. Berrange geschrieben: > On Mon, Mar 04, 2013 at 03:04:53PM +0100, Kevin Wolf wrote: > > Am 04.03.2013 um 14:09 hat Daniel P. Berrange geschrieben: > > > On Mon, Mar 04, 2013 at 01:58:12PM +0100, Ján Tomko wrote: > > > > Before

Re: [libvirt] [Qemu-devel] [RFC] qcow3 format in libvirt

2013-03-04 Thread Kevin Wolf
Am 04.03.2013 um 15:46 hat Daniel P. Berrange geschrieben: > On Mon, Mar 04, 2013 at 03:38:54PM +0100, Kevin Wolf wrote: > > Am 04.03.2013 um 15:27 hat Daniel P. Berrange geschrieben: > > > On Mon, Mar 04, 2013 at 03:04:53PM +0100, Kevin Wolf wrote: > > > > Am 04

Re: [libvirt] [Qemu-devel] [RFC] qcow3 format in libvirt

2013-03-04 Thread Kevin Wolf
Am 04.03.2013 um 16:19 hat Daniel P. Berrange geschrieben: > On Mon, Mar 04, 2013 at 04:05:50PM +0100, Kevin Wolf wrote: > > Am 04.03.2013 um 15:46 hat Daniel P. Berrange geschrieben: > > > On Mon, Mar 04, 2013 at 03:38:54PM +0100, Kevin Wolf wrote: > > > > Am 04

Re: [libvirt] [Qemu-devel] [RFC] qcow3 format in libvirt

2013-03-12 Thread Kevin Wolf
Am 11.03.2013 um 19:03 hat Ján Tomko geschrieben: > On 03/04/2013 04:40 PM, Kevin Wolf wrote: > > Am 04.03.2013 um 16:19 hat Daniel P. Berrange geschrieben: > >> On Mon, Mar 04, 2013 at 04:05:50PM +0100, Kevin Wolf wrote: > >>> > >>> I'm not tal

Re: [libvirt] [PATCH RFC] blockdev: copy legacy and common opts to qemu_drive_opts

2013-11-04 Thread Kevin Wolf
Am 04.11.2013 um 08:01 hat Amos Kong geschrieben: > Currently we have three QemuOptsList (qemu_common_drive_opts, > qemu_legacy_drive_opts, and qemu_drive_opts), only qemu_drive_opts > is added to vm_config_groups[]. > > We query commandline options by checking information in > vm_config_groups[],

Re: [libvirt] [PATCH v3] qmp: access the local QemuOptsLists for drive option

2013-11-12 Thread Kevin Wolf
Am 09.11.2013 um 05:15 hat Amos Kong geschrieben: > Currently we have three QemuOptsList (qemu_common_drive_opts, > qemu_legacy_drive_opts, and qemu_drive_opts), only qemu_drive_opts > is added to vm_config_groups[]. > > This patch changes query-command-line-options to access three local > QemuOpt

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/4] block: file descriptor passing using -filefd and getfd_file

2012-05-22 Thread Kevin Wolf
Am 21.05.2012 22:19, schrieb Corey Bryant: > libvirt's sVirt security driver provides SELinux MAC isolation for > Qemu guest processes and their corresponding image files. In other > words, sVirt uses SELinux to prevent a QEMU process from opening > files that do not belong to it. > > sVirt provi

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/4] block: file descriptor passing using -filefd and getfd_file

2012-05-22 Thread Kevin Wolf
Am 22.05.2012 14:02, schrieb Eric Blake: > On 05/22/2012 02:18 AM, Kevin Wolf wrote: > >>> This patch series adds the -filefd command-line option and the >>> getfd_file monitor command. This will enable libvirt to open a >>> file and push the correspondin

Re: [libvirt] [Qemu-devel] [RFC PATCH 1/4] qemu-options: Add -filefd command line option

2012-05-22 Thread Kevin Wolf
Am 22.05.2012 15:25, schrieb Corey Bryant: > > > On 05/21/2012 05:40 PM, Eric Blake wrote: >> On 05/21/2012 02:19 PM, Corey Bryant wrote: >>> This patch provides support for the -filefd command line option. >>> This option will allow passing of a filename and its corresponding >>> file descriptor

Re: [libvirt] [Qemu-devel] [RFC PATCH 1/4] qemu-options: Add -filefd command line option

2012-05-22 Thread Kevin Wolf
Am 22.05.2012 16:26, schrieb Stefan Hajnoczi: > On Tue, May 22, 2012 at 2:38 PM, Kevin Wolf wrote: >> Am 22.05.2012 15:25, schrieb Corey Bryant: >>> >>> >>> On 05/21/2012 05:40 PM, Eric Blake wrote: >>>> On 05/21/2012 02:19 PM, Corey Bryant wrote: &

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/4] block: file descriptor passing using -filefd and getfd_file

2012-05-22 Thread Kevin Wolf
Am 22.05.2012 16:30, schrieb Corey Bryant: > > > On 05/22/2012 04:18 AM, Kevin Wolf wrote: >> Am 21.05.2012 22:19, schrieb Corey Bryant: >>> libvirt's sVirt security driver provides SELinux MAC isolation for >>> Qemu guest processes and their corresponding i

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/4] block: file descriptor passing using -filefd and getfd_file

2012-05-22 Thread Kevin Wolf
Am 22.05.2012 17:01, schrieb Eric Blake: > On 05/22/2012 08:45 AM, Kevin Wolf wrote: > >>> I understand that open("/dev/fd/42") would be the same as dup(42), but >>> I'm not sure that I'm entirely clear on how this would work. Could you >>&g

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/4] block: file descriptor passing using -filefd and getfd_file

2012-05-22 Thread Kevin Wolf
Am 22.05.2012 17:29, schrieb Corey Bryant: > > > On 05/22/2012 10:45 AM, Kevin Wolf wrote: >> Am 22.05.2012 16:30, schrieb Corey Bryant: >>> >>> >>> On 05/22/2012 04:18 AM, Kevin Wolf wrote: >>>> Am 21.05.2012 22:19, schrieb Corey Bryant:

Re: [libvirt] [Qemu-devel] [PATCH v2 0/4] file descriptor passing using passfd

2012-06-13 Thread Kevin Wolf
Am 08.06.2012 17:42, schrieb Corey Bryant: > libvirt's sVirt security driver provides SELinux MAC isolation for > Qemu guest processes and their corresponding image files. In other > words, sVirt uses SELinux to prevent a QEMU process from opening > files that do not belong to it. > > sVirt provi

Re: [libvirt] [Qemu-devel] [PATCH v2 4/4] block: Convert open calls to qemu_open

2012-06-13 Thread Kevin Wolf
Am 08.06.2012 17:42, schrieb Corey Bryant: > This patch converts all block layer open calls to qemu_open. This > enables all block layer open paths to dup(X) a pre-opened file > descriptor if the filename is of the format /dev/fd/X. This is > useful if QEMU is restricted from opening certain file

Re: [libvirt] [PATCH v3 3/5] osdep: Enable qemu_open to dup pre-opened fd

2012-06-15 Thread Kevin Wolf
Am 15.06.2012 20:16, schrieb Corey Bryant: > > > On 06/15/2012 11:16 AM, Eric Blake wrote: >> On 06/14/2012 09:55 AM, Corey Bryant wrote: >>> This patch adds support to qemu_open to dup(fd) a pre-opened file >>> descriptor if the filename is of the format /dev/fd/X. >>> >> >>> +++ b/osdep.c >>> @

Re: [libvirt] [PATCH v3 3/5] osdep: Enable qemu_open to dup pre-opened fd

2012-06-18 Thread Kevin Wolf
Am 15.06.2012 22:00, schrieb Eric Blake: > On 06/15/2012 01:19 PM, Corey Bryant wrote: > There are some flags that I don't think we'll be able to change. For example: O_RDONLY, O_WRONLY, O_RDWR. I assume libvirt would open all files O_RDWR. >>> >>> I think we need to check all of

Re: [libvirt] [PATCH v3 0/5] file descriptor passing using pass-fd

2012-06-19 Thread Kevin Wolf
Am 19.06.2012 17:46, schrieb Eric Blake: > On 06/14/2012 09:55 AM, Corey Bryant wrote: > >> This patch series adds the pass-fd QMP monitor command, which allows >> an fd to be passed via SCM_RIGHTS, and returns the received file >> descriptor. Support is also added to the block layer to allow QEM

Re: [libvirt] [PATCH v3 0/5] file descriptor passing using pass-fd

2012-06-20 Thread Kevin Wolf
Am 19.06.2012 18:14, schrieb Eric Blake: >> Maybe it's better to have a monitor command that just prepares a reopen >> and means "for the next reopen of /dev/fd/42, the passed FD will have >> the right flags (if it hasn't, the reopen will fail)". We can use dup2() >> to keep the "name" stable. > >

Re: [libvirt] [Qemu-devel] [PATCH v4 7/7] osdep: Enable qemu_open to dup pre-opened fd

2012-06-25 Thread Kevin Wolf
Am 25.06.2012 16:34, schrieb Eric Blake: >> Also, I noticed in the fnctl man page that F_SETFL: "On Linux this >> command can change only the O_APPEND, O_ASYNC, O_DIRECT, O_NOATIME, and >> O_NONBLOCK flags." So I'll only set/unset these flags. > > O_NDELAY is the obsolete spelling of O_NONBLOCK;

  1   2   3   4   >