:
libvirtError: unsupported flags (0x1) in function qemuDomainGetTime
Signed-off-by: Luyao Huang lhu...@redhat.com
---
libvirt-override.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libvirt-override.c b/libvirt-override.c
index 9ba87eb..eed8d50 100644
--- a/libvirt-override.c
+++ b/libvirt
:
libvirtError: unsupported flags (0x1) in function qemuDomainGetTime
v1:
https://www.redhat.com/archives/libvir-list/2014-October/msg00482.html
Signed-off-by: Luyao Huang lhu...@redhat.com
---
libvirt-override.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/libvirt-override.c b
When pass a number or other things to setTime,no error output,but set time to 0.
Add a type check and give a clear error messages:
TypeError: time must be dict
Signed-off-by: Luyao Huang lhu...@redhat.com
---
libvirt-override.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/libvirt
Thanks your help and useful messages.
This issue is so small and i just want to fix the ret = NULL with no exception.
So i want to make ret = -1 and make the SystemError: error return without
exception set disappear.
Thanks,
Luyao Huang
- Original Message -
From: Peter Krempa pkre
/libvir-list/2014-October/msg00497.html
Signed-off-by: Luyao Huang lhu...@redhat.com
---
libvirt-override.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/libvirt-override.c b/libvirt-override.c
index 9ba87eb..8690f4f 100644
--- a/libvirt-override.c
+++ b/libvirt-override.c
' for a unsigned int, but i didn't change
them.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
libvirt-override.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libvirt-override.c b/libvirt-override.c
index c887b71..6dacdac 100644
--- a/libvirt-override.c
+++ b/libvirt
-off-by: Luyao Huang lhu...@redhat.com
---
libvirt-override.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/libvirt-override.c b/libvirt-override.c
index c887b71..4999ac3 100644
--- a/libvirt-override.c
+++ b/libvirt-override.c
@@ -8175,8 +8175,7
When pass None to time, it will set guest time to 0.
When pass an empty dictionary, it will report error.
Allow a one-element dictionary which contains 'seconds'
or 'nseconds', setting JUST seconds will do the sane
thing of passing 0 for nseconds, instead of erroring out.
Signed-off-by: Luyao
Thanks for your reply and i add check for one-element and 0-element.
But seems this will make the code not succinct enough.
V2:
https://www.redhat.com/archives/libvir-list/2014-October/msg00815.html
BTW,How about move the check to libvirt-override-virDomain.py?
Thanks,
Luyao Huang
: vshCommandRun (virsh.c:1915)
by 0x12A9E1: main (virsh.c:3699)
Signed-off-by: Luyao Huang lhu...@redhat.com
---
tools/virsh-network.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/virsh-network.c b/tools/virsh-network.c
index 90392d3..8ff6fd8 100644
--- a/tools/virsh-network.c
+++ b/tools
When pass None or a empty dictionary to time, it will
report error.Allow a one-element dictionary which
contains 'seconds',setting JUST seconds will do the
sane thing of passing 0 for nseconds, instead of
erroring out.If dict have a unkown key, it will report error.
Signed-off-by: Luyao Huang
When start a network fail, libvirt still call virNetworkEventLifecycleNew
to send a event.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/network/bridge_driver.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
When run net-dhcp-leases in quiet mode, cannot get
any output.
# virsh -q net-dhcp-leases default
Signed-off-by: Luyao Huang lhu...@redhat.com
---
tools/virsh-network.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/virsh-network.c b/tools/virsh-network.c
-* flags are mutually exclusive
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/libvirt-domain.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index 7dc3146..6ae6dd2 100644
--- a/src/libvirt-domain.c
+++ b/src/libvirt-domain.c
Thanks for pointing out the mistake.I will move the check in
qemuConnectGetAllDomainStats, this won't make a old client
cannot use the future server and will give a good error when
use future client to connect to old server.
Thanks,
Luyao Huang
- Original Message -
From: Eric Blake ebl
exclusive
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_driver.c | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 6acaea8..60c3882 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu
Thanks your advise :) and I have moved the check
in qemuConnectGetAllDomainStats.
And the v2:
https://www.redhat.com/archives/libvir-list/2014-November/msg00069.html
Thanks,
Luyao Huang
- Original Message -
From: Peter Krempa pkre...@redhat.com
To: Luyao Huang lhu...@redhat.com
From libvirt.org we know this attribute named:
interface_mac MAC address of the network interface, not unique
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/access/viraccessdriverpolkit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/access
From virAccessDriverPolkitCheckInterface function, we know this
attribute should named: interface_macaddr
Signed-off-by: Luyao Huang lhu...@redhat.com
---
docs/aclpolkit.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/aclpolkit.html.in b/docs/aclpolkit.html.in
is
NULL.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/security/security_selinux.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c
index f96be50..4fd09b8 100644
--- a/src/security/security_selinux.c
+++ b/src/security
in remoteDispatchDomainSnapshotCreateXML
(server=optimized out, msg=optimized out, ret=0x7fc76a60,
args=0x7fc760001f90, rerr=0x7fc77344dc80,
client=optimized out) at remote_dispatch.h:8605
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/conf/domain_conf.c | 7 ++-
1 file changed, 6
When we try to get a hot-unplug disk blkdevio settings via
qemuDomainGetBlockIoTune, libvirt will output a cannot find
device error.Move the check after confirm vm is running.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_driver.c | 9 -
1 file changed, 4 insertions
On 11/15/2014 06:29 AM, John Ferlan wrote:
On 11/13/2014 10:21 PM, Luyao Huang wrote:
It would help to put the bz link in here:
https://bugzilla.redhat.com/show_bug.cgi?id=1164080
When we try to get a hot-unplug disk blkdevio settings via
qemuDomainGetBlockIoTune, libvirt will output
console
in qemuBuildConsoleChrDeviceStr.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_command.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 1399ce4..2bf4a83 100644
--- a/src/qemu/qemu_command.c
When i pasted some xml from libvirt.org, i found some small mistake.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
docs/formatdomain.html.in | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 9c1d0f4..c08b244
'
labelunconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023/label
imagelabelsystem_u:object_r:svirt_image_t:s0-s0:c0.c1023/imagelabel
/seclabel
seclabel type='static' model='dac' relabel='yes'
label+0:+0/label
imagelabel+0:+0/imagelabel
/seclabel
Luyao Huang (2):
qemu: fix some small issue
.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_process.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 382d802..ee95adb 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/security/security_dac.c | 50 +++--
1 file changed, 48 insertions(+), 2 deletions(-)
diff --git a/src/security/security_dac.c b/src/security/security_dac.c
index 85253af..2977f71 100644
--- a/src
On 12/01/2014 06:24 PM, Martin Kletzander wrote:
On Mon, Dec 01, 2014 at 05:54:36PM +0800, Luyao Huang wrote:
When use qemuProcessAttach to attach a qemu process, cannot
get a right DAC label. Add a new func to get process label
via stat func. Do not remove virDomainDefGetSecurityLabelDef
On 12/01/2014 11:20 PM, Martin Kletzander wrote:
On Mon, Dec 01, 2014 at 11:05:30PM +0800, Luyao Huang wrote:
On 12/01/2014 06:24 PM, Martin Kletzander wrote:
On Mon, Dec 01, 2014 at 05:54:36PM +0800, Luyao Huang wrote:
When use qemuProcessAttach to attach a qemu process, cannot
get a right
On 12/01/2014 06:27 PM, Martin Kletzander wrote:
On Mon, Dec 01, 2014 at 11:17:54AM +0100, Martin Kletzander wrote:
On Mon, Dec 01, 2014 at 05:54:35PM +0800, Luyao Huang wrote:
There are some small issue in qemuProcessAttach:
1.Fix virSecurityManagerGetProcessLabel always get pid = 0,
move
.
v2 add support freeBSD.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/security/security_dac.c | 95 -
1 file changed, 93 insertions(+), 2 deletions(-)
diff --git a/src/security/security_dac.c b/src/security/security_dac.c
index 85253af..89cafa3
Sorry i didn't know that, i will pay attention next time.
And i have send a v2(but i haven't work in FreeBSD before, so...):
https://www.redhat.com/archives/libvir-list/2014-December/msg00207.html
Thanks,
Luyao Huang
- Original Message -
From: Martin Kletzander mklet...@redhat.com
at
remote_dispatch.h:14339
6 remoteDispatchStorageVolUploadHelper at remote_dispatch.h:14309
7 0x7f094524a192 in virNetServerProgramDispatchCall at
rpc/virnetserverprogram.c:437
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/storage/storage_driver.c | 5 +++--
1 file changed, 3 insertions(+), 2
.
v2 add support freeBSD.
v3 use snprintf instead of VirAsprintf and move the error
settings in virSecurityDACGetProcessLabelInternal.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/security/security_dac.c | 85 +++--
1 file changed, 82 insertions
On 12/06/2014 12:50 AM, Eric Blake wrote:
On 12/05/2014 01:20 AM, Luyao Huang wrote:
When use qemuProcessAttach to attach a qemu process, cannot
get a right DAC label. Add a new func to get process label
via stat func. Do not remove virDomainDefGetSecurityLabelDef
before try to use stat to get
, I think we should forbid negative
number in these place (we did this before, but after f18c02ec,
virStrToLong_ui changed to allow negative number). So changed to use
virStrToLong_uip in these place.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/conf/device_conf.c | 4 ++--
src/conf
console
in qemuBuildConsoleChrDeviceStr.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_command.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 1399ce4..7dced5f 100644
--- a/src/qemu/qemu_command.c
Add a func just check the base target type which
qemu support. But i still doubt this will be useful
, we already have a check when we try to start the
vm. And this check only check the target type, and
the other things will be done in virDomainChrDefParseXML.
Signed-off-by: Luyao Huang lhu
unsupported Chr device when cold-plug,
I think this maybe unnessary in this place, because we will check it
when we start the guest and it will report a clear error.But if we
use qemu* header func add a qemu unsupported things to qemu guest, it seems
strange.
Luyao Huang (2):
qemu: output error when
.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
v2 add support freeBSD.
v3 use snprintf instead of VirAsprintf and move the error
settings in virSecurityDACGetProcessLabelInternal.
v4 remove errno.h include and thanks Eric advice move this
version comment to this place.
src/security
On 12/09/2014 06:38 PM, Michal Privoznik wrote:
On 08.12.2014 09:27, Luyao Huang wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1171582
When we edit a negative controller address number to a device, some
of them will auto generate a controller with invalid index number. This
will make
Output error when we try to set a too large max_sectors.
Just like queues and cmd_per_lun here.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/conf/domain_conf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 2965d8d..d4ac301
It make no sense at all to have it there.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/conf/domain_conf.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index ec45b8c..2965d8d 100644
--- a/src/conf
/domain_conf.c:10911
2 virDomainHostdevMatch at conf/domain_conf.c:10973
3 virDomainHostdevFind at conf/domain_conf.c:10998
4 0x7f84f6a10560 in qemuDomainAttachDeviceConfig at qemu/qemu_driver.c:7223
5 qemuDomainAttachDeviceFlags at qemu/qemu_driver.c:7554
Signed-off-by: Luyao Huang lhu
https://bugzilla.redhat.com/show_bug.cgi?id=1174096
When both parameter have lockspaces present, virDomainLeaseIndex
will always -1 even there is a lease the same with the one we check.
I think we shouldn't do 'continue' when the two lockspaces are the same.
Signed-off-by: Luyao Huang lhu
We free them before, then use it. This make we always do
virDomainDefAddImplicitControllers when attach a disk.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu
start after we add them (although
they can start at the second time).
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_driver.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index df3ba6d..62fb784 100644
--- a/src/qemu
On 12/15/2014 07:58 PM, John Ferlan wrote:
On 12/14/2014 10:09 PM, Luyao Huang wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1174053
When we use attach-device to coldplug a network iscsi hostdev,
libvirt will check if there is already a device in XML. But if
the 'b' is a host iscsi
On 12/15/2014 09:27 PM, Michal Privoznik wrote:
On 15.12.2014 07:46, Luyao Huang wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1174096
When both parameter have lockspaces present, virDomainLeaseIndex
will always -1 even there is a lease the same with the one we check.
I think we
https://bugzilla.redhat.com/show_bug.cgi?id=1174569
We should do nothing for the shareable network iscsi hostdev in
qemuAddSharedHostdev and qemuRemoveSharedHostdev. Shareable for
a network iscsi hostdev is not valid, so just ignore it.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu
On 12/16/2014 08:00 PM, Peter Krempa wrote:
On 12/15/14 10:10, Luyao Huang wrote:
We free them before, then use it. This make we always do
We clear the pointer, not free.
virDomainDefAddImplicitControllers when attach a disk.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu
On 12/16/2014 08:33 PM, Peter Krempa wrote:
On 12/16/14 13:32, Luyao Huang wrote:
On 12/16/2014 08:00 PM, Peter Krempa wrote:
On 12/15/14 10:10, Luyao Huang wrote:
We free them before, then use it. This make we always do
We clear the pointer, not free.
virDomainDefAddImplicitControllers
On 12/17/2014 06:27 PM, Michal Privoznik wrote:
On 17.12.2014 11:04, lhuang wrote:
On 12/16/2014 11:46 PM, Michal Privoznik wrote:
On 16.12.2014 04:16, Luyao Huang wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1174569
We should do nothing for the shareable network iscsi hostdev
https://bugzilla.redhat.com/show_bug.cgi?id=1176503
When guest start failed, libvirt will keep the current vm-def,
this will make a issue that we cannot get a right xml after guest
start failed. Pass the newDef to def will make it work well.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src
virDomainNetDefFormat, we won't get the current vm interface
state.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/conf/domain_conf.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index aafc05e..fffd6cd 100644
--- a/src/conf
https://bugzilla.redhat.com/show_bug.cgi?id=1177723
If tc cmd failed when we use qemuDomainSetInterfaceParameters, the old
rules will be clean. Restore the old rules if tc failed.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_driver.c | 6 +-
1 file changed, 5 insertions
Please ignore this patch, i worked in a old upstream libvirt.
Sorry for the noisy.
Luyao
- Original Message -
From: Luyao Huang lhu...@redhat.com
To: libvir-list@redhat.com
Cc: Luyao Huang lhu...@redhat.com
Sent: Tuesday, December 30, 2014 5:00:03 PM
Subject: [libvirt] [PATCH] qemu: fix
https://bugzilla.redhat.com/show_bug.cgi?id=1177723
If tc cmd failed (maybe value too large) when we use
virDomainSetInterfaceParameters
, the old rules will be clean. Restore the old rules if tc failed.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
v1 make a big mistake that i used a old
qemu already support hot-plug and hot-unplug RNG device.
These patch will make libvirt support hot-plug/unplug RNG device for qemu
driver.
Luyao Huang (12):
qemu: introduce a new func qemuAssignDeviceRNGAlias for rng device
qemu: rename qemuBuildRNGDeviceArgs to qemuBuildRNGDevStr and change
virDomainRNGEquals is a func which check if two rng device
are the same.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/conf/domain_conf.c | 34 ++
src/conf/domain_conf.h | 3 +++
2 files changed, 37 insertions(+)
diff --git a/src/conf/domain_conf.c b/src
We have enough patches for hotplug RNG device, maybe we can
implement live hotplug of a RNG device.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_driver.c | 8 -
src/qemu/qemu_hotplug.c | 92 +
src/qemu/qemu_hotplug.h | 3
qemu side functions, call virDomainRNGInsert and virDomainRNGRemove
to help us.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_hotplug.c | 23 +++
src/qemu/qemu_hotplug.h | 7 +++
2 files changed, 30 insertions(+)
diff --git a/src/qemu/qemu_hotplug.c b
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/libvirt_private.syms | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index aa776b4..deab4cf 100644
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -375,7 +375,12
These 2 functions just do some basic check and then call
qemuMonitorJSONAttachRNGDev and qemuMonitorDelObject to
help us.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_monitor.c | 43 +++
src/qemu/qemu_monitor.h | 7 +++
2 files
We didn't set a id when we build RNG device cmdline before.
Give a id to every RNG device and we can hotunplug it via
QMP cmd device_del.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_command.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src
the 3 functions are:
virDomainRNGInsert: Insert a RNG device to vm-def.
virDomainRNGRemove: remove a RNG device in vm-def.
virDomainRNGFind: find a RNG device in vm-def.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/conf/domain_conf.c | 44
src
We have enough patches for hotunplug RNG device, maybe we can
implement live hotunplug of a RNG device.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_driver.c | 4 +-
src/qemu/qemu_hotplug.c | 97 -
src/qemu/qemu_hotplug.h | 4
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/conf/domain_audit.c | 2 +-
src/conf/domain_audit.h | 7 +++
src/libvirt_private.syms | 1 +
3 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/src/conf/domain_audit.c b/src/conf/domain_audit.c
index fcf9df7..159ebf5 100644
We need a new function to build a RNG device object, and need a
function to build a props which will be used in qemuMonitorJSONAddObject.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_monitor_json.c | 58
src/qemu/qemu_monitor_json.h
rename qemuBuildRNGDeviceArgs to qemuBuildRNGDevStr, we need this function
to build a cmdline.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_command.c | 33 -
src/qemu/qemu_command.h | 4
2 files changed, 20 insertions(+), 17 deletions
This function used to set a alias name for RNG device, usage just
like other named qemuAssignDevice***Alias functions.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_command.c | 25 -
src/qemu/qemu_command.h | 1 +
2 files changed, 25 insertions(+), 1
On 01/22/2015 06:19 PM, Peter Krempa wrote:
On Thu, Jan 22, 2015 at 10:28:18 +0800, Luyao Huang wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1164627
When using 'virsh attach-device' to hotplug an unsupported console type
into a qemu guest, the attachment will erroneously allows
Although it won't cause a issue now, the code won't
touch this place.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/conf/domain_conf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 706e5d2..3a0b13e 100644
--- a/src/conf
https://bugzilla.redhat.com/show_bug.cgi?id=1188914
This will cause a issue that add a unsupport input device
to a hypervisor which unsupport it, also will cause a wrong
error message when the input device is not a mouse or keyboard.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/conf
On 02/02/2015 07:38 PM, Daniel P. Berrange wrote:
On Mon, Feb 02, 2015 at 11:40:44AM +0800, Luyao Huang wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1188088
When the firewalld is running and then start the libvirtd, libvirt
will set the current backend as VIR_FIREWALL_BACKEND_FIREWALLD
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/lxc/lxc_process.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c
index 01da344..b385423 100644
--- a/src/lxc/lxc_process.c
+++ b/src/lxc/lxc_process.c
@@ -1270,11 +1270,6 @@ int
us clean the source and call
the hooks if start a vm failed
Signed-off-by: Luyao Huang lhu...@redhat.com
---
v2: use virLXCProcessCleanup to free the source and call the hook.
v3: rework the patch to suit the virLXCProcessStart code changed.
src/lxc/lxc_process.c | 76
call qemuDomainDefCopy
in qemuDomainSaveImageUpdateDef.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_driver.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 5994558..abe3b9f 100644
--- a/src/qemu
, Although a guest can be defined
with an improper target, startup will cause failure.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_command.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index c041ee7
)
And this check only check the target type, and other things
have been checked in virDomainChrDefParseXML.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/libvirt_private.syms | 2 ++
src/qemu/qemu_hotplug.c | 67
2 files changed, 69 insertions(+)
diff
and backend object ID have the same basic alias name
-rename need_remove to remove_chardev in qemuDomainAttachRNGDevice
-add qemu capability check for RNG device backend
Luyao Huang (9):
qemu: Add helper to assign RNG device aliases
qemu: refactor qemuBuildRNGDeviceArgs to allow reuse in RNG
We have enough patches for hotplug RNG device, maybe we can
implement live hotplug of a RNG device.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_driver.c | 8 +++-
src/qemu/qemu_hotplug.c | 106
src/qemu/qemu_hotplug.h | 3
We have enough patches for hotunplug RNG device, maybe we can
implement live hotunplug of a RNG device.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/libvirt_private.syms | 1 +
src/qemu/qemu_driver.c | 4 +-
src/qemu/qemu_hotplug.c | 112
qemuMonitorAttachRNGDev and qemuMonitorDetachRNGDev functions
just do some basic check and then call qemuMonitorJSONAttachRNGDev
and qemuMonitorDelObject to help us.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_monitor.c | 43
We didn't set a id when we build RNG device cmdline before.
Give a id to every RNG device and we can hotunplug it via
QMP cmd device_del.
And fix the tests.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_command.c | 12 ++--
tests
This function is used to assign an alias for a RNG device. It will be
later reused when hotplugging RNGs.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_command.c | 25 -
src/qemu/qemu_command.h | 1 +
2 files changed, 25 insertions(+), 1 deletion
Rename qemuBuildRNGDeviceArgs to qemuBuildRNGDevStr and change the
return type so that it can be reused in the device hotplug code later.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_command.c | 32
src/qemu/qemu_command.h | 4
2 files
the 3 functions are:
virDomainRNGInsert: Insert a RNG device to vm-def.
virDomainRNGRemove: remove a RNG device in vm-def.
virDomainRNGFind: find a RNG device in vm-def.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/conf/domain_conf.c | 42 ++
src
virDomainRNGEquals is a func which check if two rng device
are the same.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/conf/domain_conf.c | 34 ++
src/conf/domain_conf.h | 3 +++
src/libvirt_private.syms | 1 +
3 files changed, 38 insertions(+)
diff
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/conf/domain_audit.c | 2 +-
src/conf/domain_audit.h | 7 +++
src/libvirt_private.syms | 1 +
3 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/src/conf/domain_audit.c b/src/conf/domain_audit.c
index fcf9df7..159ebf5 100644
will use memdev for all cells if there
is at least one cell need this.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_command.c| 88 +-
.../qemuxml2argv-numatune-memnode-no-memory.args | 3 +-
2 files changed, 55 insertions(+), 36
On 01/22/2015 09:25 PM, Peter Krempa wrote:
On Thu, Jan 22, 2015 at 21:20:46 +0800, Luyao Huang wrote:
On 01/22/2015 06:19 PM, Peter Krempa wrote:
On Thu, Jan 22, 2015 at 10:28:18 +0800, Luyao Huang wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1164627
...
ACK, although the rest
On 01/21/2015 08:00 PM, Ján Tomko wrote:
On 01/21/2015 04:10 AM, lhuang wrote:
On 01/21/2015 03:00 AM, John Ferlan wrote:
On 12/09/2014 01:48 AM, Luyao Huang wrote:
Add a func just check the base target type which
qemu support. But i still doubt this will be useful
, we already have a check
Introduce a new function to help to get interface IPv6 address.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/libvirt_private.syms | 1 +
src/util/virnetdev.c | 70
src/util/virnetdev.h | 2 ++
3 files changed, 73 insertions
or network have a can be used ipv4 address
ipv6: check if the interface or network have a can be used ipv6 address
fix some test which will be break by this commit.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
docs/formatdomain.html.in | 10 +-
docs/schemas
'/
/graphics
However we do not support get a IPv6 address for the network.
add some helpers and rework networkGetNetworkAddress to make it
can get a IPv6 address when we need.
Luyao Huang (4):
util: introduce a new helper for get interface IPv6 address
conf: introduce new family attribute in graphics
Export the required helpers and rework networkGetNetworkAddress to
make it can get IPv6 address.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/conf/network_conf.c | 2 +-
src/conf/network_conf.h | 1 +
src/libvirt_private.syms| 1 +
src/network/bridge_driver.c | 50
we already set a more clearly error in networkGetNetworkAddress,
so this error will cover our error in networkGetNetworkAddress.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_command.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/src/qemu
Just like the fix for domdisplay in commit 1ba815.
---
tools/virsh-domain.c | 12
1 file changed, 12 insertions(+)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index dc4a863..2506b89 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -10269,6 +10269,18 @@
1 - 100 of 318 matches
Mail list logo
