; >
> > static virLogSource virLogLibXL = {
> > .name = "libxl.libxl_library",
> >
> > }
> >
> > LIBVIRT_LOG_FILTERS="1:libxl_library"
> >
>
> Ah, good idea. I'll look into it.
Is it done anywhere? If
On Wed, Nov 11, 2015 at 04:04:22PM +, Daniel P. Berrange wrote:
> On Wed, Nov 11, 2015 at 04:57:59PM +0100, Marek Marczykowski-Górecki wrote:
> > On Tue, Sep 15, 2015 at 11:21:00AM -0600, Jim Fehlig wrote:
> > > Daniel P. Berrange wrote:
> > > > On Tue, Sep 15,
This are some additional features to libxl driver. Some of them require change
in domain config structures/syntax. Details described with each patch.
Actually this is next iteration of a few years old patch series...
Marek Marczykowski-Górecki (10):
libxl: update dom->id
Handle features supported only on xen: driver domains, qemu in
stubdomain.
Signed-off-by: Marek Marczykowski-Górecki
---
tests/Makefile.am | 9 +-
tests/domainschematest | 2 +-
tests/xlxml2xmldata/xlxml2xml-hvm-stubdom.xml
in path.
Signed-off-by: Marek Marczykowski-Górecki
---
I think it would be good idea to introduce the same change to capabilities XML.
The problem is I can't include domain_conf.h from capabilities.h, so probably
that enum declaration needs to be moved to capabilities.h. Is it the right
Signed-off-by: Marek Marczykowski-Górecki
---
Changes in v2:
- rebase on 1.2.12+
- multiple devices support
src/libxl/libxl_conf.c | 48
1 file changed, 48 insertions(+)
diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
index
Signed-off-by: Marek Marczykowski-Górecki
---
There was a discussion about calling virDomainDefCheckABIStability. The use
case I have for this is to start multiple domains from the same savefile. This
require changing:
- UUID
- name
- IP address
Those are exactly type of changes blocked by
This implement handling of parameter introduced in
previous patch.
Lookup on domain name (to get domain ID) requires libxlDriverPrivate
object, so it must be passed down to libxlMakeDisk and libxlMakeNet from
top level callers.
Signed-off-by: Marek Marczykowski-Górecki
---
Changes in v2
enabled).
Signed-off-by: Marek Marczykowski-Górecki
---
src/libxl/libxl_conf.c | 100 -
1 file changed, 74 insertions(+), 26 deletions(-)
diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
index 1811a83..c9f8ad5 100644
--- a/src/libxl
Otherwise domainCreateWithFlags via remote returns -1 as domid.
Signed-off-by: Marek Marczykowski-Górecki
---
src/libxl/libxl_driver.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
index c95b387..ce3a99b 100644
--- a/src/libxl
It will not be possible to detach such device later. Also improve
logging in such cases.
Signed-off-by: Marek Marczykowski-Górecki
---
src/libxl/libxl_driver.c | 41 +++--
1 file changed, 39 insertions(+), 2 deletions(-)
diff --git a/src/libxl/libxl_driver.c
eeded for USB devices (hostdev
objects), but for now libxl doesn't have support for PVUSB.
Signed-off-by: Marek Marczykowski-Górecki
---
Changes in v2:
- describe in docs/formatdomain.html.in
- enforce empty domain tag (only 'name' attribute allowed)
Changes in v3:
- change elemen
Do not silently ignore its value. LibXL support only one address, so
refuse multiple IPs.
Signed-off-by: Marek Marczykowski-Górecki
---
src/libxl/libxl_conf.c | 5 +
src/libxl/libxl_domain.c | 11 +++
2 files changed, 16 insertions(+)
diff --git a/src/libxl/libxl_conf.c b/src
On Thu, Feb 05, 2015 at 02:25:41PM -0700, Jim Fehlig wrote:
> Marek Marczykowski-Górecki wrote:
> > Otherwise domainCreateWithFlags via remote returns -1 as domid.
> >
> > Signed-off-by: Marek Marczykowski-Górecki
> > ---
> > src/libxl/libxl_driver.c | 3 +++
On Fri, Feb 06, 2015 at 05:36:40PM +, Daniel P. Berrange wrote:
> On Thu, Feb 05, 2015 at 06:17:08AM +0100, Marek Marczykowski-Górecki wrote:
> > At least Xen supports backend drivers in another domain (aka "driver
> > domain"). This patch introduces XML config o
On Fri, Feb 06, 2015 at 08:03:43PM +, Daniel P. Berrange wrote:
> On Fri, Feb 06, 2015 at 07:11:40PM +0100, Marek Marczykowski-Górecki wrote:
> > On Fri, Feb 06, 2015 at 05:36:40PM +, Daniel P. Berrange wrote:
> > > On Thu, Feb 05, 2015 at 06:17:08AM +0100, Marek Ma
On Thu, Feb 05, 2015 at 02:53:44PM -0700, Jim Fehlig wrote:
> Marek Marczykowski-Górecki wrote:
> > Vfb entries in domain config are used only by PV drivers. Qemu
> > parameters are build based on b_info struct. So fill it with the same
> > data as vfb entries (actually the
On Thu, Feb 05, 2015 at 03:36:17PM -0700, Jim Fehlig wrote:
> Marek Marczykowski-Górecki wrote:
> > Do not silently ignore its value. LibXL support only one address, so
> > refuse multiple IPs.
> >
> > Signed-off-by: Marek Marczykowski-Górecki
> > ---
&
On Sat, Feb 07, 2015 at 12:22:51PM +0100, Marek Marczykowski-Górecki wrote:
> On Thu, Feb 05, 2015 at 02:53:44PM -0700, Jim Fehlig wrote:
> > Marek Marczykowski-Górecki wrote:
> > > Vfb entries in domain config are used only by PV drivers. Qemu
> > > parameters are build
On Thu, Feb 19, 2015 at 11:43:15AM -0700, Jim Fehlig wrote:
> Marek Marczykowski-Górecki wrote:
> > It will not be possible to detach such device later. Also improve
> > logging in such cases.
> >
> > Signed-off-by: Marek Marczykowski-Górecki
> > ---
&
On Thu, Feb 19, 2015 at 11:59:38AM -0700, Jim Fehlig wrote:
> Marek Marczykowski-Górecki wrote:
> > Signed-off-by: Marek Marczykowski-Górecki
> > ---
> >
> > There was a discussion about calling virDomainDefCheckABIStability. The use
> > case I have for this is t
On Thu, Feb 19, 2015 at 01:58:02PM -0700, Jim Fehlig wrote:
> Marek Marczykowski-Górecki wrote:
> > On Thu, Feb 19, 2015 at 11:43:15AM -0700, Jim Fehlig wrote:
> >
> >> Marek Marczykowski-Górecki wrote:
> >>
> >>> It will not be possi
On Thu, Feb 19, 2015 at 01:45:52PM -0700, Jim Fehlig wrote:
> Marek Marczykowski-Górecki wrote:
> > Xen have feature of having device model in separate domain (called stub
> > domain). Add a 'type' attribute to 'emulator' element to allow selecting
> >
On Thu, Feb 19, 2015 at 03:10:13PM -0700, Jim Fehlig wrote:
> Jim Fehlig wrote:
> > Marek Marczykowski-Górecki wrote:
> >
> >> On Thu, Feb 19, 2015 at 01:58:02PM -0700, Jim Fehlig wrote:
> >>
> >>
> >>> Marek Marczykowski-Góreck
On Thu, Feb 19, 2015 at 03:58:30PM -0700, Jim Fehlig wrote:
> Marek Marczykowski-Górecki wrote:
> > On Thu, Feb 19, 2015 at 03:10:13PM -0700, Jim Fehlig wrote:
> >> Jim Fehlig wrote:
> >>> Marek Marczykowski-Górecki wrote:
> >>>> On Thu, Feb 1
On Wed, Feb 18, 2015 at 08:22:12PM -0700, Jim Fehlig wrote:
> Marek Marczykowski-Górecki wrote:
> > Signed-off-by: Marek Marczykowski-Górecki
> > ---
> > Changes in v2:
> > - rebase on 1.2.12+
> > - multiple devices support
>
In Xen>=4.3, libxl supports new syntax for USB devices:
usbdevice=[ "DEVICE", "DEVICE", ... ]
Add support for that in xenconfig driver. When only one device is
defined, keep using old syntax for backward compatibility.
Signed-off-by: Marek Marczykowski-Górecki
---
src
From: Marek Marczykowski
Signed-off-by: Marek Marczykowski-Górecki
---
Changes in v2:
- rebase on 1.2.12+
- multiple devices support
Changes in v3:
- reduce code duplication
src/libxl/libxl_conf.c | 44
1 file changed, 44 insertions(+)
diff
Signed-off-by: Marek Marczykowski-Górecki
---
tests/xlconfigdata/test-fullvirt-multiusb.cfg | 29
tests/xlconfigdata/test-fullvirt-multiusb.xml | 48 +++
tests/xlconfigtest.c | 1 +
3 files changed, 78 insertions(+)
create mode
On Thu, Feb 19, 2015 at 06:13:01PM -0700, Jim Fehlig wrote:
> Marek Marczykowski-Górecki wrote:
> > On Thu, Feb 19, 2015 at 03:58:30PM -0700, Jim Fehlig wrote:
> >
> >> Marek Marczykowski-Górecki wrote:
> >>
> >>> On Thu, Feb 1
From: Marek Marczykowski
This implement handling of parameter introduced in
previous patch.
Works on Xen >= 4.3, because only there libxl supports setting backend domain
by name, not XID.
Signed-off-by: Marek Marczykowski-Górecki
---
Changes in v2:
- rebase on 1.0.6+
- fix indentat
ure same option will be needed for USB devices (hostdev
objects), but for now libxl doesn't have support for PVUSB.
Signed-off-by: Marek Marczykowski-Górecki
---
Changes in v2:
- describe in docs/formatdomain.html.in
- enforce empty domain tag (only 'name' attribute allowed)
On Fri, Feb 20, 2015 at 03:45:02PM -0700, Jim Fehlig wrote:
> Marek Marczykowski-Górecki wrote:
> > From: Marek Marczykowski
> >
> > Signed-off-by: Marek Marczykowski-Górecki
> > ---
> > Changes in v2:
> > - rebase on 1.2.12+
> > - multiple devices
On Fri, Feb 20, 2015 at 04:10:47PM -0700, Jim Fehlig wrote:
> Marek Marczykowski-Górecki wrote:
> > In Xen>=4.3, libxl supports new syntax for USB devices:
> > usbdevice=[ "DEVICE", "DEVICE", ... ]
> > Add support for that in xenconfig driver. When on
On Thu, Feb 19, 2015 at 10:19:22PM +0100, Marek Marczykowski-Górecki wrote:
> On Thu, Feb 19, 2015 at 01:45:52PM -0700, Jim Fehlig wrote:
> > Marek Marczykowski-Górecki wrote:
> > > Xen have feature of having device model in separate domain (called stub
> > > domain)
On Wed, Mar 04, 2015 at 08:34:26PM +, Daniel P. Berrange wrote:
> On Thu, Feb 19, 2015 at 10:19:22PM +0100, Marek Marczykowski-Górecki wrote:
> > On Thu, Feb 19, 2015 at 01:45:52PM -0700, Jim Fehlig wrote:
> > > Marek Marczykowski-Górecki wrote:
> > > > Xen have
virDomainNetFindIdx no longer returns info whether device was not found,
or there was multiple matches. Additionally it already handle error
reporting. Introduce virDomainHasNet which does a simple task, without
implicit error reporting.
Signed-off-by: Marek Marczykowski-Górecki
---
src/conf
Handle features supported only on xen: driver domains, qemu in
stubdomain.
Signed-off-by: Marek Marczykowski-Górecki
---
tests/Makefile.am | 9 +-
tests/domainschematest | 2 +-
tests/xlxml2xmldata/xlxml2xml-hvm-stubdom.xml
Signed-off-by: Marek Marczykowski-Górecki
---
tests/xlconfigdata/test-fullvirt-multiusb.cfg | 29
tests/xlconfigdata/test-fullvirt-multiusb.xml | 48 +++
tests/xlconfigtest.c | 1 +
3 files changed, 78 insertions(+)
create mode
Signed-off-by: Marek Marczykowski-Górecki
---
src/libxl/libxl_conf.c | 8
1 file changed, 8 insertions(+)
diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
index 8ec3c75..d78d2b2 100644
--- a/src/libxl/libxl_conf.c
+++ b/src/libxl/libxl_conf.c
@@ -735,6 +735,14
It will not be possible to detach such device later. Also improve
logging in such cases.
Signed-off-by: Marek Marczykowski-Górecki
---
src/libxl/libxl_driver.c | 15 +++
1 file changed, 15 insertions(+)
Changes in v4:
- use virDomainHasNet instead of virDomainNetFindIdx
diff
Marek Marczykowski-Górecki (8):
libxl: add tablet/mouse input device support
xenconfig: add support for multiple USB devices syntax
tests: xenconfig: test for multiple USB devices and other HVM options
conf: add virDomainHasNet
libxl: prevent attaching multiple netdevs with the same MAC
libxl: su
Xen have feature of having device model in separate domain (called stub
domain). Add element to allow selecting such configuration.
Emulator path is still used for qemu running in dom0 (if any). Libxl currently
do not allow to select stubdomain path.
Signed-off-by: Marek Marczykowski-Górecki
Signed-off-by: Marek Marczykowski-Górecki
---
src/libxl/libxl_driver.c | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
index 1313d2e..d7f5dac 100644
--- a/src/libxl/libxl_driver.c
+++ b/src/libxl
From: Marek Marczykowski
Signed-off-by: Marek Marczykowski-Górecki
---
src/libxl/libxl_conf.c | 44
1 file changed, 44 insertions(+)
Changes in v2:
- rebase on 1.2.12+
- multiple devices support
Changes in v3:
- reduce code duplication
diff
In Xen>=4.3, libxl supports new syntax for USB devices:
usbdevice=[ "DEVICE", "DEVICE", ... ]
Add support for that in xenconfig driver. When only one device is
defined, keep using old syntax for backward compatibility.
Adjust tests for changed options order.
Signed-off
On Fri, Mar 13, 2015 at 02:09:34PM -0600, Jim Fehlig wrote:
> Marek Marczykowski-Górecki wrote:
> > Xen have feature of having device model in separate domain (called stub
> > domain). Add element to allow selecting such configuration.
> > Emulator path is still used for qem
On Fri, Mar 20, 2015 at 02:11:46PM -0600, Jim Fehlig wrote:
> Wei Liu wrote:
> > On Fri, Mar 20, 2015 at 11:18:36AM -0600, Jim Fehlig wrote:
> >
> >> Marek Marczykowski-Górecki wrote:
> >>
> >>> Signed-off-by: Marek Marczykowski-Górecki
>
On Fri, Mar 20, 2015 at 02:56:11PM -0600, Jim Fehlig wrote:
> Marek Marczykowski-Górecki wrote:
> > Handle features supported only on xen: driver domains, qemu in
> > stubdomain.
> >
> > Signed-off-by: Marek Marczykowski-Górecki
> >
> [...]
> >
On Mon, Aug 27, 2018 at 03:23:16PM -0600, Jim Fehlig wrote:
> On 08/05/2018 03:48 PM, Marek Marczykowski-Górecki wrote:
> > Use preferred name: 'xen'.
>
> I'd be fine with this change if the actual code used the preferred name too
> :-). E.g. config containing
On Thu, Aug 30, 2018 at 03:29:41PM +0100, Daniel P. Berrangé wrote:
> On Thu, Aug 30, 2018 at 04:27:06PM +0200, Marek Marczykowski-Górecki wrote:
> > On Mon, Aug 27, 2018 at 03:23:16PM -0600, Jim Fehlig wrote:
> > > On 08/05/2018 03:48 PM, Marek Marczykowski-Górecki wrote:
>
When libvirtd is started, initialize domain objects state with its real
state, not only RUNNING/SHUTOFF.
Signed-off-by: Marek Marczykowski-Górecki
Reviewed-by: Jim Fehlig
---
src/libxl/libxl_driver.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/libxl/libxl_driver.c b
Signed-off-by: Marek Marczykowski-Górecki
Reviewed-by: Jim Fehlig
---
src/libxl/libxl_domain.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c
index 2ab78ac..b800bc9 100644
--- a/src/libxl
Needed libxl_domain_suspend_only is supported in Xen >= 4.11. But wakeup should
work with older versions.
Marek Marczykowski-Górecki (3):
libxl: send lifecycle event on suspend
libxl: implement virDomainPM* functions
libxl: initialize domain state with real data
src/libxl/libxl_domai
Signed-off-by: Marek Marczykowski-Górecki
---
Changes in v2:
- use virDomainObjEndAPI
- drop duplicated error reporting on virDomainObjIsActive
- bump version comment to 4.8.0
---
src/libxl/libxl_driver.c | 121 -
1 file changed, 121 insertions(+)
diff
On Thu, Sep 06, 2018 at 02:58:30PM -0600, Jim Fehlig wrote:
> On 09/03/2018 04:09 PM, Marek Marczykowski-Górecki wrote:
> > Signed-off-by: Marek Marczykowski-Górecki
> > ---
> > Changes in v2:
> > - use virDomainObjEndAPI
> > - drop duplicated error
On Fri, Sep 07, 2018 at 11:10:14AM -0600, Jim Fehlig wrote:
> On 09/06/2018 03:06 PM, Marek Marczykowski-Górecki wrote:
>
> A few additional comments came to mind while looking at this patch again...
Perfect timing, I was just going to hit "send" on v3...
> > > >
When libvirtd is started, initialize domain objects state with its real
state, not only RUNNING/SHUTOFF.
Signed-off-by: Marek Marczykowski-Górecki
Reviewed-by: Jim Fehlig
---
src/libxl/libxl_driver.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/libxl/libxl_driver.c b
Needed libxl_domain_suspend_only is supported in Xen >= 4.11. But wakeup should
work with older versions.
Marek Marczykowski-Górecki (3):
libxl: send lifecycle event on suspend
libxl: implement virDomainPM* functions
libxl: initialize domain state with real data
src/libxl/libxl_domai
Signed-off-by: Marek Marczykowski-Górecki
Reviewed-by: Jim Fehlig
---
src/libxl/libxl_domain.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c
index 2ab78ac..b800bc9 100644
--- a/src/libxl
Signed-off-by: Marek Marczykowski-Górecki
---
Changes in v2:
- use virDomainObjEndAPI
- drop duplicated error reporting on virDomainObjIsActive
- bump version comment to 4.8.0
Changes in v3:
- fix virDomainObjIsActive -> virDomainObjCheckActive
- reuse duration not supported message f
On Mon, Sep 10, 2018 at 10:06:09AM -0600, Jim Fehlig wrote:
> On 09/07/2018 01:29 PM, Marek Marczykowski-Górecki wrote:
> > Signed-off-by: Marek Marczykowski-Górecki
> > ---
> > Changes in v2:
> > - use virDomainObjEndAPI
> > - drop duplicated error
On Mon, Sep 10, 2018 at 03:44:33PM -0600, Jim Fehlig wrote:
> On 08/05/2018 03:48 PM, Marek Marczykowski-Górecki wrote:
> > Since this is something between PV and HVM, it makes sense to put the
> > setting in place where domain type is specified.
> > To enable it, use It
, [xenlight], [libxl_ctx_alloc], [libxl.h],
> [fail="1"])
> -CFLAGS="$libxlold_CFLAGS"
> -
> -if test $fail = 1; then
> - AC_MSG_ERROR([You must install the libxl Library from Xen >= 4.4 to
> compile libxenlight driver with -lxl])
> -fi
> - fi
On Mon, Sep 10, 2018 at 04:45:50PM -0600, Jim Fehlig wrote:
> On 09/10/2018 04:02 PM, Marek Marczykowski-Górecki wrote:
> > On Mon, Sep 10, 2018 at 03:44:33PM -0600, Jim Fehlig wrote:
> > > On 08/05/2018 03:48 PM, Marek Marczykowski-Górecki wrote:
> > > > Since this i
On Fri, Sep 14, 2018 at 05:21:17PM -0600, Jim Fehlig wrote:
> On 8/5/18 3:48 PM, Marek Marczykowski-Górecki wrote:
> > Handle PVH domain type in both directions (xen-xl->xml, xml->xen-xl).
> > And add a test for it.
> >
> > Signed-off-by: Marek Marczykowski-Góreck
Specifically, list sub-elements and where they can be used. In addition,
describe supported machine types for Xen.
Signed-off-by: Marek Marczykowski-Górecki
---
Changes in v2:
- clarify type@domain description, add a link to domain xml there
---
docs/formatcaps.html.in | 22
Handle PVH domain type in both directions (xen-xl->xml, xml->xen-xl).
And add a test for it.
Signed-off-by: Marek Marczykowski-Górecki
---
src/xenconfig/xen_common.c | 11 +--
src/xenconfig/xen_xl.c | 5 +
tests/testutilsxen.c | 3 ++-
Make it easier to share HVM and PVH code where relevant. No functional
change.
Signed-off-by: Marek Marczykowski-Górecki
---
src/libxl/libxl_conf.c | 26 ++
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
If available, use b_info->nested_hvm instead of
b_info->u.hvm.nested_hvm. This will make nested HVM config available
also for PVH domains.
Signed-off-by: Marek Marczykowski-Górecki
Reviewed-by: Jim Fehlig
---
src/libxl/libxl_conf.c | 13 -
ch -
migrating further away from "linux" os type is offtopic to this series and
apparently is a controversial thing
- drop "docs: update domain schema for machine attribute" patch -
already applied
- apply review comments from Jim
- rebase on master
Marek Marczykowski-G
Signed-off-by: Marek Marczykowski-Górecki
---
tests/libxlxml2domconfigdata/basic-pvh.json | 49 ++-
tests/libxlxml2domconfigdata/basic-pvh.xml | 28 +-
tests/libxlxml2domconfigtest.c | 1 +-
3 files changed, 78 insertions(+)
create mode 100644
builder="hvm" is deprecated since Xen 4.10, new syntax is type="hvm" (or
type="pv", which is default). Since the old one is still supported,
still use it when writing native config, so the config will work on
older Xen too (and will also not complicate tests).
Sig
Otherwise starting PVH guest will result in "arch_setup_bootlate:
mapping shared_info failed (pfn=..., rc=-1, errno: 12): Internal error".
After this change the behavior is the same as in `xl`.
Signed-off-by: Marek Marczykowski-Górecki
Reviewed-by: Jim Fehlig
---
src/libxl/li
igned-off-by: Marek Marczykowski-Górecki
---
Changes in v2 proposed by Jim:
- use new_arch_added var instead of i == nr_guest_archs for clarity
- improve comment
- adjust for now required Xen >= 4.6 (remove part for Xen < 4.5)
---
docs/formatcaps.html.in| 4 ++--
d
On Mon, Sep 24, 2018 at 05:09:44PM -0600, Jim Fehlig wrote:
> On 9/18/18 6:50 PM, Marek Marczykowski-Górecki wrote:
> > This is a respin of my old PVHv1 patch[1], converted to PVHv2.
> > Should the code use "PVH" name (as libxl does internally), or "PVHv2
Make it easier to share HVM and PVH code where relevant. No functional
change.
Signed-off-by: Marek Marczykowski-Górecki
---
src/libxl/libxl_conf.c | 26 ++
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
igned-off-by: Marek Marczykowski-Górecki
---
Changes in v2 proposed by Jim:
- use new_arch_added var instead of i == nr_guest_archs for clarity
- improve comment
- adjust for now required Xen >= 4.6 (remove part for Xen < 4.5)
Changes in v3:
- limit VIR_DOMAIN_OSTYPE_XEN -> VIR_DOMAI
Signed-off-by: Marek Marczykowski-Górecki
---
Changes in v3:
- update for modified "libxl: add support for PVH"
- skip PVH test on too old Xen
---
tests/libxlxml2domconfigdata/basic-pvh.json | 49 ++-
tests/libxlxml2domconfigdata/basic-pvh.xml | 28 +++
builder="hvm" is deprecated since Xen 4.10, new syntax is type="hvm" (or
type="pv", which is default). Since the old one is still supported,
still use it when writing native config, so the config will work on
older Xen too (and will also not complicate tests).
Sig
rebase on master, drop already applied patches
- use #ifdef LIBXL_DOMAIN_TYPE_PVH to detect PVH support, fix compilation
failure on older Xen
- exclude PVH from VIR_DOMAIN_OSTYPE_XEN <-> VIR_DOMAIN_OSTYPE_LINUX conversion
- fix reported capabilities for PVH
Marek Marczykowski-Górecki (5):
Handle PVH domain type in both directions (xen-xl->xml, xml->xen-xl).
And add a test for it.
Signed-off-by: Marek Marczykowski-Górecki
---
Changes in v3:
- update for modified "libxl: add support for PVH"
---
src/xenconfig/xen_common.c | 11 +--
src/xe
On Tue, Oct 02, 2018 at 04:50:02PM -0600, Jim Fehlig wrote:
> On 9/30/18 8:15 PM, Marek Marczykowski-Górecki wrote:
> > Since this is something between PV and HVM, it makes sense to put the
> > setting in place where domain type is specified.
> > To enable it, use It is
On Tue, Oct 02, 2018 at 06:54:01PM -0600, Jim Fehlig wrote:
> On 10/2/18 5:02 PM, Marek Marczykowski-Górecki wrote:
> > On Tue, Oct 02, 2018 at 04:50:02PM -0600, Jim Fehlig wrote:
> > > My idea to add this variable for clarity now seems diluted by the need for
> > >
On Wed, Oct 03, 2018 at 03:13:30PM -0600, Jim Fehlig wrote:
> On 10/2/18 4:50 PM, Jim Fehlig wrote:
> > On 9/30/18 8:15 PM, Marek Marczykowski-Górecki wrote:
> > > Since this is something between PV and HVM, it makes sense to put the
> > > setting in place where domain
Handle PVH domain type in both directions (xen-xl->xml, xml->xen-xl).
And add a test for it.
Signed-off-by: Marek Marczykowski-Górecki
---
Changes in v3:
- update for modified "libxl: add support for PVH"
---
src/xenconfig/xen_common.c | 11 +--
src/xe
builder="hvm" is deprecated since Xen 4.10, new syntax is type="hvm" (or
type="pv", which is default). Since the old one is still supported,
still use it when writing native config, so the config will work on
older Xen too (and will also not complicate tests).
Sig
igned-off-by: Marek Marczykowski-Górecki
---
Changes in v2 proposed by Jim:
- use new_arch_added var instead of i == nr_guest_archs for clarity
- improve comment
- adjust for now required Xen >= 4.6 (remove part for Xen < 4.5)
Changes in v3:
- limit VIR_DOMAIN_OSTYPE_XEN -> VIR_DOMAI
ort, fix compilation
failure on older Xen
- exclude PVH from VIR_DOMAIN_OSTYPE_XEN <-> VIR_DOMAIN_OSTYPE_LINUX conversion
- fix reported capabilities for PVH
Changes in v4:
- change PVH support detection method
Marek Marczykowski-Górecki (5):
libxl: reorder libxlMakeDomBuildInfo for upcomi
Make it easier to share HVM and PVH code where relevant. No functional
change.
Signed-off-by: Marek Marczykowski-Górecki
---
src/libxl/libxl_conf.c | 26 ++
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
Signed-off-by: Marek Marczykowski-Górecki
---
Changes in v3:
- update for modified "libxl: add support for PVH"
- skip PVH test on too old Xen
---
tests/libxlxml2domconfigdata/basic-pvh.json | 49 ++-
tests/libxlxml2domconfigdata/basic-pvh.xml | 28 +++
On Tue, Oct 09, 2018 at 04:45:01PM -0600, Jim Fehlig wrote:
> On 10/7/18 9:39 AM, Marek Marczykowski-Górecki wrote:
> > @@ -647,6 +669,22 @@ libxlMakeDomBuildInfo(virDomainDefPtr def,
> > return -1;
> > }
> > #endif
> > +} else if (p
s_type xen entry will have all features of PV
and PVH. But then, it should probably reject PV features for PVH
machine somewhere - in post parse hook? Or maybe it should forcibly
remove them - for example I see PAE is forcibly enabled for 64bit HVM
guests.
--
Best Regards,
Marek Marczykowski-Górec
ill want to report the additional under the existing 'xen'
> blocks.
Is that virt-install limitation? In that case, IMO virt-install should
be fixed, instead of changing capabilities xml to match its limitations.
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Beca
On Thu, Oct 18, 2018 at 11:08:34AM -0600, Jim Fehlig wrote:
> On 10/17/18 12:59 PM, Marek Marczykowski-Górecki wrote:
> > On Sat, Oct 13, 2018 at 08:46:19AM -0600, Jim Fehlig wrote:
> > > I had some couch time at the start of the weekend and was finally able to
> > >
18 3:11 AM, Daniel P. Berrangé wrote:
> > > > > On Thu, Oct 18, 2018 at 11:08:34AM -0600, Jim Fehlig wrote:
> > > > > > On 10/17/18 12:59 PM, Marek Marczykowski-Górecki wrote:
> > > > > > > On Sat, Oct 13, 2018 at 08:46:19AM -0600, Jim Feh
On Fri, Oct 19, 2018 at 04:19:21PM +0100, Daniel P. Berrangé wrote:
> On Fri, Oct 19, 2018 at 05:10:30PM +0200, Marek Marczykowski-Górecki wrote:
> > On Fri, Oct 19, 2018 at 03:59:03PM +0100, Daniel P. Berrangé wrote:
> > > On Fri, Oct 19, 2018 at 08:53:15AM -0600, Jim Fehlig
Use preferred name: 'xen'.
Signed-off-by: Marek Marczykowski-Górecki
---
docs/formatdomain.html.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 19b7312..8043c7c 100644
--- a/docs/formatdomain.htm
Make it easier to share HVM and PVH code where relevant. No functional
change.
Signed-off-by: Marek Marczykowski-Górecki
---
src/libxl/libxl_conf.c | 26 ++
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
Signed-off-by: Marek Marczykowski-Górecki
---
docs/schemas/domaincommon.rng | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
index ac04af5..eded1ca 100644
--- a/docs/schemas/domaincommon.rng
+++ b/docs/schemas
1 - 100 of 291 matches
Mail list logo
