[Libvir] disk shareable/ has no effect

2007-11-14 Thread Markus Armbruster
Looks like shareable/ within disk has no effect. I ran virsh dumpxml, inserted the shareable/, redefined the domain, and ran virsh dumpxml again. No shareable. I even ran virsh undefine and virsh define again, same thing. XML and output of xm list --long for this guest attached. domain

Re: [libvirt] [Qemu-devel] [PATCH] vl.c: Support multiple CPU ranges on -numa option

2013-02-21 Thread Markus Armbruster
Eduardo Habkost ehabk...@redhat.com writes: This allows , to be used a separator between each CPU range. Note that commas inside key=value command-line options have to be escaped using ,,, so the command-line will look like: -numa node,cpus=A,,B,,C,,D This is really, really ugly, and an

Re: [libvirt] [Qemu-devel] [PATCH] vl.c: Support multiple CPU ranges on -numa option

2013-02-21 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: Markus Armbruster arm...@redhat.com writes: Eduardo Habkost ehabk...@redhat.com writes: This allows , to be used a separator between each CPU range. Note that commas inside key=value command-line options have to be escaped using ,,, so

Re: [libvirt] [Qemu-devel] [PATCH] vl.c: Support multiple CPU ranges on -numa option

2013-02-22 Thread Markus Armbruster
Markus Armbruster arm...@redhat.com writes: Anthony Liguori anth...@codemonkey.ws writes: Markus Armbruster arm...@redhat.com writes: Eduardo Habkost ehabk...@redhat.com writes: This allows , to be used a separator between each CPU range. Note that commas inside key=value command-line

Re: [libvirt] [Qemu-devel] [PATCH] vl.c: Support multiple CPU ranges on -numa option

2013-02-26 Thread Markus Armbruster
Eduardo Habkost ehabk...@redhat.com writes: On Thu, Feb 21, 2013 at 09:23:22PM +0100, Markus Armbruster wrote: Eduardo Habkost ehabk...@redhat.com writes: This allows , to be used a separator between each CPU range. Note that commas inside key=value command-line options have

Re: [libvirt] [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-26 Thread Markus Armbruster
Eduardo Habkost ehabk...@redhat.com writes: This allows : to be used a separator between each CPU range, so the command-line may look like: -numa node,cpus=A-B:C-D Note that the following format, currently used by libvirt: -numa nodes,cpus=A-B,C-D will _not_ work, as , is the option

Re: [libvirt] [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-26 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Il 26/02/2013 20:35, Anthony Liguori ha scritto: See also discussion on multi-valued keys in command line option arguments and config files in v1 thread. Hopefully we can reach a conclusion soon, and then we'll see whether this patch is what we

Re: [libvirt] [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-27 Thread Markus Armbruster
Anthony Liguori aligu...@us.ibm.com writes: Paolo Bonzini pbonz...@redhat.com writes: Il 26/02/2013 20:35, Anthony Liguori ha scritto: See also discussion on multi-valued keys in command line option arguments and config files in v1 thread. Hopefully we can reach a conclusion soon,

Re: [libvirt] [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-28 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: Paolo Bonzini pbonz...@redhat.com writes: Il 27/02/2013 16:42, Anthony Liguori ha scritto: There's such thing as list support in QemuOpts. The only way QemuOptsVisitor was able to implement it was to expose QemuOpts publicly via options_int.h

Re: [libvirt] [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-28 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Il 27/02/2013 17:19, Eduardo Habkost ha scritto: If it is meant as a prototype only, and the final command-line syntax would be with repeated keys, that's okay. I think that Eduardo/Markus/I are focusing on the user interface, you're focusing

Re: [libvirt] [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-28 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: Paolo Bonzini pbonz...@redhat.com writes: Il 27/02/2013 18:08, Anthony Liguori ha scritto: No, no, no. This makes ':' special, which means you can't have lists of anything containing ':'. Your cure is worse than the disease. Let go of

Re: [libvirt] [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-28 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: Markus Armbruster arm...@redhat.com writes: Related: overwrite something you got from a config file on the command line. In both your example and mine, we have entirely separate options, and they have perfectly ordinary overwrite semantics

Re: [libvirt] [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-28 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: Markus Armbruster arm...@redhat.com writes: Anthony Liguori anth...@codemonkey.ws writes: Paolo Bonzini pbonz...@redhat.com writes: What about: [numa] node=1 cpus=2 cpus=3 qemu -readconfig

Re: [libvirt] [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-07 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: [adding libvirt] On 03/06/2013 07:52 AM, Paolo Bonzini wrote: Il 06/03/2013 15:44, Eric Blake ha scritto: Question - if libvirt misses the event (for example, if libvirtd requests a remove, but then gets restarted, and the event arrives before libvirtd

Re: [libvirt] [Qemu-devel] [PATCHv3] qdev: DEVICE_DELETED event

2013-03-07 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: libvirt has a long-standing bug: when removing the device, it can request removal but does not know when the removal completes. Add an event so we can fix this in a robust way. This is *v4*. I think you should respin to avoid confusing Anthony's

Re: [libvirt] [Qemu-devel] [PATCH v4] qdev: DEVICE_DELETED event

2013-03-07 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: libvirt has a long-standing bug: when removing the device, it can request removal but does not know when the removal completes. Add an event so we can fix this in a robust way. Signed-off-by: Michael S. Tsirkin m...@redhat.com Speaking as the

Re: [libvirt] [Qemu-devel] [PATCH v4] qdev: DEVICE_DELETED event

2013-03-08 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: On Thu, Mar 07, 2013 at 08:57:52PM +0100, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: libvirt has a long-standing bug: when removing the device, it can request removal but does not know when the removal completes. Add

Re: [libvirt] [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-08 Thread Markus Armbruster
Osier Yang jy...@redhat.com writes: I'm wondering if it could be long time to wait for the device_del completes (AFAIK from previous bugs, it can be, though it should be fine for most of the cases). If it's too long, it will be a problem for management, because it looks like hanging. We can

Re: [libvirt] [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-08 Thread Markus Armbruster
Osier Yang jy...@redhat.com writes: On 2013年03月08日 16:50, Markus Armbruster wrote: Osier Yangjy...@redhat.com writes: I'm wondering if it could be long time to wait for the device_del completes (AFAIK from previous bugs, it can be, though it should be fine for most of the cases). If it's

Re: [libvirt] [Qemu-devel] [PATCHv5 0/3] DEVICE_DELETED event

2013-03-13 Thread Markus Armbruster
the event trigger. I wouldn't do it that way myself, but I'm not going to NAK usable upstream work because of such downstream concerns. In case you pick 3: Acked-by: Markus Armbruster arm...@redhat.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman

Re: [libvirt] [Qemu-devel] [PATCH v6 1/3] qdev: DEVICE_DELETED event

2013-03-14 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: libvirt has a long-standing bug: when removing the device, it can request removal but does not know when the removal completes. Add an event so we can fix this in a robust way. Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

Re: [libvirt] [Qemu-devel] [PATCH v6 1/3] qdev: DEVICE_DELETED event

2013-03-14 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: On Thu, Mar 14, 2013 at 09:06:15AM +0100, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: [...] diff --git a/qapi-schema.json b/qapi-schema.json index 28b070f..bb361e1 100644 --- a/qapi-schema.json +++ b/qapi-schema.json

Re: [libvirt] [Qemu-devel] [PATCH v6 1/3] qdev: DEVICE_DELETED event

2013-03-14 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: On Thu, Mar 14, 2013 at 09:06:15AM +0100, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: libvirt has a long-standing bug: when removing the device, it can request removal but does not know when the removal completes. Add

Re: [libvirt] [Qemu-devel] [PATCH v8 0/3] DEVICE_DELETED event

2013-03-14 Thread Markus Armbruster
for your patience. Acked-by: Markus Armbruster arm...@redhat.com If there are no more comments I'll stick this on my pci branch. I don't mind. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Qemu-devel] [PATCH v9 1/3] qdev: DEVICE_DELETED event

2013-03-21 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: libvirt has a long-standing bug: when removing the device, it can request removal but does not know when the removal completes. Add an event so we can fix this in a robust way. Signed-off-by: Michael S. Tsirkin m...@redhat.com Acked-by: Markus

Re: [libvirt] [Qemu-devel] [PATCH v9 3/3] qmp: add path to device_deleted event

2013-03-21 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: Add QOM path to device deleted event. It now becomes useful to report it for devices which don't have an ID assigned. Signed-off-by: Michael S. Tsirkin m...@redhat.com Acked-by: Markus Armbruster arm...@redhat.com -- libvir-list mailing list

Re: [libvirt] [Qemu-devel] fix/re-do query-command-line-options

2014-01-28 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: Hi QEMU/Libvirt list, When I worked on query-command-line-options, I first used some marcos [1] to generate two config option tables. This will cover all the options, but it returns a string, it's difficult for libvirt to parse and use it. Finally I got

Re: [libvirt] [Qemu-devel] fix/re-do query-command-line-options

2014-01-28 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Il 28/01/2014 10:36, Markus Armbruster ha scritto: I think the data you can usefully collect with this approach is approximately the data getopt_long()[*] gets: list of named command line options, and whether they take an argument. You can use

Re: [libvirt] [Qemu-devel] fix/re-do query-command-line-options

2014-01-28 Thread Markus Armbruster
[Adding Luiz...] Paolo Bonzini pbonz...@redhat.com writes: Il 28/01/2014 12:55, Markus Armbruster ha scritto: Paolo Bonzini pbonz...@redhat.com writes: Il 28/01/2014 10:36, Markus Armbruster ha scritto: I think the data you can usefully collect with this approach is approximately the data

Re: [libvirt] [Qemu-devel] fix/re-do query-command-line-options

2014-01-28 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Il 28/01/2014 14:16, Markus Armbruster ha scritto: That would mean we can't ever add an option that doesn't take an argument again. We can add it under an existing QemuOpts group or invent a new one (like we did for -rt or -msg). Do you mean -rtc

Re: [libvirt] [PATCH] RFC: Add blockdev-delete QMP command

2014-02-10 Thread Markus Armbruster
Ian Main im...@redhat.com writes: This is the sister command to blockdev-add. In Fam's example he uses the drive_del HMP command to clean up but when trying to do this via libvirt it doesn't work. This command seems to be needed in order to perform proper cleanup. Signed-off-by: Ian Main

Re: [libvirt] [Qemu-devel] [PATCH 2/5] introduce two marcos to dump the options info

2014-02-11 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: We will use the marocs to generate two tables, which contain the option name and argument information. Signed-off-by: Amos Kong ak...@redhat.com --- qemu-options-wrapper.h | 18 ++ 1 file changed, 18 insertions(+) diff --git

Re: [libvirt] [Qemu-devel] [PATCH 3/5] query-command-line-options: query all the options in qemu-options.hx

2014-02-11 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: vm_config_groups[] contain the options which have parameter, but some legcy options haven't been added to vm_config_groups[]. All the options can be found in qemu-options.hx, this patch used two new marcos to generate two tables, we can check if the option

Re: [libvirt] [Qemu-devel] [PATCH 4/5] introduce QEMU_OPTIONS_GENERATE_HELPMSG

2014-02-11 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: This patch introduced a new maroc, it will be used to dump the help messages of all the options. macro. Also misspelled in PATCH 2/5. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Qemu-devel] [PATCH 5/5] query-command-line-options: return help message for legacy options

2014-02-11 Thread Markus Armbruster
[Note cc: Eric] Amos Kong ak...@redhat.com writes: Some legacy options that have arguments weren't added to vm_config_groups[], so query-command-line-options returns a NULL parameters infolist. This patch try to return help message for this kind of legacy options. Example: {

Re: [libvirt] [Qemu-devel] [PATCH v4 2/2] query-command-line-options: query all the options in qemu-options.hx

2014-03-06 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: vm_config_groups[] only contains part of the options which have argument, and all options which have no argument aren't added to vm_config_groups[]. Current query-command-line-options only checks options from vm_config_groups[], so some options will be

Re: [libvirt] [Qemu-devel] [PATCH v4 2/2] query-command-line-options: query all the options in qemu-options.hx

2014-03-07 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 03/05/2014 07:36 PM, Amos Kong wrote: vm_config_groups[] only contains part of the options which have argument, and all options which have no argument aren't added to vm_config_groups[]. Current query-command-line-options only checks options from

Re: [libvirt] [Qemu-devel] [PATCH v4 2/2] query-command-line-options: query all the options in qemu-options.hx

2014-03-07 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: vm_config_groups[] only contains part of the options which have argument, and all options which have no argument aren't added to vm_config_groups[]. Current query-command-line-options only checks options from vm_config_groups[], so some options will be

Re: [libvirt] [Qemu-devel] pvpanic plans?

2013-10-29 Thread Markus Armbruster
Ping! Hu Tao hu...@cn.fujitsu.com writes: Hi All, I know it's been a long time since this thread. But qemu 1.7 is releasing, do you have any consensus on this? Thanks. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Qemu-devel] [RFC] introduce a general query-config cmd

2013-01-23 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: [...] But info command of hmp doesn't support parameter (eg: (hmp) info config boot) It does since Wenchao Xia's recent improvements (commit 84c44613). For an example how to use them, check out his hmp: add function hmp_info_snapshots() (on list, not yet

Re: [libvirt] [Qemu-devel] q35 machine type and libvirt.

2013-02-07 Thread Markus Armbruster
Cc'ing a few QOMmers... Laine Stump la...@redhat.com writes: Now that qemu is getting the q35 machine type, libvirt needs to support it. As far as I understand, from libvirt's point of view, q35 is just another x86_64 system, but with a different set of implicit devices, and possibly some

Re: [libvirt] [Qemu-devel] live snapshot wiki updated

2011-07-20 Thread Markus Armbruster
Daniel P. Berrange berra...@redhat.com writes: On Tue, Jul 19, 2011 at 04:14:27PM +0100, Stefan Hajnoczi wrote: On Tue, Jul 19, 2011 at 3:30 PM, Jes Sorensen jes.soren...@redhat.com wrote: On 07/19/11 16:24, Eric Blake wrote: [adding the libvir-list] On 07/19/2011 08:09 AM, Jes Sorensen

Re: [libvirt] [Qemu-devel] live snapshot wiki updated

2011-07-21 Thread Markus Armbruster
Jes Sorensen jes.soren...@redhat.com writes: On 07/19/11 18:14, Anthony Liguori wrote: As nice as that sentiment is, it will never fly, because it would be a regression in current behavior. The whole reason that the virt_use_nfs SELinux bool exists is that some people are willing to make the

Re: [libvirt] [Qemu-devel] [RFC] Adding new filesystem 'proxy' to 9p

2011-10-10 Thread Markus Armbruster
Daniel P. Berrange berra...@redhat.com writes: On Thu, Sep 29, 2011 at 11:42:47PM +0530, M. Mohan Kumar wrote: On Wednesday, September 28, 2011 08:29:06 PM Daniel P. Berrange wrote: [...] If we assume that QEMU gets exploited, and that QEMU can find some flaw in the proxy_helper that it can

Re: [libvirt] [Qemu-devel] RFC decoupling VM NIC provisioning from VM NIC connection to backend networks

2011-10-31 Thread Markus Armbruster
Daniel P. Berrange berra...@redhat.com writes: On Fri, Oct 28, 2011 at 04:15:41PM -0700, Sumit Naiksatam (snaiksat) wrote: Hi, In its current implementation Libvirt makes sure that the network interfaces that it passes/provision to a VM (for example to qemu[-kvm]) are already connected to

Re: [libvirt] [Qemu-devel] RFC decoupling VM NIC provisioning fromVM NIC connection to backend networks

2011-11-02 Thread Markus Armbruster
Christian Benvenuti (benve) be...@cisco.com writes: -Original Message- From: qemu-devel-bounces+benve=cisco@nongnu.org [mailto:qemu-devel- bounces+benve=cisco@nongnu.org] On Behalf Of Markus Armbruster Sent: Monday, October 31, 2011 7:05 AM To: Daniel P. Berrange Cc: libvir

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-24 Thread Markus Armbruster
instances. For instance: commit 39a51dfda835a75c0ebbfd92705b96e4de77f795 Author: Markus Armbruster arm...@redhat.com Date: Tue Oct 27 13:52:13 2009 +0100 qdev: Tag isa-fdc, PIIX3 IDE and PIIX4 IDE as no-user These devices are created automatically, and attempting

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-25 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: On 03/25/2010 07:37 AM, Avi Kivity wrote: On 03/25/2010 02:33 PM, Anthony Liguori wrote: From my point of view, i wouldn't want to write a high level management toolstack in C, specially since the API is well defined JSON which is easily

[libvirt] [PATCH 0/7 RFC] RHEL-5 support, and a few preparatory fixes

2008-12-23 Thread Markus Armbruster
This patch series attempts to make libvirt just work on RHEL-5. Right now it doesn't, mostly because libvirt relies on version number checks in a couple of places, and RHEL-5's version numbers aren't the whole truth due to various backports of later stuff. The first two patches are plain bug

[libvirt] [PATCH 4/7] Fix HVM network device configuration for RHEL-5

2008-12-23 Thread Markus Armbruster
Omit (type ioemu) on RHEL-5, because it breaks PV drivers on HVM there. Signed-off-by: Markus Armbruster arm...@redhat.com --- src/xend_internal.c |8 +++- src/xm_internal.c |8 +++- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/src/xend_internal.c b/src

[libvirt] [PATCH 5/7] Fix PVFB device configuration for RHEL-5

2008-12-23 Thread Markus Armbruster
PVFB configuration depends on the version. The version number check doesn't work for RHEL-5 because its PVFB device was backported from later versions. Special-case it. Signed-off-by: Markus Armbruster arm...@redhat.com --- src/xend_internal.c |6 -- src/xm_internal.c |4 +++- 2

[libvirt] [PATCH 2/7] Fix graphics configuration inconsistency between xm and sxpr

2008-12-23 Thread Markus Armbruster
xenDaemonFormatSxpr() generates old-style HVM graphics configuration when xendConfigVersion is below 4. xenXMDomainConfigFormat() does that always. Change it to make it consistent with xenDaemonFormatSxpr(). Signed-off-by: Markus Armbruster arm...@redhat.com --- src/xm_internal.c |2 +- 1

[libvirt] [PATCH 1/7] Fix network device inconsistency between xm and sxpr

2008-12-23 Thread Markus Armbruster
xenDaemonFormatSxpr() adds (type ioemu) only if xendConfigVersion 4. xenXMDomainConfigFormatNet() adds type=ioemu always. Change it make it consistent with xenDaemonFormatSxpr(). Signed-off-by: Markus Armbruster arm...@redhat.com --- src/xm_internal.c |3 ++- 1 files changed, 2 insertions

[libvirt] [PATCH 3/7] New configure option --with-rhel5-api

2008-12-23 Thread Markus Armbruster
RHEL-5 has a peculiar version of Xen, which requires some special casing. Add a configure option for that. It will be used in later commits. Signed-off-by: Markus Armbruster arm...@redhat.com --- configure.in |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git

[libvirt] [PATCH 7/7] Don't treat missing topology information as error

2008-12-23 Thread Markus Armbruster
-by: Markus Armbruster arm...@redhat.com --- src/xend_internal.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/xend_internal.c b/src/xend_internal.c index 9b9f98d..096e22f 100644 --- a/src/xend_internal.c +++ b/src/xend_internal.c @@ -2546,6 +2546,8

[libvirt] [PATCH 6/7] Enable NUMA support for RHEL-5

2008-12-23 Thread Markus Armbruster
RHEL-5 supports NUMA since 5.2. Relax the version number checks. This breaks older versions, which will be fixed in the next commit. Signed-off-by: Markus Armbruster arm...@redhat.com --- src/xen_internal.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src

Re: [libvirt] [PATCH 3/7] New configure option --with-rhel5-api

2008-12-24 Thread Markus Armbruster
John Levon le...@movementarian.org writes: On Tue, Dec 23, 2008 at 04:05:13PM +0100, Markus Armbruster wrote: RHEL-5 has a peculiar version of Xen, which requires some special casing. Add a configure option for that. It will be used in later commits. Ugh, shouldn't this be staying

Re: [libvirt] [PATCH 4/7] Fix HVM network device configuration for RHEL-5

2009-01-19 Thread Markus Armbruster
Daniel Veillard veill...@redhat.com writes: On Tue, Dec 23, 2008 at 04:05:14PM +0100, Markus Armbruster wrote: Omit (type ioemu) on RHEL-5, because it breaks PV drivers on HVM there. Signed-off-by: Markus Armbruster arm...@redhat.com +#ifdef WITH_RHEL5_API +#define

Re: [libvirt] [Qemu-devel] Re: Libvirt debug API

2010-04-23 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: On 04/23/2010 07:48 AM, Avi Kivity wrote: On 04/22/2010 09:49 PM, Anthony Liguori wrote: real API. Say, adding a device libvirt doesn't know about or stopping the VM while libvirt thinks it's still running or anything like that. Another

Re: [libvirt] [PATCH] block: Set cdrom device read only flag

2012-08-07 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 02.08.2012 09:20, schrieb Kevin Shanahan: On Thu, Aug 02, 2012 at 02:49:52PM +0930, Kevin Shanahan wrote: On Thu, Aug 02, 2012 at 11:46:13AM +0930, Kevin Shanahan wrote: On Thu, Aug 02, 2012 at 11:02:42AM +0930, Kevin Shanahan wrote: Set the block

Re: [libvirt] [Qemu-devel] [PATCH] block: Set cdrom device read only flag

2012-08-07 Thread Markus Armbruster
ronnie sahlberg ronniesahlb...@gmail.com writes: Since pretty much every cdrom drive use scsi today, shouldnt the readonly/writeable flag for MMC devices rather be done down in the hw/scsi* code rather than the generic block code? There are two separate things that can be read-only: device

Re: [libvirt] [PATCH] block: Set cdrom device read only flag

2012-08-13 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 12.08.2012 04:48, schrieb Kevin Shanahan: So qmp_change_blockdev uses bdrv_is_read_only() to check whether to try and open the backing file read only, which uses the -read_only member of struct BlockDriverState to decide whether to pass the BDRV_O_RDRW

Re: [libvirt] [Qemu-devel] Problems using netdev_del+netdev_add w/o corresponding device_del+device_add

2012-10-16 Thread Markus Armbruster
Laine Stump la...@redhat.com writes: On 10/15/2012 05:25 AM, Daniel P. Berrange wrote: On Mon, Oct 15, 2012 at 10:30:07AM +0200, Stefan Hajnoczi wrote: On Sat, Oct 13, 2012 at 04:47:14PM -0400, Laine Stump wrote: Here is the sequence sent to disconnect only the host side, then reconnect it

Re: [libvirt] [Qemu-devel] [PATCH v4 2/2] query-command-line-options: query all the options in qemu-options.hx

2014-03-11 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 03/07/2014 02:54 AM, Markus Armbruster wrote: Eric Blake ebl...@redhat.com writes: On 03/05/2014 07:36 PM, Amos Kong wrote: vm_config_groups[] only contains part of the options which have argument, and all options which have no argument aren't added

Re: [libvirt] [Qemu-devel] [PATCH v4 2/2] query-command-line-options: query all the options in qemu-options.hx

2014-03-26 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: On Fri, Mar 07, 2014 at 10:54:09AM +0100, Markus Armbruster wrote: Eric Blake ebl...@redhat.com writes: On 03/05/2014 07:36 PM, Amos Kong wrote: vm_config_groups[] only contains part of the options which have argument, and all options which have

Re: [libvirt] [Qemu-devel] [PATCH v3 for 2.0] update names in option tables to match with actual command-line spelling

2014-03-26 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 03/20/2014 07:07 AM, Amos Kong wrote: We want to establish a mapping between option name and option table, then we can search related option table by option name. This patch makes all the member name of QemuOptsList to match with actual command-line

Re: [libvirt] [Qemu-devel] [PATCH v4 2/2] query-command-line-options: query all the options in qemu-options.hx

2014-03-27 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: On Wed, Mar 26, 2014 at 02:15:18PM +0100, Markus Armbruster wrote: Amos Kong ak...@redhat.com writes: On Fri, Mar 07, 2014 at 10:54:09AM +0100, Markus Armbruster wrote: Eric Blake ebl...@redhat.com writes: On 03/05/2014 07:36 PM, Amos Kong wrote

Re: [libvirt] [Qemu-devel] [PATCH v5 for 2.0 3/3] abort QEMU if group name in option table doesn't match with defined option name

2014-03-28 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: All the options are defined in qemu-options.hx. If we can't find a matched option definition by group name of option table, then the group name doesn't match with defined option name, it's not allowed from 2.0 Signed-off-by: Amos Kong ak...@redhat.com ---

Re: [libvirt] [Qemu-devel] [PATCH v5 for 2.0 3/3] abort QEMU if group name in option table doesn't match with defined option name

2014-03-28 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 03/28/2014 08:55 AM, Markus Armbruster wrote: Amos Kong ak...@redhat.com writes: All the options are defined in qemu-options.hx. If we can't find a matched option definition by group name of option table, then the group name doesn't match

Re: [libvirt] [Qemu-devel] [PATCH v5 for 2.0 1/3] only add qemu_tpmdev_opts when CONFIG_TPM is defined

2014-03-28 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 03/28/2014 06:04 AM, Markus Armbruster wrote: Amos Kong ak...@redhat.com writes: Taking a step back: quite a few command line options make sense only in certain build configurations. We deal with that in several different ways: 1. Target

Re: [libvirt] [Qemu-devel] [PATCH v5 for 2.0 1/3] only add qemu_tpmdev_opts when CONFIG_TPM is defined

2014-03-28 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: Signed-off-by: Amos Kong ak...@redhat.com --- vl.c | 4 1 file changed, 4 insertions(+) diff --git a/vl.c b/vl.c index 2355227..596ecfa 100644 --- a/vl.c +++ b/vl.c @@ -449,6 +449,7 @@ static QemuOptsList qemu_object_opts = { }, };

Re: [libvirt] [Qemu-devel] [PATCHv2] Don't log an internal error when the guest hasn't updated balloon stats

2014-05-16 Thread Markus Armbruster
Copying Luiz... Eric Blake ebl...@redhat.com writes: On 05/15/2014 01:22 AM, Ján Tomko wrote: If virDomainMemoryStats is called too soon after domain startup, QEMU returns: error:{class:GenericError,desc:guest hasn't updated any stats yet} when we try to query balloon stats. Check for

Re: [libvirt] [Qemu-devel] [PATCHv2 3/4] qemu: fix RTC_CHANGE event for clock offset='variable' basis='utc'/

2014-05-23 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 23 May 2014 00:50:38 -0300 Marcelo Tosatti mtosa...@redhat.com wrote: Then the guest triggers an RTC update, so qemu sends an event, but the event is lost. Then libvirtd starts again, and doesn't realize the event is lost. Yes,

Re: [libvirt] [Qemu-devel] IO accounting overhaul

2014-09-01 Thread Markus Armbruster
Cc'ing libvirt following Stefan's lead. Benoît Canet benoit.ca...@irqsave.net writes: Hi, I collected some items of a cloud provider wishlist regarding I/O accouting. Feedback from real power-users, lovely! In a cloud I/O accouting can have 3 purpose: billing, helping the customers and

Re: [libvirt] [Qemu-devel] IO accounting overhaul

2014-09-01 Thread Markus Armbruster
Benoît Canet benoit.ca...@irqsave.net writes: The Monday 01 Sep 2014 à 11:52:00 (+0200), Markus Armbruster wrote : Cc'ing libvirt following Stefan's lead. Benoît Canet benoit.ca...@irqsave.net writes: Hi, I collected some items of a cloud provider wishlist regarding I/O accouting

Re: [libvirt] [Qemu-devel] [PATCH 1/2] add 'umask' option to -chardev

2014-09-02 Thread Markus Armbruster
Daniel P. Berrange berra...@redhat.com writes: On Tue, Sep 02, 2014 at 03:40:42PM +0800, Chunyan Liu wrote: To use virtio-serial device, unix socket created for chardev with default umask(022) has insufficient permissions. e.g. start kvm guest with: -device virtio-serial \ -chardev

Re: [libvirt] [Qemu-devel] IO accounting overhaul

2014-09-02 Thread Markus Armbruster
Benoît Canet benoit.ca...@irqsave.net writes: The Monday 01 Sep 2014 à 13:41:01 (+0200), Markus Armbruster wrote : Benoît Canet benoit.ca...@irqsave.net writes: The Monday 01 Sep 2014 à 11:52:00 (+0200), Markus Armbruster wrote : [...] A quick stab at tasks: * QMP interface, either

Re: [libvirt] [Qemu-devel] IO accounting overhaul

2014-09-08 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 01.09.2014 um 13:41 hat Markus Armbruster geschrieben: Benoît Canet benoit.ca...@irqsave.net writes: The Monday 01 Sep 2014 à 11:52:00 (+0200), Markus Armbruster wrote : Cc'ing libvirt following Stefan's lead. Benoît Canet benoit.ca

Re: [libvirt] [Qemu-devel] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm

2014-09-22 Thread Markus Armbruster
Daniel P. Berrange berra...@redhat.com writes: On Mon, Sep 22, 2014 at 02:36:55PM +0300, Michael S. Tsirkin wrote: On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote: Add a configure option --enable-pc-1-0-qemu-kvm and the corresponding --disable-pc-1-0-qemu-kvm, defaulting to

Re: [libvirt] [Qemu-devel] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm

2014-09-22 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote: Add a configure option --enable-pc-1-0-qemu-kvm and the corresponding --disable-pc-1-0-qemu-kvm, defaulting to disabled. Rename machine type pc-1.0 to pc-1.0-qemu-git. Make pc-1.0

Re: [libvirt] [Qemu-devel] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm

2014-09-22 Thread Markus Armbruster
Alex Bligh a...@alex.org.uk writes: On 22 Sep 2014, at 16:45, Andreas Färber afaer...@suse.de wrote: What about adding a bool property qemu-kvm-compat to the MachineClass? Then a qemu-kvm shell script (like SUSE uses) can pass -global machine.qemu-kvm-compat=on whereas qemu-system-x86_64

Re: [libvirt] [Qemu-devel] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm

2014-09-23 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: On Mon, Sep 22, 2014 at 05:32:16PM +0200, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote: Add a configure option --enable-pc-1-0-qemu-kvm and the corresponding

Re: [libvirt] [Qemu-devel] [PATCH v4] Add machine parameter qemu-kvm-migration for live migrate compatibility with qemu-kvm

2014-09-24 Thread Markus Armbruster
Alex Bligh a...@alex.org.uk writes: This patch series adds inbound migrate capability from qemu-kvm version 1.0. The main ideas are those set out in Cole Robinson's patch here: http://pkgs.fedoraproject.org/cgit/qemu.git/tree/0001-Fix-migration-from-qemu-kvm.patch?h=f20 however, rather than

Re: [libvirt] [Qemu-devel] [PATCH v4] Add machine parameter qemu-kvm-migration for live migrate compatibility with qemu-kvm

2014-09-29 Thread Markus Armbruster
Alex Bligh a...@alex.org.uk writes: [...] +/* NB cirrus-vga default value is 8MB anyway, save if we + * monkey patch it to change the default when the qemu-kvm-migration + * machine parameter is selected + */ + This is too hacky for my taste. How about creating a new machine e.g.

Re: [libvirt] [Qemu-devel] spec, RFC: TLS support for NBD

2014-10-20 Thread Markus Armbruster
Stefan Hajnoczi stefa...@redhat.com writes: On Mon, Oct 20, 2014 at 08:58:14AM +0100, Daniel P. Berrange wrote: On Sat, Oct 18, 2014 at 07:33:22AM +0100, Richard W.M. Jones wrote: On Sat, Oct 18, 2014 at 12:03:23AM +0200, Wouter Verhelst wrote: Hi all, (added rjones from nbdkit fame

Re: [libvirt] [Qemu-devel] spec, RFC: TLS support for NBDµ

2014-10-21 Thread Markus Armbruster
Wouter Verhelst w...@uter.be writes: On Mon, Oct 20, 2014 at 01:51:43PM +0200, Markus Armbruster wrote: Stefan Hajnoczi stefa...@redhat.com writes: On Mon, Oct 20, 2014 at 08:58:14AM +0100, Daniel P. Berrange wrote: On Sat, Oct 18, 2014 at 07:33:22AM +0100, Richard W.M. Jones wrote

Re: [libvirt] [Qemu-devel] Close the BlockDriverState when guest eject the media

2014-10-27 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 10/21/2014 12:10 AM, Gonglei wrote: There is a problem. 1. Qemu receive the eject command. 2. Runs eject_request_cb when an eject request is issued from the monitor, the tray is closed, and the medium is locked. But the drive is not closed. 3.

Re: [libvirt] [Qemu-devel] qemu commit 65207c59 broke libvirt's capability retrieval (apparently)

2015-06-08 Thread Markus Armbruster
Laszlo Ersek ler...@redhat.com writes: On 06/05/15 23:47, Eric Blake wrote: On 06/05/2015 03:42 PM, Laszlo Ersek wrote: I found this qemu commit, ie. commit 65207c59d99f2260c5f1d3b9c491146616a522aa Author: Markus Armbruster arm...@redhat.com Date: Thu Mar 5 14:35:26 2015 +0100

Re: [libvirt] [Qemu-devel] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

2016-05-30 Thread Markus Armbruster
Eduardo Habkost <ehabk...@redhat.com> writes: > Just noticed that I hadn't replied to this yet. Sorry for the > long delay! > > On Thu, May 12, 2016 at 09:46:25AM +0200, Markus Armbruster wrote: >> Eduardo Habkost <ehabk...@redhat.com> writes: > [...]

Re: [libvirt] [Qemu-devel] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

2016-05-31 Thread Markus Armbruster
Eduardo Habkost <ehabk...@redhat.com> writes: > On Mon, May 30, 2016 at 11:33:38AM +0200, Markus Armbruster wrote: [...] >> The new members encode an answer to the question whether a certain CPU >> usable with the current machine an accelerator, and if no, why. &g

Re: [libvirt] [Qemu-devel] [PATCH v2 4/6] qmp: Add runnability information to query-cpu-definitions

2016-06-22 Thread Markus Armbruster
not available. > # > # Since: 1.2.0 > ## > { 'struct': 'CpuDefinitionInfo', > - 'data': { 'name': 'str' } } > + 'data': { 'name': 'str', > +'*unavailable-features': [ 'str' ] } } > > ## > # @query-cpu-definitions: With the commit message tidied up as per your reply to Jiri: Reviewed-by: Markus Armbruster <arm...@redhat.com> -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Qemu-devel] [PATCH v2 4/6] qmp: Add runnability information to query-cpu-definitions

2016-06-23 Thread Markus Armbruster
Eduardo Habkost <ehabk...@redhat.com> writes: > On Wed, Jun 22, 2016 at 11:00:47AM +0200, Markus Armbruster wrote: >> Eduardo Habkost <ehabk...@redhat.com> writes: >> >> > Extend query-cpu-definitions schema to allow it to return two new >> > optional

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version

2016-02-15 Thread Markus Armbruster
Peter Xu writes: > For ARM platform, we still do not have any interface to query > whether current QEMU/host support specific GIC version. This > patchset is trying to add one QMP interface for that. By querying > the GIC capability using the new interface, one should know

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version

2016-02-15 Thread Markus Armbruster
Peter Xu <pet...@redhat.com> writes: > On Mon, Feb 15, 2016 at 10:52:01AM +0100, Markus Armbruster wrote: >> Peter Xu <pet...@redhat.com> writes: >> >> > For ARM platform, we still do not have any interface to query >> > whether current QEMU/host sup

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version

2016-02-15 Thread Markus Armbruster
Peter Maydell <peter.mayd...@linaro.org> writes: > On 15 February 2016 at 15:08, Markus Armbruster <arm...@redhat.com> wrote: >> Peter Xu <pet...@redhat.com> writes: >>> On Mon, Feb 15, 2016 at 10:52:01AM +0100, Markus Armbruster wrote: >>>> Peter X

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version

2016-02-16 Thread Markus Armbruster
Peter Maydell <peter.mayd...@linaro.org> writes: > On 15 February 2016 at 20:18, Andrew Jones <drjo...@redhat.com> wrote: >> On Mon, Feb 15, 2016 at 08:40:54PM +0100, Markus Armbruster wrote: >>> How would the command line look like? >>> >> >> H

Re: [libvirt] [Qemu-devel] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

2016-05-12 Thread Markus Armbruster
Eduardo Habkost <ehabk...@redhat.com> writes: > On Wed, May 11, 2016 at 09:11:33AM +0200, Markus Armbruster wrote: >> Eduardo Habkost <ehabk...@redhat.com> writes: >> >> > On Tue, May 10, 2016 at 10:23:16AM +0200, Markus Armbruster wrote: >> >&

Re: [libvirt] [Qemu-devel] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

2016-05-11 Thread Markus Armbruster
Eduardo Habkost <ehabk...@redhat.com> writes: > On Tue, May 10, 2016 at 10:23:16AM +0200, Markus Armbruster wrote: >> Eduardo Habkost <ehabk...@redhat.com> writes: >> >> > On Mon, May 09, 2016 at 09:20:15AM -0600, Eric Blake wrote: >> >&g

Re: [libvirt] [Qemu-devel] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

2016-05-10 Thread Markus Armbruster
Eduardo Habkost writes: > On Mon, May 09, 2016 at 09:20:15AM -0600, Eric Blake wrote: >> On 05/06/2016 12:11 PM, Eduardo Habkost wrote: >> > Extend query-cpu-definitions schema to allow it to return two new >> > optional fields: "runnable" and "unavailable-features". >> >

Re: [libvirt] [Qemu-devel] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

2016-05-09 Thread Markus Armbruster
Eduardo Habkost writes: > Extend query-cpu-definitions schema to allow it to return two new > optional fields: "runnable" and "unavailable-features". > "runnable" will tell if the CPU model can be run in the current > host. "unavailable-features" will contain a list of CPU >

  1   2   3   >