Re: [PATCH 0/3] Several small documentation fixes

I knew I’d miss something... Shucks! Does this work, or should I start a separate [PATCH v2] thread with the DCO added to the commit messages? Signed-off-by: Matt Coleman > On Sep 9, 2020, at 1:41 AM, Erik Skultety wrote: > > On Tue, Sep 08, 2020 at 04:43:51PM -0400, Matt Cole

[PATCH] hyperv: fix the number of threads per core

The operands were reversed, producing an incorrect result. Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 20d372b274

[PATCH 0/3] Several small documentation fixes

This patchset fixes several spelling and punctuation errors in the documentation. Where British vs. American conventions differ, I used Google Trends to determine which form is most commonly used, globally. Matt Coleman (3): Fix a typo in compiling.html.in: that -> from Fix err

[PATCH 3/3] Fix a typo in hacking.rst: "contirbute" -> "contribute"

--- docs/hacking.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/hacking.rst b/docs/hacking.rst index 3fc5888a71..858dd2dfc1 100644 --- a/docs/hacking.rst +++ b/docs/hacking.rst @@ -15,7 +15,7 @@ libvirt-python) `online `__. Patches to

[PATCH 1/3] Fix a typo in compiling.html.in: that -> from

The original author intended to write "different than". "Different" is commonly followed by "from", "than", and "to". Globally, "from" is the most common. --- docs/compiling.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/compiling.html.in b/docs/compiling.html.in

[PATCH 2/3] Fix errors in contribute.html.in

* Add a period to the end of the page's introductory sentence. * Correct a spelling error: "Evangalism"/"evangalise" -> "Evangelism"/"evangelize" --- docs/contribute.html.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/contribute.html.in

[PATCH 0/2] hyperv: bump minimum openwsman version to 2.6.3

e codebase. Also, openwsman.h has been removed entirely, since its original purpose was to work around bugs in earlier (now unsupported) openwsman versions. Matt Coleman (2): hyperv: bump minimum openwsman version to 2.6.3 hyperv: remove openwsman.h libvirt.spec.in | 2 +- m

[PATCH 0/7] more Hyper-V APIs

This set of patches adds several new APIs and fixes several others. Matt Coleman (7): hyperv: implement domainSetAutostart hyperv: implement nodeGetFreeMemory hyperv: implement domainReboot and domainReset hyperv: implement domainShutdown and domainShutdownFlags hyperv: fix

[PATCH 1/7] hyperv: implement domainSetAutostart

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 92 ++ 1 file changed, 92 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 2ac30fa4c6..6b2acbc405 100644 --- a/src/hyperv

[PATCH 4/7] hyperv: implement domainShutdown and domainShutdownFlags

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c| 77 ++ src/hyperv/hyperv_wmi_generator.input | 78 +++ 2 files changed, 155 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv

[PATCH 7/7] news: more Hyper-V APIs

Signed-off-by: Matt Coleman --- NEWS.rst | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/NEWS.rst b/NEWS.rst index e708f06e9e..9404ed7809 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -22,8 +22,11 @@ v6.9.0 (unreleased) * hyperv: implement new APIs

[PATCH 5/7] hyperv: fix domainSuspend and domainResume on Hyper-V V2

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 15 +++ src/hyperv/hyperv_wmi_classes.h | 1 + 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 0b28c1e94b..89840f7ac4 100644 --- a/src

Re: [PATCH 5/7] hyperv: fix domainSuspend and domainResume on Hyper-V V2

> On Oct 9, 2020, at 4:43 AM, Daniel P. Berrangé wrote: > > On Fri, Oct 09, 2020 at 04:31:54AM -0400, Matt Coleman wrote: >> Signed-off-by: Matt Coleman >> --- >> src/hyperv/hyperv_driver.c | 15 +++ >> src/hyperv/hyperv_wmi_classes.h | 1 +

Re: [PATCH v2 00/10] hyperv: implement new APIs & more

> On Oct 5, 2020, at 12:20 PM, Matt Coleman wrote: > > These patches fix a couple bugs, consolidate duplicate code, and > implement several APIs. If one of the primary maintainers has a chance, I think these changes are ready. Pino gave me some great feedback on v1, but

[PATCH 2/7] hyperv: implement nodeGetFreeMemory

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 28 1 file changed, 28 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 6b2acbc405..7e2bc002bd 100644 --- a/src/hyperv/hyperv_driver.c

[PATCH 3/7] hyperv: implement domainReboot and domainReset

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 48 + src/hyperv/hyperv_wmi_classes.h | 1 + 2 files changed, 49 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 7e2bc002bd

[PATCH 1/2] hyperv: bump minimum openwsman version to 2.6.3

Bug fixes and comments specific to older versions have been removed. Signed-off-by: Matt Coleman --- libvirt.spec.in| 2 +- meson.build| 2 +- src/hyperv/hyperv_driver.c | 4 +--- src/hyperv/hyperv_wmi.c| 8 src/hyperv/openwsman.h | 21

[PATCH 2/2] hyperv: remove openwsman.h

This header's main purpose was to work around bugs in older versions of openwsman. Most of the files using it only needed wsman-api.h, which they now include directly. Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 1 - src/hyperv/hyperv_private.h | 3 ++- src/hyperv

[PATCH 6/7] hyperv: fix domainManagedSave on Hyper-V V2

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 8 ++-- src/hyperv/hyperv_wmi_classes.h | 1 + 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 89840f7ac4..c91bc58488 100644 --- a/src/hyperv

Re: [PATCH v2 4/7] hyperv: implement domainShutdown and domainShutdownFlags

> On Oct 13, 2020, at 3:55 AM, Pino Toscano wrote: > > On Tuesday, 13 October 2020 07:14:01 CEST Matt Coleman wrote: >> +hypervAddSimpleParam(params, "Force", "False"); >> +hypervAddSimpleParam(params, "Reason", _("Planned

Re: [PATCH v2 3/7] hyperv: implement domainReboot and domainReset

> On Oct 13, 2020, at 3:40 AM, Pino Toscano wrote: > > What about making a common helper function that calls > hypervMsvmComputerSystemFromDomain + > hypervInvokeMsvmComputerSystemRequestStateChange? I’ll include that in the next version of this patchset. > Note that virDomainReboot() can take

Re: [PATCH v2 1/7] hyperv: implement domainSetAutostart

> On Oct 14, 2020, at 3:24 AM, Pino Toscano wrote: > > On Tuesday, 13 October 2020 07:13:58 CEST Matt Coleman wrote: >> +const char *methodName = NULL, *embeddedParamName = NULL; >> +char enabledValue[] = "2", disabledValue[] = "0";

Re: [PATCH v2 0/7] more Hyper-V APIs

> On Oct 13, 2020, at 1:13 AM, Matt Coleman wrote: > > This set of patches adds several new APIs and fixes several others. > > Changes since v1: > * 'enabledValue' and 'disabledValue' are now static strings in > hypervDomainSetAutostart() > * a long virReportErr

[PATCH] mailmap: consolidate my email addresses

Signed-off-by: Matt Coleman --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap index 2b080568bc..9dfb7a832b 100644 --- a/.mailmap +++ b/.mailmap @@ -47,6 +47,7 @@ + # Name consolidation: # Preferred author spelling -- 2.27.0

[PATCH v2 02/10] hyperv: fix nodeGetInfo failures caused by long CPU names

Some CPU model names were too long for _virNodeInfo.model. For example: Intel Xeon CPU E5-2620 v2 @ 2.10GHz This commit removes the clock frequency suffix. Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 4 1 file changed, 4 insertions(+) diff --git a/src/hyperv

[PATCH v2 00/10] hyperv: implement new APIs & more

to a separate commit * hypervConnectGetVersion() uses a new hypervParseVersionString() and directly produces the unsigned long instead of calling virParseVersionString() Matt Coleman (10): hyperv: make Msvm_ComputerSystem WQL queries locale agnostic hyperv: fix nodeGetInfo failures caused by lon

[PATCH v2 04/10] hyperv: replace generic WMI class list helpers with a macro

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 39 -- src/hyperv/hyperv_wmi.c| 83 -- src/hyperv/hyperv_wmi.h| 28 ++--- 3 files changed, 36 insertions(+), 114 deletions(-) diff --git a/src/hyperv/hyperv_driver.c

[PATCH v2 06/10] hyperv: implement connectGetMaxVcpus

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 93e08c54c0..bbe892fd62 100644 --- a/src/hyperv

[PATCH v2 03/10] hyperv: break out common lookups into separate functions

This eliminates some duplicate code and simplifies the driver functions. Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 489 - 1 file changed, 259 insertions(+), 230 deletions(-) diff --git a/src/hyperv

[PATCH v2 05/10] hyperv: implement connectGetCapabilities

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 90 + src/hyperv/hyperv_private.h | 2 + 2 files changed, 92 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 3e4563252e

[PATCH v2 01/10] hyperv: make Msvm_ComputerSystem WQL queries locale agnostic

ng the locale to 'en-US'. Therefore, this patch changes the WQL query to make use of the "__SERVER" field to stop relying on English strings in queries and side step the issue. Co-authored-by: Dawid Zamirski Signed-off-by: Matt Coleman --- src/hyperv/hyperv_wmi_classes.h | 4 ++-- 1 fi

[PATCH v2 07/10] hyperv: fix Win32_OperatingSystem WMI queries

CurrentTimeZone's type is a signed integer, not unsigned. Signed-off-by: Matt Coleman --- src/hyperv/hyperv_wmi_generator.input | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hyperv/hyperv_wmi_generator.input b/src/hyperv/hyperv_wmi_generator.input index 77543cf6ef

[PATCH v2 10/10] news: document new Hyper-V features and bug fixes

Signed-off-by: Matt Coleman --- NEWS.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index b2ed661c8e..e708f06e9e 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -19,10 +19,20 @@ v6.9.0 (unreleased) local file-backed disks to configure a disk which discards

[PATCH v2 09/10] hyperv: implement domainGetAutostart

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 40 ++ 1 file changed, 40 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 528c826e16..dcde469442 100644 --- a/src/hyperv

[PATCH v2 08/10] hyperv: implement connectGetVersion

minor value is derived from the digits in the thousands, ten-thousands, and hundred-thousands places of Hyper-V's micro. The repacked micro is derived from the digits in the ones, tens, and hundreds places of Hyper-V's micro. Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- docs

Re: [PATCH v2 01/10] hyperv: make Msvm_ComputerSystem WQL queries locale agnostic

> On Oct 5, 2020, at 8:54 PM, Neal Gompa wrote: > > Should we require a bump to openwsman 2.6 for this? That won’t make any difference: openwsman 2.6+ supports specifying the locale, but Windows ignores it. So, this patch changes the queries to not use localized strings. -- Matt

[PATCH v2 6/7] hyperv: fix domainManagedSave on Hyper-V V2

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 8 ++-- src/hyperv/hyperv_wmi_classes.h | 1 + 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index aeee5b2b9f..fb46f42631 100644 --- a/src/hyperv

[PATCH v2 7/7] news: more Hyper-V APIs

Signed-off-by: Matt Coleman --- NEWS.rst | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/NEWS.rst b/NEWS.rst index bc35458f38..d0454b7840 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -22,8 +22,11 @@ v6.9.0 (unreleased) * hyperv: implement new APIs

[PATCH v2 4/7] hyperv: implement domainShutdown and domainShutdownFlags

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c| 77 ++ src/hyperv/hyperv_wmi_generator.input | 78 +++ 2 files changed, 155 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv

[PATCH v2 1/7] hyperv: implement domainSetAutostart

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 91 ++ 1 file changed, 91 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 2ac30fa4c6..79b48a9dff 100644 --- a/src/hyperv

[PATCH v2 2/7] hyperv: implement nodeGetFreeMemory

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 28 1 file changed, 28 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 79b48a9dff..c4fca4685e 100644 --- a/src/hyperv/hyperv_driver.c

[PATCH v2 0/7] more Hyper-V APIs

This set of patches adds several new APIs and fixes several others. Changes since v1: * 'enabledValue' and 'disabledValue' are now static strings in hypervDomainSetAutostart() * a long virReportError() call has been split into two lines Matt Coleman (7): hyperv: implement domainSetAutostart

[PATCH v2 3/7] hyperv: implement domainReboot and domainReset

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 48 + src/hyperv/hyperv_wmi_classes.h | 1 + 2 files changed, 49 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index c4fca4685e

[PATCH v2 5/7] hyperv: fix domainSuspend and domainResume on Hyper-V V2

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 15 +++ src/hyperv/hyperv_wmi_classes.h | 1 + 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 024ba7c6f4..aeee5b2b9f 100644 --- a/src

Re: [PATCH 0/5] hyperv: Make ownershipt transfer obvious

> src/hyperv/hyperv_wmi.h| 12 ++-- > 3 files changed, 94 insertions(+), 81 deletions(-) This whole patchset looks good. Reviewed-by: Matt Coleman -- Matt

Re: [PATCH v2 6/7] hyperv: fix domainManagedSave on Hyper-V V2

> On Oct 13, 2020, at 1:14 AM, Matt Coleman wrote: > > +if (priv->wmiVersion == HYPERV_WMI_VERSION_V2) > +requestedState = > MSVM_COMPUTERSYSTEM_REQUESTEDSTATE_ENABLED_BUT_OFFLINE; ... > +MSVM_COMPUTERSYSTEM_REQUESTEDSTATE_ENABLED_BUT_OFFLINE = 6, I realiz

Re: [PATCH v2 2/7] hyperv: implement nodeGetFreeMemory

> On Oct 15, 2020, at 8:56 AM, Michal Privoznik wrote: > > On 10/13/20 7:13 AM, Matt Coleman wrote: >> +if (hypervGetWmiClass(Win32_OperatingSystem, ) < 0 || >> +!operatingSystem) { >> +virReportError(VIR_ERR_INTERNAL_ERROR, >> +

Re: [PATCH v2 1/7] hyperv: implement domainSetAutostart

> On Oct 15, 2020, at 8:57 AM, Michal Privoznik wrote: > > On 10/13/20 7:13 AM, Matt Coleman wrote: >> +char enabledValue[] = "2", disabledValue[] = "0"; >> + >> +if (priv->wmiVersion == HYPERV_WMI_VERSION_V

Re: [PATCH v2 01/10] hyperv: make Msvm_ComputerSystem WQL queries locale agnostic

> On Oct 6, 2020, at 4:21 AM, Daniel P. Berrangé wrote: > > On Mon, Oct 05, 2020 at 09:13:29PM -0400, Matt Coleman wrote: >>> On Oct 5, 2020, at 8:54 PM, Neal Gompa wrote: >>> >>> Should we require a bump to openwsman 2.6 for this? >> >> That wo

Re: [PATCH 1/7] hyperv: implement domainSetAutostart

> On Oct 9, 2020, at 4:58 AM, Pino Toscano wrote: > > On Friday, 9 October 2020 10:31:50 CEST Matt Coleman wrote: >> +static int >> +hypervDomainSetAutostart(virDomainPtr domain, int autostart) >> +{ >> +int result = -1; >> +char uuid_string[VIR_UUI

Re: [PATCH 0/4] hyperv: Cleanup code create embedded properties

> On Oct 19, 2020, at 7:35 AM, Michal Privoznik wrote: > > *** BLURB HERE *** > > Michal Prívozník (4): > hyperv: Accept const @value in hypervSetEmbeddedProperty() > hyperv: Use g_auto() for virHashTable in hypervCreateEmbeddedParam > hyperv: Drop needles error label in

Re: recommendations for handling Hyper-V version number

>> For example, the Windows Server 2016 Hyper-V version is 10.0.14393.0, >> so its “micro” is over 14 times larger than the encoding allows. >> >> My current workaround is to truncate it to something that works (E.G. >> 10.0.143), but that's clearly less than ideal. > The problem here is the

Re: [PATCH] libvirt: ensure defresult is used in virConnectAuthCallbackDefault

Some additional info (feel free to add it to the commit message): Starting in version 6.1.0, virsh does not use the default username while connecting: $ ./run tools/virsh -c hyperv://example-hyperv-server?transport=http capabilities Enter username for example-hyperv-server [administrator]:

[PATCH] libvirt: ensure defresult is used in virConnectAuthCallbackDefault

A previous change to this function's password handling broke the use of default values for credential types other than VIR_CRED_PASSPHRASE and VIR_CRED_NOECHOPROMPT. Signed-off-by: Matt Coleman --- src/libvirt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src

handling Hyper-V automatic startup values

Hello, I’m implementing some new functionality in the Hyper-V driver and could use some input on how I should handle automatic startup values. Microsoft’s Msvm_VirtualSystemSettingData class stores this setting in a property named AutomaticStartupAction:

recommendations for handling Hyper-V version number

Hello again, Hyper-V version numbers are not compatible with the encoding used in virParseVersionString: https://gitlab.com/libvirt/libvirt/-/blob/master/src/util/virutil.c#L246 For example, the Windows Server 2016 Hyper-V version is 10.0.14393.0, so its “micro” is over 14 times larger than

Re: recommendations for handling Hyper-V version number

> On Sep 25, 2020, at 4:42 AM, Daniel P. Berrangé > wrote: > > IOW we could stuff both the hyper-v major + minor version digits > into the libvirt major digits. Then we can split the hyperv micro > digits across the libvirt minor + micro. > > ie pack it using > >

Re: handling Hyper-V automatic startup values

> The Go code represents it as a boolean for example. > > I think our only option is to define a new API > > virDomainSetAutostartPolicy() > > and make it take an int parameter for which we can define an enum. > > The existing API will just have to map new values onto true/false > as

Re: [PATCH 4/8] hyperv: replace generic WMI class list helpers with a macro

On Oct 2, 2020, at 2:26 AM, Pino Toscano wrote: > This change seems unrelated to the patch. Can you please split it in an > own commit? I originally had the macro in this header and had moved the function next to the other closely-related functions. Since I moved the macro to hyperv_driver.c,

Re: [PATCH 0/8] hyperv: implement new APIs & more

On Oct 2, 2020, at 2:07 AM, Pino Toscano wrote: > > One general note for all the patches: NEWS.rst is updated as a whole > at the end, as separate commit. This eases cherry-picking, removes > dependencies between patches that would not conflict otherwise, and > avoids churn in each patch.

Re: [PATCH 3/8] hyperv: break out common lookups into separate functions

On Oct 2, 2020, at 2:25 AM, Pino Toscano wrote: > Note that now hypervGetVirtualSystemByID() issues VIR_ERR_INTERNAL_ERROR > in case / *computerSystemList is null, instead of > VIR_ERR_NO_DOMAIN. Shouldn't this still be able to explicitly report > when the requested domain does not exist? I’ll

Re: [PATCH 7/8] hyperv: implement connectGetVersion

On Oct 2, 2020, at 2:48 AM, Pino Toscano wrote: > IMHO these explanations should be documented in the Hyper-V driver > page: docs/drvhyperv.html.in. This way, users know about the different > value returned by virConnectGetVersion() by the Hyper-V driver, and > can unmangle it to get the real

Re: [PATCH 0/8] hyperv: implement new APIs & more

> Are you sure your email configuration is set properly? It seems like > there's a mismatch on your email addresses. I generally expect your > authorship to be set to "Matt Coleman ", but it > seems like your latest email patch set is confused and sending emails &g

Hyper-V CPU details

Hello, I'm implementing domainGetVcpus and could use some guidance on what value to use for virVcpuInfo->cpu. Hyper-V does not allow the user to pin vCPUs to host CPUs and doesn't allow the user to see which host CPU a vCPU is currently running on. Since it's a type 1 hypervisor, none of its

Re: Entering freeze for libvirt-6.9.0

> On Oct 26, 2020, at 2:02 PM, Jiri Denemark wrote: > > I have just tagged v6.9.0-rc1 in the repository and pushed signed > tarballs and source RPMs to https://libvirt.org/sources/ > > Please give the release candidate some testing and in case you find a > serious issue which should have a fix

Re: [PATCH 0/4] hyperv: Deduplicate and reformat

> On Oct 21, 2020, at 11:44 AM, Michal Privoznik wrote: > > The more I look into the code the more things to fix I find. Well, here > are some fixes. Thanks! This whole patchset looks good. -- Matt

Re: [PATCH 0/2] hyperv: storage volume XML changes

> On Nov 23, 2020, at 10:13 AM, Daniel P. Berrangé wrote: > > Side-point > > > Looking at these patches makes me quite aware of the lack of unit > test coverage. The native <-> XML conversions are one of the places > we find most benefit from unit testing, as it catches many regrssions >

Re: [PATCH 00/11] hyperv: implement defining/undefining domains and

`git send-email` did something wonky with the subject and cut off "attaching storage devices" -- Matt

[PATCH 04/11] hyperv: add hypervMsvmVSMSAddResourceSettings

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_wmi.c | 52 + src/hyperv/hyperv_wmi.h | 5 2 files changed, 57 insertions(+) diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c index 466296fe2a..4bace10874 100644 --- a/src/hyperv

[PATCH 09/11] hyperv: attach floppy disks when defining domains

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 54 ++ 1 file changed, 54 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 914f0c743f..14371eda39 100644 --- a/src/hyperv

[PATCH 01/11] hyperv: ambiguous VM names will throw an error

Since Hyper-V allows multiple VMs to be created with the same name, some commands produce unpredictable results due to hypervDomainLookupByName's WMI query selecting the wrong domain. For example, this prevents `virsh dumpxml` from outputting XML for the wrong domain. Signed-off-by: Matt Coleman

[PATCH 11/11] news: defining/undefining domains & device attachment for Hyper-V

Signed-off-by: Matt Coleman --- NEWS.rst | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/NEWS.rst b/NEWS.rst index aa8a217eb6..f5b6dfe6a3 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -37,8 +37,11 @@ v6.10.0 (unreleased) ``virDomainGetSchedulerType

[PATCH 10/11] hyperv: implement domainAttachDevice and domainAttachDeviceFlags

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 118 + 1 file changed, 118 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 14371eda39..43d84340ec 100644 --- a/src/hyperv

[PATCH 00/11] hyperv: implement defining/undefining domains and

/iammattcoleman/libvirt/-/merge_requests/14 Matt Coleman (11): hyperv: ambiguous VM names will throw an error hyperv: implement domainUndefine and domainUndefineFlags hyperv: implement domainCreateXML and domainDefineXML hyperv: add hypervMsvmVSMSAddResourceSettings hyperv: create SCSI

[PATCH 06/11] hyperv: attach virtual disks when defining domains

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 244 +++- src/hyperv/hyperv_wmi_classes.h | 1 + 2 files changed, 242 insertions(+), 3 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c

[PATCH 08/11] hyperv: attach virtual optical disks when defining domains

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 128 + 1 file changed, 128 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 3d4aa8ab8e..914f0c743f 100644 --- a/src/hyperv

[PATCH 02/11] hyperv: implement domainUndefine and domainUndefineFlags

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 60 ++ 1 file changed, 60 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 6d81deb4d9..8e16ff529f 100644 --- a/src/hyperv

[PATCH 03/11] hyperv: implement domainCreateXML and domainDefineXML

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 114 + 1 file changed, 114 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 8e16ff529f..559b60d3df 100644 --- a/src/hyperv

[PATCH 07/11] hyperv: attach physical disks when defining domains

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 111 + 1 file changed, 111 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index a3da2ec524..3d4aa8ab8e 100644 --- a/src/hyperv

[PATCH 05/11] hyperv: create SCSI controllers when defining domains

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 51 ++ 1 file changed, 51 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 559b60d3df..1ad52e598a 100644 --- a/src/hyperv

[PATCH v3 1/2] hyperv: XML parsing of storage volumes

dumpxml can now serialize: * floppy drives * file-backed and device-backed disk drives * images mounted to virtual CD/DVD drives * IDE and SCSI controllers Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c| 425 +- src

[PATCH v3 0/2] hyperv: storage volume XML changes

between v2 and v3: https://gitlab.com/iammattcoleman/libvirt/-/merge_requests/12/diffs?diff_id=126400840_sha=6c5a3dfc2bf2f13c0d9765f00b53b15043693517 Matt Coleman (2): hyperv: XML parsing of storage volumes schema: add support for Windows file paths and device names docs/schemas/basictypes.rng

[PATCH v3 2/2] schema: add support for Windows file paths and device names

Signed-off-by: Matt Coleman --- docs/schemas/basictypes.rng | 2 +- docs/schemas/domaincommon.rng | 5 +++- .../disk-hyperv-physical.xml | 17 ++ .../disk-hyperv-virtual.xml | 17 ++ .../disk-hyperv

Re: [PATCH 1/7] hyperv: remove V1 classes from the WMI generator input

> On Nov 9, 2020, at 9:55 AM, Daniel P. Berrangé wrote: > > That doesn't seem to be the case. If I modify this patch so that it > only removes the Msvm_ classes for v1, everything still compiles. Sorry, I'm juggling several branches and have many commits ahead of this. I thought I had

Re: [PATCH 00/28] a bunch of domain_conf cleanup

> On Nov 9, 2020, at 9:43 AM, Michal Privoznik wrote: > > Nice cleanup. But as I say in 03/28 I think we might want glib adoption to be > done in bigger chunks. Usually we rewrite VIR_ALLOC/VIR_REALLOC_N -> > g_new0()/g_renew() in one patch (might be coupled with g_free() except > VIR_FREE()

[PATCH 6/7] hyperv: implement domainGetScheduler*

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 83 ++ 1 file changed, 83 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index e05c10d194..9fda0d6047 100644 --- a/src/hyperv

[PATCH 7/7] news: some memory and scheduler Hyper-V APIs

Signed-off-by: Matt Coleman --- NEWS.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 0e56f5dbca..8b60a5da11 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -13,6 +13,13 @@ v6.10.0 (unreleased) * **New features** + * hyperv: implement new APIs

[PATCH 5/7] hyperv: refactor hypervDomainSetMemoryProperty

* use hypervMsvmVSMSModifyResourceSettings() * improve the error message: say which property it failed to set * remove usage of VIR_FREE() Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 26 +- 1 file changed, 5 insertions(+), 21 deletions(-) diff --git

[PATCH 4/7] hyperv: add hypervMsvmVSMSModifyResourceSettings

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_wmi.c | 37 + src/hyperv/hyperv_wmi.h | 8 2 files changed, 45 insertions(+) diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c index 72a68c0591..866b347bc2 100644 --- a/src/hyperv

[PATCH 2/7] hyperv: move hypervDomainSetMemory and hypervDomainSetMemoryFlags

This matches their placement in struct _virHypervisorDriver. Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 144 ++--- 1 file changed, 72 insertions(+), 72 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index

[PATCH 3/7] hyperv: implement domainSetMaxMemory

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 24 +++- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index e779b67d00..6d7bc4b80f 100644 --- a/src/hyperv

[PATCH 1/7] hyperv: implement domainGetMaxMemory

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 28 1 file changed, 28 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index b789ef58e8..67b8b771d9 100644 --- a/src/hyperv/hyperv_driver.c

[PATCH 0/7] hyperv: some memory and scheduler APIs

Here's a GitLab merge request, if you'd prefer to review it there: https://gitlab.com/iammattcoleman/libvirt/-/merge_requests/9 Matt Coleman (7): hyperv: implement domainGetMaxMemory hyperv: move hypervDomainSetMemory and hypervDomainSetMemoryFlags hyperv: implement domainSetMaxMemory

Re: [PATCH 1/6] domain: introduce constants for virVcpuInfo->cpu state values

> On Nov 12, 2020, at 8:46 AM, Michal Privoznik wrote: > > On 11/12/20 12:51 PM, Matt Coleman wrote: >> +/** >> + * VIR_VCPU_INFO_CPU_OFFLINE: >> + * >> + * The VCPU is offline. >> + */ >> +# define VIR_VCPU_INFO_CPU_OFFLINE -1 >

Re: [PATCH 4/6] hyperv: implement domainGetMaxVcpus

> On Nov 12, 2020, at 8:46 AM, Michal Privoznik wrote: > > On 11/12/20 12:51 PM, Matt Coleman wrote: >> Co-authored-by: Sri Ramanujam >> Signed-off-by: Matt Coleman >> --- >> src/hyperv/hyperv_driver.c | 16 >> 1 file changed, 16 i

[PATCH v2 6/6] news: implement vCPU APIs in the Hyper-V driver

Signed-off-by: Matt Coleman --- NEWS.rst | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/NEWS.rst b/NEWS.rst index 8b60a5da11..3fd3ce4cb9 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -16,9 +16,11 @@ v6.10.0 (unreleased) * hyperv: implement new APIs

Re: [PATCH 4/6] hyperv: implement domainGetMaxVcpus

> On Nov 12, 2020, at 11:34 AM, Michal Privoznik wrote: > > Well, I think I can live with this one since there is an (esthetic) reason to > it. Since I wrote that email, I've looked at other drivers in the codebase and decided it's not worth it. I've eliminated the forward declaration (as

[PATCH v2 0/6] hyperv: implement vCPU APIs

Changes since v1: * use an enum for the real CPU constants * remove the forward declaration Here's a GitLab merge request, if you'd prefer to review it there: https://gitlab.com/iammattcoleman/libvirt/-/merge_requests/11 Matt Coleman (6): domain: introduce constants for virVcpuInfo->cpu st

[PATCH v2 3/6] hyperv: implement domainGetVcpusFlags

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 52 ++ 1 file changed, 52 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 56d6da80e0..3c436d9465 100644 --- a/src/hyperv

[PATCH v2 5/6] hyperv: implement domainSetVcpus and domainSetVcpusFlags

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 56 ++ 1 file changed, 56 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 44ef4c53e0..40739595ac 100644 --- a/src/hyperv

  1   2   3   4   >