Re: [libvirt] [PATCH 0/5] vz: Reformat

2015-06-25 Thread Maxim Nestratov
work. Maxim Nestratov -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/5] vz: Reformat

2015-06-25 Thread Maxim Nestratov
25.06.2015 12:19, Maxim Nestratov пишет: 25.06.2015 11:18, Michal Privoznik пишет: There shouldn't be any functional change. Only some formatting nits fixed. Michal Privoznik (5): vz_driver: Reformat vz_network: Reformat vz_sdk: Reformat vz_storage: Reformat vz_utils: Ref

Re: [libvirt] [PATCH 0/5] vz: Reformat

2015-06-25 Thread Maxim Nestratov
25.06.2015 16:21, Michal Privoznik пишет: On 25.06.2015 11:46, Maxim Nestratov wrote: 25.06.2015 12:19, Maxim Nestratov пишет: 25.06.2015 11:18, Michal Privoznik пишет: There shouldn't be any functional change. Only some formatting nits fixed. Michal Privoznik (5): vz_driver: Ref

Re: [libvirt] [PATCH] vz: fix building capabilities

2015-07-03 Thread Maxim Nestratov
03.07.2015 19:00, Dmitry Guryanov пишет: There should be at least one domain for each guest in cababilities. And in current code we don't add domain for this guest for example. if ((guest = virCapabilitiesAddGuest(caps, VIR_DOMAIN_OSTYPE_HVM, VIR_AR

Re: [libvirt] [PATCH v2] vz: fix building capabilities

2015-07-06 Thread Maxim Nestratov
03.07.2015 20:26, Dmitry Guryanov пишет: There should be at least one domain for each guest in cababilities. And in current code we don't add domain for this guest for example. if ((guest = virCapabilitiesAddGuest(caps, VIR_DOMAIN_OSTYPE_HVM, VIR_AR

[libvirt] [PATCH] vz: use PRL_USE_VNET_NAME_FOR_BRIDGE_NAME

2015-07-06 Thread Maxim Nestratov
It is better not to assume that newly created network should be connected to a bridge with same name, but specify it explicitly by PRL_USE_VNET_NAME_FOR_BRIDGE_NAME flag. Signed-off-by: Maxim Nestratov --- src/vz/vz_sdk.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git

Re: [libvirt] [PATCH] vz: fix cleanup of nets of bridged type

2015-07-09 Thread Maxim Nestratov
09.07.2015 19:20, Dmitry Guryanov пишет: We create a virtual network of special type, which has the same name as bridge name to create bridged network adapter in vz. So when we delete such an adapter we have to remove corresponding virtual network. So let's rename prlsdkDelNet to prlsdkCleanupBr

Re: [libvirt] [PATCH v5 0/5] vz: add migration support

2015-09-04 Thread Maxim Nestratov
04.09.2015 17:18, Nikolay Shirokovskiy пишет: NOTE that minimal command to migrate vz domain is like next: virsh -c vz:///system migrate 200 vz+ssh://shiny0/system --p2p --live --compressed --persistent --undefinesource Difference from v4: 1. move preparation of the migration uri from src t

Re: [libvirt] [PATCH v5 0/5] vz: add migration support

2015-09-04 Thread Maxim Nestratov
04.09.2015 17:48, Maxim Nestratov пишет: 04.09.2015 17:18, Nikolay Shirokovskiy пишет: NOTE that minimal command to migrate vz domain is like next: virsh -c vz:///system migrate 200 vz+ssh://shiny0/system --p2p --live --compressed --persistent --undefinesource Difference from v4: 1. move

[libvirt] [PATCH] vz: set mount point for container image-based disks

2015-09-20 Thread Maxim Nestratov
From: Maxim Nestratov In order to support not only root disks with type=file for containers, we need to specify mount points for them. For instance, if a secondary disk is added by the following record in xml: we are going to add it to container mounted to '

Re: [libvirt] [PATCH] vz: set mount point for container image-based disks

2015-09-21 Thread Maxim Nestratov
21.09.2015 11:44, Daniel P. Berrange пишет: On Sun, Sep 20, 2015 at 10:17:51PM +0300, Maxim Nestratov wrote: From: Maxim Nestratov In order to support not only root disks with type=file for containers, we need to specify mount points for them. For instance, if a secondary disk is added by the

Re: [libvirt] [PATCH] vz: set mount point for container image-based disks

2015-09-21 Thread Maxim Nestratov
21.09.2015 12:23, Daniel P. Berrange пишет: On Mon, Sep 21, 2015 at 12:14:57PM +0300, Maxim Nestratov wrote: 21.09.2015 11:44, Daniel P. Berrange пишет: On Sun, Sep 20, 2015 at 10:17:51PM +0300, Maxim Nestratov wrote: From: Maxim Nestratov In order to support not only root disks with type

[libvirt] [PATCH] vz: remove error logging from prlsdkUUIDParse

2015-09-21 Thread Maxim Nestratov
From: Maxim Nestratov As far as not every call of prlsdkUUIDParse assume correct UUID supplied, there is no use to complain about wrong format in it. Otherwise our log is flooded with false error messages. For instance, calling prlsdkUUIDParse from prlsdkEventsHandler works as a filter and in

Re: [libvirt] [PATCH] vz: remove error logging from prlsdkUUIDParse

2015-09-21 Thread Maxim Nestratov
21.09.2015 14:59, Dmitry Guryanov пишет: On 09/21/2015 02:08 PM, Maxim Nestratov wrote: From: Maxim Nestratov As far as not every call of prlsdkUUIDParse assume correct UUID supplied, there is no use to complain about wrong format in it. Otherwise our log is flooded with false error messages

Re: [libvirt] [PATCH] vz: remove error logging from prlsdkUUIDParse

2015-09-21 Thread Maxim Nestratov
21.09.2015 14:56, Michal Privoznik пишет: On 21.09.2015 13:08, Maxim Nestratov wrote: From: Maxim Nestratov As far as not every call of prlsdkUUIDParse assume correct UUID supplied, there is no use to complain about wrong format in it. Otherwise our log is flooded with false error messages

[libvirt] [PATCH 0/2] vz: remove unused network and storage drivers

2015-09-22 Thread Maxim Nestratov
From: Maxim Nestratov Maxim Nestratov (2): vz: remove network driver as never used vz: remove storage driver as never used -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 2/2] vz: remove storage driver as never used

2015-09-22 Thread Maxim Nestratov
From: Maxim Nestratov In fact, it was never used as far as vz has no features supporting it. That is why there will be no harm to anyone if we just remove this code to prevent further misunderstanding and efforts to support dead code. Signed-off-by: Maxim Nestratov --- src/Makefile.am

[libvirt] [PATCH 1/2] vz: remove network driver as never used

2015-09-22 Thread Maxim Nestratov
From: Maxim Nestratov At the time this code was added we had intentions to support libvirt interface to manage vz networks. In fact, it was never implemented completely to work correctly that makes me think that there will be no harm to anyone if we just rip it off. Moreover, in vz7 we started

[libvirt] [PATCH] vz: cleanup

2015-10-07 Thread Maxim Nestratov
From: Maxim Nestratov Remove unused definitions, functions and structure fields. Signed-off-by: Maxim Nestratov --- src/vz/vz_driver.c |1 - src/vz/vz_utils.c | 67 src/vz/vz_utils.h | 20 --- 3 files changed, 0

[libvirt] [PATCH 1/3] vz: implement connectGetType and connectGetMaxVcpus API calls

2015-10-14 Thread Maxim Nestratov
From: Maxim Nestratov As a connection type we report 'vz'. And because we have no limitation for maximal number of vcpus in containers we report as maximum 1028 just for the sake of common sence. Signed-off-by: Maxim Nestratov --- src/vz/vz_driver.c | 19 +++ 1 fil

[libvirt] [PATCH 2/3] vz: implement API calls of nodeGetxxx family

2015-10-14 Thread Maxim Nestratov
From: Maxim Nestratov The following functions were implemented: vzNodeGetCPUStats, vzNodeGetMemoryStats, vzNodeGetCellsFreeMemory and vzNodeGetFreeMemory. Signed-off-by: Maxim Nestratov --- src/vz/vz_driver.c | 42 ++ 1 files changed, 42 insertions

[libvirt] [PATCH 3/3] vz: implement some domain API calls

2015-10-14 Thread Maxim Nestratov
From: Maxim Nestratov The following functions are implemented: vzDomainIsUpdated, vzDomainGetVcpusFlags and vzDomainGetMaxVcpus. Signed-off-by: Maxim Nestratov --- src/vz/vz_driver.c | 53 1 files changed, 53 insertions(+), 0 deletions

Re: [libvirt] [PATCH 1/3] vz: implement connectGetType and connectGetMaxVcpus API calls

2015-10-19 Thread Maxim Nestratov
14.10.2015 18:28, Dmitry Guryanov пишет: On 10/14/2015 12:50 PM, Maxim Nestratov wrote: From: Maxim Nestratov As a connection type we report 'vz'. And because we have no limitation for maximal number of vcpus in containers we report as maximum 1028 just for the sake of co

[libvirt] [PATCH 2/3] vz: implement API calls of nodeGetxxx family

2015-10-19 Thread Maxim Nestratov
The following functions were implemented: vzNodeGetCPUStats, vzNodeGetMemoryStats, vzNodeGetCellsFreeMemory and vzNodeGetFreeMemory. Signed-off-by: Maxim Nestratov --- src/vz/vz_driver.c | 42 ++ 1 file changed, 42 insertions(+) diff --git a/src/vz

[libvirt] [PATCH v2 0/3] vz: implement some API calls

2015-10-19 Thread Maxim Nestratov
v1-v2 change: - removed vzConnectGetType - addressed comments on vzConnectGetMaxVcpus Maxim Nestratov (3): vz: implement connectGetMaxVcpus API calls vz: implement API calls of nodeGetxxx family vz: implement some domain API calls src/vz/vz_driver.c | 109

[libvirt] [PATCH 1/3] vz: implement connectGetMaxVcpus API calls

2015-10-19 Thread Maxim Nestratov
Because we have no limitation for maximal number of vcpus in containers we report as maximum 1028 just for the sake of common sence. Signed-off-by: Maxim Nestratov --- src/vz/vz_driver.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c

[libvirt] [PATCH 3/3] vz: implement some domain API calls

2015-10-19 Thread Maxim Nestratov
The following functions are implemented: vzDomainIsUpdated, vzDomainGetVcpusFlags and vzDomainGetMaxVcpus. Signed-off-by: Maxim Nestratov --- src/vz/vz_driver.c | 53 + 1 file changed, 53 insertions(+) diff --git a/src/vz/vz_driver.c b/src

Re: [libvirt] [PATCH] vz: add func to set shared drivers after libvirtd init

2015-10-23 Thread Maxim Nestratov
22.10.2015 11:13, Mikhail Feoktistov пишет: Built-in drivers in libvirt are initialized before libvirtd initialization. Libvirt loads shared drivers on libvirtd initialization step. For built-in drivers we can't set shared drivers, because they are not initialized yet. This patch adds function t

Re: [libvirt] [PATCH] vz: support cpu time in driver's domainGetInfo

2015-10-29 Thread Maxim Nestratov
28.10.2015 17:29, Nikolay Shirokovskiy пишет: Just straight-forward patch. Use reference counting for privdom as stats internally could drop domain lock. Signed-off-by: Nikolay Shirokovskiy --- src/vz/vz_driver.c | 19 --- 1 files changed, 16 insertions(+), 3 deletions(-)

Re: [libvirt] [PATCH] vz: implement memory setting functions in driver

2015-11-06 Thread Maxim Nestratov
05.11.2015 13:13, Nikolay Shirokovskiy пишет: Implement functions for vz containers only. vz VMs memory managment thru libvirt yet to be designed. [snip] static virHypervisorDriver vzDriver = { .name = "vz", .connectOpen = vzConnectOpen,/* 0.10.0 */ @@ -1499,6 +1577,

[libvirt] libvirt-snmp development

2015-11-10 Thread Maxim Nestratov
Hi all, There were no active develoment in libvirt-snmp subproject for a while. Taking this into account I want to ask the following. If we are, here in Virtuozzo, interested in extending this subproject, will there be support from project maintainers in doing this or not? Maxim Nestratov

Re: [libvirt] libvirt-snmp development

2015-11-10 Thread Maxim Nestratov
10.11.2015 12:23, Daniel P. Berrange пишет: On Tue, Nov 10, 2015 at 12:18:14PM +0300, Maxim Nestratov wrote: Hi all, There were no active develoment in libvirt-snmp subproject for a while. Taking this into account I want to ask the following. If we are, here in Virtuozzo, interested in

Re: [libvirt] libvirt-snmp development

2015-11-10 Thread Maxim Nestratov
10.11.2015 13:36, Martin Kletzander пишет: On Tue, Nov 10, 2015 at 12:40:36PM +0300, Maxim Nestratov wrote: 10.11.2015 12:23, Daniel P. Berrange пишет: On Tue, Nov 10, 2015 at 12:18:14PM +0300, Maxim Nestratov wrote: Hi all, There were no active develoment in libvirt-snmp subproject for a

Re: [libvirt] Issue with Parallel/VZ driver on Parallel Cloud Server 6.0

2015-11-10 Thread Maxim Nestratov
need an open version, which comes with the next VZ 7.0. You can get sources from here: https://src.openvz.org/scm/ovz/libprlsdk.git https://github.com/OpenVZ/libprlsdk Then build it yourself. If have any questions, please feel free to contact me directly. Best, Maxim Nestratov -- libvi

Re: [libvirt] [PATCH] vz: implementation of domainReboot callback

2015-11-19 Thread Maxim Nestratov
18.11.2015 18:38, Mikhail Feoktistov пишет: --- src/vz/vz_driver.c | 8 src/vz/vz_sdk.c| 8 src/vz/vz_sdk.h| 1 + 3 files changed, 17 insertions(+) diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index 0a968b9..5f56eaf 100644 --- a/src/vz/vz_driver.c +++ b/sr

Re: [libvirt] [PATCH v2] vz: implementation of domainReboot callback

2015-11-19 Thread Maxim Nestratov
19.11.2015 15:16, Mikhail Feoktistov пишет: Diff from v1. 1. Add virCheckFlags() call in vzDomainReboot This way even better. ACK --- src/vz/vz_driver.c | 8 src/vz/vz_sdk.c| 8 src/vz/vz_sdk.h| 1 + 3 files changed, 17 insertions(+) diff --git a/src/vz/vz_driv

Re: [libvirt] libprl_sdk.so.7 library dependancies

2015-11-26 Thread Maxim Nestratov
26.11.2015 18:19, Daniel P. Berrange пишет: In debugging some recent problem I was rather surprised to find that libvirt.so was linked against Qt, X11 and GObject. It turns out that this is due to the VZ driver linking to libprl_sdk.so which pulls in all these libs: $ ldd /usr/lib64/libprl_sd

Re: [libvirt] libprl_sdk.so.7 library dependancies

2015-11-27 Thread Maxim Nestratov
26.11.2015 20:08, Maxim Nestratov пишет: 26.11.2015 18:19, Daniel P. Berrange пишет: In debugging some recent problem I was rather surprised to find that libvirt.so was linked against Qt, X11 and GObject. It turns out that this is due to the VZ driver linking to libprl_sdk.so which pulls in

Re: [libvirt] libprl_sdk.so.7 library dependancies

2015-11-27 Thread Maxim Nestratov
27.11.2015 20:46, Daniel P. Berrange пишет: On Fri, Nov 27, 2015 at 07:48:10PM +0300, Maxim Nestratov wrote: 26.11.2015 20:08, Maxim Nestratov пишет: 26.11.2015 18:19, Daniel P. Berrange пишет: In debugging some recent problem I was rather surprised to find that libvirt.so was linked against

[libvirt] [PATCH 2/3] vz: move prlsdkCleanupBridgedNet after domain deletion

2015-12-22 Thread Maxim Nestratov
prlsdkCleanupBridgedNet call should be made strongly after any actual domain deletion accurs. By doing this we avoid any potential problems connected with second undefine call when it is made after first one fails by some reason, and we detect that network is already deleted. Signed-off-by: Maxim

[libvirt] [PATCH 1/3] vz: delete domains when undefine is called

2015-12-22 Thread Maxim Nestratov
vent images deletion. Signed-off-by: Maxim Nestratov --- src/vz/vz_sdk.c | 45 - 1 file changed, 44 insertions(+), 1 deletion(-) diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index 2b031c9..12c8be9 100644 --- a/src/vz/vz_sdk.c +++ b/src/vz/vz_sdk.c

[libvirt] [PATCH 0/3] vz: domain undefine fixes

2015-12-22 Thread Maxim Nestratov
Maxim Nestratov (3): vz: delete domains when undefine is called vz: move prlsdkCleanupBridgedNet after domain deletion vz: support additional flags in domain undefine src/vz/vz_driver.c | 5 +- src/vz/vz_sdk.c| 138 +++-- src/vz

[libvirt] [PATCH 3/3] vz: support additional flags in domain undefine

2015-12-22 Thread Maxim Nestratov
Implement VIR_DOMAIN_UNDEFINE_MANAGED_SAVE and VIR_DOMAIN_UNDEFINE_SNAPSHOTS_METADATA flags support. Signed-off-by: Maxim Nestratov --- src/vz/vz_driver.c | 5 ++-- src/vz/vz_sdk.c| 88 +- src/vz/vz_sdk.h| 2 +- 3 files changed, 91

[libvirt] [PATCH] vz: BUG: fix connecting hang in case of init failure

2015-12-24 Thread Maxim Nestratov
In case of prlsdkLoadDomains fails, vzOpenDefault should clear connection privateData pointer every time its memory is actually freed. Also it is not necessary to call vzConnectClose if a call to vzOpenDefault fails, because they both make cleanup of connection privateData. Signed-off-by: Maxim

Re: [libvirt] [RFC] memory settings interface for containers

2016-01-14 Thread Maxim Nestratov
14.01.2016 16:01, Daniel P. Berrange пишет: [snip] I agree we should be more explicit about this all in the docs. For initial XML config, we should just raise an error if both and are present and have different values, or possibly just clamp to match . Hmm. And what if a user wants a VM to be

Re: [libvirt] [RFC] memory settings interface for containers

2016-01-14 Thread Maxim Nestratov
14.01.2016 16:16, Daniel P. Berrange пишет: On Thu, Jan 14, 2016 at 04:14:49PM +0300, Maxim Nestratov wrote: 14.01.2016 16:01, Daniel P. Berrange пишет: [snip] I agree we should be more explicit about this all in the docs. For initial XML config, we should just raise an error if both and

[libvirt] [PATCH] qemu: qemuDomainRename and virDomainObjListNumOfDomains ABBA deadlock fix

2016-01-25 Thread Maxim Nestratov
t The patch establishes a single order of taking locks: driver->domains list first, then a particular VM. This is done by implementing a set of virDomainObjListXxxLocked functions working with driver->domains that assume that list lock is already aquired by calling functions. Signed-off-b

Re: [libvirt] [PATCH v5 6/7] Implement qemuSetupGlobalCpuCgroup

2016-01-26 Thread Maxim Nestratov
18.01.2016 13:08, Alexander Burluka пишет: This functions setups per-domain cpu bandwidth parameters Signed-off-by: Alexander Burluka --- src/qemu/qemu_cgroup.c | 54 + src/qemu/qemu_cgroup.h | 1 + src/qemu/qemu_process.c | 4 3 fi

Re: [libvirt] [PATCH] qemu: qemuDomainRename and virDomainObjListNumOfDomains ABBA deadlock fix

2016-01-26 Thread Maxim Nestratov
26.01.2016 12:29, Martin Kletzander пишет: On Mon, Jan 25, 2016 at 12:16:12PM +0300, Maxim Nestratov wrote: A pretty nasty deadlock occurs while trying to rename a VM in parallel with virDomainObjListNumOfDomains. The short description of the problem is as follows: Thread #1: qemuDomainRename

Re: [libvirt] [PATCH] qemu: qemuDomainRename and virDomainObjListNumOfDomains ABBA deadlock fix

2016-01-26 Thread Maxim Nestratov
26.01.2016 16:33, Martin Kletzander пишет: On Tue, Jan 26, 2016 at 02:14:23PM +0100, Jiri Denemark wrote: On Tue, Jan 26, 2016 at 13:26:32 +0100, Michal Privoznik wrote: On 25.01.2016 10:16, Maxim Nestratov wrote: ... [snip] What if, instead of introducing bunch of Locked() functions we

Re: [libvirt] [PATCH 1/4] vz: make output arguments in prlsdkGetDomainIds as optional

2016-01-29 Thread Maxim Nestratov
28.01.2016 18:38, Mikhail Feoktistov пишет: prlsdkGetDomainIds() returns name and uuid for specified instance. Now output arguments can be NULL. It allows to get only necessary info(name or uuid). --- src/vz/vz_sdk.c | 34 +++--- 1 file changed, 19 insertions(+), 15

Re: [libvirt] [PATCH 3/4] vz: fix notification subscription

2016-01-29 Thread Maxim Nestratov
28.01.2016 18:38, Mikhail Feoktistov пишет: Bug cause: Update the domain that is subscribed to hypervisor notification. LoadDomain() rewrites notifications fields in vzDomObj structure and makes domain as "unsubscribed". Fix: Initialize notification fields in vzDomObj only if we create a new dom

Re: [libvirt] [PATCH 4/4] vz: fix race condition when adding domain to domains list

2016-01-29 Thread Maxim Nestratov
28.01.2016 18:38, Mikhail Feoktistov пишет: Race condition: User calls defineXML to create new instance. The main thread from vzDomainDefineXMLFlags() creates new instance by prlsdkCreateVm. Then this thread calls prlsdkAddDomain to add new domain to domains list. The second thread receives not

Re: [libvirt] [PATCH] migration: add option to set target ndb server port

2016-01-29 Thread Maxim Nestratov
13.01.2016 14:01, Nikolay Shirokovskiy пишет: Current libvirt + qemu pair lacks secure migrations in case of VMs with non-shared disks. The only option to migrate securely natively is to use tunneled mode and some kind of secure destination URI. But tunelled mode does not support non-shared disks

Re: [libvirt] [PATCH v3 0/8] add close callback for drivers with persistent connection

2016-01-30 Thread Maxim Nestratov
22.01.2016 11:59, Nikolay Shirokovskiy пишет: Currently close callback API can only inform us of closing the connection between remote driver and daemon. But what if a driver running in the daemon itself can have another persistent connection? In this case we want to be informed of that connectio

Re: [libvirt] [PATCH v2] qemu: return -1 on error paths in qemuDomainSaveImageStartVM

2016-01-30 Thread Maxim Nestratov
29.01.2016 11:49, Nikolay Shirokovskiy пишет: Error paths after sending the event that domain is started written as if ret = -1 which is set at the beginning of the function. It's common idioma to keep 'ret' equal to -1 until the end of function where it is set to 0. But here we use ret to keep

Re: [libvirt] [PATCH v3 1/7] qemu migration: factor out setting migration option

2016-01-30 Thread Maxim Nestratov
28.01.2016 10:04, Nikolay Shirokovskiy пишет: Signed-off-by: Nikolay Shirokovskiy I'd be happy if you added a bit info into the commit message what functions you are removing and to what function you are combining them. Otherwise ACK. --- src/qemu/qemu_migration.c | 138 ++---

Re: [libvirt] [PATCH v3 2/7] migration: add compress method option

2016-01-30 Thread Maxim Nestratov
28.01.2016 10:04, Nikolay Shirokovskiy пишет: Signed-off-by: Nikolay Shirokovskiy --- include/libvirt/libvirt-domain.h | 13 +- src/qemu/qemu_driver.c | 75 +--- src/qemu/qemu_migration.c| 94 src/qem

Re: [libvirt] [PATCH v3 3/7] qemu monitor: add multithread compress parameters accessors

2016-01-30 Thread Maxim Nestratov
28.01.2016 10:04, Nikolay Shirokovskiy пишет: From: ShaoHe Feng Current compression does not use all range of parameter values so let's use some of them as 'unspecified' values. These values will be used to mark parameters that were not specified on migrate command line. Thus we check that qemu

Re: [libvirt] [PATCH v3 4/7] qemumonitorjsontest: add test for getting multithread compress params

2016-01-30 Thread Maxim Nestratov
28.01.2016 10:04, Nikolay Shirokovskiy пишет: From: Eli Qiao Signed-off-by: Eli Qiao Signed-off-by: ShaoHe Feng Signed-off-by: Nikolay Shirokovskiy --- tests/qemumonitorjsontest.c | 53 + 1 file changed, 53 insertions(+) diff --git a/tests/qemu

Re: [libvirt] [PATCH v3 5/7] qemu migration: add multithread compression options

2016-01-30 Thread Maxim Nestratov
28.01.2016 10:04, Nikolay Shirokovskiy пишет: Signed-off-by: Nikolay Shirokovskiy Again, I miss some description in commit message. Otherwise ACK. --- include/libvirt/libvirt-domain.h | 25 - src/qemu/qemu_domain.c | 3 +++ src/qemu/qemu_domain.h

Re: [libvirt] [PATCH v3 6/7] qemu migration: add xbzrle compression options

2016-01-30 Thread Maxim Nestratov
28.01.2016 10:04, Nikolay Shirokovskiy пишет: Signed-off-by: Nikolay Shirokovskiy --- include/libvirt/libvirt-domain.h | 8 src/qemu/qemu_domain.c | 1 + src/qemu/qemu_domain.h | 1 + src/qemu/qemu_driver.c | 16 src/qemu/qemu_migr

Re: [libvirt] [PATCH v3 7/7] virsh: add compression options for migration

2016-01-30 Thread Maxim Nestratov
28.01.2016 10:04, Nikolay Shirokovskiy пишет: From: ShaoHe Feng Signed-off-by: Nikolay Shirokovskiy --- tools/virsh-domain.c | 84 tools/virsh.pod | 25 2 files changed, 104 insertions(+), 5 deletions(-) diff --git

[libvirt] [PATCH] conf: qemu: Add support for more HyperV Enlightenment features

2016-02-02 Thread Maxim Nestratov
trolled via MSRs. - Hyper-V "stimer" switches on Hyper-V SynIC timers MSR's support. Guest can setup and use fired by host events (SynIC interrupt and appropriate timer expiration message) as guest clock events Signed-off-by: Maxim Nestratov --- docs/formatdomain.html.i

Re: [libvirt] [PATCH 1/7] storage:dir: added ploop format in vol-create-as cmd

2016-02-08 Thread Maxim Nestratov
08.02.2016 16:04, Olga Krishtal пишет: In order to support ploop in storage pools we need separate volume type: VIR_STORAGE_VOL_PLOOP Signed-off-by: Olga Krishtal --- include/libvirt/libvirt-storage.h | 2 +- src/conf/storage_conf.c | 2 +- src/storage/storage_backend_fs.c | 3 ++

Re: [libvirt] [PATCH 2/7] storage:dir: .buildVol and .buildVolFrom callbacks for ploop

2016-02-08 Thread Maxim Nestratov
08.02.2016 16:04, Olga Krishtal пишет: These callbacks let us to create ploop volumes in directory pools. If a ploop volume was created via buildVol callback, then this volume is an empty ploop device with DiskDescriptor.xml. If the volume was created via .buildFrom - then its content is the same

Re: [libvirt] [PATCH 3/7] storage:dir: .deleteVol callback for ploop volume

2016-02-08 Thread Maxim Nestratov
08.02.2016 16:04, Olga Krishtal пишет: Deletes whole directory of a ploop volume. To delete ploop image it has to be unmounted. Signed-off-by: Olga Krishtal --- src/storage/storage_backend.c| 6 ++ src/storage/storage_backend.h| 2 ++ src/storage/storage_backend_fs.c | 5 -

Re: [libvirt] [PATCH 4/7] storage:dir: adapts .uploadVol .dowloadVol for ploop volume

2016-02-08 Thread Maxim Nestratov
08.02.2016 16:04, Olga Krishtal пишет: In case of ploop volume, target path of the volume is the path to the directory that contains image file named root.hds and DiskDescriptor.xml. While using uploadVol and downloadVol callbacks we need to open root.hds itself. To accomplish this goal we must c

Re: [libvirt] [PATCH 5/7] storage:dir: .resizeVol callback for ploop volume

2016-02-08 Thread Maxim Nestratov
08.02.2016 16:04, Olga Krishtal пишет: To change the size of ploop image file we use ploop resize cmd that takes 2 args: new size and path/to/DiskDescriptor.xml Signed-off-by: Olga Krishtal --- src/storage/storage_backend.c| 28 src/storage/storage_backend.

Re: [libvirt] [PATCH 6/7] storage:dir: .wipeVol is left unsupported for ploop volume

2016-02-08 Thread Maxim Nestratov
08.02.2016 16:04, Olga Krishtal пишет: Returns error in case of vol-wipe cmd for a ploop volume ACK for now. We need to figure out how we can implement it. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 7/7] storage:dir: adapts .refreshVol .refreshPool for ploop volumes

2016-02-08 Thread Maxim Nestratov
08.02.2016 16:04, Olga Krishtal пишет: To update information about ploop volumes inside the a single pool we need to be sure that it is the ploop directory and not some other directory. Ploop volume directory obligatory contains root.hds - image file and disk descriptor - DiskDescriptor.xml. If p

Re: [libvirt] [PATCH v2 0/7] storage:dir: ploop volumes support

2016-02-08 Thread Maxim Nestratov
oop external tool and report an error message that it wasn't detected and it is required to be installed for PLOOP storage pools. Maxim Nestratov -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 0/7] storage:dir: ploop volumes support

2016-02-08 Thread Maxim Nestratov
08.02.2016 20:45, Maxim Nestratov пишет: 08.02.2016 16:04, Olga Krishtal пишет: In-Reply-To: v2: - fixed memory leak - chenged the return value of all helper functions to 0/-1. Now check for success is smth like that: virPloop() < 0 - fixed some identation issues. Overall looks g

Re: [libvirt] [PATCH] migration: add option to set target ndb server port

2016-02-11 Thread Maxim Nestratov
29.01.2016 18:18, Maxim Nestratov пишет: 13.01.2016 14:01, Nikolay Shirokovskiy пишет: Current libvirt + qemu pair lacks secure migrations in case of VMs with non-shared disks. The only option to migrate securely natively is to use tunneled mode and some kind of secure destination URI. But

Re: [libvirt] [PATCH 0/4] vz: rework domain creation

2016-02-12 Thread Maxim Nestratov
10.02.2016 12:39, Mikhail Feoktistov пишет: Patches 1 and 2 make preparation for patch 4 Patch 3 fixes notification subscription To get domain info we should receive and handle notification from hypervisor Patch 4 fixes race condition when adding domain to domains list Race condition: User call

Re: [libvirt] [PATCH] migration: add option to set target ndb server port

2016-02-12 Thread Maxim Nestratov
11.02.2016 16:19, Maxim Nestratov пишет: 29.01.2016 18:18, Maxim Nestratov пишет: 13.01.2016 14:01, Nikolay Shirokovskiy пишет: [snip] Set maximum tolerable downtime for a domain which is being live-migrated to You should use /**/ commens rather than // Otherwise looks OK. ACK. -- libvir

Re: [libvirt] [PATCH 6/6] storage:dir: adapts .refreshVol .refreshPool for ploop volumes

2016-02-18 Thread Maxim Nestratov
18.02.2016 16:46, Ján Tomko пишет: On Wed, Feb 17, 2016 at 02:40:05PM +0300, Olga Krishtal wrote: To update information about ploop volumes inside the a single pool we need to be sure that it is the ploop directory and not some other directory. Ploop volume directory obligatory contains root.hds

[libvirt] [PATCH] vz: fix active domain listing

2016-03-11 Thread Maxim Nestratov
eplaces with a new one within prlsdkLoadDomain function. Signed-off-by: Maxim Nestratov --- src/vz/vz_sdk.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index de73c31..f7d769b 100644 --- a/src/vz/vz_sdk.c +++ b/s

Re: [libvirt] [PATCH] vz: fix active domain listing

2016-03-14 Thread Maxim Nestratov
14.03.2016 12:26, Nikolay Shirokovskiy пишет: On 11.03.2016 12:05, Maxim Nestratov wrote: Since commit 9c14a9ab we have broken active domain listing because reworked prlsdkLoadDomain doesn't set dom->def->id propely. It just looses it when a new def structure is set.

Re: [libvirt] [PATCH 3/6] vz: check supported disk format and bus

2016-03-16 Thread Maxim Nestratov
15.03.2016 10:47, Mikhail Feoktistov пишет: In DomainPostParse phase we check disk format and bus. If disk format is not specified in XML (VIR_STORAGE_FILE_NONE) than we accept this disk. Otherwise we try to find disk format in vzCapabilities struct. Also we try to find disk bus in vzCapabilitie

Re: [libvirt] [PATCH 5/6] vz: check supported controllers

2016-03-16 Thread Maxim Nestratov
15.03.2016 10:47, Mikhail Feoktistov пишет: Virtuozzo6 supports only SCSI(BUSLOGIC) IDE and SATA controllers. Virtuozzo7 supports only SCSI(VIRTIO_SCSI) and IDE. In this patch we add list of supported controllers and scsi models to vzCapabilities structure. In openConnection() callback we get vi

[libvirt] [PATCH v2 5/7] vz: report correct disk format in domainGetXMLDesc

2016-03-18 Thread Maxim Nestratov
From: Mikhail Feoktistov We should report correct disk format depending on vz version and domain type. Since we support only one disk format for each domain type, we can take it from vzCapabilities structure. --- src/vz/vz_sdk.c | 29 + 1 file changed, 17 insertions(+

Re: [libvirt] [PATCH v2 0/7] vz: add disk and controller check in domainPostParse phase

2016-03-18 Thread Maxim Nestratov
16.03.2016 19:21, Mikhail Feoktistov пишет: ACK to the series, but please fix [patch 4/7] Fixed and pushed. Thank you. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v2 4/7] vz: move prlsdkCheckDiskUnsupportedParams to vz_utils.c

2016-03-19 Thread Maxim Nestratov
As long as we have another function checking disk parameters correctness, let's have them in one place. Here we change prefix of the moved function and start to call it from vzCheckUnsupportedDisks rather than add disk. Signed-off-by: Maxim Nestratov --- src/vz/vz_sdk.c

[libvirt] [PATCH v2 6/7] vz: check supported controllers

2016-03-19 Thread Maxim Nestratov
according to Virtuozzo version and check them in XMLPostParse. Signed-off-by: Maxim Nestratov --- src/vz/vz_driver.c | 3 +++ src/vz/vz_utils.c | 48 src/vz/vz_utils.h | 5 + 3 files changed, 56 insertions(+) diff --git a/src/vz/vz_driver.c b/src

[libvirt] [PATCH v2 0/7] vz: add disk and controller check in domainPostParse phase

2016-03-19 Thread Maxim Nestratov
Changes from v1 === A new patch moving prlsdkCheckDiskUnsupportedParams to vz_utils.c added. Commit messages reworded. Minor formatting issues fixed. Maxim Nestratov (1): vz: move prlsdkCheckDiskUnsupportedParams to vz_utils.c Mikhail Feoktistov (6): vz: save vz version in

Re: [libvirt] [PATCH 0/6] vz: add disk and controller check in domainPostParse phase

2016-03-19 Thread Maxim Nestratov
15.03.2016 10:47, Mikhail Feoktistov пишет: Mikhail Feoktistov (6): vz: save vz version in connection structure vz: add vzCapabilities to connection structure vz: check supported disk format and bus vz: report correct disk format in domainGetXMLDesc vz: check supported controllers

[libvirt] [PATCH v2 7/7] vz: set default SCSI model

2016-03-19 Thread Maxim Nestratov
From: Mikhail Feoktistov Each version of virtuozzo supports only one type of SCSI controller So if we add disk on SCSI bus, we should set SCSI controller model. We can take it from vzCapabilities structure. --- src/vz/vz_driver.c | 2 +- src/vz/vz_sdk.c| 27 +++ src/

[libvirt] [PATCH v2 2/7] vz: add vzCapabilities to connection structure

2016-03-19 Thread Maxim Nestratov
From: Mikhail Feoktistov As far as Virtuozzo6 and Virtuozzo7 support different disk types for virtual machines (ploop and qcow2 respectively) and different buses (vz6: IDE, SCSI, SATA; vz7: IDE SCSI) we add vzCapabilities structure to help undestand which disk formats and buses are supported in t

[libvirt] [PATCH v2 1/7] vz: save vz version in connection structure

2016-03-19 Thread Maxim Nestratov
From: Mikhail Feoktistov Move code from connectGetVersion callback to vzInitVersion function --- src/vz/vz_driver.c | 50 +++--- src/vz/vz_utils.c | 47 +++ src/vz/vz_utils.h | 3 +++ 3 files changed, 57 i

[libvirt] [PATCH v2 3/7] vz: check supported disk format and bus

2016-03-19 Thread Maxim Nestratov
From: Mikhail Feoktistov Now we check disk parameters correctness in DomainPostParse. Signed-off-by: Maxim Nestratov --- src/vz/vz_driver.c | 6 +- src/vz/vz_sdk.c| 24 ++-- src/vz/vz_utils.c | 50 ++ src/vz

Re: [libvirt] [PATCH v2] add func to set shared drivers after libvirtd init

2016-03-20 Thread Maxim Nestratov
19.11.2015 15:22, Mikhail Feoktistov пишет: Diff from v1: Remove vz prefix from the title of this letter. Because this is the common case for all drivers in libvirt. Description: Built-in drivers in libvirt are initialized before libvirtd initialization. Libvirt loads shared drivers on libvirtd

[libvirt] RFC backup API

2016-03-21 Thread Maxim Nestratov
Hi all, It's been already quite a long time since qemu implemented QMP "drive-backup" command to create block devices backups. Even more, since qemu 2.4 there is a possibility to create incremental backups. Though it is possible to backup all attached to a domain disk drives by combining them

Re: [libvirt] RFC backup API

2016-03-22 Thread Maxim Nestratov
21.03.2016 13:36, Daniel P. Berrange пишет: On Mon, Mar 21, 2016 at 01:18:19PM +0300, Maxim Nestratov wrote: Hi all, It's been already quite a long time since qemu implemented QMP "drive-backup" command to create block devices backups. Even more, since qemu 2.4 there is a possib

Re: [libvirt] RFC backup API

2016-03-23 Thread Maxim Nestratov
23.03.2016 13:30, Daniel P. Berrange пишет: On Tue, Mar 22, 2016 at 02:19:10PM +0300, Maxim Nestratov wrote: 21.03.2016 13:36, Daniel P. Berrange пишет: On Mon, Mar 21, 2016 at 01:18:19PM +0300, Maxim Nestratov wrote: Hi all, It's been already quite a long time since qemu implemente

Re: [libvirt] RFC backup API

2016-03-23 Thread Maxim Nestratov
23.03.2016 13:36, Kashyap Chamarthy пишет: On Mon, Mar 21, 2016 at 01:18:19PM +0300, Maxim Nestratov wrote: Hi all, It's been already quite a long time since qemu implemented QMP "drive-backup" command to create block devices backups. Even more, since qemu 2.4 there is a possib

Re: [libvirt] RFC backup API

2016-03-25 Thread Maxim Nestratov
23.03.2016 17:27, John Snow пишет: On 03/23/2016 06:36 AM, Kashyap Chamarthy wrote: On Mon, Mar 21, 2016 at 01:18:19PM +0300, Maxim Nestratov wrote: Hi all, It's been already quite a long time since qemu implemented QMP "drive-backup" command to create block devices backups. E

Re: [libvirt] [PATCH v2 3/3] conf: qemu: Add support for more HyperV Enlightenment features

2016-03-28 Thread Maxim Nestratov
28.03.2016 17:55, John Ferlan пишет: On 03/10/2016 07:43 AM, Nikolay Shirokovskiy wrote: From: Maxim Nestratov This patch adds support for "vpindex", "runtime", "synic" and "stimer" features available in qemu 2.5+. Should "vendor_id" be

[libvirt] Fwd: Re: [PATCH v2 3/3] conf: qemu: Add support for more HyperV Enlightenment features

2016-03-28 Thread Maxim Nestratov
Just forwarding as my original letter seems to get lost, please ignore if isn't. 28.03.2016 17:55, John Ferlan пишет: On 03/10/2016 07:43 AM, Nikolay Shirokovskiy wrote: From: Maxim Nestratov This patch adds support for "vpindex", "runtime", "synic" and

Re: [libvirt] [PATCH] docs: Update the hyperv feature qemu supported version

2016-03-28 Thread Maxim Nestratov
28.03.2016 20:13, John Ferlan пишет: In order to follow recent comments which indicate support for specific feature bits are supported by a specific QEMU version add the version from whence the relaxed, vapic, and spinlocks support was added. Signed-off-by: John Ferlan --- Pushing as trivial an

  1   2   3   4   5   6   7   >