[libvirt] OVMF exposure in libvirt

2014-07-14 Thread Michal Privoznik
Dear list, there's been a lot of development in QEMU on this part. And I think it's settled down enough long so I can start looking at it. So I'd like to hear you opinion what's the best way to expose this in libvirt. OVMF can bee looked at as a UEFI enablement in guest. Standard UEFI consis

Re: [libvirt] [PATCH 3/3] virSecurityLabelDef: use enum type for @type

2014-07-14 Thread Michal Privoznik
On 11.07.2014 18:59, Eric Blake wrote: > On 07/11/2014 03:32 AM, Michal Privoznik wrote: >> There's this trend in libvirt of using enum types wherever possible. >> Now that I'm at virSecurityLabelDef let's rework @type item of the >> structure so we

Re: [libvirt] [PATCHv2]util:openvswitch:Delete port if it is exist when add port

2014-07-14 Thread Michal Privoznik
On 12.07.2014 06:47, Lichunhe wrote: If the ovs service stop abnormal, or host cold reboot, vm is destroyed after ovs service stop. The ovs port which connect to interface of vm will not be clear. When the ovs service restart, recover configuration from db, but the interface is no exist, port

Re: [libvirt] [PATCH 0/2] Implement interface stats for BSD

2014-07-14 Thread Michal Privoznik
On 06.07.2014 18:28, Roman Bogorodskiy wrote: This series implements support for querying network interface stats on (Free)BSD. It's more of an RFC, because I'm uncertain about few things: - It feels a little strange to have a source file that implements only a single function like this.

Re: [libvirt] [PATCH v2 07/16] numatune: Encapsulate numatune configuration in order to unify results

2014-07-15 Thread Michal Privoznik
On 15.07.2014 08:33, Martin Kletzander wrote: On Fri, Jul 11, 2014 at 05:11:00PM +0200, Michal Privoznik wrote: On 08.07.2014 13:50, Martin Kletzander wrote: There were numerous places where numatune configuration (and thus domain config as well) was changed in different ways. On some places

Re: [libvirt] [PATCH v2 04/16] conf, schema: add 'id' field for cells

2014-07-15 Thread Michal Privoznik
On 15.07.2014 08:23, Martin Kletzander wrote: On Fri, Jul 11, 2014 at 05:11:05PM +0200, Michal Privoznik wrote: On 08.07.2014 13:50, Martin Kletzander wrote: In XML format, by definition, order of fields should not matter, so order of parsing the elements doesn't affect the end result.

[libvirt] [PATCH 0/4] Resolve const correctness isues

2014-07-15 Thread Michal Privoznik
Okay, okay. The approach in 4/4 can be considered hackish, but hey - it works! Michal Privoznik (4): Fix const correctness viralloc: Honor const correctness in VIR_FREE VIR_FREE: Avoid doing side work in callees virFree: Check const correctness src/conf/network_conf.c | 12

[libvirt] [PATCH 2/4] viralloc: Honor const correctness in VIR_FREE

2014-07-15 Thread Michal Privoznik
Since we've corrected all the callers that passed a const pointer to VIR_FREE() we may drop the typecasting horribility and let the macro be a simple wrapper over the virFree() function. Signed-off-by: Michal Privoznik --- src/util/viralloc.h | 15 +-- 1 file changed, 1 inse

[libvirt] [PATCH 4/4] virFree: Check const correctness

2014-07-15 Thread Michal Privoznik
a const pointer into 'void *' triggers compiler warning about discarding 'const' qualifier from pointer. So the virFree() function gains new dummy argument, that is not touched anyhow, just fulfills the const correctness check duty. Signed-off-by: Michal Privoznik --- src/uti

[libvirt] [PATCH 3/4] VIR_FREE: Avoid doing side work in callees

2014-07-15 Thread Michal Privoznik
There are just two places where we rely on the fact that VIR_FREE() macro is without any side effects. In the future, this property of the macro is going to change, so we need the code to be adjusted to deal with argument passed to VIR_FREE() being evaluated multiple times. Signed-off-by: Michal

[libvirt] [PATCH 1/4] Fix const correctness

2014-07-15 Thread Michal Privoznik
pi/xen_common.h public header. The structure contains session_id which is type of 'const char *' when in fact it should have been just 'char *'. So I'm leaving this unmodified, just noticing the fact in comment. Signed-off-by: Michal Privoznik --- src/locking/l

Re: [libvirt] [PATCH 4/4] virFree: Check const correctness

2014-07-15 Thread Michal Privoznik
On 15.07.2014 15:27, Martin Kletzander wrote: On Tue, Jul 15, 2014 at 02:38:36PM +0200, Michal Privoznik wrote: Up to now it's possible to do something like this: const char *ptr; ptr = strdup("my example string"); VIR_FREE(ptr); The problem is, const char * pointers should

Re: [libvirt] [PATCH 3/4] VIR_FREE: Avoid doing side work in callees

2014-07-15 Thread Michal Privoznik
On 15.07.2014 14:58, Ján Tomko wrote: On 07/15/2014 02:38 PM, Michal Privoznik wrote: There are just two places where we rely on the fact that VIR_FREE() macro is without any side effects. In the future, this property of the macro is going to change, so we need the code to be adjusted to deal

[libvirt] [PATCH] examples: Introduce domtop

2014-07-16 Thread Michal Privoznik
o. Yes, it could be written in different ways, but I've chosen this one as I think it show explicitly what users need to implement in order to imitate virt-manager's graphing. Signed-off-by: Michal Privoznik --- .gitignore | 1 + Makefile.am

Re: [libvirt] [PATCH 2/3] lxc conf2xml: convert lxc.network.name for veth networks

2014-07-16 Thread Michal Privoznik
On 02.07.2014 15:57, Cédric Bosdonnat wrote: --- src/lxc/lxc_native.c | 22 -- .../lxcconf2xmldata/lxcconf2xml-physnetwork.config | 1 + tests/lxcconf2xmldata/lxcconf2xml-simple.xml | 1 + 3 files changed, 18 insertions(+), 6 deletion

Re: [libvirt] [PATCH 1/3] lxc network configuration allows setting target container NIC name

2014-07-16 Thread Michal Privoznik
On 02.07.2014 15:57, Cédric Bosdonnat wrote: LXC network devices can now be assigned a custom NIC device name on the container side. For example, this is configured with: In this example the network card will appear as eth1 in the guest. --- docs/schemas/domaincomm

Re: [libvirt] [PATCH v2] support for QEMU vhost-user

2014-07-16 Thread Michal Privoznik
On 11.07.2014 19:47, Michele Paolino wrote: > This patch adds support for the QEMU vhost-user feature to libvirt. > vhost-user enables the communication between a QEMU virtual machine > and other userspace process using the Virtio transport protocol. > It uses a char dev (e.g. Unix socket) for the

Re: [libvirt] [PATCH v3 00/16] Support for per-guest-node binding

2014-07-16 Thread Michal Privoznik
On 16.07.2014 16:42, Martin Kletzander wrote: v3 of https://www.redhat.com/archives/libvir-list/2014-July/msg00372.html v3: - Michal's suggestions worked in - rebased on current master Martin Kletzander (16): qemu: purely a code movement qemu: remove useless error check conf: purel

Re: [libvirt] virsh capabilities vs. domcapabilities

2014-07-17 Thread Michal Privoznik
On 16.07.2014 21:00, Eric Blake wrote: We have some inconsistencies in the node capabilities (which shows guest capabilities for some default binaries) and domcapabilities (which shows guest capabilities for a specified binary). It might be nicer for client applications if the two XML components

[libvirt] [PATCH] qemuConnectGetDomainCapabilities: Use wiser defaults

2014-07-17 Thread Michal Privoznik
ties error: invalid argument: at least one of emulatorbin or architecture fields must be present After: # virsh domcapabilities /usr/bin/qemu-system-x86_64 kvm pc-i440fx-2.1 x86_64 Signed-off-by: Michal Privoznik --- src/qemu/qemu_driver.c | 24 ++-

Re: [libvirt] virsh capabilities vs. domcapabilities

2014-07-17 Thread Michal Privoznik
On 17.07.2014 11:11, Daniel P. Berrange wrote: On Thu, Jul 17, 2014 at 11:05:08AM +0200, Michal Privoznik wrote: # tools/virsh domcapabilities --virttype kvm error: failed to get emulator capabilities error: invalid argument: at least one of emulatorbin or architecture fields must be present

[libvirt] [PATCH v1 0/7] Hugepages wrt to NUMA

2014-07-17 Thread Michal Privoznik
Up to now, domains are either backed by an arbitrary huge page but without any NUMA awareness. This is suboptimal and I'm trying to fix it. Michal Privoznik (7): configure: Check for statfs Introduce virFileFindHugeTLBFS qemu: Utilize virFileFindHugeTLBFS virbitmap: Intr

[libvirt] [PATCH v1 7/7] tests: Some testing of hugepages mapping

2014-07-17 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- .../qemuxml2argv-hugepages-pages2.args | 10 ++ .../qemuxml2argv-hugepages-pages2.xml | 38 ++ .../qemuxml2argv-hugepages-pages3.args | 9 + .../qemuxml2argv-hugepages-pages3.xml

[libvirt] [PATCH v1 2/7] Introduce virFileFindHugeTLBFS

2014-07-17 Thread Michal Privoznik
This should iterate over mount tab and search for hugetlbfs among with looking for the default value of huge pages. Signed-off-by: Michal Privoznik --- src/libvirt_private.syms | 1 + src/util/virfile.c | 155 +++ src/util/virfile.h

[libvirt] [PATCH v1 4/7] virbitmap: Introduce virBitmapDoesIntersect

2014-07-17 Thread Michal Privoznik
This internal API just checks if two bitmaps intersect or not. Signed-off-by: Michal Privoznik --- src/libvirt_private.syms | 1 + src/util/virbitmap.c | 20 src/util/virbitmap.h | 3 +++ tests/virbitmaptest.c| 26 ++ 4 files changed

[libvirt] [PATCH v1 1/7] configure: Check for statfs

2014-07-17 Thread Michal Privoznik
course different: sys/param.h and sys/mount.h on the FreeBSD and sys/statfs.h on the Linux. The header files are checked too. Signed-off-by: Michal Privoznik --- configure.ac | 4 ++-- src/util/virfile.c | 21 ++--- 2 files changed, 16 insertions(+), 9 deletions(-) diff

[libvirt] [PATCH v1 5/7] domain: Introduce ./hugepages/page/[@size, @unit, @nodeset]

2014-07-17 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- docs/formatdomain.html.in | 18 +- docs/schemas/domaincommon.rng | 19 +- src/conf/domain_conf.c | 197 +++-- src/conf/domain_conf.h

[libvirt] [PATCH v1 3/7] qemu: Utilize virFileFindHugeTLBFS

2014-07-17 Thread Michal Privoznik
, so the "hugetlbfs_mount" option must take an list of strings (mount points). But previously, it was just a string, so we must accept both types now. Signed-off-by: Michal Privoznik --- src/Makefile.am | 1 + src/qemu/qemu_command.c | 20 src/qemu/qemu_conf.c

[libvirt] [PATCH v1 6/7] qemu: Implement ./hugepages/page/[@size, @unit, @nodeset]

2014-07-17 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c| 91 +++--- .../qemuxml2argv-hugepages-pages.args | 16

[libvirt] [PATCH v2] examples: Introduce domtop

2014-07-18 Thread Michal Privoznik
be fairly simple to switch do just guest CPU usage if needed. Signed-off-by: Michal Privoznik --- .gitignore | 1 + Makefile.am | 2 +- cfg.mk | 2 +- configure.ac| 1 + examples/domtop/Makefile.am | 27 +++ exam

Re: [libvirt] [PATCH] qemuConnectGetDomainCapabilities: Use wiser defaults

2014-07-18 Thread Michal Privoznik
On 17.07.2014 11:28, Daniel P. Berrange wrote: > On Thu, Jul 17, 2014 at 11:12:05AM +0200, Michal Privoznik wrote: >> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c >> index 33541d3..7d99435 100644 >> --- a/src/qemu/qemu_driver.c >> +++ b/src/qemu/qe

Re: [libvirt] OVMF exposure in libvirt

2014-07-18 Thread Michal Privoznik
On 14.07.2014 16:12, Paolo Bonzini wrote: Il 14/07/2014 11:27, Daniel P. Berrange ha scritto: -drive file=img_1,if=pflash,format=raw,readonly \ -drive file=img_2,if=pflash,format=raw It's safer to add ",unit=0" and ",unit=1" too. We already use for specifying alternative BIOS bl

Re: [libvirt] [REPOST 4/8] scsi_backend: Use existing LINUX_SYSFS_SCSI_HOST_PREFIX definition

2014-07-18 Thread Michal Privoznik
On 08.07.2014 13:54, John Ferlan wrote: Rather than supplying the path again in the formatting of the sysfs scsi_host directory. Signed-off-by: John Ferlan --- src/storage/storage_backend_scsi.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/storage/storage_bac

Re: [libvirt] [REPOST 0/8] storage_scsi: Stable SCSI host addressing

2014-07-18 Thread Michal Privoznik
On 08.07.2014 13:54, John Ferlan wrote: Reposting of a series from last month changing only the span version in the docs from 1.2.6 to 1.2.7. Previous posting here: http://www.redhat.com/archives/libvir-list/2014-June/msg00448.html The concept still remains the same - rather than rely on the

Re: [libvirt] [REPOST 5/8] virutil: Introduce virReadSCSIUniqueId

2014-07-18 Thread Michal Privoznik
On 08.07.2014 13:54, John Ferlan wrote: Introduce a new function to read the current scsi_host entry and return the value found in the 'unique_id' file. Add a 'scsihosttest' test (similar to the fchosttest, but incorporating some of the concepts of the mocked pci test library) in order to read t

Re: [libvirt] [REPOST 1/8] getAdapterName: check for SCSI_HOST

2014-07-18 Thread Michal Privoznik
On 08.07.2014 13:54, John Ferlan wrote: Rather than assume that NOT FC_HOST is SCSI_HOST, let's call them out specifically. Makes it easier to find SCSI_HOST code/structs and ensures something isn't missed in the future Signed-off-by: John Ferlan --- src/storage/storage_backend_scsi.c | 21 ++

Re: [libvirt] [PATCH v2] examples: Introduce domtop

2014-07-18 Thread Michal Privoznik
On 18.07.2014 15:48, Eric Blake wrote: On 07/18/2014 03:08 AM, Michal Privoznik wrote: There's this question on the list that is asked over and over again. How do I get {cpu, memory, ...} usage in percentage? Or its modified version: How do I plot nice graphs like virt-manager does? It

[libvirt] [PATCH] domtop: Fix build on mingw

2014-07-21 Thread Michal Privoznik
Firstly, there's no sigaction() nor struct sigaction on mingw. We have to use the one implemented by gnulib (and hence link with gnulib). Then, for some reason one header file from windows defines ERROR symbol. Yes it does. Sigh. Signed-off-by: Michal Privoznik --- examples/domtop/Makefi

[libvirt] [PATCH] tests: Remove stale scsihostdata dir

2014-07-22 Thread Michal Privoznik
In the fbd91d49 commit, new scsihostdata dir is added to EXTRA_DIST in the tests/Makefile.am. However, the directory itself is not created anywhere, nor in the commit. Signed-off-by: Michal Privoznik --- Notes: Pushed under build-breaker rule. tests/Makefile.am | 1 - 1 file changed, 1

Re: [libvirt] [PATCH v1 5/7] domain: Introduce ./hugepages/page/[@size, @unit, @nodeset]

2014-07-22 Thread Michal Privoznik
On 21.07.2014 17:09, Daniel P. Berrange wrote: On Thu, Jul 17, 2014 at 06:12:46PM +0200, Michal Privoznik wrote: + + QEMUGuest1 + c7a5fdbd-edaf-9455-926a-d65c16db1809 + 4194304 + 4194304 + + + + + + + 4 + + + + + +hvm

[libvirt] [PATCH v2 0/6] Hugepages wrt NUMA

2014-07-23 Thread Michal Privoznik
Another attempt. I've dropped the 1/7 from v1, and changed a few bits raised during review. Although, I'm still using: as I don't feel there's any disagreement. But if there is I can rework the patches. Michal Privoznik (6): Introduce virFile

[libvirt] [PATCH v2 2/6] qemu: Utilize virFileFindHugeTLBFS

2014-07-23 Thread Michal Privoznik
, so the "hugetlbfs_mount" option must take an list of strings (mount points). But previously, it was just a string, so we must accept both types now. Signed-off-by: Michal Privoznik --- Notes: Yes, the libvirtd_qemu.aug change is missing here. The reason is prosaic: I don

[libvirt] [PATCH v2 6/6] tests: Some testing of hugepages mapping

2014-07-23 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- .../qemuxml2argv-hugepages-pages2.args | 10 ++ .../qemuxml2argv-hugepages-pages2.xml | 38 ++ .../qemuxml2argv-hugepages-pages3.args | 9 + .../qemuxml2argv-hugepages-pages3.xml

[libvirt] [PATCH v2 1/6] Introduce virFileFindHugeTLBFS

2014-07-23 Thread Michal Privoznik
This should iterate over mount tab and search for hugetlbfs among with looking for the default value of huge pages. Signed-off-by: Michal Privoznik --- src/libvirt_private.syms | 2 + src/util/virfile.c | 151 ++- src/util/virfile.h

[libvirt] [PATCH v2 5/6] qemu: Implement ./hugepages/page/[@size, @unit, @nodeset]

2014-07-23 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c| 91 +++--- .../qemuxml2argv-hugepages-pages.args | 16

[libvirt] [PATCH v2 3/6] virbitmap: Introduce virBitmapOverlaps

2014-07-23 Thread Michal Privoznik
This internal API just checks if two bitmaps intersect or not. Signed-off-by: Michal Privoznik --- Notes: This has been ACKed already, but the name of the function was not quite right. But there's no functional change since then. src/libvirt_private.syms | 1 + src/util/virbit

[libvirt] [PATCH v2 4/6] domain: Introduce ./hugepages/page/[@size, @unit, @nodeset]

2014-07-23 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- docs/formatdomain.html.in | 18 +- docs/schemas/domaincommon.rng | 19 +- src/conf/domain_conf.c | 197 +++-- src/conf/domain_conf.h

[libvirt] [PATCH v2] qemuConnectGetDomainCapabilities: Use wiser defaults

2014-07-23 Thread Michal Privoznik
ties error: invalid argument: at least one of emulatorbin or architecture fields must be present After: # virsh domcapabilities /usr/bin/qemu-system-x86_64 kvm pc-i440fx-2.1 x86_64 Signed-off-by: Michal Privoznik --- Notes: It would be nice to have this in the same re

Re: [libvirt] [PATCH v2 1/6] Introduce virFileFindHugeTLBFS

2014-07-24 Thread Michal Privoznik
On 24.07.2014 08:41, Peter Krempa wrote: > On 07/23/14 21:06, Daniel P. Berrange wrote: >> On Wed, Jul 23, 2014 at 05:37:17PM +0200, Michal Privoznik wrote: >>> +int >>> +virFileFindHugeTLBFS(virHugeTLBFSPtr *ret_fs, >>> + size_t *r

Re: [libvirt] [PATCH 1/2] LXC: add support for --config in setmaxmem command

2014-07-24 Thread Michal Privoznik
On 16.07.2014 11:51, Chen Hanxiao wrote: In lxc, we could not use setmaxmem command with --config options. This patch will add support for this. Signed-off-by: Chen Hanxiao --- src/lxc/lxc_driver.c | 69 ++-- 1 file changed, 46 insertions(+), 2

Re: [libvirt] [PATCH 2/2] LXC: use lxcDomainSetMemoryFlags to do lxcDomainSetMaxMemory's work

2014-07-24 Thread Michal Privoznik
On 16.07.2014 11:51, Chen Hanxiao wrote: Signed-off-by: Chen Hanxiao --- src/lxc/lxc_driver.c | 36 +--- 1 file changed, 5 insertions(+), 31 deletions(-) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index be6ee19..9f974eb 100644 --- a/src/lxc/lxc_d

Re: [libvirt] [PATCH V2 2/6] qemu: Introduce vgamem attribute for video model

2014-07-24 Thread Michal Privoznik
On 14.07.2014 13:20, Wang Rui wrote: From: Zeng Junliang This patch introduces vgamem attribute for video model, and sets its default value as qemu used. Parse it in two ways accroding to qemu startup parameters supported: -device or -vga. Signed-off-by: Zeng Junliang Signed-off-by: Wang Rui

Re: [libvirt] [libvirt-sandbox PATCH 0/2] virt-sandbox-service fixes

2014-07-24 Thread Michal Privoznik
On 07.07.2014 15:47, Cédric Bosdonnat wrote: Here are a 2 fixes that make virt-sandbox-service work for me. One allows it to work if selinux isn't handled by libvirtd, the other safely handles some file copying that can be different across distros. Cédric Bosdonnat (2): virt-sandbox-service:

Re: [libvirt] [PATCH 1/2] Add test for virtio serial port assignment

2014-07-24 Thread Michal Privoznik
On 25.06.2014 19:22, Ján Tomko wrote: Add a test to demonstrate the effect of the next patch. --- .../qemuxml2argv-channel-virtio-autoassign.args| 20 + .../qemuxml2argv-channel-virtio-autoassign.xml | 50 ++ tests/qemuxml2argvtest.c

Re: [libvirt] [RFC PATCH 2/2] Implement virtio serial address allocation

2014-07-24 Thread Michal Privoznik
On 25.06.2014 19:22, Ján Tomko wrote: Over-engineered to allow non-contiguous indexes. Free ports of a controller are stored in a virBitmap. These bitmaps are stored in a hash table, indexed by the controller index formatted as a string. Buses are ignored for now, QEMU doesn't seem to support an

[libvirt] [PATCH] qemuConnectGetDomainCapabilities: Report error on unknown arch

2014-07-24 Thread Michal Privoznik
should throw an error message prior jumping onto 'cleanup' label as the helper lookup function remains silent on no search result. Signed-off-by: Michal Privoznik --- Notes: This would qualify to be pushed under trivial rule, but maybe somebody has a better idea for the error mes

[libvirt] [PATCH] domtop: Turn parse_argv into void

2014-08-04 Thread Michal Privoznik
eturn an integer value, if it effectively can return only value of zero. Signed-off-by: Michal Privoznik --- examples/domtop/domtop.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/examples/domtop/domtop.c b/examples/domtop/domtop.c index af5da46..204fdc3 100644

[libvirt] [PATCH] domtop: Remove unused variable

2014-08-04 Thread Michal Privoznik
The variable 'k' in the print_cpu_usage function is not used anywhere and can fire a warning on some compilers. Signed-off-by: Michal Privoznik --- examples/domtop/domtop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/domtop/domtop.c b/examples/domto

Re: [libvirt] help

2014-08-05 Thread Michal Privoznik
[Dropping libvirt-announce list] On 05.08.2014 11:47, Himanshu Sharma wrote: Dear Team, Greetings!! I'm testing libvirt with VMware ESXi. I'm able to connect to VMware ESXi with libvirt driver but not able to connect it through "Virtual Machine manager" GUI also not able to run virt-clone com

[libvirt] [PATCH] qemu: Make virFileFindHugeTLBFS fault tolerant

2014-08-06 Thread Michal Privoznik
tlbfs mounts and malformed meminfo file, but that's expected (how can one mount hugetlbfs without kernel supporting huge pages?). Workaround in that case is to umount all the hugetlbfs mounts. Reported-by: Jim Fehlig Signed-off-by: Michal Privoznik --- src/util/virfile.c | 9 + 1 file

[libvirt] [PATCH v1 0/3] OVMF exposure

2014-08-08 Thread Michal Privoznik
files For the case number one we are almost ready. The second case, however, needs more changes on our side. Especially if you consider fact, that the UEFI code can be shared among multiple domains while the variables store can't. Michal Privoznik (3): conf: Extend and introduce qemu: Impl

[libvirt] [PATCH v1 1/3] conf: Extend and introduce

2014-08-08 Thread Michal Privoznik
file. Signed-off-by: Michal Privoznik --- docs/formatdomain.html.in | 19 - docs/schemas/domaincommon.rng | 21 ++ src/conf/domain_conf.c | 87 +- src/conf/domain_c

[libvirt] [PATCH v1 2/3] qemu: Implement extended loader and nvram

2014-08-08 Thread Michal Privoznik
obsoletes the -bios argument. Note that UEFI is unusable without ACPI. This is handled properly now. Among with this extension, the variable file is expected to be writable and hence we need security drivers to label it. Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c

[libvirt] [PATCH v1 3/3] qemu: Automatically create NVRAM store

2014-08-08 Thread Michal Privoznik
artup process, if it's determined that domain needs _VARS file it's copied from this master _VARS file. The location of the master file is configurable in qemu.conf and the default path can be compiled in via --with-qemu-nvram-file configure option. Signed-off-by: Michal Privoznik --

Re: [libvirt] [PATCH v1 2/3] qemu: Implement extended loader and nvram

2014-08-08 Thread Michal Privoznik
On 08.08.2014 14:08, Paolo Bonzini wrote: Il 08/08/2014 12:17, Michal Privoznik ha scritto: +if (loader->nvram) { +virBufferFreeAndReset(&buf); +virBufferAsprintf(&buf, + "file=%s,if=pflash,f

Re: [libvirt] [PATCH] Include param.h in case of HAVE_BSD_CPU_AFFINITY

2014-08-11 Thread Michal Privoznik
On 10.08.2014 11:44, Guido Günther wrote: This fixes compilation on kFreeBSD which otherwise fails like CC util/libvirt_util_la-virprocess.lo In file included from /usr/include/sys/cpuset.h:35:0, from util/virprocess.c:43: /usr/include/sys/_cpuset.h:49:43: error: 'NBBY

Re: [libvirt] [PATCH] Don't fail qemu driver intialization if we can't determine hugepage size

2014-08-11 Thread Michal Privoznik
On 10.08.2014 13:51, Guido Günther wrote: Otherwise we fail like libvirt version: 1.2.7, package: 6 (root 2014-08-08-16:09:22 bogon) virAuditOpen:62 : Unable to initialize audit layer: Protocol not supported virFileGetDefaultHugepageSize:2958 : internal error: Unable to parse /proc/mem

Re: [libvirt] qemu driver fails to load on Xen after be0782e1

2014-08-11 Thread Michal Privoznik
On 11.08.2014 11:16, Daniel P. Berrange wrote: On Tue, Aug 05, 2014 at 11:16:53AM -0600, Jim Fehlig wrote: Jim Fehlig wrote: Until recently, the qemu driver has always succeeded in loading even on a system booted to Xen. Commit be0782e1 broke this, hence libvirtd no longer loads xendom0 # /us

Re: [libvirt] [PATCH] Clear bandwidth settings for a shutoff domain using domiftune

2014-08-11 Thread Michal Privoznik
On 11.08.2014 08:41, Jianwei Hu wrote: qemu: To clear bandwidth settings for a shutoff domain by using domiftune. After applying this patch, we can use virsh domiftune command to clear inbound or/and outbound setting for a shutoff domain. for example: virsh domiftune $domain $interface 0 0 Th

[libvirt] [PATCH] conf: Format interface's driver more frequently

2014-08-11 Thread Michal Privoznik
XML would never get formatted back. Signed-off-by: Michal Privoznik --- src/conf/domain_conf.c | 4 +- .../qemuxml2argv-interface-driver.xml | 51 ++ tests/qemuxml2xmltest.c| 1 + 3 files changed, 55 insert

Re: [libvirt] [PATCH] qemu: use guest-fsfreeze-freeze-list command if mountpoints to freeze specified

2014-08-11 Thread Michal Privoznik
On 08.08.2014 22:03, Tomoki Sekiyama wrote: A command to freeze a part of mounted file systems is implemented in upstream QEMU-guest-agent with a name of 'guest-fsfreeze-freeze-list'. This fixes the name of the command used to partial fsfreeze in qemu driver when 'mountpoints' option is specified

Re: [libvirt] [python-PATCH] Fix libvirt_longlongWrap returning a very large value

2014-08-11 Thread Michal Privoznik
On 11.08.2014 14:59, Wang Rui wrote: From: Zhou Yimin If hypervisor is not Xen, the errs in struct _virDomainBlockStats will be -1. But in KVM when we call domain.blockStats(), errs is 18446744073709551615. To fix that, this patch has two changes: 1. Replace use of the PyLong_FromUnsignedLongL

Re: [libvirt] [PATCH 10/66] vbox: Rewrite vboxConnectGetCapabilities

2014-08-12 Thread Michal Privoznik
On 11.08.2014 12:06, Taowei wrote: --- src/vbox/vbox_common.c| 11 +++ src/vbox/vbox_tmpl.c | 16 ++-- src/vbox/vbox_uniformed_api.h |1 + 3 files changed, 18 insertions(+), 10 deletions(-) diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_comm

Re: [libvirt] [PATCH 14/66] vbox: Rewrite vboxDomainLookupByUUID

2014-08-12 Thread Michal Privoznik
On 11.08.2014 12:06, Taowei wrote: --- src/vbox/vbox_common.c| 73 + src/vbox/vbox_tmpl.c | 73 - src/vbox/vbox_uniformed_api.h |2 ++ 3 files changed, 75 insertions(+), 73 deletions(-)

Re: [libvirt] [PATCH 45/66] vbox: Rewrite vboxDomainAttachDeviceFlags

2014-08-12 Thread Michal Privoznik
On 11.08.2014 12:06, Taowei wrote: --- src/vbox/vbox_common.c| 14 ++ src/vbox/vbox_tmpl.c | 15 --- src/vbox/vbox_uniformed_api.h |2 ++ 3 files changed, 16 insertions(+), 15 deletions(-) diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_c

Re: [libvirt] [PATCH 00/66] vbox: Rewrite vbox domain driver

2014-08-12 Thread Michal Privoznik
On 11.08.2014 12:06, Taowei wrote: This series of patches rewrite the vbox's domain driver. The driver is separated into two parts: the version specified and the common part. The common driver use vboxUniformedAPI to build a general driver for all vbox versions. The vboxUniformedAPI take the resp

[libvirt] [PATCH] qemu_conf: Undefine the correct symbol

2014-08-12 Thread Michal Privoznik
GET_VALUE_STR. Signed-off-by: Michal Privoznik --- Pushed as trivial. src/qemu/qemu_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index b14b1bc..238d2b1 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -662,7

Re: [libvirt] Initializing qemu driver

2014-08-13 Thread Michal Privoznik
On 13.08.2014 00:00, David kiarie wrote: Hi there, I get this errors trying to intialialize libvirtd $libvirtd -vvv 2014-08-12 21:57:47.887+: 6449: info : libvirt version: 1.2.8 2014-08-12 21:57:47.887+: 6449: warning : virGetHostname:665 : getaddrinfo failed for 'linux-xzc4': Name or s

Re: [libvirt] Pass additional environmental variables

2014-08-13 Thread Michal Privoznik
ve access to kerberos tickets? On the other hand, we've done this for a limited use case: commit afc984af2e055b33f7c7b06ccacaf00103d4ce5e Author: Michal Privoznik AuthorDate: Fri Sep 9 15:59:26 2011 +0200 Commit: Michal Privoznik CommitDate: Fri Sep 9 15:59:26 2011 +0200 virnetsock

[libvirt] [PATCH] qemu: Issue rtc_reset_reinjection command after guest-set-time

2014-08-13 Thread Michal Privoznik
via guest agent. 1: http://www.mail-archive.com/qemu-devel@nongnu.org/msg236435.html Signed-off-by: Michal Privoznik --- src/qemu/qemu_driver.c | 10 ++ src/qemu/qemu_monitor.c | 33 + src/qemu/qemu_monitor.h | 2 ++ src/qemu/qemu_moni

Re: [libvirt] [PATCH 00/66] vbox: Rewrite vbox domain driver

2014-08-13 Thread Michal Privoznik
[CC-ing Yohan BELLEGUIC and Manuel VIVES] On 12.08.2014 17:31, Michal Privoznik wrote: On 11.08.2014 12:06, Taowei wrote: This series of patches rewrite the vbox's domain driver. The driver is separated into two parts: the version specified and the common part. The common drive

Re: [libvirt] [PATCH] qemuDomainFSFreeze: report unless the agent supports mountpoints param

2014-08-14 Thread Michal Privoznik
On 13.08.2014 17:42, Tomoki Sekiyama wrote: > This patch gives users a nicer error message when the QEMU guest agent is > not new enough to support 'guest-fsfreeze-freeze-list' command, which is > used by qemuDomainFSFreeze() to freeze specified filesystems only. > > Before this patch, it was depe

Re: [libvirt] [PATCH] qemu: Issue rtc_reset_reinjection command after guest-set-time

2014-08-14 Thread Michal Privoznik
On 13.08.2014 18:30, Eric Blake wrote: On 08/13/2014 06:51 AM, Michal Privoznik wrote: s/_/-/2 in the subject line An advice appeared there on the qemu-devel list [1]. When a domain is suspended and then resumed guest kernel is not aware of this. So we've introduced virDomainSetTime API

[libvirt] [PATCHv2 libvirt] qemu: Issue rtc-reset-reinjection command after guest-set-time

2014-08-14 Thread Michal Privoznik
uld not use the RTC injection if the guest time is set via guest agent. 1: http://www.mail-archive.com/qemu-devel@nongnu.org/msg236435.html Signed-off-by: Michal Privoznik --- Notes: diff to v1: -fixed command name in subject -added testcase src/qemu/qemu_driver.c | 10 +

Re: [libvirt] [PATCH] conf: fix parsing 'cmd_per_lun' and 'max_sectors'

2014-08-14 Thread Michal Privoznik
On 14.08.2014 09:55, Wang Rui wrote: From: Mo yuxiang commit d9504941 introduces two new attributes "cmd_per_lun" and "max_sectors" same with the names QEMU uses for virtio-scsi. But the case of parsing them is not exact. Change to parse them if controller has "driver" element. Signed-off-by:

Re: [libvirt] [PATCH] build: force configure failed when perl is missing

2014-08-14 Thread Michal Privoznik
On 14.08.2014 05:37, Jincheng Miao wrote: Perl is necessary to our build processing, it will invoke a lot of generating script, like: gendispatch.pl. If perl is missing, it's ok for build from git checkout, because autogen.sh will tell you. But for compiling from a release tarball, configure will

Re: [libvirt] [PATCH] fix

2014-08-14 Thread Michal Privoznik
On 14.08.2014 10:41, Ján Tomko wrote: Also add qemuDomainChangeGraphicsPasswords, qemuProcessVerifyGuestCPU and qemuProcessInitPCIAddresses. Replace tabs by spaces. --- I'll do some testing on the patch and push it later with this squashed in if it works well. src/qemu/qemu_domain.c | 2 +-

Re: [libvirt] [PATCH 00/66] vbox: Rewrite vbox domain driver

2014-08-15 Thread Michal Privoznik
On 14.08.2014 17:50, Yohan Belleguic wrote: Le Wednesday 13 August 2014 17:18:44, Michal Privoznik a écrit : [CC-ing Yohan BELLEGUIC and Manuel VIVES] On 12.08.2014 17:31, Michal Privoznik wrote: On 11.08.2014 12:06, Taowei wrote: This series of patches rewrite the vbox's domain driver

[libvirt] Virtual box storage and network sub-drivers

2014-08-15 Thread Michal Privoznik
Dear list, Virtualbox driver has its own implementation of storage and network sub-drivers. But as of commit ba5f3c7c8ecc1037e44904916989a1c65777a9d5 (contained in the 1.0.6 release) when the VBox moved from client to daemon, the storage and network sub-drivers are indeed registered but in fa

[libvirt] [PATCH] daemon: Fix driver registration ordering

2014-08-15 Thread Michal Privoznik
this commit is moving interface module load a bit earlier to match the ordering in case libvirt is built without driver modules. Reported-by: Taowei Luo Signed-off-by: Michal Privoznik --- daemon/libvirtd.c | 31 ++- 1 file changed, 18 insertions(+), 13 deletions

[libvirt] [PATCH v2 1/3] conf: Extend and introduce

2014-08-15 Thread Michal Privoznik
file. Signed-off-by: Michal Privoznik --- docs/formatdomain.html.in | 19 - docs/schemas/domaincommon.rng | 21 ++ src/conf/domain_conf.c | 87 +- src/conf/domain_c

[libvirt] [PATCH v2 0/3] OVMF exposure

2014-08-15 Thread Michal Privoznik
diff to v1: - adapt to new code - restrict usage to x86_64 qemu guests - Adapted to Laszlo's suggestion for qemu.conf format Michal Privoznik (3): conf: Extend and introduce qemu: Implement extended loader and nvram qemu: Automatically create NVRAM store configu

[libvirt] [PATCH v2 3/3] qemu: Automatically create NVRAM store

2014-08-15 Thread Michal Privoznik
artup process, if it's determined that domain needs _VARS file it's copied from this master _VARS file. The location of the master file is configurable in qemu.conf. Signed-off-by: Michal Privoznik --- configure.ac | 1 - libvirt.spec.in| 2 +

[libvirt] [PATCH v2 2/3] qemu: Implement extended loader and nvram

2014-08-15 Thread Michal Privoznik
obsoletes the -bios argument. Note that UEFI is unusable without ACPI. This is handled properly now. Among with this extension, the variable file is expected to be writable and hence we need security drivers to label it. Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c

Re: [libvirt] [PATCH v2 1/3] conf: Extend and introduce

2014-08-15 Thread Michal Privoznik
On 15.08.2014 16:13, Laszlo Ersek wrote: On 08/15/14 15:43, Michal Privoznik wrote: Up to now, users can configure BIOS via the element. With the upcoming implementation of UEFI this is not enough as BIOS and UEFI are conceptually different. For instance, while BIOS is ROM, UEFI is

[libvirt] [PATCH v3 2/3] qemu: Implement extended loader and nvram

2014-08-18 Thread Michal Privoznik
obsoletes the -bios argument. Note that UEFI is unusable without ACPI. This is handled properly now. Among with this extension, the variable file is expected to be writable and hence we need security drivers to label it. Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c

[libvirt] [PATCH v3 3/3] qemu: Automatically create NVRAM store

2014-08-18 Thread Michal Privoznik
artup process, if it's determined that domain needs _VARS file it's copied from this master _VARS file. The location of the master file is configurable in qemu.conf. Signed-off-by: Michal Privoznik --- libvirt.spec.in| 2 + src/Makefile.am|

[libvirt] [PATCH v3 1/3] conf: Extend and introduce

2014-08-18 Thread Michal Privoznik
file. Signed-off-by: Michal Privoznik --- docs/formatdomain.html.in | 19 - docs/schemas/domaincommon.rng | 21 ++ src/conf/domain_conf.c | 87 +- src/conf/domain_c

[libvirt] [PATCH v3 0/3] OVMF exposure

2014-08-18 Thread Michal Privoznik
diff to v2: -Adapted to Laszlo's review on v2 Michal Privoznik (3): conf: Extend and introduce qemu: Implement extended loader and nvram qemu: Automatically create NVRAM store docs/formatdomain.html.in | 19 ++- docs/schemas/domaincommo

Re: [libvirt] [PATCHv2 libvirt] qemu: Issue rtc-reset-reinjection command after guest-set-time

2014-08-18 Thread Michal Privoznik
On 18.08.2014 17:28, Eric Blake wrote: On 08/14/2014 02:24 AM, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1103245 An advice appeared there on the qemu-devel list [1]. When a domain is suspended and then resumed guest kernel is not aware of this. So we've intro

  1   2   3   4   5   6   7   8   9   10   >