Re: [PATCH 1/6] util: introduce a parser for kernel cmdline arguments

2020-05-28 Thread Paulo de Rezende Pinatti
On 15/05/20 16:19, Erik Skultety wrote: On Mon, May 11, 2020 at 06:41:56PM +0200, Boris Fiuczynski wrote: From: Paulo de Rezende Pinatti Introduce two utility functions to parse a kernel command line string according to the kernel code parsing rules in order to enable the caller to perform

[PATCH v2 4/7] tools: secure guest check on s390 in virt-host-validate

2020-05-29 Thread Paulo de Rezende Pinatti
From: Boris Fiuczynski Add checking in virt-host-validate for secure guest support on s390 for IBM Secure Execution. Signed-off-by: Boris Fiuczynski Tested-by: Viktor Mihajlovski Reviewed-by: Paulo de Rezende Pinatti Reviewed-by: Bjoern Walk --- tools/virt-host-validate-common.c | 58

[PATCH v2 2/7] qemu: check if s390 secure guest support is enabled

2020-05-29 Thread Paulo de Rezende Pinatti
in the cache then libvirt will re-build it in order to pick up the new set of capabilities available. Signed-off-by: Paulo de Rezende Pinatti Signed-off-by: Boris Fiuczynski Tested-by: Viktor Mihajlovski Reviewed-by: Bjoern Walk --- src/qemu/qemu_capabilities.c | 56

[PATCH v2 5/7] tools: secure guest check for AMD in virt-host-validate

2020-05-29 Thread Paulo de Rezende Pinatti
From: Boris Fiuczynski Add checking in virt-host-validate for secure guest support on x86 for AMD Secure Encrypted Virtualization. Signed-off-by: Boris Fiuczynski Reviewed-by: Paulo de Rezende Pinatti Reviewed-by: Bjoern Walk --- tools/virt-host-validate-common.c | 29

[PATCH v2 1/7] util: introduce a parser for kernel cmdline arguments

2020-05-29 Thread Paulo de Rezende Pinatti
Introduce two utility functions to parse a kernel command line string according to the kernel code parsing rules in order to enable the caller to perform operations such as verifying whether certain argument=value combinations are present or retrieving an argument's value. Signed-off-by: Paulo de

[PATCH v2 7/7] docs: Describe protected virtualization guest setup

2020-05-29 Thread Paulo de Rezende Pinatti
Fiuczynski Reviewed-by: Paulo de Rezende Pinatti --- docs/kbase.html.in | 3 + docs/kbase/s390_protected_virt.rst | 189 + 2 files changed, 192 insertions(+) create mode 100644 docs/kbase/s390_protected_virt.rst diff --git a/docs/kbase.html.in b/docs

[PATCH v2 3/7] qemu: check if AMD secure guest support is enabled

2020-05-29 Thread Paulo de Rezende Pinatti
': meaning SEV is enabled in the host kernel; - checking if /dev/sev exists Signed-off-by: Paulo de Rezende Pinatti Signed-off-by: Boris Fiuczynski Reviewed-by: Bjoern Walk --- src/qemu/qemu_capabilities.c | 20 1 file changed, 20 insertions(+) diff --git a/src/qemu

[PATCH v2 6/7] docs: update AMD launch secure description

2020-05-29 Thread Paulo de Rezende Pinatti
From: Boris Fiuczynski Update document with changes in qemu capability caching and the added secure guest support checking for AMD SEV in virt-host-validate. Signed-off-by: Boris Fiuczynski --- docs/kbase/launch_security_sev.rst | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-)

[PATCH v2 0/7] Add Security Guest doc and check for capabilities cache validation

2020-05-29 Thread Paulo de Rezende Pinatti
host-validate docs: update AMD launch secure description Paulo de Rezende Pinatti (3): util: introduce a parser for kernel cmdline arguments qemu: check if s390 secure guest support is enabled qemu: check if AMD secure guest support is enabled Viktor Mihajlovski (1): docs: Describe protected

Re: [PATCH] qemu: do not add model when actual iface type is hostdev

2020-06-17 Thread Paulo de Rezende Pinatti
On 17/06/20 06:01, Laine Stump wrote: On 6/16/20 10:32 AM, Paulo de Rezende Pinatti wrote: No default model should be added to the interface entry at post parse when its actual network type is hostdev as doing so might cause a mismatch between the interface definition and its actual device

Re: [PATCH] qemu: auto-assign hostdev interface devices to PCIe

2020-06-18 Thread Paulo de Rezende Pinatti
Flags; } -- Best regards, Paulo de Rezende Pinatti

Re: [PATCH] qemu: do not add model when actual iface type is hostdev

2020-06-16 Thread Paulo de Rezende Pinatti
Sorry, forgot to include my signed-off-by, so: On 16/06/20 16:32, Paulo de Rezende Pinatti wrote: No default model should be added to the interface entry at post parse when its actual network type is hostdev as doing so might cause a mismatch between the interface definition and its actual

[PATCH] qemu: do not add model when actual iface type is hostdev

2020-06-16 Thread Paulo de Rezende Pinatti
No default model should be added to the interface entry at post parse when its actual network type is hostdev as doing so might cause a mismatch between the interface definition and its actual device type. --- src/qemu/qemu_domain.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v3 2/7] qemu: check if s390 secure guest support is enabled

2020-06-15 Thread Paulo de Rezende Pinatti
in the cache then libvirt will re-build it in order to pick up the new set of capabilities available. Signed-off-by: Paulo de Rezende Pinatti Signed-off-by: Boris Fiuczynski Tested-by: Viktor Mihajlovski Reviewed-by: Bjoern Walk --- src/qemu/qemu_capabilities.c | 56

[PATCH v3 6/7] docs: update AMD launch secure description

2020-06-15 Thread Paulo de Rezende Pinatti
From: Boris Fiuczynski Update document with changes in qemu capability caching and the added secure guest support checking for AMD SEV in virt-host-validate. Signed-off-by: Boris Fiuczynski Reviewed-by: Erik Skultety --- docs/kbase/launch_security_sev.rst | 9 ++--- 1 file changed, 6

[PATCH v3 1/7] util: introduce a parser for kernel cmdline arguments

2020-06-15 Thread Paulo de Rezende Pinatti
Introduce two utility functions to parse a kernel command line string according to the kernel code parsing rules in order to enable the caller to perform operations such as verifying whether certain argument=value combinations are present or retrieving an argument's value. Signed-off-by: Paulo de

[PATCH v3 4/7] tools: secure guest check on s390 in virt-host-validate

2020-06-15 Thread Paulo de Rezende Pinatti
From: Boris Fiuczynski Add checking in virt-host-validate for secure guest support on s390 for IBM Secure Execution. Signed-off-by: Boris Fiuczynski Tested-by: Viktor Mihajlovski Reviewed-by: Paulo de Rezende Pinatti Reviewed-by: Bjoern Walk Reviewed-by: Erik Skultety --- tools/virt-host

[PATCH v3 0/7] Add Security Guest doc and check for capabilities cache validation

2020-06-15 Thread Paulo de Rezende Pinatti
): tools: secure guest check on s390 in virt-host-validate tools: secure guest check for AMD in virt-host-validate docs: update AMD launch secure description Paulo de Rezende Pinatti (3): util: introduce a parser for kernel cmdline arguments qemu: check if s390 secure guest support

[PATCH v3 3/7] qemu: check if AMD secure guest support is enabled

2020-06-15 Thread Paulo de Rezende Pinatti
': meaning SEV is enabled in the host kernel; - checking if /dev/sev exists Signed-off-by: Paulo de Rezende Pinatti Signed-off-by: Boris Fiuczynski Reviewed-by: Bjoern Walk Reviewed-by: Erik Skultety --- src/qemu/qemu_capabilities.c | 20 1 file changed, 20 insertions(+) diff

[PATCH v3 7/7] docs: Describe protected virtualization guest setup

2020-06-15 Thread Paulo de Rezende Pinatti
Fiuczynski Reviewed-by: Paulo de Rezende Pinatti Reviewed-by: Erik Skultety --- docs/kbase.html.in | 3 + docs/kbase/s390_protected_virt.rst | 189 + 2 files changed, 192 insertions(+) create mode 100644 docs/kbase/s390_protected_virt.rst diff --git

[PATCH v3 5/7] tools: secure guest check for AMD in virt-host-validate

2020-06-15 Thread Paulo de Rezende Pinatti
From: Boris Fiuczynski Add checking in virt-host-validate for secure guest support on x86 for AMD Secure Encrypted Virtualization. Signed-off-by: Boris Fiuczynski Reviewed-by: Paulo de Rezende Pinatti Reviewed-by: Bjoern Walk Reviewed-by: Erik Skultety --- tools/virt-host-validate-common.c

Re: [PATCH v3 1/7] util: introduce a parser for kernel cmdline arguments

2020-06-15 Thread Paulo de Rezende Pinatti
On 15/06/20 17:46, Erik Skultety wrote: On Mon, Jun 15, 2020 at 04:49:10PM +0200, Paulo de Rezende Pinatti wrote: On 15/06/20 16:16, Erik Skultety wrote: On Mon, Jun 15, 2020 at 10:28:06AM +0200, Paulo de Rezende Pinatti wrote: Introduce two utility functions to parse a kernel command

Re: [PATCH v3 1/7] util: introduce a parser for kernel cmdline arguments

2020-06-15 Thread Paulo de Rezende Pinatti
On 15/06/20 16:16, Erik Skultety wrote: On Mon, Jun 15, 2020 at 10:28:06AM +0200, Paulo de Rezende Pinatti wrote: Introduce two utility functions to parse a kernel command line string according to the kernel code parsing rules in order to enable the caller to perform operations

Re: [PATCH v2 1/7] util: introduce a parser for kernel cmdline arguments

2020-06-10 Thread Paulo de Rezende Pinatti
On 10/06/20 15:55, Paulo de Rezende Pinatti wrote: +    { " arg3\" escaped=val2\"", "arg3\" escaped", "val2",    "" }, ^Is this even valid for the kernel itself? Looking at [1], they clearl

Re: [PATCH v2 1/7] util: introduce a parser for kernel cmdline arguments

2020-06-10 Thread Paulo de Rezende Pinatti
On 08/06/20 16:35, Erik Skultety wrote: On Fri, May 29, 2020 at 12:10:03PM +0200, Paulo de Rezende Pinatti wrote: Introduce two utility functions to parse a kernel command line string according to the kernel code parsing rules in order to enable the caller to perform operations

Re: [PATCH v2 0/7] Add Security Guest doc and check for capabilities cache validation

2020-06-08 Thread Paulo de Rezende Pinatti
Ping for reviews. On 29/05/20 12:10, Paulo de Rezende Pinatti wrote: This series introduces the concept of a 'Secure Guest' feature which covers on s390 IBM Secure Execution and on x86 AMD Secure Encrypted Virtualization. Besides adding documentation for IBM Secure Execution it also adds

Re: [PATCH v2 1/7] util: introduce a parser for kernel cmdline arguments

2020-06-12 Thread Paulo de Rezende Pinatti
On 11/06/20 10:09, Erik Skultety wrote: On Wed, Jun 10, 2020 at 03:55:14PM +0200, Paulo de Rezende Pinatti wrote: On 08/06/20 16:35, Erik Skultety wrote: On Fri, May 29, 2020 at 12:10:03PM +0200, Paulo de Rezende Pinatti wrote: Introduce two utility functions to parse a kernel command line

[PATCH] doc: fix name of file containing max number of VFs

2020-07-28 Thread Paulo de Rezende Pinatti
Signed-off-by: Paulo de Rezende Pinatti --- docs/formatnode.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatnode.html.in b/docs/formatnode.html.in index e4328fedbe..8a51c4da80 100644 --- a/docs/formatnode.html.in +++ b/docs/formatnode.html.in @@ -141,7

[RFC] Dynamic creation of VFs in a network definition containing an SRIOV device

2020-07-28 Thread Paulo de Rezende Pinatti
, Paulo de Rezende Pinatti