Re: RFC PATCH: Issue 90 (Test Clarification)

On Tue, Dec 29, 2020 at 10:11 AM Peter Krempa wrote: > Please don't post screenshots of text. It's pointlessly bloating the > mail and I can't respond inline. Please re-post all the relevant bits as > text. > Sorry about that, I didn't know what the policy on images was. Basically, we used the

[PATCH v2 2/7] util: Added nfs params to virStorageSource

Signed-off-by: Ryan Gahagan --- src/util/virstoragefile.c | 8 src/util/virstoragefile.h | 8 2 files changed, 16 insertions(+) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index 1176630282..3097e11984 100644 --- a/src/util/virstoragefile.c +++ b/src/util

[PATCH v2 3/7] docs: added rng schema and formatdomain for NFS

Signed-off-by: Ryan Gahagan --- docs/formatdomain.rst | 24 ++-- docs/schemas/domaincommon.rng | 32 2 files changed, 54 insertions(+), 2 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 1189795974

[PATCH v2 4/7] conf: Added NFS XML format/parse methods

Signed-off-by: Ryan Gahagan --- src/conf/domain_conf.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 453e06491e..96ee009058 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -6888,6

[PATCH v2 5/7] qemu: Added NFS JSON props methods

Signed-off-by: Ryan Gahagan --- src/qemu/qemu_block.c | 67 +++- src/qemu/qemu_domain.c | 70 ++ 2 files changed, 136 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c index

PATCH v2: Implement NFS Protocol

Per Issue 90[1], QEMU supports using an NFS disk but Libvirt had no support for attaching a disk of this type. This patch series adds in this capability as well as the tests necessary to make sure it works correctly. The changes in this second version over the previous patch series for this issue

[PATCH v2 6/7] util: Added a backing store NFS parser

Signed-off-by: Ryan Gahagan --- src/util/virstoragefile.c | 49 +++ tests/virstoragetest.c| 13 +++ 2 files changed, 62 insertions(+) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index 3097e11984..d67f0f2c3f 100644 --- a/src

[PATCH v2 1/7] conf: Add NFS disk protocol

Signed-off-by: Ryan Gahagan --- src/libxl/libxl_conf.c| 1 + src/libxl/xen_xl.c| 1 + src/qemu/qemu_block.c | 3 +++ src/qemu/qemu_command.c | 1 + src/qemu/qemu_domain.c| 2 ++ src/qemu/qemu_snapshot.c | 3 +++ src/util/virstoragefile.c | 6 ++ src/util

[PATCH v2 7/7] tests: Added tests for NFS disk protocol

Signed-off-by: Ryan Gahagan --- .../disk-network-nfs.x86_64-latest.args | 56 +++ tests/qemuxml2argvdata/disk-network-nfs.xml | 48 tests/qemuxml2argvtest.c | 1 + ...isk-network-nfs-inactive.x86_64-latest.xml | 54

[PATCH 12/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/virnetdevbandwidth.c Signed-off-by: Barrett Schonefeld --- src/util/virnetdevbandwidth.c | 44 --- 1 file changed, 15 insertions(+), 29 deletions(-) diff --git a/src/util/virnetdevbandwidth.c b/src/util/virnetdevbandwidth.c

[PATCH 21/30] util: remove cleanup label

From: Barrett Schonefeld - src/util/virutil.c Signed-off-by: Barrett Schonefeld --- src/util/virutil.c | 45 - 1 file changed, 16 insertions(+), 29 deletions(-) diff --git a/src/util/virutil.c b/src/util/virutil.c index d4b864d5cb..52ab6c6e6d

[PATCH 23/30] util: remove error label

From: Barrett Schonefeld - src/util/virsysinfo.c Signed-off-by: Barrett Schonefeld --- src/util/virsysinfo.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/util/virsysinfo.c b/src/util/virsysinfo.c index 36317c97eb..45a950c85a 100644 --- a/src/util/virsysinfo.c

[PATCH 09/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/virscsihost.c Signed-off-by: Barrett Schonefeld --- src/util/virscsihost.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/util/virscsihost.c b/src/util/virscsihost.c index 969cdd9f79..2ce33e4cfb 100644 ---

[PATCH 17/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/virfile.c Signed-off-by: Barrett Schonefeld --- src/util/virfile.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/util/virfile.c b/src/util/virfile.c index f57272ca2f..38207f1948 100644 --- a/src/util/virfile.c +++

[PATCH 22/30] util: remove cleanup labels

From: Barrett Schonefeld - src/util/viruri.c Signed-off-by: Barrett Schonefeld --- src/util/viruri.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/util/viruri.c b/src/util/viruri.c index 704e5b2132..d49821451e 100644 --- a/src/util/viruri.c +++ b/src/util/viruri.c

[PATCH 11/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/virresctrl.c Signed-off-by: Barrett Schonefeld --- src/util/virresctrl.c | 25 - 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c index d3087b98c1..1c2d175295 100644 ---

[PATCH 13/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/virmacmap.c Signed-off-by: Barrett Schonefeld --- src/util/virmacmap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/util/virmacmap.c b/src/util/virmacmap.c index f9047d0fb1..e68742de10 100644 --- a/src/util/virmacmap.c +++

[PATCH 18/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/virdnsmasq.c Signed-off-by: Barrett Schonefeld --- src/util/virdnsmasq.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/src/util/virdnsmasq.c b/src/util/virdnsmasq.c index 9030f9218a..5f477c976d 100644 ---

[PATCH 20/30] util: remove cleanup label

From: Barrett Schonefeld - src/util/virvhba.c Signed-off-by: Barrett Schonefeld --- src/util/virvhba.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/src/util/virvhba.c b/src/util/virvhba.c index a80145b8fd..e0a79344cc 100644 ---

[PATCH 16/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/virhostcpu.c Signed-off-by: Barrett Schonefeld --- src/util/virhostcpu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/util/virhostcpu.c b/src/util/virhostcpu.c index c531d65f86..4f6c3390ce 100644 --- a/src/util/virhostcpu.c +++

[PATCH 04/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/viruri.c Signed-off-by: Barrett Schonefeld --- src/util/viruri.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/util/viruri.c b/src/util/viruri.c index 11753a0aef..704e5b2132 100644 --- a/src/util/viruri.c +++ b/src/util/viruri.c

[PATCH 25/30] util: remove cleanup labels

From: Barrett Schonefeld - src/util/virsecret.c Signed-off-by: Barrett Schonefeld --- src/util/virsecret.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/util/virsecret.c b/src/util/virsecret.c index 78a3b41bc5..9ed803d45b 100644 ---

[PATCH 27/30] util: remove cleanup labels

From: Barrett Schonefeld - src/util/virrotatingfile.c Signed-off-by: Barrett Schonefeld --- src/util/virrotatingfile.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/util/virrotatingfile.c b/src/util/virrotatingfile.c index 6d8076e7c4..45dc66e94d 100644 ---

[PATCH 01/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/virxml.c Signed-off-by: Barrett Schonefeld --- src/util/virxml.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/util/virxml.c b/src/util/virxml.c index a3b819d85c..7df50e4b4d 100644 --- a/src/util/virxml.c +++

[PATCH 15/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/virlockspace.c Signed-off-by: Barrett Schonefeld --- src/util/virlockspace.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/util/virlockspace.c b/src/util/virlockspace.c index b90e13f506..71d5dfb83e 100644 ---

[PATCH 06/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/virstoragefilebackend.c Signed-off-by: Barrett Schonefeld --- src/util/virstoragefilebackend.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/util/virstoragefilebackend.c b/src/util/virstoragefilebackend.c index

[PATCH 30/30] util: remove cleanup labels

From: Barrett Schonefeld - src/util/virdnsmasq.c Signed-off-by: Barrett Schonefeld --- src/util/virdnsmasq.c | 46 +-- 1 file changed, 14 insertions(+), 32 deletions(-) diff --git a/src/util/virdnsmasq.c b/src/util/virdnsmasq.c index

[PATCH 26/30] util: remove cleanup labels

From: Barrett Schonefeld - src/util/virscsihost.c Signed-off-by: Barrett Schonefeld --- src/util/virscsihost.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/util/virscsihost.c b/src/util/virscsihost.c index 2ce33e4cfb..3aecb3146f 100644 ---

[PATCH 19/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/vircgroupv1.c Signed-off-by: Barrett Schonefeld --- src/util/vircgroupv1.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/util/vircgroupv1.c b/src/util/vircgroupv1.c index 731e9d61d4..984cd50409 100644 --- a/src/util/vircgroupv1.c

[PATCH 28/30] util: remove cleanup labels

From: Barrett Schonefeld - src/util/virnetdevbandwidth.c Signed-off-by: Barrett Schonefeld --- src/util/virnetdevbandwidth.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/util/virnetdevbandwidth.c b/src/util/virnetdevbandwidth.c index 364b39e3c1..e222bcd6a2

[PATCH 10/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/virrotatingfile.c Signed-off-by: Barrett Schonefeld --- src/util/virrotatingfile.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/util/virrotatingfile.c b/src/util/virrotatingfile.c index 9f1ef17c3e..6d8076e7c4 100644 ---

[PATCH 07/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/virstorageencryption.c Signed-off-by: Barrett Schonefeld --- src/util/virstorageencryption.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/util/virstorageencryption.c b/src/util/virstorageencryption.c index

[PATCH 08/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/virsecret.c Signed-off-by: Barrett Schonefeld --- src/util/virsecret.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/util/virsecret.c b/src/util/virsecret.c index 54d6bbcb7c..78a3b41bc5 100644 --- a/src/util/virsecret.c +++

[PATCH 24/30] util: remove cleanup labels

From: Barrett Schonefeld - src/util/virstorageencryption.c Signed-off-by: Barrett Schonefeld --- src/util/virstorageencryption.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/util/virstorageencryption.c b/src/util/virstorageencryption.c index

[PATCH 29/30] util: remove cleanup labels

From: Barrett Schonefeld - src/util/virlog.c Signed-off-by: Barrett Schonefeld --- src/util/virlog.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/util/virlog.c b/src/util/virlog.c index e12fd58831..2bf606b8c5 100644 --- a/src/util/virlog.c +++

[PATCH 14/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/virlog.c Signed-off-by: Barrett Schonefeld --- src/util/virlog.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/util/virlog.c b/src/util/virlog.c index 6b7a4512e9..e12fd58831 100644 --- a/src/util/virlog.c +++

[PATCH 02/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/virvhba.c Signed-off-by: Barrett Schonefeld --- src/util/virvhba.c | 35 --- 1 file changed, 12 insertions(+), 23 deletions(-) diff --git a/src/util/virvhba.c b/src/util/virvhba.c index a4e88024d1..a80145b8fd 100644 ---

[PATCH 05/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/virsysinfo.c Signed-off-by: Barrett Schonefeld --- src/util/virsysinfo.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/util/virsysinfo.c b/src/util/virsysinfo.c index 217f842a37..36317c97eb 100644 ---

[PATCH 03/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/virutil.c Signed-off-by: Barrett Schonefeld --- src/util/virutil.c | 33 ++--- 1 file changed, 10 insertions(+), 23 deletions(-) diff --git a/src/util/virutil.c b/src/util/virutil.c index a0cd0f1bcd..d4b864d5cb 100644 ---

[RFC PATCH 4/6] conf: Added NFS XML format/parse methods

Signed-off-by: Ryan Gahagan --- src/conf/domain_conf.c | 33 + 1 file changed, 33 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 23415b323c..265c7584a2 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -7844,6

[RFC PATCH 3/6] docs: added rng schema and formatdomain for NFS

Signed-off-by: Ryan Gahagan --- docs/formatdomain.rst | 1 + docs/schemas/domaincommon.rng | 38 +++ 2 files changed, 39 insertions(+) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 512939679b..40a1a3c1e2 100644 --- a/docs

RFC PATCH: Issue 90

This is a request for comments on our patch for Issue 90. We didn't add in the test yet because we've had a ton of trouble getting the testing suite to work with our new test files, so they've omitted for now. We also did not add any logic to the attach-disk method yet because we wanted to focus

[RFC PATCH 6/6] util: Added a backing store NFS parser

Signed-off-by: Ryan Gahagan --- src/util/virstoragefile.c | 42 +++ 1 file changed, 42 insertions(+) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index cff6dabd9e..098ec80542 100644 --- a/src/util/virstoragefile.c +++ b/src/util

[RFC PATCH 1/6] compatibilities: added in flags for NFS support

Signed-off-by: Ryan Gahagan --- src/libxl/libxl_conf.c| 1 + src/libxl/xen_xl.c| 1 + src/qemu/qemu_block.c | 3 +++ src/qemu/qemu_command.c | 1 + src/qemu/qemu_domain.c| 2 ++ src/qemu/qemu_snapshot.c | 3 +++ src/util/virstoragefile.c | 6 ++ src/util

[RFC PATCH 5/6] qemu: added NFS JSON props methods

Signed-off-by: Ryan Gahagan --- src/qemu/qemu_block.c | 42 +- src/qemu/qemu_domain.c | 42 ++ 2 files changed, 83 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c index

[RFC PATCH 2/6] util: Added nfs params to virStorageSource

Signed-off-by: Ryan Gahagan --- src/util/virstoragefile.c | 8 src/util/virstoragefile.h | 5 + 2 files changed, 13 insertions(+) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index 5a57e5d12d..cff6dabd9e 100644 --- a/src/util/virstoragefile.c +++ b/src/util

Re: RFC PATCH: Issue 90 (Test Clarification)

We were able to get the testing environment running after some trial-and-error. The issue was that the version of libtirpc was out of date, causing an error in meson.build when the XDR dependency was being read. By updating the libtirpc-dev package we were able to start building locally. However,

Re: RFC PATCH: Issue 90 (Test Clarification)

On Wed, Dec 23, 2020 at 11:45 AM Peter Krempa wrote: > For this test, > you'll be better off adding a hack to fill in the uid/gid values (e.g. > by checking that they start with a + to be safe. Our interpretation of what you mean here is to add a check in our parse method (specifically in

Re: RFC PATCH: Issue 90 (Test Clarification)

On Thu, Dec 17, 2020 at 8:00 AM Peter Krempa wrote: > Also note that the upstream test-suite run in the CI does actually > provide the expected output. Obviously you can't use the ENV variable to > automatically overwrite your files, but you certainly can copy out the > diffs from the CI. Just

[RFC PATCH 6/6] util: Added a backing store NFS parser

Signed-off-by: Ryan Gahagan --- src/util/virstoragefile.c | 37 + 1 file changed, 37 insertions(+) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index cff6dabd9e..341eac2eb7 100644 --- a/src/util/virstoragefile.c +++ b/src/util

[RFC PATCH 1/6] conf: Add NFS disk protocol

Signed-off-by: Ryan Gahagan --- src/libxl/libxl_conf.c| 1 + src/libxl/xen_xl.c| 1 + src/qemu/qemu_block.c | 3 +++ src/qemu/qemu_command.c | 1 + src/qemu/qemu_domain.c| 10 ++ src/qemu/qemu_snapshot.c | 3 +++ src/util/virstoragefile.c | 6 ++ src/util

[RFC PATCH 5/6] qemu: Added NFS JSON props methods

Signed-off-by: Ryan Gahagan --- src/qemu/qemu_block.c | 48 +- src/qemu/qemu_domain.c | 39 ++ 2 files changed, 86 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c index b224a550f3

[RFC PATCH 3/6] docs: added rng schema and formatdomain for NFS

Signed-off-by: Ryan Gahagan --- docs/formatdomain.rst | 11 +- docs/schemas/domaincommon.rng | 38 +++ 2 files changed, 48 insertions(+), 1 deletion(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 512939679b..23a7bca643 100644

[RFC PATCH 2/6] util: Added nfs params to virStorageSource

Signed-off-by: Ryan Gahagan --- src/util/virstoragefile.c | 8 src/util/virstoragefile.h | 5 + 2 files changed, 13 insertions(+) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index 5a57e5d12d..cff6dabd9e 100644 --- a/src/util/virstoragefile.c +++ b/src/util

RFC PATCH: Issue 90 (Test Clarification)

We addressed the feedback from our previous RFC patch for the most part. Under src/util/virstoragefile.c, we left a cast to an integer pointer that Peter mentioned because we were unable to provide a better solution. We've written some tests for our code but our testing environment is not working

[RFC PATCH 4/6] conf: Added NFS XML format/parse methods

Signed-off-by: Ryan Gahagan --- src/conf/domain_conf.c | 33 + 1 file changed, 33 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index b301ac0a08..565ca680c9 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -6888,6

Re: [RFC PATCH 5/6] qemu: added NFS JSON props methods

On Fri, Dec 11, 2020 at 3:30 AM Peter Krempa wrote: > There's also virJSONValueObjectAdd, that might come in handy given my > comment below. > > [...] > > The best bet is to actually avoid formatting the user/group members > formatting towards qemu. > > Unfortunately 0 is a very valid uid, so

Re: [RFC PATCH 6/6] util: Added a backing store NFS parser

On Fri, Dec 11, 2020 at 3:24 AM Peter Krempa wrote: > On Thu, Dec 10, 2020 at 14:00:07 -0600, Ryan Gahagan wrote: > > +virJSONValuePtr server = virJSONValueObjectGetObject(json, > "server"); > > +int gotUID = virJSONValueObjectGetNumberInt(json, "use

Re: [RFC PATCH 3/6] docs: added rng schema and formatdomain for NFS

On Thu, Dec 10, 2020 at 10:37 PM Han Han wrote: > On Fri, Dec 11, 2020 at 4:00 AM Ryan Gahagan > wrote: > >> diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst >> index 512939679b..40a1a3c1e2 100644 >> --- a/docs/formatdomain.rst >> +++ b/docs/forma

Re: [RFC PATCH 1/6] compatibilities: added in flags for NFS support

On Fri, Dec 11, 2020 at 3:35 AM Peter Krempa wrote: > In subject/summary. We don't have anything which we'd prefix with > 'compatibilities:'. Just to confirm, does this mean that we should not implement the feedback Han Han suggested about the NFS capability flags and instead leave the commit

[PATCH] util: convert char pointers to use g_autofree

From: Barrett Schonefeld additional conversions to the GLib API in src/util per issue #11. files updated are: - src/util/vircgroupv1.c - src/util/virhostcpu.c - src/util/virlockspace.c - src/util/virmacmap.c - src/util/virresctrl.c - src/util/virsysinfo.c Related issue:

Re: Libvirt Open Source Contribution

ay be able to use outside of the CONTRIBUTING.rst file? -Ryan Gahagan On Sat, Nov 7, 2020 at 12:04 PM Barrett J Schonefeld wrote: > Michal, > > We've struggled with the email system so far. You may have seen when we > submitted a chain of 65 patches when we meant to send only the la

[PATCH 3/8] Fixed code style bug for virBufferAddLit

Signed-off-by: Ryan Gahagan --- tools/virsh-domain.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 810e55fa53..5862993464 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -688,7 +688,7

[PATCH 8/8] Added new params to attach-disk docs

Signed-off-by: Ryan Gahagan --- docs/manpages/virsh.rst | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index bfd26e3120..83134ba571 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -4500,9

[PATCH 6/8] Bump - rerun CI HTTP 500 err

Signed-off-by: Ryan Gahagan --- tools/virsh-domain.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 9d00cb8b21..ae9a2b1101 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -711,7 +711,6 @@ cmdAttachDisk(vshControl *ctl, const

[PATCH 2/8] Fixed compile error where was missing

Signed-off-by: Ryan Gahagan --- tools/virsh-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 16227085cc..810e55fa53 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -707,7 +707,7 @@ cmdAttachDisk

[PATCH 7/8] Re-wrote attach-disk to support multiple hosts

Signed-off-by: Ryan Gahagan --- tools/virsh-domain.c | 70 ++-- 1 file changed, 55 insertions(+), 15 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index ae9a2b1101..64c7c454bd 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh

[PATCH 5/8] Fixed error where char** not being promoted to const

Signed-off-by: Ryan Gahagan --- tools/virsh-domain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index cda0531a37..9d00cb8b21 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -227,7 +227,7 @@ static const

[PATCH 4/8] Fixed error of writing to ROM in host_name

Signed-off-by: Ryan Gahagan --- tools/virsh-domain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 5862993464..cda0531a37 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -587,8 +587,7 @@ cmdAttachDisk

[PATCH 1/8] Added a few attach-disk parameters

Signed-off-by: Ryan Gahagan --- tools/virsh-domain.c | 76 +++- 1 file changed, 68 insertions(+), 8 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 12b35c037d..16227085cc 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh

[PATCH] Added attach-disk parameters for network disk support

be defined by providing multiple instances of --source-host-name, followed by optional transport and socket parameters. Using a single host does not require a host name. Added documentation to virsh.rst specifying usage. Signed-off-by: Ryan Gahagan --- docs/manpages/virsh.rst | 24

[PATCH] Added attach-disk parameters for network disk support

be defined by providing multiple instances of --source-host-name, followed by optional transport and socket parameters. Using a single host does not require a host name. Added documentation to virsh.rst specifying usage. Signed-off-by: Ryan Gahagan --- docs/manpages/virsh.rst | 24

[PATCH] virsh: Added attach-disk support for network disk

Related issue: https://gitlab.com/libvirt/libvirt/-/issues/16 Added in support for the following parameters in attach-disk: --source-protocol --source-host-name --source-host-socket --source-host-transport Added documentation to virsh.rst specifying usage. Signed-off-by: Ryan Gahagan --- docs

Re: [PATCH] virsh: Added attach-disk support for network disk

t; $ ./build/libvirt/gcc/tools/virsh attach-disk upstream-bj /tmp/ble vda --source-host-name test:1234 --source-protocol test --print-xml > > > > > > What specifically would you want to be changed? On Mon, Nov 16, 2020 at 6:58 AM Peter Krempa wrote: >

[PATCH] virsh: Added attach-disk support for network disk

Related issue: https://gitlab.com/libvirt/libvirt/-/issues/16 Added in support for the following parameters in attach-disk: --source-protocol --source-host-name --source-host-socket --source-host-transport Added documentation to virsh.rst specifying usage. Signed-off-by: Ryan Gahagan --- docs

[PATCH] util: convert char pointers to use g_autofree

From: Barrett Schonefeld additional conversions to the GLib API in src/util per issue #11. Related issue: https://gitlab.com/libvirt/libvirt/-/issues/11 Signed-off-by: Barrett Schonefeld --- src/util/vircgroupv1.c | 3 +- src/util/virdnsmasq.c| 43 -

[PATCH] convert char pointers to use g_autofree

From: bschoney additional conversions to the GLib API in src/util per issue #11. Please let me know if there are additional changes I should make in the files updated so far. I intend to submit work on additional files, and I want to be sure the changes so far are correct. Related issue:

[PATCH 5/5] Fixed error where char** not being promoted to const

Signed-off-by: Ryan Gahagan --- tools/virsh-domain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 8abca1b65e..10ff7175a2 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -227,7 +227,7 @@ static const

[PATCH] convert char pointers to use g_autofree

From: bschoney additional conversions to the GLib API in src/util per issue #11. Please let me know if there are additional changes I should make in the files updated so far. I intend to submit work on additional files, and I want to be sure the changes so far are correct. Related issue:

[PATCH] convert char pointers to use g_autofree

From: bschoney additional conversions to the GLib API in src/util per issue #11. Please let me know if there are additional changes I should make in the files updated so far. I intend to submit work on additional files, and I want to be sure the changes so far are correct. Related issue:

Re: [PATCH 6/7] util: Added a backing store NFS parser

On Mon, Jan 4, 2021 at 8:41 AM Peter Krempa wrote: > On Tue, Dec 29, 2020 at 15:21:28 -0600, Ryan Gahagan wrote: > > +src->nfs_uid = (uid_t) uidStore; > > +src->nfs_gid = (gid_t) gidStore; > > This function must not fill in runtime data, just configu

Re: [PATCH 3/7] docs: added rng schema and formatdomain for NFS

On Mon, Jan 4, 2021 at 8:24 AM Peter Krempa wrote: > On Tue, Dec 29, 2020 at 15:21:25 -0600, Ryan Gahagan wrote: > > + > > + > > + > > + > > + > > +nfs > > + > > + > > +

[PATCH 3/7] docs: added rng schema and formatdomain for NFS

Signed-off-by: Ryan Gahagan --- docs/formatdomain.rst | 11 +- docs/schemas/domaincommon.rng | 38 +++ 2 files changed, 48 insertions(+), 1 deletion(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 512939679b..23a7bca643 100644

[PATCH 4/7] conf: Added NFS XML format/parse methods

Signed-off-by: Ryan Gahagan --- src/conf/domain_conf.c | 33 + 1 file changed, 33 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index b301ac0a08..565ca680c9 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -6888,6

[PATCH 5/7] qemu: Added NFS JSON props methods

Signed-off-by: Ryan Gahagan --- src/qemu/qemu_block.c | 79 +- src/qemu/qemu_domain.c | 47 + 2 files changed, 125 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c index b224a550f3

[PATCH 2/7] util: Added nfs params to virStorageSource

Signed-off-by: Ryan Gahagan --- src/util/virstoragefile.c | 8 src/util/virstoragefile.h | 5 + 2 files changed, 13 insertions(+) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index 103dade0e7..b5a5f267b9 100644 --- a/src/util/virstoragefile.c +++ b/src/util

[PATCH 6/7] util: Added a backing store NFS parser

Signed-off-by: Ryan Gahagan --- src/util/virstoragefile.c | 51 +++ 1 file changed, 51 insertions(+) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index b5a5f267b9..ee8e31ce58 100644 --- a/src/util/virstoragefile.c +++ b/src/util

[PATCH 7/7] tests: Added tests for NFS disk protocol

Signed-off-by: Ryan Gahagan --- tests/qemuxml2argvdata/disk-network-nfs.args | 1 + .../disk-network-nfs.x86_64-latest.args | 56 +++ tests/qemuxml2argvdata/disk-network-nfs.xml | 48 tests/qemuxml2argvtest.c | 1 + ...isk-network

[PATCH 1/7] conf: Add NFS disk protocol

Per Issue 90, Libvirt does not support attaching an NFS disk even though QEMU has added support for it. This series of patches seeks to implement this support in Libvirt and begins by adding in flags for an NFS disk. Signed-off-by: Ryan Gahagan --- src/libxl/libxl_conf.c| 1 + src/libxl