Re: [libvirt] Entering freeze for libvirt-1.0.3

for the next release. -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des Aufsichtsrats: Martin Jetter Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294 -- libvir

Re: [libvirt] Entering freeze for libvirt-1.0.3

freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des Aufsichtsrats: Martin Jetter Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294 -- libvir-list mailing list libvir-list

[libvirt] [PATCH] qemu: virConnectGetVersion returns bogus value

The unitialized local variable qemuVersion can cause an random value to be returned for the hypervisor version, observable with virsh version. Introduced by commit b46f7f4a0b96c2d2d01d64d960bd7bc90dc16b0c Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- src/qemu/qemu_driver.c

[libvirt] [PATCHv4 1/5] S390: Documentation for CCW address type

virtio devices on the CCW bus. Here we add the new machine type and the new device address to the schema definition and add a new paragraph to the domain XML documentation. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- V2 Changes - replace single devno attribute with cssid, ssid

[libvirt] [PATCHv4 2/5] S390: domain_conf support for CCW

Add necessary handling code for the new s390 CCW address type to virDomainDeviceInfo. Further, introduce memory management, XML parsing, output formatting and range validation for the new virDomainDeviceCCWAddress type. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- V2 Changes

[libvirt] [PATCHv4 3/5] S390: QEMU driver support for CCW addresses

type of s390-ccw-virtio requires a few extra checks for machine type in qemu_command.c on top of querying QEMU_CAPS_VIRTIO_{CCW|S390}. The majority of the new functions deals with CCW address generation and management. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- V2 Changes

[libvirt] [PATCHv4 5/5] S390: Testcases for virtio-ccw machines

This adds and corrects testcases for virtio devices on s390 guests. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- V2 Changes - adapt the testcase XML files to use the new attributes - use different variations for the values: hex, decimal, leading zeroes... V3 Changes - add

[libvirt] [PATCHv4 0/5] S390: Support for native CCW bus

. Joret (1): S390: Add hotplug support for s390 virtio devices Viktor Mihajlovski (4): S390: Documentation for CCW address type S390: domain_conf support for CCW S390: QEMU driver support for CCW addresses S390: Testcases for virtio-ccw machines docs/formatdomain.html.in

[libvirt] [PATCHv4 4/5] S390: Add hotplug support for s390 virtio devices

this to libvirt too. Since the virtio hotplug isn't limited to PCI anymore, we change the function names from xxxPCIyyy to xxxVirtioyyy, where we handle all three virtio bus types. Signed-off-by: J.B. Joret j...@linux.vnet.ibm.com Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- V2

Re: [libvirt] [PATCHv4 2/5] S390: domain_conf support for CCW

the QEMU driver will assign the address. -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des Aufsichtsrats: Martin Jetter Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart

Re: [libvirt] [PATCH 1/1] Set legacy USB option with default for ppc64.

. in virQEMUCapsInitQMP, which might be conceptually cleaner. Maybe a libvirt committer wants to comment... -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk Wittkopp Sitz

[libvirt] Race/broken mutex when closing a connection

Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294 -- libvir-list mailing list libvir-list

Re: [libvirt] Race/broken mutex when closing a connection

On 03/12/2013 06:15 PM, Viktor Mihajlovski wrote: At the same time the event loop will call remoteClientCloseFunc which waits for the mutex while the connection is unrefed. It will obtain the (now invalid but non-error checking) mutex, copy the closeCallback pointer (shorty before the connection

Re: [libvirt] [PATCHv4 3/5] S390: QEMU driver support for CCW addresses

field is zero-padded. I'll push this, along with the other ACK'd patches in the series, shortly. Thanks for the review, cleanup and pushing. -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des Aufsichtsrats: Martina

[libvirt] [PATCH] remote: Prevent race when closing a connection

on the freed connection object. This could be fixed using an error checking mutex which however has a much broader scope and impact. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- src/datatypes.c|8 +++- src/remote/remote_driver.c |3 ++- 2 files changed, 9

[libvirt] [PATCH 0/3] Enable virtio-scsi and virtio-rng for s390

Early QEMU versions did not support virtio-scsi or virtio-rng for s390 machines. This series enables libvirt to exploit the capabilities provided by newer QEMUs. Viktor Mihajlovski (3): qemu: rename virtio-scsi capability S390: Enable virtio-scsi and virtio-rng S390: Testcases for virtio

[libvirt] [PATCH 3/3] S390: Testcases for virtio-scsi and virtio-rng

Adding test cases for virtio-scsi and virtio-rng. Since ccw is covering the superset of the s390 bus handling, these are deemed to be sufficient. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- .../qemuxml2argv-disk-virtio-scsi-ccw.args |9 ++ .../qemuxml2argv

[libvirt] [PATCH 2/3] S390: Enable virtio-scsi and virtio-rng

Newer versions of QEMU support virtio-scsi and virtio-rng devices on the virtio-s390 and ccw busses. Adding capability detecion, address assignment and command line generation for that. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- src/qemu/qemu_capabilities.c |4

[libvirt] [PATCH 1/3] qemu: rename virtio-scsi capability

QEMU_CAPS_VIRTIO_SCSI_PCI implies that virtio-scsi is only supported for the PCI bus, which is not the case. Remove the _PCI suffix. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- src/qemu/qemu_capabilities.c |4 ++-- src/qemu/qemu_capabilities.h |2 +- src/qemu

[libvirt] [PATCHv2 1/2] S390: Enable virtio-scsi and virtio-rng

. Adding capability detection, address assignment and command line generation for virtio-scsi and virtio-rng. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- V2 Changes - Add virtio-scsi capability for non-PCI busses. - Check for both capabilities in qemuSetScsiControllerModel

[libvirt] [PATCHv2 2/2] S390: Testcases for virtio-scsi and virtio-rng

Adding test cases for virtio-scsi and virtio-rng. Since ccw is covering the superset of the s390 bus handling, these are deemed to be sufficient. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- .../qemuxml2argv-disk-virtio-scsi-ccw.args |9 ++ .../qemuxml2argv

[libvirt] [PATCHv2 0/2] Enable virtio-scsi and virtio-rng for s390

generic virtio-scsi capability for non-pci busses Viktor Mihajlovski (2): S390: Enable virtio-scsi and virtio-rng S390: Testcases for virtio-scsi and virtio-rng src/qemu/qemu_capabilities.c |7 - src/qemu/qemu_capabilities.h |1 + src/qemu

Re: [libvirt] [PATCHv2 1/2] S390: Enable virtio-scsi and virtio-rng

understood that this was technically feasible, however found it strange to use virtio-scsi-pci in a, say CCW context. If you think that this is only a minor quirk we can go that way. Just let me know ... it's only a stroke of the pen :-). -- Mit freundlichen Grüßen/Kind Regards Viktor

Re: [libvirt] [PATCHv2 1/2] S390: Enable virtio-scsi and virtio-rng

On 03/14/2013 06:56 PM, Eric Blake wrote: s|virtio-scsi-pci;| /* the -pci suffix is a back-compat historical wart */| don't tempt me use *that* wording ... but, yes I am convinced by now -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development

[libvirt] [PATCHv3 0/3] Enable virtio-scsi and virtio-rng for s390

... V2 Changes: - Dropped 1/3, the rename of virtio-scsi-pci capability, we will keep it for compatibility reasons. - Add a new generic virtio-scsi capability for non-pci busses V3 Changes - Reverting to three patches with rename of enum symbol only Viktor Mihajlovski (3): qemu: Rename virtio

[libvirt] [PATCHv3 2/3] S390: Enable virtio-scsi and virtio-rng

Newer versions of QEMU support virtio-scsi and virtio-rng devices on the virtio-s390 and ccw busses. Adding capability detecion, address assignment and command line generation for that. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- src/qemu/qemu_capabilities.c |4

[libvirt] [PATCHv3 3/3] S390: Testcases for virtio-scsi and virtio-rng

Adding test cases for virtio-scsi and virtio-rng. Since ccw is covering the superset of the s390 bus handling, these are deemed to be sufficient. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- .../qemuxml2argv-disk-virtio-scsi-ccw.args |9 ++ .../qemuxml2argv

[libvirt] [PATCHv3 1/3] qemu: Rename virtio-scsi capability

QEMU_CAPS_VIRTIO_SCSI_PCI implies that virtio-scsi is only supported for the PCI bus, which is not the case. Remove the _PCI suffix. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- V3 Changes - Rename only the enum symbol, not the string reptresentation src/qemu

Re: [libvirt] [PATCH] remote: Prevent race when closing a connection

the freeing callback is invoked, i.e. within the lock. Waiting for Dan's comments... -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen

Re: [libvirt] [PATCHv3 3/3] S390: Testcases for virtio-scsi and virtio-rng

On 03/14/2013 11:05 PM, Eric Blake wrote: ACK, and pushed. Big thanks, again. -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft

Re: [libvirt] [PATCH] remote: Prevent race when closing a connection

Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com

[libvirt] [PATCH 2/3] remote: Don't call NULL closeFreeCallback

Check function pointer before calling. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- src/remote/remote_driver.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 3721af9..885120e 100644

[libvirt] [PATCH 1/3] libvirt: Increase connection reference count for callbacks

By adjusting the reference count of the connection object we prevent races between callback function and virConnectClose. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- src/libvirt.c |5 + 1 file changed, 5 insertions(+) diff --git a/src/libvirt.c b/src/libvirt.c

[libvirt] [PATCH 0/3] Fix virsh race and coredump

. The last one tries to ensure that we don't leak connection references. Viktor Mihajlovski (3): libvirt: Increase connection reference count for callbacks remote: Don't call NULL closeFreeCallback virsh: Unregister the connection close notifier upon termination src/libvirt.c |5

[libvirt] [PATCH 0/3 RESENT] Fix virsh race and coredump

disposal. The second patch prevents the invocation of a NULL callback. The last one tries to ensure that we don't leak connection references in virsh. Viktor Mihajlovski (3): libvirt: Increase connection reference count for callbacks remote: Don't call NULL closeFreeCallback virsh: Unregister

[libvirt] [PATCH 2/3] remote: Don't call NULL closeFreeCallback

Check function pointer before calling. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- src/remote/remote_driver.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 3721af9..885120e 100644

[libvirt] [PATCH 1/3] libvirt: Increase connection reference count for callbacks

By adjusting the reference count of the connection object we prevent races between callback function and virConnectClose. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- src/libvirt.c |5 + 1 file changed, 5 insertions(+) diff --git a/src/libvirt.c b/src/libvirt.c

[libvirt] [PATCH 3/3] virsh: Unregister the connection close notifier upon termination

-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- tools/virsh.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index b574d7e..3c0b398 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -311,6 +311,8 @@ vshCatchDisconnect

Re: [libvirt] [PATCHv2 4/4] virsh: Register and unregister the close callback also in cmdConnect

deletions(-) Hi Peter, I see a bunch of errors running make check with this patch applied (at least in conjunction with my patches). Mostly: error: Failed to disconnect from the hypervisor, 1 leaked reference(s) -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland

Re: [libvirt] [PATCHv2 4/4] virsh: Register and unregister the close callback also in cmdConnect

, as the refcount isn't incremented in the register callback. It seems that there are quite a lot situations where virsh exits without unregistering the callback. Please apply 1/3 (which is actually the essential patch of the series) to see it happen. -- Mit freundlichen Grüßen/Kind Regards Viktor

Re: [libvirt] [PATCHv2 4/4] virsh: Register and unregister the close callback also in cmdConnect

by our mail gateway which delivered the 1/4 and 2/4 messages without the [libvirt] subject prefix. So I ended up seeing only 3/4 and 4/4 in my libvir-list folder. Argh... With everything applied itlooks and works great. From my side a +1. -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski

Re: [libvirt] [PATCH v5.1 04/11] qemu: Record the default NIC model in the domain XML

))) +goto no_memory; } /* set default disk types and drivers */ -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen

Re: [libvirt] [PATCH 00/18] Re-arrange the way cgroups are setup

get rid of the emulator directory altogether? -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht

Re: [libvirt] [PATCH 00/18] Re-arrange the way cgroups are setup

to the vcpuN directories, not a parent of them. probably not for vcpuN (since we set them explicitly) but maybe for a future third kind of processes/threads, so I agree. -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des Aufsichtsrats

Re: [libvirt] [RFC] Per machine type qemu capability detection

-February/msg00537.html and Dan's concerns with that approach. In a better world the QMP interface might allow to query per machine type (one can always dream...) -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des

Re: [libvirt] [PATCH v5.1 04/11] qemu: Record the default NIC model in the domain XML

on the model being NULL. So your patch is indeed causing a regression. We can fix this before the next release though. No need for a V5.1.1 ;-) -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz

Re: [libvirt] [PATCH 1/3] qemu: Use correct default model on s390

: the NULL assignment above is useless. I assume you will need a third pair of eyes? -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft

Re: [libvirt] [PATCH 2/3] qemu: Clean up network device CLI generator

Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294 -- libvir-list mailing list libvir-list@redhat.com https

Re: [libvirt] [PATCH 3/3] qemu: Remove now obsolete assignment of default netwokr card model for s390 hosts

]-info.type = type; [Unauthoritative] ACK -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart

Re: [libvirt] [PATCH 3/3] qemu: Remove now obsolete assignment of default netwokr card model for s390 hosts

Oops: typo in the subject line s/netwokr/network/ -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht

Re: [libvirt] [PATCHv2] qemu: Use correct default model on s390

On 04/05/2013 03:16 PM, Peter Krempa wrote: From: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com Commit a68d6726679323823ee5be47f0144e9ccffa0757 breaks networking on s390 as it changes the default network card model. --- src/qemu/qemu_domain.c | 16 +++- 1 file changed, 11

Re: [libvirt] [PATCHv3 0/6] Fix memory corruption/crash in the connection close callback

. virsh: Move cmdConnect from virsh-host.c to virsh.c virsh: Register and unregister the close callback also in cmdConnect rpc: Fix connection close callback race condition and memory corruption/crash Viktor Mihajlovski (2): libvirt: Increase connection reference count

Re: [libvirt] [PATCH 1/2] conf: Fix race between looking up a domain object and freeing it

); virObjectUnlock(doms); } +1, small fix big impact... -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen

[libvirt] [PATCH] qemu: Enable the capability bit for -no-kvm-pit-reinjection on x86 only

bound capabilities initialization function. Signed-off-by: Boris Fiuczynski fiu...@linux.vnet.ibm.com Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- src/qemu/qemu_capabilities.c | 55 -- 1 file changed, 37 insertions(+), 18 deletions

[libvirt] [PATCH] rpc: message related sizes enlarged

(e.g. maximum string size, message size, etc.) to handle larger system configurations used on s390x platform. Signed-off-by: Daniel Hansel daniel.han...@linux.vnet.ibm.com Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- src/remote/remote_protocol.x |6 +++--- src/rpc

Re: [libvirt] [PATCH] rpc: message related sizes enlarged

On 04/22/2013 04:34 PM, Daniel P. Berrange wrote: On Mon, Apr 22, 2013 at 04:22:26PM +0200, Viktor Mihajlovski wrote: I'm not against this in general, but before we enlarge this so much there needs to be some code work to make RPC message encoding more efficient. Currently

[libvirt] [PATCHv2] rpc: message related sizes enlarged

to 16MB if the payload data is larger). Signed-off-by: Daniel Hansel daniel.han...@linux.vnet.ibm.com Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- src/libvirt.c|4 src/remote/remote_protocol.x |6 +++--- src/rpc/virnetmessage.c | 46

Re: [libvirt] Entering freeze for libvirt-1.0.5

freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294 -- libvir-list mailing list libvir

Re: [libvirt] Entering freeze for libvirt-1.0.5

the workaround adding a fake PCI root. Will get you posted. If that works it will give us time to come up with a cleaner solution for the next release. I don't want to unconditionally disable PCI for s390 even if it is not implemented in today's QEMUs. Jan -- Mit freundlichen Grüßen/Kind Regards Viktor

[libvirt] [PATCH] S390: Add fake PCI root

For the time being add a PCI root for s390 to avoid getting issues later on with PCI address checking. I don't want to unconditionally switch off PCI for s390. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- src/qemu/qemu_domain.c |2 ++ 1 file changed, 2 insertions

Re: [libvirt] Entering freeze for libvirt-1.0.5

) Disregard that, it would get added there anyway. I'll do my best to post a patch today Jan. Please check out the patch I just sent. It works for me and should be good enough until we find a better way to disable the implicit USB-PCI device creation. -- Mit freundlichen Grüßen/Kind Regards Viktor

Re: [libvirt] [PATCH] S390: Add fake PCI root

On 04/26/2013 04:57 PM, Eric Blake wrote: +case VIR_ARCH_S390X: ACK - this is a sane workaround while trying to get a better fix. Will push soon. Thanks! -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des

Re: [libvirt] Entering freeze for libvirt-1.0.5

us a while, but eventually we need to get rid of the implicit devices where they are not applicable. Thanks again for fixing the issues. -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz

[libvirt] [PATCH 0/2] Get rid of default USB controller on S390

the USB controller (including it's bogus PCI address) if the source XML has no usb controller element. Explicitly set addresses are still honored. Viktor Mihajlovski (2): S390: Mention changed USB behavior S390: Do not generate a default USB controller docs/formatdomain.html.in

[libvirt] [PATCH 1/2] S390: Mention changed USB behavior

Add a line saying that no USB controllers are generated by default on s390. --- docs/formatdomain.html.in |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index f325c3c..8870e46 100644 --- a/docs/formatdomain.html.in

[libvirt] [PATCH 2/2] S390: Do not generate a default USB controller

-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- src/qemu/qemu_domain.c |8 .../qemuxml2argv-console-sclp.args |2 +- .../qemuxml2argv-console-virtio-ccw.args |2 +- .../qemuxml2argv-console-virtio-s390.args

[libvirt] [PATCHv3] rpc: message related sizes enlarged

to 16MB if the payload data is larger). Signed-off-by: Daniel Hansel daniel.han...@linux.vnet.ibm.com Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- V2 Changes - switch to dynamical allocation of RPC message buffers - mention upstream version in libvirt.c V3 Changes - update

[libvirt] [PATCH RESENT] qemu: Enable the capability bit for -no-kvm-pit-reinjection on x86 only

bound capabilities initialization function. Signed-off-by: Boris Fiuczynski fiu...@linux.vnet.ibm.com Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- src/qemu/qemu_capabilities.c | 59 -- 1 file changed, 39 insertions(+), 20 deletions

Re: [libvirt] [PATCHv3] rpc: message related sizes enlarged

On 05/07/2013 02:14 PM, Michal Privoznik wrote: ACK. Now is the best time to push this so we have as much time for testing as possible. So I've pushed this as well. Michal Right, a couple of weeks should suffice. Thanks! -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM

[libvirt] [PATCH] qemu: Fix crash in migration of graphics-less guests.

. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- src/qemu/qemu_migration.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index e38d99b..e10127d 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu

[libvirt] [PATCH] test: fix VPATH fchosttest failure

Running make check in a VPATH configured build directory fails in fchosttest as the test data files are searched for relative to the current working directory. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- This may become obsolete with Osier's pending patches, but it helps

Re: [libvirt] [PATCH 2/7] qemu: Abstract code for memory controller setting into a helper

this commit. -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294 -- libvir-list

[libvirt] [PATCH] cgroups: Do not enforce nonexistent controllers

ever be needed, more work will have to be done. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- src/util/vircgroup.c |8 tests/vircgrouptest.c |4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c

Re: [libvirt] [PATCH] cgroups: Do not enforce nonexistent controllers

On 05/24/2013 12:20 PM, Michal Privoznik wrote: ACKed and pushed. Michal Thanks, glad it made it before freeze -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung

[libvirt] [PATCH] spec: Build vbox packages only for x86 architectures

Commit 6ab6bc19f03513fd87d29ecfd405bb7f4a7de114 has introduced separate daemon/driver packages for vbox. These should only be built for x86 architectures which is done hereby. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- libvirt.spec.in |5 + 1 file changed, 5

Re: [libvirt] [PATCH] libvirt supports Guest Panicked

) 0) goto error; see above, it's not good to change defaults, plus make check fails with this hunk applied. Other than that looks good to me (Tested on s390x with destroy, reboot and preserve). Looking forward to see this in libvirt. -- Mit freundlichen Grüßen/Kind Regards Viktor

Re: [libvirt] [PATCH] libvirt supports Guest Panicked

I would expect crashed (guest panicked). Either QEMU is reporting a bogus state or the state computation is flawed somewhere... -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz

Re: [libvirt] Entering freeze for libvirt-1.0.6

. thanks in advance, Daniel Basic tests on s390 show no problems so far. -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen

Re: [libvirt] [PATCH v3 0/3] libvirt supports Guest panicked

/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294 -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH v3] conf: Generate address for scsi host device automatically

: note: 'next_unit' was declared here It seems that the older compiler is not smart enough to grasp the tie between 'found' and 'next_unit'... + +return 0; +} -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des

Re: [libvirt] [PATCH v3] conf: Generate address for scsi host device automatically

On 06/03/2013 04:29 PM, Osier Yang wrote: fixed by Jirka with 4db39e3fee6 the post somehow went past me, sorry... :$ -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung

[libvirt] [RFC] conf: Order of AddImplicitControllers and DomainDefPostParse

-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- src/conf/domain_conf.c |8 .../qemuxml2xmlout-balloon-device-auto.xml |2 +- .../qemuxml2xmlout-channel-virtio-auto.xml |2 +- .../qemuxml2xmlout-console-virtio.xml

[libvirt] [PATCHv2 2/2] conf: Swap order of AddImplicitControllers and DomainDefPostParse

. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- src/conf/domain_conf.c |8 .../qemuxml2xmlout-balloon-device-auto.xml |2 +- .../qemuxml2xmlout-channel-virtio-auto.xml |2 +- .../qemuxml2xmlout-console-virtio.xml

[libvirt] [PATCHv2 1/2] S390: Testcase for console default target type (virtio)

element is generated too. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- .../qemuxml2argv-s390-defaultconsole.xml | 20 .../qemuxml2xmlout-s390-defaultconsole.xml | 24 tests/qemuxml2xmltest.c

[libvirt] [PATCHv2 0/2] Swap order of AddImplicitControllers and DomainDefPostParse

to Patch Series - Added an qemuxml2xml testcase highlighting the issue: applying the first patch only will fail make check as the implicit controller is missing. Viktor Mihajlovski (2): S390: Testcase for console default target type (virtio) conf: Swap order of AddImplicitControllers

[libvirt] [PATCH] build: Fix VPATH build for access/*

VPATH build failed for the generated access driver files. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- src/Makefile.am | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index e6b1927..4cf999d

Re: [libvirt] [PATCHv2 0/2] Swap order of AddImplicitControllers and DomainDefPostParse

On 06/28/2013 09:56 AM, Ján Tomko wrote: ACK to both. Now pushed. Jan Thanks! -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft

Re: [libvirt] [PATCH] build: Fix VPATH build for access/*

On 06/28/2013 12:46 PM, Jiri Denemark wrote: On Thu, Jun 27, 2013 at 18:24:16 +0200, Viktor Mihajlovski wrote: VPATH build failed for the generated access driver files. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- src/Makefile.am | 23 +-- 1 file

[libvirt] [PATCH] qemu: add macvlan delete to qemuDomainAttachNetDevice cleanup

...@linux.vnet.ibm.com Reviewed-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- src/qemu/qemu_hotplug.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 46875ad..c6045a0 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src

[libvirt] [PATCH] scsi: Fix construction of sysfs device path

The device bus value was used instead of the device target when building the sysfs device path. Trivial. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- Should probably go into the 1.0.6 maintenance branch as well. src/util/virscsi.c |2 +- 1 file changed, 1 insertion

[libvirt] [RFC PATCH] qemu: Shorten SCSI hostdev alias to avoid QEMU failure

) scheme. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- Actually this is highlighting a larger issue. Apparently QEMU ids are limited to a length of 32 bytes. This means that SCSI based drives are also in danger to exceed this limit. We should consider to use a drive index

[libvirt] [PATCH] qemu: Allow hotplug of multiple SCSI devices

available index is used. Signed-off-by: Eric Farman far...@linux.vnet.ibm.com Reviewed-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- src/qemu/qemu_hotplug.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 7a6946e

Re: [libvirt] [PATCH] HACKING: Introduce basic Signed-off-by politic

out patches originating from a colleague. I.e. roughly similar to the subsystem maintainer policy used by the kernel folks. So that should be allow too IMHO. -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des Aufsichtsrats

Re: [libvirt] Entering freeze for libvirt-1.1.2

=/home/mihajlov/src/checkout-tuxgit/libvirt/build/src/.libs LIBVIRT_AUTOSTART=0 LC_ALL=C VIR_TEST_EXPENSIVE=0 ${dir}$tst -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung

Re: [libvirt] Entering freeze for libvirt-1.1.2

the LD_PRELOAD works differently for intra-library calls there. But here I am entering the realm of wild speculations... -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk

Re: [libvirt] Entering freeze for libvirt-1.1.2

the final release 1.1.2 on Monday. Please give it a try especially for potential portability issues, thanks in advance ! Daniel Briefly kicked the tires on s390, no issues seen so far. -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development

Re: [libvirt] [PATCH] Change way we fake dbus method calls

cannot use dbus_message_new_error or dbus_message_new_method_return Signed-off-by: Daniel P. Berrange berra...@redhat.com --- tests/virsystemdmock.c | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) [Works for me...] Tested-by: Viktor Mihajlovski mihaj

[libvirt] [PATCH] build: Fix VPATH build error for locking daemon

Removed superfluous/wrong srcdir prefix. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- src/Makefile.am |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index 4057eda..09311b7 100644 --- a/src/Makefile.am +++ b/src

Re: [libvirt] Entering freeze for libvirt-1.1.3

no problems, except for a vpath build error. I've sent a trivial patch. -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht

Re: [libvirt] error: server response too large

, specifically we can't go back to the small buffers again. For a proper solution client and server would need to advertise their respective maximum buffer sizes (or know it by the version number) and restrict themselves to using the lower number. -- Mit freundlichen Grüßen/Kind Regards Viktor

  1   2   3   4   5   >