See my update inline.
> -Original Message-
> From: Martin Kletzander [mailto:mklet...@redhat.com]
> Sent: Monday, June 11, 2018 4:40 PM
> To: Wang, Huaqiang
> Cc: libvir-list@redhat.com; Feng, Shaohe ; Niu, Bing
> ; Ding, Jian-feng ; Zang, Rui
>
> Subject:
> -Original Message-
> From: Martin Kletzander [mailto:mklet...@redhat.com]
> Sent: Monday, June 11, 2018 4:45 PM
> To: Wang, Huaqiang
> Cc: libvir-list@redhat.com; Feng, Shaohe ; Niu, Bing
> ; Ding, Jian-feng ; Zang, Rui
>
> Subject: Re: [libvirt] [PATC
Hi Martin,
Thanks for your comments, please see my update inline below.
> -Original Message-
> From: Martin Kletzander [mailto:mklet...@redhat.com]
> Sent: Monday, June 11, 2018 4:30 PM
> To: Wang, Huaqiang
> Cc: libvir-list@redhat.com; Feng, Shaohe ; Niu, Bing
>
Add RDT/CMT feature (Intel x86) by interacting with kernel resctrl file system.
Integrate code into util/resctrl.
---
src/libvirt_private.syms | 9 ++
src/util/virresctrl.c| 316 ++-
src/util/virresctrl.h| 44 +++
3 files changed, 367
---
include/libvirt/libvirt-domain.h | 1 +
src/libvirt-domain.c | 11 +
src/qemu/qemu_driver.c | 48
tools/virsh-domain-monitor.c | 7 ++
4 files changed, 67 insertions(+)
diff --git
-c200 libvirt]# virsh domstats --resctrl
Domain: 'vm1'
resctrl.cmt=0
Domain: 'vm3'
resctrl.cmt=180224
Domain: 'vm2'
resctrl.cmt=2613248
```
Wang Huaqiang (3):
util: add Intel x86 RDT/CMT support
tools: virsh: add command for controling/monitoring resctrl
tools
---
include/libvirt/libvirt-domain.h| 9 +++
src/conf/domain_conf.c | 28 +++
src/conf/domain_conf.h | 3 +
src/driver-hypervisor.h | 8 ++
src/libvirt-domain.c| 81 +
src/libvirt_public.syms |
Please see my inline reply.
> -Original Message-
> From: Martin Kletzander [mailto:mklet...@redhat.com]
> Sent: Thursday, June 14, 2018 3:54 PM
> To: Wang, Huaqiang
> Cc: libvir-list@redhat.com; Feng, Shaohe ; Niu, Bing
> ; Ding, Jian-feng ; Zang, Rui
>
> Sub
> -Original Message-
> From: John Ferlan [mailto:jfer...@redhat.com]
> Sent: Friday, July 27, 2018 12:33 AM
> To: Niu, Bing ; libvir-list@redhat.com
> Cc: Feng, Shaohe ; Wang, Huaqiang
> ; Ding, Jian-feng ;
> rui.z...@yandex.com
> Subject: Re: [libvirt]
> -Original Message-
> From: John Ferlan [mailto:jfer...@redhat.com]
> Sent: Friday, July 27, 2018 12:33 AM
> To: Niu, Bing ; libvir-list@redhat.com
> Cc: Feng, Shaohe ; Wang, Huaqiang
> ; Ding, Jian-feng ;
> rui.z...@yandex.com
> Subject: Re: [libvirt]
cpu.cache.1.name=vcpus_4-6
cpu.cache.1.vcpus=4,5,6
cpu.cache.1.bank.count=2
cpu.cache.1.bank.0.id=0
cpu.cache.1.bank.0.bytes=17571840
cpu.cache.1.bank.1.id=1
cpu.cache.1.bank.1.bytes=29106176
Signed-off-by: Wang Huaqiang
---
src/libvirt-domain.c | 9
To add CMT/MBM feature and let code be consistent in later patches,
renaming variable name from 'controlBuf' to 'childrenBuf', locates
in functions 'virCapabilitiesFormatCaches' and
'virCapabilitiesFormatMemoryBandwidth'.
Signed-off-by: Wang Huaqiang
---
.gnulib | 1 -
src/conf
+289,12 @@ struct _virResctrlAlloc {
virResctrlAllocMemBWPtr mem_bw;
+ virResctrlAllocMonPtr *monitors;
+ size_t nmonitors;
}
Signed-off-by: Wang Huaqiang
---
src/libvirt_private.syms | 6 +
src/util/virresctrl.c| 361
-by: Wang Huaqiang
---
docs/schemas/capability.rng | 28
src/conf/capabilities.c | 17 +
2 files changed, 45 insertions(+)
diff --git a/docs/schemas/capability.rng b/docs/schemas/capability.rng
index d61515c..67498f1 100644
--- a/docs/schemas
all vcpus belonging to current allocation.
3. monitoring group for vcpu(s) that does not have dedicated
allocation group:
e.g. "" creates a monitoring group but
no resource control applied to it.
+
+
+
+
Resource monitoring group monitors the resource consumption, cache and
memory bandwidth, of particular resctrl allocation. Introduce the resctrl
monitoring group.
Signed-off-by: Wang Huaqiang
---
src/qemu/qemu_process.c | 40 ++--
1 file changed, 38
.
Signed-off-by: Wang Huaqiang
---
src/conf/domain_conf.c | 48 ++--
1 file changed, 34 insertions(+), 14 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index bde9fef..9a65655 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf
Some code, in virresctrl.c, manupulating the file objects of resctrlfs
could be reused for cache monitor interfaces. This patch refactor these
functions for purpose of reusing code in later patch:
virResctrlAllocDeterminePath
virResctrlAllocCreate
virResctrlAddPID
Signed-off-by: Wang Huaqiang
=29106176
Wang Huaqiang (10):
conf: Renamed 'controlBuf' to 'childrenBuf'
util: add interface retrieving CMT capability
conf: Add CMT capability to host
test: add test case for resctrl monitor
util: resctrl: refactoring some functions
util: Introduce resctrl monitor for CMT
conf: refactor
Signed-off-by: Wang Huaqiang
---
.../linux-resctrl/resctrl/info/L3_MON/max_threshold_occupancy | 1 +
.../vircaps2xmldata/linux-resctrl/resctrl/info/L3_MON/mon_features | 3 +++
tests/vircaps2xmldata/linux-resctrl/resctrl/info/L3_MON/num_rmids | 1 +
tests/vircaps2xmldata/vircaps-x86_64
Introduce function for reporting CMT capability through going through
files under /sys/fs/info/L3_MON.
This patch is co-work with later patches and report these
information to domain.
Signed-off-by: Wang Huaqiang
---
src/conf/capabilities.c | 6 ++-
src/conf/capabilities.h | 1 +
src/util
> -Original Message-
> From: Martin Kletzander [mailto:mklet...@redhat.com]
> Sent: Tuesday, July 17, 2018 5:11 PM
> To: Wang, Huaqiang
> Cc: libvir-list@redhat.com; Feng, Shaohe ; Niu, Bing
> ; Ding, Jian-feng ; Zang, Rui
>
> Subject: Re: [libvirt] [RFC PATC
Hi Martin,
Thanks for your comments. Please see my reply inline.
> -Original Message-
> From: Martin Kletzander [mailto:mklet...@redhat.com]
> Sent: Tuesday, July 17, 2018 2:27 PM
> To: Wang, Huaqiang
> Cc: libvir-list@redhat.com; Feng, Shaohe ; Niu,
> Bing ; Ding, J
> -Original Message-
> From: Martin Kletzander [mailto:mklet...@redhat.com]
> Sent: Wednesday, July 18, 2018 10:03 PM
> To: Wang, Huaqiang
> Cc: libvir-list@redhat.com; Feng, Shaohe ; Niu, Bing
> ; Ding, Jian-feng ; Zang, Rui
>
> Subject: Re: [libvirt] [RF
> -Original Message-
> From: Martin Kletzander [mailto:mklet...@redhat.com]
> Sent: Wednesday, July 18, 2018 8:07 PM
> To: Wang, Huaqiang
> Cc: libvir-list@redhat.com; Feng, Shaohe ; Niu, Bing
> ; Ding, Jian-feng ; Zang, Rui
>
> Subject: Re: [libvirt] [RFC PATC
> -Original Message-
> From: John Ferlan [mailto:jfer...@redhat.com]
> Sent: Wednesday, September 5, 2018 7:58 PM
> To: Wang, Huaqiang ; libvir-list@redhat.com
> Cc: Feng, Shaohe ; Niu, Bing ;
> Ding, Jian-feng ; Zang, Rui
> Subject: Re: [libvirt] [PATCH 02/10
> -Original Message-
> From: John Ferlan [mailto:jfer...@redhat.com]
> Sent: Wednesday, September 5, 2018 7:59 PM
> To: Wang, Huaqiang ; libvir-list@redhat.com
> Cc: Feng, Shaohe ; Niu, Bing ;
> Ding, Jian-feng ; Zang, Rui
> Subject: Re: [libvirt] [PATCH 04/10
> -Original Message-
> From: John Ferlan [mailto:jfer...@redhat.com]
> Sent: Wednesday, September 5, 2018 7:59 PM
> To: Wang, Huaqiang ; libvir-list@redhat.com
> Cc: Feng, Shaohe ; Niu, Bing ;
> Ding, Jian-feng ; Zang, Rui
> Subject: Re: [libvirt] [PATCH 03/10] con
> -Original Message-
> From: John Ferlan [mailto:jfer...@redhat.com]
> Sent: Wednesday, September 5, 2018 7:58 PM
> To: Wang, Huaqiang ; libvir-list@redhat.com
> Cc: Feng, Shaohe ; Niu, Bing ;
> Ding, Jian-feng ; Zang, Rui
> Subject: Re: [libvirt] [PATCH
> -Original Message-
> From: John Ferlan [mailto:jfer...@redhat.com]
> Sent: Wednesday, September 5, 2018 10:49 PM
> To: Wang, Huaqiang ; libvir-list@redhat.com
> Cc: Feng, Shaohe ; Niu, Bing ;
> Ding, Jian-feng ; Zang, Rui
> Subject: Re: [libvirt] [PATCH
> -Original Message-
> From: John Ferlan [mailto:jfer...@redhat.com]
> Sent: Wednesday, September 5, 2018 11:00 PM
> To: Wang, Huaqiang ; libvir-list@redhat.com
> Cc: Feng, Shaohe ; Niu, Bing ;
> Ding, Jian-feng ; Zang, Rui
> Subject: Re: [libvirt] [PATCH 06/10] ut
> -Original Message-
> From: John Ferlan [mailto:jfer...@redhat.com]
> Sent: Wednesday, September 5, 2018 11:49 PM
> To: Wang, Huaqiang ; libvir-list@redhat.com
> Cc: Feng, Shaohe ; Niu, Bing ;
> Ding, Jian-feng ; Zang, Rui
> Subject: Re: [libvirt] [PATCH
> -Original Message-
> From: John Ferlan [mailto:jfer...@redhat.com]
> Sent: Saturday, September 8, 2018 1:11 AM
> To: Wang, Huaqiang ; libvir-list@redhat.com
> Cc: Feng, Shaohe ; Niu, Bing ;
> Ding, Jian-feng ; Zang, Rui
> Subject: Re: [libvirt] [PATCH 03/10] con
> -Original Message-
> From: John Ferlan [mailto:jfer...@redhat.com]
> Sent: Saturday, September 8, 2018 12:49 AM
> To: Wang, Huaqiang ; libvir-list@redhat.com
> Cc: Feng, Shaohe ; Niu, Bing ;
> Ding, Jian-feng ; Zang, Rui
> Subject: Re: [libvirt] [PATCH 02/10
> -Original Message-
> From: John Ferlan [mailto:jfer...@redhat.com]
> Sent: Saturday, September 8, 2018 1:41 AM
> To: Wang, Huaqiang ; libvir-list@redhat.com
> Cc: Feng, Shaohe ; Niu, Bing ;
> Ding, Jian-feng ; Zang, Rui
> Subject: Re: [libvirt] [PATCH
> -Original Message-
> From: John Ferlan [mailto:jfer...@redhat.com]
> Sent: Saturday, September 8, 2018 1:14 AM
> To: Wang, Huaqiang ; libvir-list@redhat.com
> Cc: Feng, Shaohe ; Niu, Bing ;
> Ding, Jian-feng ; Zang, Rui
> Subject: Re: [libvirt] [PATCH 04/10
> -Original Message-
> From: John Ferlan [mailto:jfer...@redhat.com]
> Sent: Thursday, September 6, 2018 12:39 AM
> To: Wang, Huaqiang ; libvir-list@redhat.com
> Cc: Feng, Shaohe ; Niu, Bing ;
> Ding, Jian-feng ; Zang, Rui
> Subject: Re: [libvirt] [PATCH 08/10] co
Add interfaces for resource monitoring group
- query monitoring group status
- dynamically create monitoring group
- dynamically destory monitoring group
---
src/qemu/qemu_driver.c | 252 +
1 file changed, 252 insertions(+)
diff --git
Add RDT/CMT feature (Intel x86) by interacting with kernel
resctrl file system. Integrate code into util/resctrl.
---
src/libvirt_private.syms | 10 ++
src/util/virresctrl.c| 338 +++
src/util/virresctrl.h| 40 ++
3 files changed, 388
---
tests/genericxml2xmlindata/cachetune-cdp.xml | 3 ++
tests/genericxml2xmlindata/cachetune-small.xml | 2 ++
tests/genericxml2xmlindata/cachetune.xml | 2 ++
.../resmongroup-colliding-cachetune.xml| 34 ++
tests/genericxml2xmltest.c
Function includes setting and getting the status of
resource monitoring group.
---
src/remote/remote_daemon_dispatch.c | 45 +
src/remote/remote_driver.c | 4 +++-
src/remote/remote_protocol.x| 31 -
fetching resctrl monitoring group settings from def->resmons
and createing resctrl group accodring to cachetune element
status. This patch relies on the function of resctrl of
util.
---
src/qemu/qemu_process.c | 45 +
1 file changed, 41 insertions(+), 4
A tool to create, destroy and query resource monitoring group lively.
---
tools/virsh-domain.c | 139 +++
1 file changed, 139 insertions(+)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index e9b88f0..6aa674e 100644
---
up instead of whole
domain.
* be possible to destroy vcpu group at run time
* XML configuration file changed
* change naming for describing 'RDT CMT' to 'cpu-resource'
Wang Huaqiang (10):
util: add Intel x86 RDT/CMT support
conf: introduce element
tests: add tests for validating
libvirt:
support functions to create, destory and monitoring resctl
monioring group.
---
include/libvirt/libvirt-domain.h | 13 ++
src/conf/domain_conf.c | 2 +
src/driver-hypervisor.h | 13 ++
src/libvirt-domain.c | 96
add cache occupancy information in command virsh domstats
for domains has resource monitoring groups.
---
include/libvirt/libvirt-domain.h | 1 +
src/qemu/qemu_driver.c | 105 +++
tools/virsh-domain-monitor.c | 7 +++
3 files changed, 113
---
docs/news.xml | 10 ++
1 file changed, 10 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 773c95b..d406e51 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -44,6 +44,16 @@
support should be available to the guest.
+
+
+
resmongroup element is used for feature of resctrl monitoring
group, and keeps the information for how resctrl monitoring
groups is arranged.
---
docs/formatdomain.html.in | 17 +++
docs/schemas/domaincommon.rng | 14 ++
src/conf/domain_conf.c| 318
> -Original Message-
> From: John Ferlan [mailto:jfer...@redhat.com]
> Sent: Thursday, October 11, 2018 4:59 AM
> To: Wang, Huaqiang ; libvir-list@redhat.com
> Cc: Feng, Shaohe ; Niu, Bing ;
> Ding, Jian-feng ; Zang, Rui
> Subject: Re: [libvirt] [PATCHv5 15/19]
On 10/12/2018 10:27 PM, John Ferlan wrote:
[...]
402 virResctrlMonitorDispose(void *obj)
403 {
404 virResctrlMonitorPtr monitor = obj;
405
406 virObjectUnref(monitor->alloc);
407 VIR_FREE(monitor->id);
408 VIR_FREE(monitor->path);
409 }
The one "thing"
On 10/12/2018 10:40 PM, John Ferlan wrote:
[...]
virResctrlMonitorCreate(virResctrlAllocPtr alloc,
virResctrlMonitorPtr monitor,
const char *machinename)
@@ -2534,3 +2565,177 @@ virResctrlMonitorCreate(virResctrlAllocPtr alloc,
On 10/12/2018 11:18 PM, John Ferlan wrote:
On 10/11/18 8:02 AM, Wang, Huaqiang wrote:
Answers refined.
On 10/11/2018 3:14 AM, John Ferlan wrote:
On 10/9/18 6:30 AM, Wang Huaqiang wrote:
In resctrl file system, more than one monitoring groups
could be created within one allocation group
Adding element 'id' to virDomainResctrlDef tracking resource group
id, it reflects the attribute 'id' of of element in XML.
virResctrlAlloc.id is a copy from virDomanResctrlDef.id.
Signed-off-by: Wang Huaqiang
---
src/conf/domain_conf.c | 20
src/conf/domain_conf.h | 1
The code for creating resctrl allocation group could be reused
for monitoring group, refactor it for reuse in the later patch.
Signed-off-by: Wang Huaqiang
---
src/util/virresctrl.c | 37 +++--
1 file changed, 23 insertions(+), 14 deletions(-)
diff --git a/src
The code for determining resctrl allocation path could be reused
for monitor. Refactor it for reuse.
Signed-off-by: Wang Huaqiang
---
src/util/virresctrl.c | 38 ++
1 file changed, 30 insertions(+), 8 deletions(-)
diff --git a/src/util/virresctrl.c b/src
Cache Monitoring Technology (aka CMT) provides the capability
to report cache utilization information of system task.
This patch introduces the concept of resctrl monitor through
data structure virResctrlMonitor.
Signed-off-by: Wang Huaqiang
---
src/libvirt_private.syms | 2 +-
src/util
Check whether monitor is running by checking the monitor's PIDs status.
Monitor is looked as running normally if the vcpu PID list matches with
the content of monitor's 'tasks' file.
Signed-off-by: Wang Huaqiang
---
src/libvirt_private.syms | 1 +
src/util/virresctrl.c| 102
Add interface for resctrl monitor to determine the path.
Signed-off-by: Wang Huaqiang
---
src/libvirt_private.syms | 1 +
src/util/virresctrl.c| 55
src/util/virresctrl.h| 5 -
3 files changed, 60 insertions(+), 1 deletion(-)
diff
This refactor allows to add some code between virDomainResctrlNew
and virResctrlAllocIsEmpty to extend the scope of resctrl.
Signed-off-by: Wang Huaqiang
---
src/conf/domain_conf.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf
The code for creating resctrl allocation group could be reused
for monitoring group, refactor it for reuse in the later patch.
Signed-off-by: Wang Huaqiang
---
src/util/virresctrl.c | 37 +++--
1 file changed, 23 insertions(+), 14 deletions(-)
diff --git a/src
Refactoring qemuDomainGetStatsCpu, make it possible to add
more CPU statistics.
Signed-off-by: Wang Huaqiang
---
src/qemu/qemu_driver.c | 45 ++---
1 file changed, 22 insertions(+), 23 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu
pus and
virObjectRef for @alloc, thus removing the need to set each to NULL after the
call.
Signed-off-by: Wang Huaqiang
---
src/conf/domain_conf.c | 60 +-
1 file changed, 35 insertions(+), 25 deletions(-)
diff --git a/src/conf/domain_conf.c b/
This refactor allows to add some code between virDomainResctrlNew
and virResctrlAllocIsEmpty to extend the scope of resctrl.
Signed-off-by: Wang Huaqiang
---
src/conf/domain_conf.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf
Invoking qemuProcessSetupVcpus in process of VM reconnection.
The vcpu pid information need to be refilled to resctrl monitor
after a VM reconnection./
Signed-off-by: Wang Huaqiang
---
src/qemu/qemu_process.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/qemu/qemu_process.c b/src
Add interfaces monitor group to support operations such
as add PID, set ID, remove group ... etc.
Signed-off-by: Wang Huaqiang
---
src/libvirt_private.syms | 5 +
src/util/virresctrl.c| 47 +++
src/util/virresctrl.h| 14 ++
3
Introducing element under to represent
a cache monitor.
Signed-off-by: Wang Huaqiang
---
docs/formatdomain.html.in | 26 +++
docs/schemas/domaincommon.rng | 10 +
src/conf/domain_conf.c | 234
Check whether monitor is running by checking the monitor's PIDs status.
Monitor is looked as running normally if the vcpu PID list matches with
the content of monitor's 'tasks' file.
Signed-off-by: Wang Huaqiang
---
src/libvirt_private.syms | 1 +
src/util/virresctrl.c| 102
Cache Monitoring Technology (aka CMT) provides the capability
to report cache utilization information of system task.
This patch introduces the concept of resctrl monitor through
data structure virResctrlMonitor.
Signed-off-by: Wang Huaqiang
---
src/libvirt_private.syms | 1 +
src/util
/resctrl/schemata'.
Signed-off-by: Wang Huaqiang
---
docs/formatdomain.html.in | 4 ++--
docs/schemas/domaincommon.rng | 4 ++--
src/util/virresctrl.c | 28
3 files changed, 32 insertions(+), 4 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs
Add interface for adding task PID to the monitor.
Signed-off-by: Wang Huaqiang
---
src/libvirt_private.syms | 1 +
src/util/virresctrl.c| 8
src/util/virresctrl.h| 4
3 files changed, 13 insertions(+)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index
' changed.
- Introduced API virResctrlInfoGetMonitorPrefix
- Added more tests, covering standalone CMT, fake new
feature.
- Creating CMT resource control group will be
subsequent job.
Wang Huaqiang (18):
docs,util: Refactor schemas and virresctrl to support optional cache
util: Introduce
Add functions for creating, destroying, reconnecting resctrl
monitor in qemu according to the configuration in domain XML.
Signed-off-by: Wang Huaqiang
---
src/qemu/qemu_process.c | 66 -
1 file changed, 65 insertions(+), 1 deletion(-)
diff --git
Add interface for creating the resource monitoring group according
to '@virResctrlMonitor->path'.
Signed-off-by: Wang Huaqiang
---
src/libvirt_private.syms | 1 +
src/util/virresctrl.c| 24
src/util/virresctrl.h| 4
3 files changed, 29 insertions(+)
d
Refactoring qemuDomainGetStatsCpu, make it possible to add
more CPU statistics.
Signed-off-by: Wang Huaqiang
---
src/qemu/qemu_driver.c | 45 ++---
1 file changed, 22 insertions(+), 23 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu
Add interface for resctrl monitor to determine the path.
Signed-off-by: Wang Huaqiang
---
src/libvirt_private.syms | 1 +
src/util/virresctrl.c| 55
src/util/virresctrl.h| 5 -
3 files changed, 60 insertions(+), 1 deletion(-)
diff
The code of adding PID to the allocation could be reused, refactor it
for later reuse.
Signed-off-by: Wang Huaqiang
---
src/util/virresctrl.c | 30 +++---
1 file changed, 19 insertions(+), 11 deletions(-)
diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c
index
.bytes=29106176
Signed-off-by: Wang Huaqiang
---
src/libvirt-domain.c | 9 ++
src/libvirt_private.syms | 1 +
src/qemu/qemu_driver.c | 229 +++
src/util/virresctrl.c| 130 +++
src/util/virresctrl.h| 12 +++
5 files
Introducing element under to represent
a cache monitor.
Signed-off-by: Wang Huaqiang
---
docs/formatdomain.html.in | 26 +++
docs/schemas/domaincommon.rng | 10 +
src/conf/domain_conf.c | 234
The code of adding PID to the allocation could be reused, refactor it
for later reuse.
Signed-off-by: Wang Huaqiang
---
src/util/virresctrl.c | 30 +++---
1 file changed, 19 insertions(+), 11 deletions(-)
diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c
index
/resctrl/schemata'.
Signed-off-by: Wang Huaqiang
---
docs/formatdomain.html.in | 4 ++--
docs/schemas/domaincommon.rng | 4 ++--
src/util/virresctrl.c | 31 ---
3 files changed, 32 insertions(+), 7 deletions(-)
diff --git a/docs/formatdomain.html.in b
Invoking qemuProcessSetupVcpus in process of VM reconnection.
The vcpu pid information need to be refilled to resctrl monitor
after a VM reconnection./
Signed-off-by: Wang Huaqiang
---
src/qemu/qemu_process.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/qemu/qemu_process.c b/src
.bytes=29106176
Signed-off-by: Wang Huaqiang
---
src/libvirt-domain.c | 9 ++
src/libvirt_private.syms | 1 +
src/qemu/qemu_driver.c | 229 +++
src/util/virresctrl.c| 130 +++
src/util/virresctrl.h| 12 +++
5 files
Adding element 'id' to virDomainResctrlDef tracking resource group
id, it reflects the attribute 'id' of of element in XML.
virResctrlAlloc.id is a copy from virDomanResctrlDef.id.
Signed-off-by: Wang Huaqiang
---
src/conf/domain_conf.c | 20
src/conf/domain_conf.h | 1
Add functions for creating, destroying, reconnecting resctrl
monitor in qemu according to the configuration in domain XML.
Signed-off-by: Wang Huaqiang
---
src/qemu/qemu_process.c | 66 -
1 file changed, 65 insertions(+), 1 deletion(-)
diff --git
The code for determining resctrl allocation path could be reused
for monitor. Refactor it for reuse.
Signed-off-by: Wang Huaqiang
---
src/util/virresctrl.c | 38 ++
1 file changed, 30 insertions(+), 8 deletions(-)
diff --git a/src/util/virresctrl.c b/src
pus and
virObjectRef for @alloc, thus removing the need to set each to NULL after the
call.
Signed-off-by: Wang Huaqiang
---
src/conf/domain_conf.c | 60 +-
1 file changed, 35 insertions(+), 25 deletions(-)
diff --git a/src/conf/domain_conf.c b/
Add interface for creating the resource monitoring group according
to '@virResctrlMonitor->path'.
Signed-off-by: Wang Huaqiang
---
src/libvirt_private.syms | 1 +
src/util/virresctrl.c| 24
src/util/virresctrl.h| 4
3 files changed, 29 insertions(+)
d
Add interfaces monitor group to support operations such
as add PID, set ID, remove group ... etc.
Signed-off-by: Wang Huaqiang
---
src/libvirt_private.syms | 5 +
src/util/virresctrl.c| 47 +++
src/util/virresctrl.h| 14 ++
3
Add interface for adding task PID to the monitor.
Signed-off-by: Wang Huaqiang
---
src/libvirt_private.syms | 1 +
src/util/virresctrl.c| 8
src/util/virresctrl.h| 4
3 files changed, 13 insertions(+)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index
virResctrlInfoGetMonitorPrefix
- Added more tests, covering standalone CMT, fake new
feature.
- Creating CMT resource control group will be
subsequent job.
Wang Huaqiang (18):
docs,util: Refactor schemas and virresctrl to support optional cache
util: Introduce resctrl monitor for CMT
util: Refactor code
Signed-off-by: Wang Huaqiang
---
src/util/virresctrl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c
index df5b512..5d811a2 100644
--- a/src/util/virresctrl.c
+++ b/src/util/virresctrl.c
@@ -259,7 +259,7 @@ virResctrlInfoMonFree
I think I have forget replying this review.
On 10/11/2018 5:28 AM, John Ferlan wrote:
On 10/10/18 9:44 AM, Wang, Huaqiang wrote:
-Original Message-
From: John Ferlan [mailto:jfer...@redhat.com]
Sent: Wednesday, October 10, 2018 4:36 AM
To: Wang, Huaqiang ; libvir-list@redhat.com
Cc
> -Original Message-
> From: John Ferlan [mailto:jfer...@redhat.com]
> Sent: Thursday, October 11, 2018 5:41 AM
> To: Wang, Huaqiang ; libvir-list@redhat.com
> Cc: Feng, Shaohe ; Niu, Bing ;
> Ding, Jian-feng ; Zang, Rui
> Subject: Re: [libvirt] [PATCHv5 05/19
The @alloc object returned by virDomainResctrlVcpuMatch is not
properly referenced and un-referenced in virDomainCachetuneDefParse.
This patch fixes this problem.
Signed-off-by: Wang Huaqiang
---
src/conf/domain_conf.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src
> -Original Message-
> From: John Ferlan [mailto:jfer...@redhat.com]
> Sent: Thursday, October 11, 2018 5:58 AM
> To: Wang, Huaqiang ; libvir-list@redhat.com
> Cc: Feng, Shaohe ; Niu, Bing ;
> Ding, Jian-feng ; Zang, Rui
> Subject: Re: [libvirt] [PATCHv5 11/19
> -Original Message-
> From: John Ferlan [mailto:jfer...@redhat.com]
> Sent: Thursday, October 11, 2018 5:43 AM
> To: Wang, Huaqiang ; libvir-list@redhat.com
> Cc: Feng, Shaohe ; Niu, Bing ;
> Ding, Jian-feng ; Zang, Rui
> Subject: Re: [libvirt] [PATCHv5 06/
> -Original Message-
> From: John Ferlan [mailto:jfer...@redhat.com]
> Sent: Thursday, October 11, 2018 3:54 AM
> To: Wang, Huaqiang ; libvir-list@redhat.com
> Cc: Feng, Shaohe ; Niu, Bing ;
> Ding, Jian-feng ; Zang, Rui
> Subject: Re: [libvirt] [PATCHv5
> -Original Message-
> From: John Ferlan [mailto:jfer...@redhat.com]
> Sent: Thursday, October 11, 2018 4:58 AM
> To: Wang, Huaqiang ; libvir-list@redhat.com
> Cc: Feng, Shaohe ; Niu, Bing ;
> Ding, Jian-feng ; Zang, Rui
> Subject: Re: [libvirt] [PATCHv5 14/1
> -Original Message-
> From: John Ferlan [mailto:jfer...@redhat.com]
> Sent: Thursday, October 11, 2018 4:58 AM
> To: Wang, Huaqiang ; libvir-list@redhat.com
> Cc: Feng, Shaohe ; Niu, Bing ;
> Ding, Jian-feng ; Zang, Rui
> Subject: Re: [libvirt] [PATCHv5 13/19] conf
On 10/13/2018 6:29 AM, John Ferlan wrote:
On 10/12/18 3:10 AM, Wang, Huaqiang wrote:
-Original Message-
From: John Ferlan [mailto:jfer...@redhat.com]
Sent: Thursday, October 11, 2018 4:58 AM
To: Wang, Huaqiang ; libvir-list@redhat.com
Cc: Feng, Shaohe ; Niu, Bing ;
Ding, Jian-feng
1 - 100 of 268 matches
Mail list logo
