Re: [libvirt] [PATCH] conf: nodedev: Update capabilities from within virNodeDeviceObjHasCap

2018-03-15 Thread John Ferlan
On 03/15/2018 04:35 AM, Erik Skultety wrote: > On Wed, Mar 14, 2018 at 03:28:36PM -0400, John Ferlan wrote: >> >> >> On 03/06/2018 10:32 AM, Erik Skultety wrote: >>> Commit d18feadc0c put this into virNodeDeviceMatch, but this should have >>> rather been part of virNodeDeviceObjHasCap from the

Re: [libvirt] [PATCH] conf: nodedev: Update capabilities from within virNodeDeviceObjHasCap

2018-03-15 Thread Erik Skultety
On Wed, Mar 14, 2018 at 03:28:36PM -0400, John Ferlan wrote: > > > On 03/06/2018 10:32 AM, Erik Skultety wrote: > > Commit d18feadc0c put this into virNodeDeviceMatch, but this should have > > rather been part of virNodeDeviceObjHasCap from the beginning, since > > virNodeDeviceObjHasCap is the

Re: [libvirt] [PATCH] conf: nodedev: Update capabilities from within virNodeDeviceObjHasCap

2018-03-15 Thread John Ferlan
On 03/06/2018 10:32 AM, Erik Skultety wrote: > Commit d18feadc0c put this into virNodeDeviceMatch, but this should have > rather been part of virNodeDeviceObjHasCap from the beginning, since > virNodeDeviceObjHasCap is the last helper to be called (in the calltree) > whereas virNodeDeviceMatch

[libvirt] [PATCH] conf: nodedev: Update capabilities from within virNodeDeviceObjHasCap

2018-03-06 Thread Erik Skultety
Commit d18feadc0c put this into virNodeDeviceMatch, but this should have rather been part of virNodeDeviceObjHasCap from the beginning, since virNodeDeviceObjHasCap is the last helper to be called (in the calltree) whereas virNodeDeviceMatch is called from a single place only -