Re: [libvirt] [PATCH] qemuxml2argvtest: Don't leak TPM unix path

2018-06-14 Thread Andrea Bolognani
On Thu, 2018-06-14 at 11:09 +0200, Michal Privoznik wrote: > On 06/14/2018 10:39 AM, Andrea Bolognani wrote: > > On Wed, 2018-06-13 at 15:58 +0200, Michal Privoznik wrote: > > > When testing a domain XML with TPM we overwrite UNIX socket path > > > to mimic what qemuTPMEmulatorPrepareHost() is

Re: [libvirt] [PATCH] qemuxml2argvtest: Don't leak TPM unix path

2018-06-14 Thread Michal Privoznik
On 06/14/2018 10:39 AM, Andrea Bolognani wrote: > On Wed, 2018-06-13 at 15:58 +0200, Michal Privoznik wrote: >> When testing a domain XML with TPM we overwrite UNIX socket path >> to mimic what qemuTPMEmulatorPrepareHost() is doing (because >> *PrepareHost() functions are not called from the

Re: [libvirt] [PATCH] qemuxml2argvtest: Don't leak TPM unix path

2018-06-14 Thread Andrea Bolognani
On Wed, 2018-06-13 at 15:58 +0200, Michal Privoznik wrote: > When testing a domain XML with TPM we overwrite UNIX socket path > to mimic what qemuTPMEmulatorPrepareHost() is doing (because > *PrepareHost() functions are not called from the test). But we > are not doing it fully - we need to set

[libvirt] [PATCH] qemuxml2argvtest: Don't leak TPM unix path

2018-06-13 Thread Michal Privoznik
When testing a domain XML with TPM we overwrite UNIX socket path to mimic what qemuTPMEmulatorPrepareHost() is doing (because *PrepareHost() functions are not called from the test). But we are not doing it fully - we need to set the chardev's type too so that virDomainTPMDefFree() can free the