Re: [libvirt] [PATCH 03/22] virsh: Enhance documentation of cpu-compare command

2018-05-24 Thread Ján Tomko 

On Wed, May 16, 2018 at 10:39:22AM +0200, Jiri Denemark wrote:

Signed-off-by: Jiri Denemark 
---
tools/virsh.pod | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)



Reviewed-by: Ján Tomko 

Jano


signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 03/22] virsh: Enhance documentation of cpu-compare command

2018-05-23 Thread Kashyap Chamarthy 
On Wed, May 16, 2018 at 10:39:22AM +0200, Jiri Denemark wrote:
> Signed-off-by: Jiri Denemark 
> ---
>  tools/virsh.pod | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/virsh.pod b/tools/virsh.pod
> index 929958a953..5f72e11dec 100644
> --- a/tools/virsh.pod
> +++ b/tools/virsh.pod
> @@ -589,7 +589,9 @@ Compare CPU definition from XML  with host CPU. The 
> XML  may
>  contain either host or guest CPU definition. The host CPU definition is the
>   element and its contents as printed by B command. The
>  guest CPU definition is the  element and its contents from domain XML
> -definition. For more information on guest CPU definition see:
> +definition. In addition to the  element itself, this command accepts
> +full domain or capabilities XML containing the  element. For more
> +information on guest CPU definition see:
>  L. If I<--error> is
>  specified, the command will return an error when the given CPU is
>  incompatible with host CPU and a message providing more details about the

Reviewed-by: Kashyap Chamarthy 

-- 
/kashyap

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 03/22] virsh: Enhance documentation of cpu-compare command

2018-05-22 Thread Collin Walling 
On 05/16/2018 04:39 AM, Jiri Denemark wrote:
> Signed-off-by: Jiri Denemark 
> ---
>  tools/virsh.pod | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/virsh.pod b/tools/virsh.pod
> index 929958a953..5f72e11dec 100644
> --- a/tools/virsh.pod
> +++ b/tools/virsh.pod
> @@ -589,7 +589,9 @@ Compare CPU definition from XML  with host CPU. The 
> XML  may
>  contain either host or guest CPU definition. The host CPU definition is the
>   element and its contents as printed by B command. The
>  guest CPU definition is the  element and its contents from domain XML
> -definition. For more information on guest CPU definition see:
> +definition. In addition to the  element itself, this command accepts
> +full domain or capabilities XML containing the  element. For more
> +information on guest CPU definition see:
>  L. If I<--error> is
>  specified, the command will return an error when the given CPU is
>  incompatible with host CPU and a message providing more details about the
> 

Reviewed-by: Collin Walling 

-- 
Respectfully,
- Collin Walling

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 03/22] virsh: Enhance documentation of cpu-compare command

2018-05-16 Thread Jiri Denemark 
Signed-off-by: Jiri Denemark 
---
 tools/virsh.pod | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/virsh.pod b/tools/virsh.pod
index 929958a953..5f72e11dec 100644
--- a/tools/virsh.pod
+++ b/tools/virsh.pod
@@ -589,7 +589,9 @@ Compare CPU definition from XML  with host CPU. The 
XML  may
 contain either host or guest CPU definition. The host CPU definition is the
  element and its contents as printed by B command. The
 guest CPU definition is the  element and its contents from domain XML
-definition. For more information on guest CPU definition see:
+definition. In addition to the  element itself, this command accepts
+full domain or capabilities XML containing the  element. For more
+information on guest CPU definition see:
 L. If I<--error> is
 specified, the command will return an error when the given CPU is
 incompatible with host CPU and a message providing more details about the
-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list