On Thu, Jan 12, 2017 at 19:45:52 -0500, John Ferlan wrote:
>
>
> On 01/12/2017 09:41 AM, Peter Krempa wrote:
> > On Thu, Jan 12, 2017 at 09:36:01 -0500, John Ferlan wrote:
> >>
> >>
> >> On 01/12/2017 09:24 AM, Peter Krempa wrote:
> >>> The check does not work properly (crashes) with netfs
On Thu, Jan 12, 2017 at 19:45:52 -0500, John Ferlan wrote:
> Here's the difference between the check and removing the check (not
> withstanding the no PARTED and no BLKID available)...
>
> Create a pool using ext4, start it - life is happy. Destroy the pool.
> Define a pool using xfs. Start it
On 01/12/2017 09:41 AM, Peter Krempa wrote:
> On Thu, Jan 12, 2017 at 09:36:01 -0500, John Ferlan wrote:
>>
>>
>> On 01/12/2017 09:24 AM, Peter Krempa wrote:
>>> The check does not work properly (crashes) with netfs filesystems and
>>> also checking that a device is not empty when attempting to
On 01/12/2017 09:24 AM, Peter Krempa wrote:
> The check does not work properly (crashes) with netfs filesystems and
> also checking that a device is not empty when attempting to mount a
> filesystem is not very usefull since the mount will fail anyways.
>
> As the code would improve only a very
On Thu, Jan 12, 2017 at 09:36:01 -0500, John Ferlan wrote:
>
>
> On 01/12/2017 09:24 AM, Peter Krempa wrote:
> > The check does not work properly (crashes) with netfs filesystems and
> > also checking that a device is not empty when attempting to mount a
> > filesystem is not very usefull since
The check does not work properly (crashes) with netfs filesystems and
also checking that a device is not empty when attempting to mount a
filesystem is not very usefull since the mount will fail anyways.
As the code would improve only a very minor corner case I don't really
see a reason to have
