Re: [libvirt] [PATCH 1/4] test_driver: implement virDomainAddIOThread

2019-07-25 Thread Erik Skultety
On Tue, Jul 23, 2019 at 12:17:54PM +0200, Ilias Stamatis wrote: > Signed-off-by: Ilias Stamatis > --- ... > + > +if (VIR_ALLOC(iothrid) < 0) > +goto cleanup; > + > +iothrid->iothread_id = iothread_id; > + > +if (VIR_APPEND_ELEMENT_COPY(def->iothreadids, def->niothreadids, >

Re: [libvirt] [PATCH 1/4] test_driver: implement virDomainAddIOThread

2019-07-25 Thread Erik Skultety
On Thu, Jul 25, 2019 at 02:09:01PM +0200, Erik Skultety wrote: > On Tue, Jul 23, 2019 at 12:17:54PM +0200, Ilias Stamatis wrote: > > Signed-off-by: Ilias Stamatis > > --- > > One more thing, this patch will break virsh-optparse again, more specifically > some of the cpu-stats tests (yeah, those

Re: [libvirt] [PATCH 1/4] test_driver: implement virDomainAddIOThread

2019-07-25 Thread Erik Skultety
On Tue, Jul 23, 2019 at 12:17:54PM +0200, Ilias Stamatis wrote: > Signed-off-by: Ilias Stamatis > --- One more thing, this patch will break virsh-optparse again, more specifically some of the cpu-stats tests (yeah, those are very bad tests). The offending ones need to be removed in a standalone

[libvirt] [PATCH 1/4] test_driver: implement virDomainAddIOThread

2019-07-23 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 51 ++ 1 file changed, 51 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 2e33a9dd55..313cf5e7ef 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c