Re: [libvirt] [PATCH 2/2] test: Implement virConnectListAllNodeDevices

2018-03-02 Thread John Ferlan


On 02/23/2018 06:16 PM, Cole Robinson wrote:
> Signed-off-by: Cole Robinson 
> ---
>  src/test/test_driver.c | 13 +
>  1 file changed, 13 insertions(+)
> 
> diff --git a/src/test/test_driver.c b/src/test/test_driver.c
> index 39784c9fa..844e99dd7 100644
> --- a/src/test/test_driver.c
> +++ b/src/test/test_driver.c
> @@ -5385,6 +5385,18 @@ testNodeListDevices(virConnectPtr conn,
>  cap, names, maxnames);
>  }
>  
> +static int
> +testConnectListAllNodeDevices(virConnectPtr conn,
> +  virNodeDevicePtr **devices,
> +  unsigned int flags)
> +{
> +testDriverPtr driver = conn->privateData;
> +
> +virCheckFlags(VIR_CONNECT_LIST_NODE_DEVICES_FILTERS_CAP, -1);
> +
> +return virNodeDeviceObjListExport(conn, driver->devs, devices,
> +  NULL, flags);
> +}
>  
>  static virNodeDevicePtr
>  testNodeDeviceLookupByName(virConnectPtr conn, const char *name)
> @@ -7022,6 +7034,7 @@ static virStorageDriver testStorageDriver = {
>  };
>  
>  static virNodeDeviceDriver testNodeDeviceDriver = {
> +.connectListAllNodeDevices = testConnectListAllNodeDevices, /* 4.1.0 */

At least 4.2.0 now

Reviewed-by: John Ferlan 

John

>  .connectNodeDeviceEventRegisterAny = 
> testConnectNodeDeviceEventRegisterAny, /* 2.2.0 */
>  .connectNodeDeviceEventDeregisterAny = 
> testConnectNodeDeviceEventDeregisterAny, /* 2.2.0 */
>  .nodeNumOfDevices = testNodeNumOfDevices, /* 0.7.2 */
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


[libvirt] [PATCH 2/2] test: Implement virConnectListAllNodeDevices

2018-02-23 Thread Cole Robinson
Signed-off-by: Cole Robinson 
---
 src/test/test_driver.c | 13 +
 1 file changed, 13 insertions(+)

diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 39784c9fa..844e99dd7 100644
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -5385,6 +5385,18 @@ testNodeListDevices(virConnectPtr conn,
 cap, names, maxnames);
 }
 
+static int
+testConnectListAllNodeDevices(virConnectPtr conn,
+  virNodeDevicePtr **devices,
+  unsigned int flags)
+{
+testDriverPtr driver = conn->privateData;
+
+virCheckFlags(VIR_CONNECT_LIST_NODE_DEVICES_FILTERS_CAP, -1);
+
+return virNodeDeviceObjListExport(conn, driver->devs, devices,
+  NULL, flags);
+}
 
 static virNodeDevicePtr
 testNodeDeviceLookupByName(virConnectPtr conn, const char *name)
@@ -7022,6 +7034,7 @@ static virStorageDriver testStorageDriver = {
 };
 
 static virNodeDeviceDriver testNodeDeviceDriver = {
+.connectListAllNodeDevices = testConnectListAllNodeDevices, /* 4.1.0 */
 .connectNodeDeviceEventRegisterAny = 
testConnectNodeDeviceEventRegisterAny, /* 2.2.0 */
 .connectNodeDeviceEventDeregisterAny = 
testConnectNodeDeviceEventDeregisterAny, /* 2.2.0 */
 .nodeNumOfDevices = testNodeNumOfDevices, /* 0.7.2 */
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list