Re: [libvirt] [PATCH 4/7] virsh-edit: remove unreachable break

2018-03-06 Thread Laine Stump 
On 03/06/2018 09:21 AM, Peter Krempa wrote:
> On Tue, Mar 06, 2018 at 15:01:36 +0100, Ján Tomko wrote:
>> Introduced by .
>>
>> Signed-off-by: Ján Tomko 
>> Signed-off-by: Ján Tomko 
> You don't need to overdo it. The commit hook looks for just one.

He repeatedly pushes the "Close Door" button on elevators too. At least
when I'm running to catch it, anyway...

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 4/7] virsh-edit: remove unreachable break

2018-03-06 Thread Peter Krempa 
On Tue, Mar 06, 2018 at 15:01:36 +0100, Ján Tomko wrote:
> Introduced by .
> 
> Signed-off-by: Ján Tomko 
> Signed-off-by: Ján Tomko 

You don't need to overdo it. The commit hook looks for just one.

> ---
>  tools/virsh-edit.c | 1 -
>  1 file changed, 1 deletion(-)

ACK


signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 4/7] virsh-edit: remove unreachable break

2018-03-06 Thread Ján Tomko 
Introduced by .

Signed-off-by: Ján Tomko 
Signed-off-by: Ján Tomko 
---
 tools/virsh-edit.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/virsh-edit.c b/tools/virsh-edit.c
index 92a00b7f9..d97794fed 100644
--- a/tools/virsh-edit.c
+++ b/tools/virsh-edit.c
@@ -138,7 +138,6 @@ do {
 EDIT_RELAX;
 relax_avail = false;
 goto redefine;
-break;
 }
 ATTRIBUTE_FALLTHROUGH;
 #endif
-- 
2.16.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list