[libvirt] [PATCH v2 24/73] qemu: Hide internals of qemuMigrationParams struct

[Jiri Denemark]

All users of migration parameters are supposed to use APIs provided by
qemu_migration_params.c without having to worry about the internals.

Signed-off-by: Jiri Denemark 
---
 src/qemu/qemu_migration_params.c | 5 +
 src/qemu/qemu_migration_params.h | 3 ---
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/qemu/qemu_migration_params.c b/src/qemu/qemu_migration_params.c
index 92fe84d324..4ca49d942e 100644
--- a/src/qemu/qemu_migration_params.c
+++ b/src/qemu/qemu_migration_params.c
@@ -30,6 +30,7 @@
 #include "qemu_hotplug.h"
 #include "qemu_migration.h"
 #include "qemu_migration_params.h"
+#include "qemu_monitor.h"
 
 #define VIR_FROM_THIS VIR_FROM_QEMU
 
@@ -37,6 +38,10 @@ VIR_LOG_INIT("qemu.qemu_migration_params");
 
 #define QEMU_MIGRATION_TLS_ALIAS_BASE "libvirt_migrate"
 
+struct _qemuMigrationParams {
+qemuMonitorMigrationParams params;
+};
+
 
 qemuMigrationParamsPtr
 qemuMigrationParamsNew(void)
diff --git a/src/qemu/qemu_migration_params.h b/src/qemu/qemu_migration_params.h
index ce7f84fd66..37e528f36c 100644
--- a/src/qemu/qemu_migration_params.h
+++ b/src/qemu/qemu_migration_params.h
@@ -49,9 +49,6 @@ struct _qemuMigrationCompression {
 
 typedef struct _qemuMigrationParams qemuMigrationParams;
 typedef qemuMigrationParams *qemuMigrationParamsPtr;
-struct _qemuMigrationParams {
-qemuMonitorMigrationParams params;
-};
 
 
 qemuMigrationParamsPtr
-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 24/73] qemu: Hide internals of qemuMigrationParams struct

[Ján Tomko]

On Wed, Apr 11, 2018 at 04:41:14PM +0200, Jiri Denemark wrote:

All users of migration parameters are supposed to use APIs provided by
qemu_migration_params.c without having to worry about the internals.

Signed-off-by: Jiri Denemark 
---
src/qemu/qemu_migration_params.c | 5 +
src/qemu/qemu_migration_params.h | 3 ---
2 files changed, 5 insertions(+), 3 deletions(-)



Reviewed-by: Ján Tomko 

Jano


signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list