Re: [libvirt] [PATCH v5 03/10] qemu: Introduce QEMU_DOMAIN_JOB_STATS_TYPE_MEMDUMP

[John Ferlan]

On 02/05/2018 10:41 AM, Jiri Denemark wrote:
> On Fri, Feb 02, 2018 at 17:40:11 -0500, John Ferlan wrote:
>> Define the qemuMonitorDumpStats as a new job JobStatsType to handle
>> being able to get memory dump statistics. For now do nothing with
>> the new TYPE_MEMDUMP.
>>
>> Reviewed-by: Jiri Denemark 
>> Signed-off-by: John Ferlan 
> 
> Aren't new tags usually added to the end of the commit message? In other
> words:
> 
> Signed-off-by: John Ferlan 
> Reviewed-by: Jiri Denemark 
> 
> I don't know if it makes any difference (probably not), though.
> 
> Jirka
> 

I thought that was strange too - figuring it was just me...

Then I looked at a few other recent commits (see 1b9fe756) and figured
that's just how the S-o-b seems to work - it gets tacked onto the end.

Not sure what would happen if I modified things to have S-o-b followed
by R-b... Would git be smart enough to not tack another one or would
there be a 2nd S-o-b also appended.

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v5 03/10] qemu: Introduce QEMU_DOMAIN_JOB_STATS_TYPE_MEMDUMP

[Jiri Denemark]

On Fri, Feb 02, 2018 at 17:40:11 -0500, John Ferlan wrote:
> Define the qemuMonitorDumpStats as a new job JobStatsType to handle
> being able to get memory dump statistics. For now do nothing with
> the new TYPE_MEMDUMP.
> 
> Reviewed-by: Jiri Denemark 
> Signed-off-by: John Ferlan 

Aren't new tags usually added to the end of the commit message? In other
words:

Signed-off-by: John Ferlan 
Reviewed-by: Jiri Denemark 

I don't know if it makes any difference (probably not), though.

Jirka

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v5 03/10] qemu: Introduce QEMU_DOMAIN_JOB_STATS_TYPE_MEMDUMP

[John Ferlan]

Define the qemuMonitorDumpStats as a new job JobStatsType to handle
being able to get memory dump statistics. For now do nothing with
the new TYPE_MEMDUMP.

Reviewed-by: Jiri Denemark 
Signed-off-by: John Ferlan 
---
 src/qemu/qemu_domain.c  |  2 ++
 src/qemu/qemu_domain.h  |  2 ++
 src/qemu/qemu_driver.c  |  1 +
 src/qemu/qemu_monitor.h | 19 +++
 4 files changed, 24 insertions(+)

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index bdb942f57..a37012a10 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -467,6 +467,7 @@ qemuDomainJobInfoToInfo(qemuDomainJobInfoPtr jobInfo,
 info->memProcessed = jobInfo->stats.mig.ram_transferred;
 break;
 
+case QEMU_DOMAIN_JOB_STATS_TYPE_MEMDUMP:
 case QEMU_DOMAIN_JOB_STATS_TYPE_NONE:
 break;
 }
@@ -664,6 +665,7 @@ qemuDomainJobInfoToParams(qemuDomainJobInfoPtr jobInfo,
 case QEMU_DOMAIN_JOB_STATS_TYPE_SAVEDUMP:
 return qemuDomainMigrationJobInfoToParams(jobInfo, type, params, 
nparams);
 
+case QEMU_DOMAIN_JOB_STATS_TYPE_MEMDUMP:
 case QEMU_DOMAIN_JOB_STATS_TYPE_NONE:
 break;
 }
diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h
index 29a5c7c9a..0bdd98459 100644
--- a/src/qemu/qemu_domain.h
+++ b/src/qemu/qemu_domain.h
@@ -114,6 +114,7 @@ typedef enum {
 QEMU_DOMAIN_JOB_STATS_TYPE_NONE = 0,
 QEMU_DOMAIN_JOB_STATS_TYPE_MIGRATION,
 QEMU_DOMAIN_JOB_STATS_TYPE_SAVEDUMP,
+QEMU_DOMAIN_JOB_STATS_TYPE_MEMDUMP,
 } qemuDomainJobStatsType;
 
 
@@ -147,6 +148,7 @@ struct _qemuDomainJobInfo {
 qemuDomainJobStatsType statsType;
 union {
 qemuMonitorMigrationStats mig;
+qemuMonitorDumpStats dump;
 } stats;
 qemuDomainMirrorStats mirrorStats;
 };
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 382f03bbe..5e537dc89 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -13240,6 +13240,7 @@ qemuDomainGetJobStatsInternal(virQEMUDriverPtr driver,
 ret = 0;
 break;
 
+case QEMU_DOMAIN_JOB_STATS_TYPE_MEMDUMP:
 case QEMU_DOMAIN_JOB_STATS_TYPE_NONE:
 break;
 }
diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h
index 67b785e60..c58839ca7 100644
--- a/src/qemu/qemu_monitor.h
+++ b/src/qemu/qemu_monitor.h
@@ -247,6 +247,25 @@ typedef int 
(*qemuMonitorDomainBlockThresholdCallback)(qemuMonitorPtr mon,
void *opaque);
 
 
+typedef enum {
+QEMU_MONITOR_DUMP_STATUS_NONE,
+QEMU_MONITOR_DUMP_STATUS_ACTIVE,
+QEMU_MONITOR_DUMP_STATUS_COMPLETED,
+QEMU_MONITOR_DUMP_STATUS_FAILED,
+
+QEMU_MONITOR_DUMP_STATUS_LAST,
+} qemuMonitorDumpStatus;
+
+VIR_ENUM_DECL(qemuMonitorDumpStatus)
+
+typedef struct _qemuMonitorDumpStats qemuMonitorDumpStats;
+typedef qemuMonitorDumpStats *qemuMonitorDumpStatsPtr;
+struct _qemuMonitorDumpStats {
+int status; /* qemuMonitorDumpStatus */
+unsigned long long completed; /* bytes written */
+unsigned long long total; /* total bytes to be written */
+};
+
 typedef struct _qemuMonitorCallbacks qemuMonitorCallbacks;
 typedef qemuMonitorCallbacks *qemuMonitorCallbacksPtr;
 struct _qemuMonitorCallbacks {
-- 
2.13.6

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list