Re: [libvirt] [dbus PATCH 1/9] tests: Rename minimal_xml to minimal_domain_xml

[Pavel Hrdina]

On Fri, Apr 06, 2018 at 01:20:26PM +0200, Katerina Koukiou wrote:
> Needed so as to keep consistent naming when we 'll introduce XML

s/we 'll/we'll/

> for other entities.
> 
> Signed-off-by: Katerina Koukiou 
> ---
>  test/test_connect.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Pavel Hrdina 


signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [dbus PATCH 1/9] tests: Rename minimal_xml to minimal_domain_xml

[Katerina Koukiou]

Needed so as to keep consistent naming when we 'll introduce XML
for other entities.

Signed-off-by: Katerina Koukiou 
---
 test/test_connect.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/test/test_connect.py b/test/test_connect.py
index 79402b8..5436a29 100755
--- a/test/test_connect.py
+++ b/test/test_connect.py
@@ -6,7 +6,7 @@ import pytest
 
 
 class TestConnect(libvirttest.BaseTestClass):
-minimal_xml = '''
+minimal_domain_xml = '''
 
   foo
   1024
@@ -35,7 +35,7 @@ class TestConnect(libvirttest.BaseTestClass):
 
 self.connect.connect_to_signal('DomainEvent', domain_started, 
arg1='Started')
 
-path = self.connect.CreateXML(self.minimal_xml, 0)
+path = self.connect.CreateXML(self.minimal_domain_xml, 0)
 assert isinstance(path, dbus.ObjectPath)
 
 self.main_loop()
@@ -47,7 +47,7 @@ class TestConnect(libvirttest.BaseTestClass):
 
 self.connect.connect_to_signal('DomainEvent', domain_defined, 
arg1='Defined')
 
-path = self.connect.DefineXML(self.minimal_xml)
+path = self.connect.DefineXML(self.minimal_domain_xml)
 assert isinstance(path, dbus.ObjectPath)
 
 self.main_loop()
-- 
2.15.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list