Re: [libvirt] [libvirt PATCH v2 02/44] Delete bogus cpu-host-passthrough test

[Andrea Bolognani]

On Thu, 2018-04-05 at 14:22 +0200, Ján Tomko wrote:
> We test the same XML for a type='kvm' domain twice, once with
> QEMU_CAPS_KVM (expecting success), once without (expecting failure).
> 
> The failure case relies on QEMU_CAPS_MACHINE_OPT not being set,
> failing in qemuBuildObsoleteAccelArg.
> 
> Checking a domain-type error message in a cpu test is strange.
> Delete the negative test to allow assuming QEMU_CAPS_MACHINE_OPT by
> default.
> 
> Signed-off-by: Ján Tomko 
> ---
>  tests/qemuxml2argvtest.c | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Andrea Bolognani 

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [libvirt PATCH v2 02/44] Delete bogus cpu-host-passthrough test

[Ján Tomko]

We test the same XML for a type='kvm' domain twice, once with
QEMU_CAPS_KVM (expecting success), once without (expecting failure).

The failure case relies on QEMU_CAPS_MACHINE_OPT not being set,
failing in qemuBuildObsoleteAccelArg.

Checking a domain-type error message in a cpu test is strange.
Delete the negative test to allow assuming QEMU_CAPS_MACHINE_OPT by
default.

Signed-off-by: Ján Tomko 
---
 tests/qemuxml2argvtest.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
index 5ccbb3cff9..24eb8cbc5b 100644
--- a/tests/qemuxml2argvtest.c
+++ b/tests/qemuxml2argvtest.c
@@ -1715,7 +1715,6 @@ mymain(void)
 DO_TEST_FAILURE("cpu-host-model-nofallback", NONE);
 skipLegacyCPUs = false;
 DO_TEST("cpu-host-passthrough", QEMU_CAPS_KVM);
-DO_TEST_FAILURE("cpu-host-passthrough", NONE);
 DO_TEST_FAILURE("cpu-qemu-host-passthrough", QEMU_CAPS_KVM);
 
 qemuTestSetHostArch(driver.caps, VIR_ARCH_S390X);
-- 
2.16.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list