Re: [libvirt] [libvirt PATCH v2 14/44] Deprecate QEMU_CAPS_SDL

2018-04-12 Thread Andrea Bolognani
On Mon, 2018-04-09 at 17:20 +0200, Ján Tomko wrote: > diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c > index 009ae2d36c..18f7e6d2d7 100644 > --- a/tests/qemuxml2argvtest.c > +++ b/tests/qemuxml2argvtest.c > @@ -1141,8 +1141,8 @@ mymain(void) > VIR_FREE(driver.config->vncSASLd

Re: [libvirt] [libvirt PATCH v2 14/44] Deprecate QEMU_CAPS_SDL

2018-04-09 Thread Eric Blake
On 04/09/2018 10:33 AM, Daniel P. Berrangé wrote: > On Mon, Apr 09, 2018 at 05:20:07PM +0200, Ján Tomko wrote: >> Implied by QEMU >= 1.2.0. >> >> +++ b/src/qemu/qemu_capabilities.h >> @@ -85,7 +85,7 @@ typedef enum { >> /* 25 */ >> X_QEMU_CAPS_BALLOON, /* -balloon available */ >> X_

Re: [libvirt] [libvirt PATCH v2 14/44] Deprecate QEMU_CAPS_SDL

2018-04-09 Thread Daniel P . Berrangé
On Mon, Apr 09, 2018 at 05:20:07PM +0200, Ján Tomko wrote: > Implied by QEMU >= 1.2.0. > > Signed-off-by: Ján Tomko > --- > src/qemu/qemu_capabilities.c | 4 +--- > src/qemu/qemu_capabilities.h | 2 +- > src/qemu/qemu_command.c

[libvirt] [libvirt PATCH v2 14/44] Deprecate QEMU_CAPS_SDL

2018-04-09 Thread Ján Tomko
Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 4 +--- src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 9 + tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1