Re: [PATCH v6 2/5] migration: migrate 'inc' command option is deprecated.

2023-10-18 Thread Juan Quintela
Markus Armbruster  wrote:
> Juan Quintela  writes:
>
>> Use blockdev-mirror with NBD instead.
>>
>> Reviewed-by: Thomas Huth 
>> Acked-by: Stefan Hajnoczi 
>> Reviewed-by: Markus Armbruster 
>> Signed-off-by: Juan Quintela 
>> ---
>>  docs/about/deprecated.rst  | 9 +
>>  qapi/migration.json| 8 +++-
>>  migration/migration-hmp-cmds.c | 5 +
>>  migration/migration.c  | 5 +
>>  4 files changed, 26 insertions(+), 1 deletion(-)
>>
>> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
>> index 2febd2d12f..b51136f50a 100644
>> --- a/docs/about/deprecated.rst
>> +++ b/docs/about/deprecated.rst
>> @@ -461,3 +461,12 @@ Migration
>>  ``skipped`` field in Migration stats has been deprecated.  It hasn't
>>  been used for more than 10 years.
>>  
>> +``inc`` migrate command option (since 8.2)
>> +''
>> +
>> +Use blockdev-mirror with NBD instead.
>> +
>> +As an intermediate step the ``inc`` functionality can be achieved by
>> +setting the ``block-incremental`` migration parameter to ``true``.
>> +But this parameter is also deprecated.
>> +
>
> If you need to respin for some other reason, drop the blank line at end
> of file.  Same in later patches.
>
> [...]

Done.

There is a tool, git-am maybe, that complains if files don't end in a
blank line.

You can't have happy everybody.

Later, Juan.



Re: [PATCH v6 2/5] migration: migrate 'inc' command option is deprecated.

2023-10-18 Thread Markus Armbruster
Juan Quintela  writes:

> Use blockdev-mirror with NBD instead.
>
> Reviewed-by: Thomas Huth 
> Acked-by: Stefan Hajnoczi 
> Reviewed-by: Markus Armbruster 
> Signed-off-by: Juan Quintela 
> ---
>  docs/about/deprecated.rst  | 9 +
>  qapi/migration.json| 8 +++-
>  migration/migration-hmp-cmds.c | 5 +
>  migration/migration.c  | 5 +
>  4 files changed, 26 insertions(+), 1 deletion(-)
>
> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
> index 2febd2d12f..b51136f50a 100644
> --- a/docs/about/deprecated.rst
> +++ b/docs/about/deprecated.rst
> @@ -461,3 +461,12 @@ Migration
>  ``skipped`` field in Migration stats has been deprecated.  It hasn't
>  been used for more than 10 years.
>  
> +``inc`` migrate command option (since 8.2)
> +''
> +
> +Use blockdev-mirror with NBD instead.
> +
> +As an intermediate step the ``inc`` functionality can be achieved by
> +setting the ``block-incremental`` migration parameter to ``true``.
> +But this parameter is also deprecated.
> +

If you need to respin for some other reason, drop the blank line at end
of file.  Same in later patches.

[...]