Re: [libvirt] [PATCH] Fixed NULL pointer check

2012-03-19 Thread Wen Congyang
At 03/18/2012 08:29 AM, Martin Kletzander Wrote: This patch fixes a NULL pointer check that was causing SegFault on some specific configurations. --- src/util/conf.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/src/util/conf.c b/src/util/conf.c index

Re: [libvirt] [PATCH] Fixed NULL pointer check

2012-03-19 Thread Martin Kletzander
On 03/19/2012 08:43 AM, Wen Congyang wrote: At 03/18/2012 08:29 AM, Martin Kletzander Wrote: This patch fixes a NULL pointer check that was causing SegFault on some specific configurations. --- src/util/conf.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git

Re: [libvirt] [PATCH] Fixed NULL pointer check

2012-03-19 Thread Daniel P. Berrange
On Mon, Mar 19, 2012 at 08:51:24AM +0100, Martin Kletzander wrote: On 03/19/2012 08:43 AM, Wen Congyang wrote: At 03/18/2012 08:29 AM, Martin Kletzander Wrote: This patch fixes a NULL pointer check that was causing SegFault on some specific configurations. --- src/util/conf.c |5

Re: [libvirt] [PATCH] Fixed NULL pointer check

2012-03-19 Thread Martin Kletzander
On 03/19/2012 11:32 AM, Daniel P. Berrange wrote: On Mon, Mar 19, 2012 at 08:51:24AM +0100, Martin Kletzander wrote: On 03/19/2012 08:43 AM, Wen Congyang wrote: At 03/18/2012 08:29 AM, Martin Kletzander Wrote: This patch fixes a NULL pointer check that was causing SegFault on some specific

Re: [libvirt] [PATCH] Fixed NULL pointer check

2012-03-19 Thread Daniel P. Berrange
On Mon, Mar 19, 2012 at 01:38:47PM +0100, Martin Kletzander wrote: On 03/19/2012 11:32 AM, Daniel P. Berrange wrote: On Mon, Mar 19, 2012 at 08:51:24AM +0100, Martin Kletzander wrote: On 03/19/2012 08:43 AM, Wen Congyang wrote: At 03/18/2012 08:29 AM, Martin Kletzander Wrote: This patch

Re: [libvirt] [PATCH] Fixed NULL pointer check

2012-03-19 Thread Eric Blake
On 03/19/2012 06:43 AM, Daniel P. Berrange wrote: That is a historical remant. Do feel free to send another followup patch to cleanup all the cases of 'return(NULL)' as well. Daniel Did you mean in that file or globally? Because I just tried the first thing that came to my mind and look at

Re: [libvirt] [PATCH] Fixed NULL pointer check

2012-03-19 Thread Martin Kletzander
On 03/19/2012 04:43 PM, Eric Blake wrote: On 03/19/2012 06:43 AM, Daniel P. Berrange wrote: [...] since the open '(' lets the rest of the code indent nicely when using default emacs indentation. But it's still pretty easy to recognize the difference between complex returns and the real

Re: [libvirt] [PATCH] Fixed NULL pointer check

2012-03-19 Thread Daniel P. Berrange
On Mon, Mar 19, 2012 at 09:43:26AM -0600, Eric Blake wrote: On 03/19/2012 06:43 AM, Daniel P. Berrange wrote: That is a historical remant. Do feel free to send another followup patch to cleanup all the cases of 'return(NULL)' as well. Daniel Did you mean in that file or globally?