Re: [libvirt] [PATCH] conf: Don't assign value from ..TypeFromString directly to enum

2017-05-19 Thread Ján Tomko
On Fri, May 19, 2017 at 10:27:57AM +0200, Peter Krempa wrote: Enums are unsigned, so it's impossible to check whether the helper returned -1 for invalid conversions. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1452454 --- src/conf/domain_conf.c | 15 +-- 1 file changed, 9 in

Re: [libvirt] [PATCH] conf: Don't assign value from ..TypeFromString directly to enum

2017-05-19 Thread Pavel Hrdina
On Fri, May 19, 2017 at 10:27:57AM +0200, Peter Krempa wrote: > Enums are unsigned, so it's impossible to check whether the helper > returned -1 for invalid conversions. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1452454 > --- > src/conf/domain_conf.c | 15 +-- > 1 file