Re: [libvirt] [PATCH] node_device: Check return value for udev_new()

2016-12-21 Thread Martin Kletzander
On Wed, Dec 21, 2016 at 10:35:47AM +0100, Marc Hartmayer wrote: On Thu, Dec 08, 2016 at 01:48 PM +0100, Martin Kletzander wrote: On Thu, Dec 01, 2016 at 01:52:03PM +0100, Marc Hartmayer wrote: On Wed, Nov 30, 2016 at 04:25 PM +0100, Martin Kletzander

Re: [libvirt] [PATCH] node_device: Check return value for udev_new()

2016-12-21 Thread Marc Hartmayer
On Thu, Dec 08, 2016 at 01:48 PM +0100, Martin Kletzander wrote: > On Thu, Dec 01, 2016 at 01:52:03PM +0100, Marc Hartmayer wrote: >>On Wed, Nov 30, 2016 at 04:25 PM +0100, Martin Kletzander >> wrote: >>> On Wed, Nov 30, 2016 at 01:45:32PM +0100, Marc

Re: [libvirt] [PATCH] node_device: Check return value for udev_new()

2016-12-08 Thread Boris Fiuczynski
On 12/08/2016 01:48 PM, Martin Kletzander wrote: On Thu, Dec 01, 2016 at 01:52:03PM +0100, Marc Hartmayer wrote: On Wed, Nov 30, 2016 at 04:25 PM +0100, Martin Kletzander wrote: On Wed, Nov 30, 2016 at 01:45:32PM +0100, Marc Hartmayer wrote: The comment was actually

Re: [libvirt] [PATCH] node_device: Check return value for udev_new()

2016-12-08 Thread Martin Kletzander
On Thu, Dec 01, 2016 at 01:52:03PM +0100, Marc Hartmayer wrote: On Wed, Nov 30, 2016 at 04:25 PM +0100, Martin Kletzander wrote: On Wed, Nov 30, 2016 at 01:45:32PM +0100, Marc Hartmayer wrote: The comment was actually wrong as

Re: [libvirt] [PATCH] node_device: Check return value for udev_new()

2016-12-01 Thread Marc Hartmayer
On Wed, Nov 30, 2016 at 04:25 PM +0100, Martin Kletzander wrote: > On Wed, Nov 30, 2016 at 01:45:32PM +0100, Marc Hartmayer wrote: >>The comment was actually wrong as >>https://www.freedesktop.org/software/systemd/man/udev_new.html >>mentions that on failure NULL is

Re: [libvirt] [PATCH] node_device: Check return value for udev_new()

2016-11-30 Thread Daniel P. Berrange
On Wed, Nov 30, 2016 at 04:25:58PM +0100, Martin Kletzander wrote: > On Wed, Nov 30, 2016 at 01:45:32PM +0100, Marc Hartmayer wrote: > > The comment was actually wrong as > > https://www.freedesktop.org/software/systemd/man/udev_new.html > > mentions that on failure NULL is returned. > > > >