Re: [libvirt] [PATCH] qemu: s/VIR_ERR_NO_SUPPORT/VIR_ERR_OPERATION_UNSUPPORTED
On 20.03.2013 18:26, Eric Blake wrote: On 03/20/2013 09:59 AM, Michal Privoznik wrote: The VIR_ERR_NO_SUPPORT error code is reserved for cases where an API is not implemented in a driver. It definitely should not be used when an API execution fails due to unsupported operation. --- src/qemu/qemu_driver.c | 2 +- src/qemu/qemu_hotplug.c | 30 +++--- src/qemu/qemu_monitor.c | 2 +- src/qemu/qemu_monitor_text.c | 2 +- src/qemu/qemu_process.c | 2 +- 5 files changed, 19 insertions(+), 19 deletions(-) ACK. Thanks, pushed. Michal -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] qemu: s/VIR_ERR_NO_SUPPORT/VIR_ERR_OPERATION_UNSUPPORTED
On 03/20/2013 09:59 AM, Michal Privoznik wrote: The VIR_ERR_NO_SUPPORT error code is reserved for cases where an API is not implemented in a driver. It definitely should not be used when an API execution fails due to unsupported operation. --- src/qemu/qemu_driver.c | 2 +- src/qemu/qemu_hotplug.c | 30 +++--- src/qemu/qemu_monitor.c | 2 +- src/qemu/qemu_monitor_text.c | 2 +- src/qemu/qemu_process.c | 2 +- 5 files changed, 19 insertions(+), 19 deletions(-) ACK. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list