Re: [libvirt] [PATCH] virsh: only report filled values in nodecpustats

2014-02-06 Thread Michal Privoznik

On 04.02.2014 10:22, Ján Tomko wrote:

Rewrite the function to use an array instead of a struct,
translating the field names to int via an enum.
---
  tools/virsh-host.c | 126 +++--
  1 file changed, 64 insertions(+), 62 deletions(-)



ACK, I like this one more.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


Re: [libvirt] [PATCH] virsh: only report filled values in nodecpustats

2014-02-06 Thread Ján Tomko
On 02/06/2014 01:14 PM, Michal Privoznik wrote:
 On 04.02.2014 10:22, Ján Tomko wrote:
 Rewrite the function to use an array instead of a struct,
 translating the field names to int via an enum.
 ---
   tools/virsh-host.c | 126
 +++--
   1 file changed, 64 insertions(+), 62 deletions(-)
 
 
 ACK, I like this one more.
 

Now pushed. Thank you for the reviews!

Jan




signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] virsh: only report filled values in nodecpustats

2014-02-04 Thread Roman Bogorodskiy
  Ján Tomko wrote:

 Rewrite the function to use an array instead of a struct,
 translating the field names to int via an enum.

That works as expected on FreeBSD.

Thanks,

Roman Bogorodskiy

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list