On 18.10.2016 03:48, John Ferlan wrote:
> The following were all part of the review of the TCP chardev TLS series which
> were outside the realm of the specific changes for the series...
>
> http://www.redhat.com/archives/libvir-list/2016-October/msg00742.html
>
> 1. Removal of cfg from qemuProcessPrepareDomain should be separate patch
> 2. Setting chardevTLSx509verify should have been it's own patch...
> 3. !conn in qemuDomainSecretChardevPrepare not necessary - so that's
>true for the SecretDiskPrepare and SecretHostdevPrepare too
>
> John Ferlan (3):
> qemu: Remove unnecessary cfg fetch/unref
> qemu: Add 'verify-peer=yes' test for chardev TCP TLS
> qemu: Remove unnecessary NULL arg check
>
> src/qemu/qemu_domain.c | 5 +--
> src/qemu/qemu_process.c| 2 --
> ...xml2argv-serial-tcp-tlsx509-chardev-verify.args | 33 +
> ...uxml2argv-serial-tcp-tlsx509-chardev-verify.xml | 41
> ++
> tests/qemuxml2argvtest.c | 5 +++
> 5 files changed, 80 insertions(+), 6 deletions(-)
> create mode 100644
> tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-chardev-verify.args
> create mode 100644
> tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-chardev-verify.xml
>
ACK series
Michal
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
