Re: [libvirt] [PATCH 00/14] Add tests for virCPUUpdateLive API
On Mon, Mar 27, 2017 at 16:11:17 +0200, Pavel Hrdina wrote: > On Fri, Mar 17, 2017 at 05:36:38PM +0100, Jiri Denemark wrote: > > Jiri Denemark (14): > > cpu_conf: Introduce virCPUDefFreeFeatures > > cpu: Introduce virCPUExpandFeatures > > cpu: Drop unused flags from cpuArchDecode > > cpu: Move feature expansion out of cpuBaseline > > cpu: Do not pass virConnectBaselineCPUFlags to cpuBaseline > > cputest: Move instantiation of JSONDecoder in cpu-convert.py > > cputest: Rename cpu-convert.py script as cpu-cpuid.py > > cputest: Add cpuidIsSet helper to cpu-cpuid.py > > cputest: Add cpuidLeaf helper to cpu-cpuid.py > > cputest: Add "diff" command to cpu-cpuid.py > > cputest: Generate data for virCPUUpdateLive > > cputest: Disable TSX on broken models > > cputest: Disable "cmt" feature unknown to QEMU > > cputest: Add tests for virCPUUpdateLive API > > ACK series but see my comment for patch 10/14. OK, I modified 10/14 according to your suggestions, checked that the script generates identical files to those from 11/14, and pushed this series. (And broke syntax check in non VPATH.) Thanks Jirka -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 00/14] Add tests for virCPUUpdateLive API
On Fri, Mar 17, 2017 at 05:36:38PM +0100, Jiri Denemark wrote: > Jiri Denemark (14): > cpu_conf: Introduce virCPUDefFreeFeatures > cpu: Introduce virCPUExpandFeatures > cpu: Drop unused flags from cpuArchDecode > cpu: Move feature expansion out of cpuBaseline > cpu: Do not pass virConnectBaselineCPUFlags to cpuBaseline > cputest: Move instantiation of JSONDecoder in cpu-convert.py > cputest: Rename cpu-convert.py script as cpu-cpuid.py > cputest: Add cpuidIsSet helper to cpu-cpuid.py > cputest: Add cpuidLeaf helper to cpu-cpuid.py > cputest: Add "diff" command to cpu-cpuid.py > cputest: Generate data for virCPUUpdateLive > cputest: Disable TSX on broken models > cputest: Disable "cmt" feature unknown to QEMU > cputest: Add tests for virCPUUpdateLive API ACK series but see my comment for patch 10/14. Pavel signature.asc Description: Digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 00/14] Add tests for virCPUUpdateLive API
On Sun, Mar 19, 2017 at 22:09:47 -0400, Laine Stump wrote: > On 03/17/2017 12:36 PM, Jiri Denemark wrote: > > Jiri Denemark (14): > > cpu_conf: Introduce virCPUDefFreeFeatures > > cpu: Introduce virCPUExpandFeatures > > cpu: Drop unused flags from cpuArchDecode > > cpu: Move feature expansion out of cpuBaseline > > cpu: Do not pass virConnectBaselineCPUFlags to cpuBaseline > > cputest: Move instantiation of JSONDecoder in cpu-convert.py > > cputest: Rename cpu-convert.py script as cpu-cpuid.py > > cputest: Add cpuidIsSet helper to cpu-cpuid.py > > cputest: Add cpuidLeaf helper to cpu-cpuid.py > > cputest: Add "diff" command to cpu-cpuid.py > > cputest: Generate data for virCPUUpdateLive > > cputest: Disable TSX on broken models > > cputest: Disable "cmt" feature unknown to QEMU > > cputest: Add tests for virCPUUpdateLive API > > Does one of these perhaps fix a segv in virCPUUpdateLive? With current > tip of master, it's being called with cpu == NULL: Oops, none of these patches fix the crash. It's a bug in the caller not in the virCPUUpdateLive itself. A patch is coming soon... Jirka -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 00/14] Add tests for virCPUUpdateLive API
On 03/17/2017 12:36 PM, Jiri Denemark wrote: > Jiri Denemark (14): > cpu_conf: Introduce virCPUDefFreeFeatures > cpu: Introduce virCPUExpandFeatures > cpu: Drop unused flags from cpuArchDecode > cpu: Move feature expansion out of cpuBaseline > cpu: Do not pass virConnectBaselineCPUFlags to cpuBaseline > cputest: Move instantiation of JSONDecoder in cpu-convert.py > cputest: Rename cpu-convert.py script as cpu-cpuid.py > cputest: Add cpuidIsSet helper to cpu-cpuid.py > cputest: Add cpuidLeaf helper to cpu-cpuid.py > cputest: Add "diff" command to cpu-cpuid.py > cputest: Generate data for virCPUUpdateLive > cputest: Disable TSX on broken models > cputest: Disable "cmt" feature unknown to QEMU > cputest: Add tests for virCPUUpdateLive API Does one of these perhaps fix a segv in virCPUUpdateLive? With current tip of master, it's being called with cpu == NULL: Thread 5 "lt-libvirtd" received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7f89075bf700 (LWP 21908)] virCPUUpdateLive (arch=VIR_ARCH_X86_64, cpu=0x0, dataEnabled=dataEnabled@entry=0x7f88d00078e0, dataDisabled=0x7f88d0006430) at cpu/cpu.c:750 750 if (cpu->mode != VIR_CPU_MODE_CUSTOM) (gdb) where #0 virCPUUpdateLive (arch=VIR_ARCH_X86_64, cpu=0x0, dataEnabled=dataEnabled@entry=0x7f88d00078e0, dataDisabled=0x7f88d0006430) at cpu/cpu.c:750 #1 0x7f88eb3646ff in qemuProcessUpdateLiveGuestCPU ( asyncJob=QEMU_ASYNC_JOB_START, vm=0x7f88e01e9480, driver=0x7f88e04e9450) at qemu/qemu_process.c:3876 #2 qemuProcessLaunch (conn=conn@entry=0x7f88d80027f0, driver=driver@entry=0x7f88e04e9450, vm=vm@entry=0x7f88e01e9480, asyncJob=asyncJob@entry=QEMU_ASYNC_JOB_START, incoming=incoming@entry=0x0, snapshot=snapshot@entry=0x0, vmop=VIR_NETDEV_VPORT_PROFILE_OP_CREATE, flags=17) at qemu/qemu_process.c:5731 #3 0x7f88eb364c66 in qemuProcessStart (conn=conn@entry=0x7f88d80027f0, driver=driver@entry=0x7f88e04e9450, vm=vm@entry=0x7f88e01e9480, asyncJob=asyncJob@entry=QEMU_ASYNC_JOB_START, migrateFrom=migrateFrom@entry=0x0, migrateFd=migrateFd@entry=-1, migratePath=0x0, snapshot=0x0, vmop=VIR_NETDEV_VPORT_PROFILE_OP_CREATE, flags=17) at qemu/qemu_process.c:5927 #4 0x7f88eb3bf9be in qemuDomainObjStart (conn=0x7f88d80027f0, driver=driver@entry=0x7f88e04e9450, vm=0x7f88e01e9480, flags=flags@entry=0, asyncJob=QEMU_ASYNC_JOB_START) at qemu/qemu_driver.c:6945 #5 0x7f88eb3c00b6 in qemuDomainCreateWithFlags (dom=0x7f88d9f0, flags=0) at qemu/qemu_driver.c:6999 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
