Re: [libvirt] [PATCH 1/2] util: Add function to check if string contains some chars

2016-10-19 Thread Sławek Kapłoński
Hello, -- Best regards / Pozdrawiam Sławek Kapłoński sla...@kaplonski.pl On Wed, 19 Oct 2016, Michal Privoznik wrote: > On 19.10.2016 03:55, Sławek Kapłoński wrote: > > Tue, 18 Oct 2016, Michal Privoznik wrote: > >> > On 14.10.2016 04:53, Sławek Kapłoński wrote: > >>> > > This new function

Re: [libvirt] [PATCH 1/2] util: Add function to check if string contains some chars

2016-10-18 Thread Michal Privoznik
On 19.10.2016 03:55, Sławek Kapłoński wrote: > Tue, 18 Oct 2016, Michal Privoznik wrote: >> > On 14.10.2016 04:53, Sławek Kapłoński wrote: >>> > > This new function can be used to check if e.g. name of XML node >>> > > don't contains forbidden chars like "/" or new-line. >>> > > --- >>> > >

Re: [libvirt] [PATCH 1/2] util: Add function to check if string contains some chars

2016-10-18 Thread Sławek Kapłoński
Hello, Thx for review. Please read my answear inline. -- Best regards / Pozdrawiam Sławek Kapłoński sla...@kaplonski.pl On Tue, 18 Oct 2016, Michal Privoznik wrote: > On 14.10.2016 04:53, Sławek Kapłoński wrote: > > This new function can be used to check if e.g. name of XML node > > don't

Re: [libvirt] [PATCH 1/2] util: Add function to check if string contains some chars

2016-10-17 Thread Michal Privoznik
On 14.10.2016 04:53, Sławek Kapłoński wrote: > This new function can be used to check if e.g. name of XML node > don't contains forbidden chars like "/" or new-line. > --- > src/conf/network_conf.c | 2 +- > src/libvirt_private.syms | 1 + > src/util/virstring.c | 9 + >

Re: [libvirt] [PATCH 1/2] util: Add function to check if string contains some chars

2016-10-12 Thread John Ferlan
On 10/10/2016 04:15 PM, Sławek Kapłoński wrote: > This new function can be used to check if e.g. name of XML node don't s/don't/doesn't/ > contains forbidden chars like "/" or new-line. s/new-line/'\n' > --- > src/util/virxml.c | 18 ++ > src/util/virxml.h | 4 > 2

Re: [libvirt] [PATCH 1/2] util: Add function to check if string contains some chars

2016-10-11 Thread Michal Privoznik
On 11.10.2016 04:15, Sławek Kapłoński wrote: > This new function can be used to check if e.g. name of XML node don't > contains forbidden chars like "/" or new-line. > --- > src/util/virxml.c | 18 ++ > src/util/virxml.h | 4 > 2 files changed, 22 insertions(+) > > diff