Re: [libvirt] [PATCH 1/3] Add a plugin dlm for lock manager

2018-02-08 Thread John Ferlan
On 02/08/2018 03:30 AM, Lin Fu wrote: > I could feel that you want to express "Oh, shit! How terrible the code it > is." from the reply, although across the screen. Anyway, I'm really glad > to thanks for your review and suggestions. :-) > No - just trying to be thorough with respect to

Re: [libvirt] [PATCH 1/3] Add a plugin dlm for lock manager

2018-02-08 Thread Lin Fu
I could feel that you want to express "Oh, shit! How terrible the code it is." from the reply, although across the screen. Anyway, I'm really glad to thanks for your review and suggestions. :-) On 2018年02月08日 07:55, John Ferlan wrote: > That's where I'd expect to find the details of why someone

Re: [libvirt] [PATCH 1/3] Add a plugin dlm for lock manager

2018-02-07 Thread John Ferlan
On 02/05/2018 04:07 AM, river wrote: > dlm is implemented by linux kernel, provides userspace API by > 'libdlm' to lock/unlock resource, cooperated with cluster > communication software, such as corosync, could satisfy the > demands of libvirt lock manager. This is lacking in any description of