Re: [libvirt] [PATCH 1/3] Move linux specific symbol to src/libvirt_linux.syms
On Wed, Apr 04, 2012 at 01:47:57PM +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com linuxNodeInfoCPUPopulate is not built on Mingw32 so should be in libvirt_linux.syms, not libvirt_private.syms Opps, misleading comment. For upstream, it was never in libvirt_private.syms at all. I only had it there in a temporarily local change.So this should read Add linuxNodeInfoCPUPopulate to libvirt_private.syms for benefit of nodeinfotest.c Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 1/3] Move linux specific symbol to src/libvirt_linux.syms
On Wed, Apr 04, 2012 at 13:47:57 +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com linuxNodeInfoCPUPopulate is not built on Mingw32 so should be in libvirt_linux.syms, not libvirt_private.syms Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/libvirt_linux.syms |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/libvirt_linux.syms b/src/libvirt_linux.syms index 018c892..2258739 100644 --- a/src/libvirt_linux.syms +++ b/src/libvirt_linux.syms @@ -6,3 +6,6 @@ # stats_linux.h linuxDomainInterfaceStats; xenLinuxDomainBlockStats; + +# nodeinfo.h +linuxNodeInfoCPUPopulate; Both subject and commit message confused me a bit since they are misleading. The symbol is not really moved since it was missing from any *.syms in the first place. ACK to adding it to libvirt_linux.syms, though. Jirka -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
