Re: [libvirt] [PATCH 1/4] conf: Fix error path logic in virDomainObjListAddLocked

2018-04-06 Thread John Ferlan
On 04/06/2018 08:56 AM, Michal Privoznik wrote: > On 03/29/2018 02:34 PM, John Ferlan wrote: >> If the virHashAddEntry fails, then we need to "careful" about >> how we free the @vm. When virDomainObjNew returns there is one >> reference and the object is locked, so use virDomainObjEndAPI >> when

Re: [libvirt] [PATCH 1/4] conf: Fix error path logic in virDomainObjListAddLocked

2018-04-06 Thread Michal Privoznik
On 03/29/2018 02:34 PM, John Ferlan wrote: > If the virHashAddEntry fails, then we need to "careful" about > how we free the @vm. When virDomainObjNew returns there is one > reference and the object is locked, so use virDomainObjEndAPI > when done. > > Add a virObjectRef in the error path for the